33701 2010-01-14 18:14:07 -0800 webkit-patch should authenticate more often 2010-01-19 16:37:02 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth webkit-unassigned commit-queue eric oldest_to_newest 181060 0 abarth 2010-01-14 18:14:07 -0800 webkit-patch should authenticate more often 181061 1 46631 abarth 2010-01-14 18:14:28 -0800 Created attachment 46631 Patch 181485 2 abarth 2010-01-15 23:32:11 -0800 Eric had som concerns about this patch being unfriendly to folks who haven't configured their key chain / git credentials. Eric, are you still concerned about that? 181791 3 46631 abarth 2010-01-18 01:56:46 -0800 Comment on attachment 46631 Patch If this is problematic, we can re-visit. 181842 4 46631 commit-queue 2010-01-18 05:49:38 -0800 Comment on attachment 46631 Patch Clearing flags on attachment: 46631 Committed r53403: <http://trac.webkit.org/changeset/53403> 181843 5 commit-queue 2010-01-18 05:49:45 -0800 All reviewed patches have been landed. Closing bug. 182506 6 eric 2010-01-19 16:37:02 -0800 *** Bug 28777 has been marked as a duplicate of this bug. *** 46631 2010-01-14 18:14:28 -0800 2010-01-18 05:49:38 -0800 Patch bug-33701-20100114181427.patch text/plain 1485 abarth ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA2YjIyZGM1Li4zMGY4NmZjIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDEt MTQgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICB3ZWJraXQtcGF0Y2ggc2hvdWxkIGF1dGhlbnRp Y2F0ZSBtb3JlIG9mdGVuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0zMzcwMQorCisgICAgICAgIFRoaXMgbWFrZXMgaXQgZWFzaWVyIHRvIHdvcmsgd2l0 aCBzZWN1cml0eSBwYXRjaGVzLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9idWd6aWxs YS5weToKKwogMjAxMC0wMS0xMyAgRGllZ28gR29uemFsZXogIDxkaWVnby5nb256YWxlekBvcGVu Ym9zc2Eub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggQ2hyaXN0aWFuc2VuLgpk aWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9idWd6aWxsYS5weSBiL1dl YktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvYnVnemlsbGEucHkKaW5kZXggYzBiYmIwNy4uYWI0 MTQyNyAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9idWd6aWxsYS5w eQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2J1Z3ppbGxhLnB5CkBAIC0xNjIs NiArMTYyLDggQEAgY2xhc3MgQnVnemlsbGFRdWVyaWVzKG9iamVjdCk6CiAKICAgICAjIE5vdGU6 IF9sb2FkX3F1ZXJ5IGFuZCBfZmV0Y2hfYnVnIGFyZSB0aGUgb25seSB0d28gbWV0aG9kcyB3aGlj aCBhY2Nlc3Mgc2VsZi5fYnVnemlsbGEuCiAgICAgZGVmIF9sb2FkX3F1ZXJ5KHNlbGYsIHF1ZXJ5 KToKKyAgICAgICAgc2VsZi5fYnVnemlsbGEuYXV0aGVudGljYXRlKCkKKwogICAgICAgICBmdWxs X3VybCA9ICIlcyVzIiAlIChzZWxmLl9idWd6aWxsYS5idWdfc2VydmVyX3VybCwgcXVlcnkpCiAg ICAgICAgIHJldHVybiBzZWxmLl9idWd6aWxsYS5icm93c2VyLm9wZW4oZnVsbF91cmwpCiAKQEAg LTM0Miw2ICszNDQsOCBAQCBjbGFzcyBCdWd6aWxsYShvYmplY3QpOgogICAgICAgICByZXR1cm4g aW50KG1hdGNoLmdyb3VwKCdidWdfaWQnKSkKIAogICAgIGRlZiBidWdfaWRfZm9yX2F0dGFjaG1l bnRfaWQoc2VsZiwgYXR0YWNobWVudF9pZCk6CisgICAgICAgIHNlbGYuYXV0aGVudGljYXRlKCkK KwogICAgICAgICBhdHRhY2htZW50X3VybCA9IHNlbGYuYXR0YWNobWVudF91cmxfZm9yX2lkKGF0 dGFjaG1lbnRfaWQsICdlZGl0JykKICAgICAgICAgbG9nKCJGZXRjaGluZzogJXMiICUgYXR0YWNo bWVudF91cmwpCiAgICAgICAgIHBhZ2UgPSBzZWxmLmJyb3dzZXIub3BlbihhdHRhY2htZW50X3Vy bCkK