33697 2010-01-14 16:37:22 -0800 dragOpFromIEOp("move") returns DragOperationGeneric instead of DragOperationMove 2010-03-25 01:46:53 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 bweinstein webkit-unassigned aroben dbates oliver tony yael oldest_to_newest 181001 0 bweinstein 2010-01-14 16:37:22 -0800 dragOpFromIEOp("move") returns DragOperationGeneric instead of DragOperationMove. This doesn't make any sense. 201207 1 51012 tony 2010-03-18 00:46:40 -0700 Created attachment 51012 Patch 201211 2 tony 2010-03-18 00:49:35 -0700 (In reply to comment #0) > dragOpFromIEOp("move") returns DragOperationGeneric instead of > DragOperationMove. This doesn't make any sense. This is causing fast/events/drag-and-drop.html to fail on Chromium. The test tries to set a dropEffect of 'move', but no operation occurs because the source operation mask doesn't include generic. 201212 3 tony 2010-03-18 00:50:31 -0700 Also, as far as I can tell, this code hasn't changed since the initial commit: http://trac.webkit.org/changeset/6779 201263 4 aroben 2010-03-18 06:22:16 -0700 How do we know this won't cause any regressions in interacting with the rest of the OS? Your patch doesn't mention what effect this will have on platforms that *do* have a concept of a "generic" operation. 201275 5 tony 2010-03-18 07:11:51 -0700 (In reply to comment #4) > How do we know this won't cause any regressions in interacting with the rest of > the OS? Your patch doesn't mention what effect this will have on platforms that > *do* have a concept of a "generic" operation. The layout tests pass on mac and manual testing seems to confirm that nothing has regressed. Is there some other way for me to test for regressions (manual or automated tests)? I'm happy to write additional tests if you have some suggestions on areas that might not be well covered. 201297 6 aroben 2010-03-18 08:05:13 -0700 (In reply to comment #5) > (In reply to comment #4) > > How do we know this won't cause any regressions in interacting with the rest of > > the OS? Your patch doesn't mention what effect this will have on platforms that > > *do* have a concept of a "generic" operation. > > The layout tests pass on mac and manual testing seems to confirm that nothing > has regressed. Is there some other way for me to test for regressions (manual > or automated tests)? I'm happy to write additional tests if you have some > suggestions on areas that might not be well covered. Have you tried the case mentioned in <http://trac.webkit.org/changeset/3400>? 201311 7 51012 darin 2010-03-18 08:29:57 -0700 Comment on attachment 51012 Patch > + Covered by existing tests (fast/events/drag-and-drop.html). If this change is covered by those tests, why aren't the tests failing? 201577 8 tony 2010-03-18 14:51:04 -0700 (In reply to comment #7) > (From update of attachment 51012 [details]) > > + Covered by existing tests (fast/events/drag-and-drop.html). > > If this change is covered by those tests, why aren't the tests failing? The win port is passing because it converts generic into move: http://trac.webkit.org/browser/trunk/WebKit/win/WebView.cpp#L4861 gkt and qt skip this test and this test is failing on the chromium ports. If you prefer, I can make the chromium ports convert generic to move, but I imagine qt and gtk will have to do the same. 201682 9 tony 2010-03-18 19:23:30 -0700 (In reply to comment #6) > Have you tried the case mentioned in <http://trac.webkit.org/changeset/3400>? Yes, I am still able to drag text from Safari to Terminal. Note that I haven't removed Generic, I just added Move. Let me know if this isn't a patch you want to take and I'll just work around the problem in WebKit/chromium/ like the code in WebKit/win/. 203866 10 51012 eric 2010-03-25 00:33:35 -0700 Comment on attachment 51012 Patch This looks sane to me. Doesn't this also require changes to test_expectations now that that's in webkit.org? 203870 11 tony 2010-03-25 00:36:48 -0700 (In reply to comment #10) > (From update of attachment 51012 [details]) > This looks sane to me. Doesn't this also require changes to test_expectations > now that that's in webkit.org? It does. I will rev the patch in https://bugs.webkit.org/show_bug.cgi?id=36484 which will include the test_expectations change. 203918 12 51012 tony 2010-03-25 01:46:44 -0700 Comment on attachment 51012 Patch Clearing flags on attachment: 51012 Committed r56513: <http://trac.webkit.org/changeset/56513> 203919 13 tony 2010-03-25 01:46:53 -0700 All reviewed patches have been landed. Closing bug. 51012 2010-03-18 00:46:40 -0700 2010-03-25 01:46:44 -0700 Patch bug-33697-20100318164638.patch text/plain 2581 tony ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NzBjZDNlOS4uYzhiYmExOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0wMy0xOCAgVG9ueSBDaGFuZyAg PHRvbnlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzY5 NworICAgICAgICBIYXZlIGRyYWdPcEZyb21JRU9wKCJtb3ZlIikgcmV0dXJuIERyYWdPcGVyYXRp b25HZW5lcmljIHwgRHJhZ09wZXJhdGlvbk1vdmUKKyAgICAgICAgYmVjYXVzZSBvbmx5IHJldHVy bmluZyBHZW5lcmljIGRvZXNuJ3Qgd29yayBmb3IgcGxhdGZvcm1zIHRoYXQgZG9uJ3QKKyAgICAg ICAgaGF2ZSBhIGdlbmVyaWMgb3BlcmF0aW9uLgorCisgICAgICAgIENvdmVyZWQgYnkgZXhpc3Rp bmcgdGVzdHMgKGZhc3QvZXZlbnRzL2RyYWctYW5kLWRyb3AuaHRtbCkuCisKKyAgICAgICAgKiBk b20vQ2xpcGJvYXJkLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmRyYWdPcEZyb21JRU9wKToKKyAg ICAgICAgKFdlYkNvcmU6OkNsaXBib2FyZDo6ZGVzdGluYXRpb25PcGVyYXRpb24pOgorICAgICAg ICAoV2ViQ29yZTo6Q2xpcGJvYXJkOjpzZXREZXN0aW5hdGlvbk9wZXJhdGlvbik6CisKIDIwMTAt MDMtMTcgIERtaXRyeSBUaXRvdiAgPGRpbWljaEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgRGltaXRyaSBHbGF6a292LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9kb20vQ2xpcGJv YXJkLmNwcCBiL1dlYkNvcmUvZG9tL0NsaXBib2FyZC5jcHAKaW5kZXggNDQ3M2I3NC4uMWJiYTE0 YiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9kb20vQ2xpcGJvYXJkLmNwcAorKysgYi9XZWJDb3JlL2Rv bS9DbGlwYm9hcmQuY3BwCkBAIC02Niw3ICs2Niw3IEBAIHN0YXRpYyBEcmFnT3BlcmF0aW9uIGRy YWdPcEZyb21JRU9wKGNvbnN0IFN0cmluZyYgb3ApCiAgICAgaWYgKG9wID09ICJsaW5rIikKICAg ICAgICAgcmV0dXJuIERyYWdPcGVyYXRpb25MaW5rOwogICAgIGlmIChvcCA9PSAibW92ZSIpCi0g ICAgICAgIHJldHVybiBEcmFnT3BlcmF0aW9uR2VuZXJpYzsgICAgLy8gRklYTUU6IFdoeSBpcyB0 aGlzIERyYWdPcGVyYXRpb25HZW5lcmljPyA8aHR0cDovL3dlYmtpdC5vcmcvYi8zMzY5Nz4KKyAg ICAgICAgcmV0dXJuIChEcmFnT3BlcmF0aW9uKShEcmFnT3BlcmF0aW9uR2VuZXJpYyB8IERyYWdP cGVyYXRpb25Nb3ZlKTsKICAgICBpZiAob3AgPT0gImNvcHlMaW5rIikKICAgICAgICAgcmV0dXJu IChEcmFnT3BlcmF0aW9uKShEcmFnT3BlcmF0aW9uQ29weSB8IERyYWdPcGVyYXRpb25MaW5rKTsK ICAgICBpZiAob3AgPT0gImNvcHlNb3ZlIikKQEAgLTExMCw3ICsxMTAsNyBAQCBEcmFnT3BlcmF0 aW9uIENsaXBib2FyZDo6c291cmNlT3BlcmF0aW9uKCkgY29uc3QKIERyYWdPcGVyYXRpb24gQ2xp cGJvYXJkOjpkZXN0aW5hdGlvbk9wZXJhdGlvbigpIGNvbnN0CiB7CiAgICAgRHJhZ09wZXJhdGlv biBvcCA9IGRyYWdPcEZyb21JRU9wKG1fZHJvcEVmZmVjdCk7Ci0gICAgQVNTRVJUKG9wID09IERy YWdPcGVyYXRpb25Db3B5IHx8IG9wID09IERyYWdPcGVyYXRpb25Ob25lIHx8IG9wID09IERyYWdP cGVyYXRpb25MaW5rIHx8IG9wID09IERyYWdPcGVyYXRpb25HZW5lcmljIHx8IG9wID09IERyYWdP cGVyYXRpb25Nb3ZlIHx8IG9wID09IERyYWdPcGVyYXRpb25FdmVyeSk7CisgICAgQVNTRVJUKG9w ID09IERyYWdPcGVyYXRpb25Db3B5IHx8IG9wID09IERyYWdPcGVyYXRpb25Ob25lIHx8IG9wID09 IERyYWdPcGVyYXRpb25MaW5rIHx8IG9wID09IChEcmFnT3BlcmF0aW9uKShEcmFnT3BlcmF0aW9u R2VuZXJpYyB8IERyYWdPcGVyYXRpb25Nb3ZlKSB8fCBvcCA9PSBEcmFnT3BlcmF0aW9uRXZlcnkp OwogICAgIHJldHVybiBvcDsKIH0KIApAQCAtMTIyLDcgKzEyMiw3IEBAIHZvaWQgQ2xpcGJvYXJk OjpzZXRTb3VyY2VPcGVyYXRpb24oRHJhZ09wZXJhdGlvbiBvcCkKIAogdm9pZCBDbGlwYm9hcmQ6 OnNldERlc3RpbmF0aW9uT3BlcmF0aW9uKERyYWdPcGVyYXRpb24gb3ApCiB7Ci0gICAgQVNTRVJU X0FSRyhvcCwgb3AgPT0gRHJhZ09wZXJhdGlvbkNvcHkgfHwgb3AgPT0gRHJhZ09wZXJhdGlvbk5v bmUgfHwgb3AgPT0gRHJhZ09wZXJhdGlvbkxpbmsgfHwgb3AgPT0gRHJhZ09wZXJhdGlvbkdlbmVy aWMgfHwgb3AgPT0gRHJhZ09wZXJhdGlvbk1vdmUpOworICAgIEFTU0VSVF9BUkcob3AsIG9wID09 IERyYWdPcGVyYXRpb25Db3B5IHx8IG9wID09IERyYWdPcGVyYXRpb25Ob25lIHx8IG9wID09IERy YWdPcGVyYXRpb25MaW5rIHx8IG9wID09IERyYWdPcGVyYXRpb25HZW5lcmljIHx8IG9wID09IERy YWdPcGVyYXRpb25Nb3ZlIHx8IG9wID09IChEcmFnT3BlcmF0aW9uKShEcmFnT3BlcmF0aW9uR2Vu ZXJpYyB8IERyYWdPcGVyYXRpb25Nb3ZlKSk7CiAgICAgbV9kcm9wRWZmZWN0ID0gSUVPcEZyb21E cmFnT3Aob3ApOwogfQogCg==