33693 2010-01-14 15:22:37 -0800 [Qt] Defective dependencies caused build failing on QtBuildBot 2010-01-14 22:15:13 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED Qt P3 Normal --- 1 ossy webkit-unassigned abarth eric hausmann jturcotte oldest_to_newest 180961 0 ossy 2010-01-14 15:22:37 -0800 Build failed on QtBuildbot yesterday: http://build.webkit.org/builders/Qt%20Linux%20Release/builds/5945 (Clean WebKitBuild/JavaScriptCore directory manually resolved the problem) error message: ... obj/release/jsc.o:jsc.cpp:(.text+0x1e36): more undefined references to `JSC::UStringImpl::destroy()' follow collect2: ld returned 1 exit status ... JSC::UStringImpl::destroy() removed by http://trac.webkit.org/changeset/53221 , but jsc.o and Debugger.o wasn't rebuild mistakenly. It caused by defective dependencies for jsc.o and Debugger.o. Debugger.cpp -> interpreter/Interpreter.h -> runtime/JSCell.h -> runtime/Structure.h -> runtime/Identifier.h -> JsGlobalData.h -> NumericStrings.h -> UString.h -> UStringImpl.h Debugger.o depends on UStringImpl.h, but this dependency was missing from the Makefile, because CONFIG variable of jsc.pro doesn't contain depend_includepath. 180965 1 46613 ossy 2010-01-14 15:26:35 -0800 Created attachment 46613 proposed fix I suggest we add CONFIG += depend_includepath to WebKit.pri, because all complex pro files include it. 181019 2 46613 eric 2010-01-14 17:18:33 -0800 Comment on attachment 46613 proposed fix OK. I trust you. 181099 3 ossy 2010-01-14 22:15:13 -0800 (In reply to comment #2) > (From update of attachment 46613 [details]) > OK. I trust you. Thx, landed in 53319. 46613 2010-01-14 15:26:35 -0800 2010-01-14 17:18:32 -0800 proposed fix dep.patch text/plain 793 ossy ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA5NDM3ZWY5Li5kODY0ZTFj IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTAtMDEtMTQgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIERlZmVjdGl2 ZSBkZXBlbmRlbmNpZXMgY2F1c2VkIGJ1aWxkIGZhaWxpbmcgb24gUXRCdWlsZEJvdC4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMzNjkzCisKKyAgICAg ICAgKiBXZWJLaXQucHJpOiBDT05GSUcgKz0gZGVwZW5kX2luY2x1ZGVwYXRoIGFkZGVkLgorCiAy MDEwLTAxLTE0ICBTdGV2ZSBCbG9jayAgPHN0ZXZlYmxvY2tAZ29vZ2xlLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBEYXZpZCBMZXZpbi4KZGlmZiAtLWdpdCBhL1dlYktpdC5wcmkgYi9XZWJL aXQucHJpCmluZGV4IGE2MDM5NGIuLjIxMWY2YTQgMTAwNjQ0Ci0tLSBhL1dlYktpdC5wcmkKKysr IGIvV2ViS2l0LnByaQpAQCAtMTAsNiArMTAsOCBAQCBDT05GSUcoc3RhbmRhbG9uZV9wYWNrYWdl KSB7CiAgICAgT1VUUFVUX0RJUj0kJFBXRAogfQogCitDT05GSUcgKz0gZGVwZW5kX2luY2x1ZGVw YXRoCisKIGlzRW1wdHkoT1VUUFVUX0RJUikgewogICAgIENPTkZJRyhkZWJ1ZywgZGVidWd8cmVs ZWFzZSkgewogICAgICAgICBPVVRQVVRfRElSPSQkUFdEL1dlYktpdEJ1aWxkL0RlYnVnCg==