33690 2010-01-14 14:48:56 -0800 Web Inspector: debugger does not work with isolated worlds 2010-01-14 15:41:06 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 33692 1 timothy timothy aroben bweinstein joepeck keishi pfeldman pmuellr rik timothy yurys oldest_to_newest 180940 0 timothy 2010-01-14 14:48:56 -0800 We should make the debugger work with isolated worlds. 180959 1 46612 timothy 2010-01-14 15:20:35 -0800 Created attachment 46612 Proposed Patch 180963 2 46612 aroben 2010-01-14 15:25:23 -0800 Comment on attachment 46612 Proposed Patch Can we get rid of debuggerWorld() now? Any way to write a test? r=me 180968 3 timothy 2010-01-14 15:31:55 -0800 (In reply to comment #2) > (From update of attachment 46612 [details]) > Can we get rid of debuggerWorld() now? debuggerWorld is used by profiling still. I will file a bug about fixing that. > Any way to write a test? Not possible to make a debugger test at this time. 180973 4 timothy 2010-01-14 15:39:27 -0800 Landed in r53295. 46612 2010-01-14 15:20:35 -0800 2010-01-14 15:25:23 -0800 Proposed Patch 0001-Make-the-Web-Inspector-s-JavaScript-debugger-work-wi.patch text/plain 6954 timothy RnJvbSBkNGJlMTA5NDM1Mjk1OGUwN2UzNTJjZDA1OWM5NGVhN2JlNjdjMzUwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUaW1vdGh5IEhhdGNoZXIgPHRpbW90aHlAYXBwbGUuY29tPgpE YXRlOiBUaHUsIDE0IEphbiAyMDEwIDE1OjE0OjM1IC0wODAwClN1YmplY3Q6IFtQQVRDSF0gTWFr ZSB0aGUgV2ViIEluc3BlY3RvcidzIEphdmFTY3JpcHQgZGVidWdnZXIgd29yayB3aXRoIGlzb2xh dGVkIHdvcmxkcy4KIENvbnNvbGUgZXZhbHVhdGlvbiBpcyBub3QgcGVyZm9ybWVkIGluIHRoZSBj b3JyZWN0IHdvcmxkIHlldCwgdHJhY2tlZAogYnkgYnVnIGh0dHA6Ly93ZWJraXQub3JnL2IvMzM2 OTIuCgpodHRwOi8vd2Via2l0Lm9yZy9iLzMzNjkwCgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KCiogYmluZGluZ3MvanMvU2NyaXB0Q2FjaGVkRnJhbWVEYXRhLmNwcDoKKFdlYkNvcmU6OlNj cmlwdENhY2hlZEZyYW1lRGF0YTo6cmVzdG9yZSk6IEF0dGFjaCB0aGUgZGVidWdnZXIgdG8KYW55 IHdpbmRvdyBzaGVsbCwgbm90IGp1c3QgZm9yIHRoZSBkZWJ1Z2dlciB3b3JsZC4KKiBiaW5kaW5n cy9qcy9TY3JpcHRDb250cm9sbGVyLmNwcDoKKFdlYkNvcmU6OlNjcmlwdENvbnRyb2xsZXI6OmNs ZWFyV2luZG93U2hlbGwpOiBEZXRhY2ggdGhlIGRlYnVnZ2VyLCBhbmQKcmVhdHRhY2ggdG8gYWxs IHdpbmRvdyBzaGVsbHMsIG5vdCBqdXN0IGZvciB0aGUgZGVidWdnZXIgd29ybGQuCihXZWJDb3Jl OjpTY3JpcHRDb250cm9sbGVyOjppbml0U2NyaXB0KTogQXR0YWNoIHRoZSBkZWJ1Z2dlciB0bwph bnkgd2luZG93IHNoZWxsLCBub3QganVzdCBmb3IgdGhlIGRlYnVnZ2VyIHdvcmxkLgooV2ViQ29y ZTo6U2NyaXB0Q29udHJvbGxlcjo6YXR0YWNoRGVidWdnZXIpOiBDaGFuZ2VkIHRvIGxvb3AgdGhy b3VnaAphbGwgdGhlIHdpbmRvdyBzaGVsbHMgYW5kIGNhbGwgdGhlIG5ldyBvdmVybG9hZGVkIGF0 dGFjaERlYnVnZ2VyLgooV2ViQ29yZTo6U2NyaXB0Q29udHJvbGxlcjo6YXR0YWNoRGVidWdnZXIp OiBBZGRlZC4gQW4gb3ZlcmxvYWQgdGhhdAp0YWtlcyBhIHdpbmRvdyBzaGVsbCB0byBhdHRhY2gg dGhlIGRlYnVnZ2VyIHRvLiBIYXMgbW9zdCBvZiB0aGUKbG9naWMgZnJvbSB0aGUgb3JpZ2luYWwg YXR0YWNoRGVidWdnZXIuCiogYmluZGluZ3MvanMvU2NyaXB0Q29udHJvbGxlci5oOiBBZGRlZCB0 aGUgbmV3IGF0dGFjaERlYnVnZ2VyLgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAg ICAgICAgICAgICAgICAgICB8ICAgMjUgKysrKysrKysrKysrKysrKysrKysrKysrKwogV2ViQ29y ZS9iaW5kaW5ncy9qcy9TY3JpcHRDYWNoZWRGcmFtZURhdGEuY3BwIHwgICAgNyArKystLS0tCiBX ZWJDb3JlL2JpbmRpbmdzL2pzL1NjcmlwdENvbnRyb2xsZXIuY3BwICAgICAgfCAgIDIzICsrKysr KysrKysrKy0tLS0tLS0tLS0tCiBXZWJDb3JlL2JpbmRpbmdzL2pzL1NjcmlwdENvbnRyb2xsZXIu aCAgICAgICAgfCAgICA0ICsrKy0KIDQgZmlsZXMgY2hhbmdlZCwgNDMgaW5zZXJ0aW9ucygrKSwg MTYgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3Jl L0NoYW5nZUxvZwppbmRleCA0ZjMwODQ1Li4wM2M2ZDgwIDEwMDY0NAotLS0gYS9XZWJDb3JlL0No YW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDEwLTAx LTE0ICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KKworICAgICAgICBNYWtl IHRoZSBXZWIgSW5zcGVjdG9yJ3MgSmF2YVNjcmlwdCBkZWJ1Z2dlciB3b3JrIHdpdGggaXNvbGF0 ZWQgd29ybGRzLgorICAgICAgICBDb25zb2xlIGV2YWx1YXRpb24gaXMgbm90IHBlcmZvcm1lZCBp biB0aGUgY29ycmVjdCB3b3JsZCB5ZXQsIHRyYWNrZWQKKyAgICAgICAgYnkgYnVnIGh0dHA6Ly93 ZWJraXQub3JnL2IvMzM2OTIuCisKKyAgICAgICAgaHR0cDovL3dlYmtpdC5vcmcvYi8zMzY5MAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYmluZGlu Z3MvanMvU2NyaXB0Q2FjaGVkRnJhbWVEYXRhLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlw dENhY2hlZEZyYW1lRGF0YTo6cmVzdG9yZSk6IEF0dGFjaCB0aGUgZGVidWdnZXIgdG8KKyAgICAg ICAgYW55IHdpbmRvdyBzaGVsbCwgbm90IGp1c3QgZm9yIHRoZSBkZWJ1Z2dlciB3b3JsZC4KKyAg ICAgICAgKiBiaW5kaW5ncy9qcy9TY3JpcHRDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlNjcmlwdENvbnRyb2xsZXI6OmNsZWFyV2luZG93U2hlbGwpOiBEZXRhY2ggdGhlIGRlYnVn Z2VyLCBhbmQKKyAgICAgICAgcmVhdHRhY2ggdG8gYWxsIHdpbmRvdyBzaGVsbHMsIG5vdCBqdXN0 IGZvciB0aGUgZGVidWdnZXIgd29ybGQuCisgICAgICAgIChXZWJDb3JlOjpTY3JpcHRDb250cm9s bGVyOjppbml0U2NyaXB0KTogQXR0YWNoIHRoZSBkZWJ1Z2dlciB0bworICAgICAgICBhbnkgd2lu ZG93IHNoZWxsLCBub3QganVzdCBmb3IgdGhlIGRlYnVnZ2VyIHdvcmxkLgorICAgICAgICAoV2Vi Q29yZTo6U2NyaXB0Q29udHJvbGxlcjo6YXR0YWNoRGVidWdnZXIpOiBDaGFuZ2VkIHRvIGxvb3Ag dGhyb3VnaAorICAgICAgICBhbGwgdGhlIHdpbmRvdyBzaGVsbHMgYW5kIGNhbGwgdGhlIG5ldyBv dmVybG9hZGVkIGF0dGFjaERlYnVnZ2VyLgorICAgICAgICAoV2ViQ29yZTo6U2NyaXB0Q29udHJv bGxlcjo6YXR0YWNoRGVidWdnZXIpOiBBZGRlZC4gQW4gb3ZlcmxvYWQgdGhhdAorICAgICAgICB0 YWtlcyBhIHdpbmRvdyBzaGVsbCB0byBhdHRhY2ggdGhlIGRlYnVnZ2VyIHRvLiBIYXMgbW9zdCBv ZiB0aGUKKyAgICAgICAgbG9naWMgZnJvbSB0aGUgb3JpZ2luYWwgYXR0YWNoRGVidWdnZXIuCisg ICAgICAgICogYmluZGluZ3MvanMvU2NyaXB0Q29udHJvbGxlci5oOiBBZGRlZCB0aGUgbmV3IGF0 dGFjaERlYnVnZ2VyLgorCiAyMDEwLTAxLTE0ICBOYXRlIENoYXBpbiAgPGphcGhldEBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGltaXRyaSBHbGF6a292LgpkaWZmIC0tZ2l0 IGEvV2ViQ29yZS9iaW5kaW5ncy9qcy9TY3JpcHRDYWNoZWRGcmFtZURhdGEuY3BwIGIvV2ViQ29y ZS9iaW5kaW5ncy9qcy9TY3JpcHRDYWNoZWRGcmFtZURhdGEuY3BwCmluZGV4IGYyYjY0ZGUuLjE2 ZjE4ZDMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvYmluZGluZ3MvanMvU2NyaXB0Q2FjaGVkRnJhbWVE YXRhLmNwcAorKysgYi9XZWJDb3JlL2JpbmRpbmdzL2pzL1NjcmlwdENhY2hlZEZyYW1lRGF0YS5j cHAKQEAgLTczLDggKzczLDYgQEAgU2NyaXB0Q2FjaGVkRnJhbWVEYXRhOjp+U2NyaXB0Q2FjaGVk RnJhbWVEYXRhKCkKIAogdm9pZCBTY3JpcHRDYWNoZWRGcmFtZURhdGE6OnJlc3RvcmUoRnJhbWUq IGZyYW1lKQogewotICAgIFBhZ2UqIHBhZ2UgPSBmcmFtZS0+cGFnZSgpOwotCiAgICAgSlNMb2Nr IGxvY2soU2lsZW5jZUFzc2VydGlvbnNPbmx5KTsKIAogICAgIFNjcmlwdENvbnRyb2xsZXIqIHNj cmlwdENvbnRyb2xsZXIgPSBmcmFtZS0+c2NyaXB0KCk7CkBAIC04OSw4ICs4Nyw5IEBAIHZvaWQg U2NyaXB0Q2FjaGVkRnJhbWVEYXRhOjpyZXN0b3JlKEZyYW1lKiBmcmFtZSkKICAgICAgICAgICAg IHdpbmRvd1NoZWxsLT5zZXRXaW5kb3cod2luZG93KTsKICAgICAgICAgZWxzZSB7CiAgICAgICAg ICAgICB3aW5kb3dTaGVsbC0+c2V0V2luZG93KGZyYW1lLT5kb21XaW5kb3coKSk7Ci0gICAgICAg ICAgICBpZiAod29ybGQgPT0gZGVidWdnZXJXb3JsZCgpKSB7Ci0gICAgICAgICAgICAgICAgc2Ny aXB0Q29udHJvbGxlci0+YXR0YWNoRGVidWdnZXIocGFnZS0+ZGVidWdnZXIoKSk7CisKKyAgICAg ICAgICAgIGlmIChQYWdlKiBwYWdlID0gZnJhbWUtPnBhZ2UoKSkgeworICAgICAgICAgICAgICAg IHNjcmlwdENvbnRyb2xsZXItPmF0dGFjaERlYnVnZ2VyKHdpbmRvd1NoZWxsLCBwYWdlLT5kZWJ1 Z2dlcigpKTsKICAgICAgICAgICAgICAgICB3aW5kb3dTaGVsbC0+d2luZG93KCktPnNldFByb2Zp bGVHcm91cChwYWdlLT5ncm91cCgpLmlkZW50aWZpZXIoKSk7CiAgICAgICAgICAgICB9CiAgICAg ICAgIH0KZGlmZiAtLWdpdCBhL1dlYkNvcmUvYmluZGluZ3MvanMvU2NyaXB0Q29udHJvbGxlci5j cHAgYi9XZWJDb3JlL2JpbmRpbmdzL2pzL1NjcmlwdENvbnRyb2xsZXIuY3BwCmluZGV4IGJmZGNh YWYuLjk5NWQyZDQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvYmluZGluZ3MvanMvU2NyaXB0Q29udHJv bGxlci5jcHAKKysrIGIvV2ViQ29yZS9iaW5kaW5ncy9qcy9TY3JpcHRDb250cm9sbGVyLmNwcApA QCAtMTgzLDE5ICsxODMsMTcgQEAgdm9pZCBTY3JpcHRDb250cm9sbGVyOjpjbGVhcldpbmRvd1No ZWxsKCkKIAogICAgIEpTTG9jayBsb2NrKFNpbGVuY2VBc3NlcnRpb25zT25seSk7CiAKLSAgICAv LyBDbGVhciB0aGUgZGVidWdnZXIgZnJvbSB0aGUgY3VycmVudCB3aW5kb3cgYmVmb3JlIHNldHRp bmcgdGhlIG5ldyB3aW5kb3cuCi0gICAgRE9NV3JhcHBlcldvcmxkKiBkZWJ1Z1dvcmxkID0gZGVi dWdnZXJXb3JsZCgpOwotICAgIGF0dGFjaERlYnVnZ2VyKDApOwotCiAgICAgZm9yIChTaGVsbE1h cDo6aXRlcmF0b3IgaXRlciA9IG1fd2luZG93U2hlbGxzLmJlZ2luKCk7IGl0ZXIgIT0gbV93aW5k b3dTaGVsbHMuZW5kKCk7ICsraXRlcikgewotICAgICAgICBET01XcmFwcGVyV29ybGQqIHdvcmxk ID0gaXRlci0+Zmlyc3QuZ2V0KCk7CiAgICAgICAgIEpTRE9NV2luZG93U2hlbGwqIHdpbmRvd1No ZWxsID0gaXRlci0+c2Vjb25kOworCisgICAgICAgIC8vIENsZWFyIHRoZSBkZWJ1Z2dlciBmcm9t IHRoZSBjdXJyZW50IHdpbmRvdyBiZWZvcmUgc2V0dGluZyB0aGUgbmV3IHdpbmRvdy4KKyAgICAg ICAgYXR0YWNoRGVidWdnZXIod2luZG93U2hlbGwsIDApOworCiAgICAgICAgIHdpbmRvd1NoZWxs LT53aW5kb3coKS0+d2lsbFJlbW92ZUZyb21XaW5kb3dTaGVsbCgpOwogICAgICAgICB3aW5kb3dT aGVsbC0+c2V0V2luZG93KG1fZnJhbWUtPmRvbVdpbmRvdygpKTsKIAogICAgICAgICBpZiAoUGFn ZSogcGFnZSA9IG1fZnJhbWUtPnBhZ2UoKSkgewotICAgICAgICAgICAgaWYgKHdvcmxkID09IGRl YnVnV29ybGQpCi0gICAgICAgICAgICAgICAgYXR0YWNoRGVidWdnZXIocGFnZS0+ZGVidWdnZXIo KSk7CisgICAgICAgICAgICBhdHRhY2hEZWJ1Z2dlcih3aW5kb3dTaGVsbCwgcGFnZS0+ZGVidWdn ZXIoKSk7CiAgICAgICAgICAgICB3aW5kb3dTaGVsbC0+d2luZG93KCktPnNldFByb2ZpbGVHcm91 cChwYWdlLT5ncm91cCgpLmlkZW50aWZpZXIoKSk7CiAgICAgICAgIH0KICAgICB9CkBAIC0yMTUs OCArMjEzLDcgQEAgSlNET01XaW5kb3dTaGVsbCogU2NyaXB0Q29udHJvbGxlcjo6aW5pdFNjcmlw dChET01XcmFwcGVyV29ybGQqIHdvcmxkKQogICAgIHdpbmRvd1NoZWxsLT53aW5kb3coKS0+dXBk YXRlRG9jdW1lbnQoKTsKIAogICAgIGlmIChQYWdlKiBwYWdlID0gbV9mcmFtZS0+cGFnZSgpKSB7 Ci0gICAgICAgIGlmICh3b3JsZCA9PSBkZWJ1Z2dlcldvcmxkKCkpCi0gICAgICAgICAgICBhdHRh Y2hEZWJ1Z2dlcihwYWdlLT5kZWJ1Z2dlcigpKTsKKyAgICAgICAgYXR0YWNoRGVidWdnZXIod2lu ZG93U2hlbGwsIHBhZ2UtPmRlYnVnZ2VyKCkpOwogICAgICAgICB3aW5kb3dTaGVsbC0+d2luZG93 KCktPnNldFByb2ZpbGVHcm91cChwYWdlLT5ncm91cCgpLmlkZW50aWZpZXIoKSk7CiAgICAgfQog CkBAIC0yOTMsOCArMjkwLDEyIEBAIGJvb2wgU2NyaXB0Q29udHJvbGxlcjo6YW55UGFnZUlzUHJv Y2Vzc2luZ1VzZXJHZXN0dXJlKCkgY29uc3QKIAogdm9pZCBTY3JpcHRDb250cm9sbGVyOjphdHRh Y2hEZWJ1Z2dlcihKU0M6OkRlYnVnZ2VyKiBkZWJ1Z2dlcikKIHsKLSAgICAvLyBGSVhNRTogU2hv dWxkIGJlIGFibGUgdG8gZGVidWcgaXNvbGF0ZWQgd29ybGRzLgotICAgIEpTRE9NV2luZG93U2hl bGwqIHNoZWxsID0gZXhpc3RpbmdXaW5kb3dTaGVsbChkZWJ1Z2dlcldvcmxkKCkpOworICAgIGZv ciAoU2hlbGxNYXA6Oml0ZXJhdG9yIGl0ZXIgPSBtX3dpbmRvd1NoZWxscy5iZWdpbigpOyBpdGVy ICE9IG1fd2luZG93U2hlbGxzLmVuZCgpOyArK2l0ZXIpCisgICAgICAgIGF0dGFjaERlYnVnZ2Vy KGl0ZXItPnNlY29uZCwgZGVidWdnZXIpOworfQorCit2b2lkIFNjcmlwdENvbnRyb2xsZXI6OmF0 dGFjaERlYnVnZ2VyKEpTRE9NV2luZG93U2hlbGwqIHNoZWxsLCBKU0M6OkRlYnVnZ2VyKiBkZWJ1 Z2dlcikKK3sKICAgICBpZiAoIXNoZWxsKQogICAgICAgICByZXR1cm47CiAKZGlmZiAtLWdpdCBh L1dlYkNvcmUvYmluZGluZ3MvanMvU2NyaXB0Q29udHJvbGxlci5oIGIvV2ViQ29yZS9iaW5kaW5n cy9qcy9TY3JpcHRDb250cm9sbGVyLmgKaW5kZXggMzVlYzAyOC4uZjNlNWFkZiAxMDA2NDQKLS0t IGEvV2ViQ29yZS9iaW5kaW5ncy9qcy9TY3JpcHRDb250cm9sbGVyLmgKKysrIGIvV2ViQ29yZS9i aW5kaW5ncy9qcy9TY3JpcHRDb250cm9sbGVyLmgKQEAgLTExMiw3ICsxMTIsOSBAQCBwdWJsaWM6 CiAKICAgICBib29sIGNhbkV4ZWN1dGVTY3JpcHRzKCk7CiAKLSAgICB2b2lkIGF0dGFjaERlYnVn Z2VyKEpTQzo6RGVidWdnZXIqKTsKKyAgICAvLyBEZWJ1Z2dlciBjYW4gYmUgMCB0byBkZXRhY2gg YW55IGV4aXN0aW5nIERlYnVnZ2VyLgorICAgIHZvaWQgYXR0YWNoRGVidWdnZXIoSlNDOjpEZWJ1 Z2dlciopOyAvLyBBdHRhY2hlcy9kZXRhY2hlcyBpbiBhbGwgd29ybGRzL3dpbmRvdyBzaGVsbHMu CisgICAgdm9pZCBhdHRhY2hEZWJ1Z2dlcihKU0RPTVdpbmRvd1NoZWxsKiwgSlNDOjpEZWJ1Z2dl ciopOwogCiAgICAgdm9pZCBzZXRQYXVzZWQoYm9vbCBiKSB7IG1fcGF1c2VkID0gYjsgfQogICAg IGJvb2wgaXNQYXVzZWQoKSBjb25zdCB7IHJldHVybiBtX3BhdXNlZDsgfQotLSAKMS42LjMuMwoK