33687 2010-01-14 14:08:00 -0800 window.onload never fires if page contains a <script src=foo> whose load is cancelled by resource load delegate returning null from willSendRequest 2010-01-15 07:46:14 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 aroben webkit-unassigned eric xan.lopez oldest_to_newest 180913 0 aroben 2010-01-14 14:08:00 -0800 To reproduce: 1. Download the attached test case to LayoutTests/fast/loader 2. run-webkit-tests fast/loader/onload-willSendRequest-null-for-script.html The test will generate no output. It should generate output that includes the text "PASSED". 180915 1 aroben 2010-01-14 14:08:31 -0800 <rdar://problem/7543406> 180919 2 aroben 2010-01-14 14:11:31 -0800 The load of the script is initiated in HTMLTokenizer::scriptHandler with a call to DocLoader::requestScript. The load fails before requestScript returns, but requestScript returns a non-null CachedScript* anyway. HTMLTokenizer then never gets CachedResourceClient::notifyFinished for this script. I think the right fix might be for requestScript to return null in this case. 180922 3 aroben 2010-01-14 14:17:20 -0800 Cache.cpp says <http://trac.webkit.org/browser/trunk/WebCore/loader/Cache.cpp?rev=53151#L134>: // We don't support immediate loads, but we do support immediate failure. But we're missing this particular "immediate failure" case. 180924 4 aroben 2010-01-14 14:21:35 -0800 Cache::requestResource already returns null when the resource's load fails, but only if the cache is disabled. Maybe we should return null when the resource's load fails and the cache is enabled, too? 180933 5 aroben 2010-01-14 14:43:15 -0800 (In reply to comment #4) > Cache::requestResource already returns null when the resource's load fails, but > only if the cache is disabled. Maybe we should return null when the resource's > load fails and the cache is enabled, too? I'm testing a fix that does just this. It fixes this bug, but I need to see if it causes any regression tests to fail. 180936 6 aroben 2010-01-14 14:45:40 -0800 The current "immediate failure" code was added in r21732, for what it's worth: <http://trac.webkit.org/changeset/21732#file2>. 180948 7 46610 aroben 2010-01-14 15:01:37 -0800 Created attachment 46610 Patch 180950 8 aroben 2010-01-14 15:02:51 -0800 I'll add the new test to LayoutTests/platform/qt/Skipped, too. 180951 9 46610 hyatt 2010-01-14 15:03:15 -0800 Comment on attachment 46610 Patch r=me 180952 10 aroben 2010-01-14 15:05:56 -0800 Committed r53292: <http://trac.webkit.org/changeset/53292> 180995 11 eric 2010-01-14 16:26:05 -0800 This looks like this broke the Gtk bots: http://build.webkit.org/results/GTK%20Linux%2032-bit%20Debug/r53294%20(2386)/fast/loader/onload-willSendRequest-null-for-script-diffs.txt --- layout-test-results/fast/loader/onload-willSendRequest-null-for-script-expected.txt 2010-01-14 15:35:03.995244189 -0800 +++ layout-test-results/fast/loader/onload-willSendRequest-null-for-script-actual.txt 2010-01-14 15:35:03.995244189 -0800 @@ -1,3 +1,4 @@ +CONSOLE MESSAGE: line 1: SyntaxError: Parse error Test for Bug 33687: window.onload never fires if page contains a <script src=foo> whose load is cancelled by resource load delegate returning null from willSendRequest. If the test passes, you should see the word "PASSED" below. PASSED 181017 12 eric 2010-01-14 17:14:19 -0800 Adam? Any thoughts on what we should do here for the Gtk bot? Just skip this test? 181053 13 eric 2010-01-14 18:02:35 -0800 Re-opening due to the bot failures. 181229 14 aroben 2010-01-15 07:46:14 -0800 (In reply to comment #12) > Adam? Any thoughts on what we should do here for the Gtk bot? Just skip this > test? Yeah, I guess I was too hopeful about this "just working" on other platforms. The test was adde to GTK+'s Skipped file in r53286. 46610 2010-01-14 15:01:37 -0800 2010-01-14 15:03:15 -0800 Patch bug-33687-20100114180135.patch text/plain 5354 aroben ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA5ZTk1YTFiLi5lMDA4OWU4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTkgQEAKIDIwMTAtMDEt MTQgIEFkYW0gUm9iZW4gIDxhcm9iZW5AYXBwbGUuY29tPgogCisgICAgICAgIEFkZCBhIHRlc3Qg dGhhdCBzaG93cyBvbmxvYWQgc3RpbGwgZmlyZXMgaWYgYSBsb2FkIG9mIGEgPHNjcmlwdCBzcmM+ CisgICAgICAgIGlzIGNhbmNlbGxlZCBieSB0aGUgcmVzb3VyY2UgbG9hZCBkZWxlZ2F0ZQorCisg ICAgICAgIFRlc3RzIGZvciA8aHR0cDovL3dlYmtpdC5vcmcvYi8zMzY4Nz4gd2luZG93Lm9ubG9h ZCBuZXZlciBmaXJlcyBpZgorICAgICAgICBwYWdlIGNvbnRhaW5zIGEgPHNjcmlwdCBzcmM9Zm9v PiB3aG9zZSBsb2FkIGlzIGNhbmNlbGxlZCBieSByZXNvdXJjZQorICAgICAgICBsb2FkIGRlbGVn YXRlIHJldHVybmluZyBudWxsIGZyb20gd2lsbFNlbmRSZXF1ZXN0CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L2xvYWRlci9vbmxvYWQtd2ls bFNlbmRSZXF1ZXN0LW51bGwtZm9yLXNjcmlwdC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAg ICAqIGZhc3QvbG9hZGVyL29ubG9hZC13aWxsU2VuZFJlcXVlc3QtbnVsbC1mb3Itc2NyaXB0Lmh0 bWw6IEFkZGVkLgorCisyMDEwLTAxLTE0ICBBZGFtIFJvYmVuICA8YXJvYmVuQGFwcGxlLmNvbT4K KwogICAgICAgICBBZGQgbmV3IHRlc3QgZnJvbSByNTMyNzcgdG8gdGhlIEdUSysgU2tpcHBlZCBs aXN0CiAKICAgICAgICAgKiBwbGF0Zm9ybS9ndGsvU2tpcHBlZDoKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL2Zhc3QvbG9hZGVyL29ubG9hZC13aWxsU2VuZFJlcXVlc3QtbnVsbC1mb3Itc2NyaXB0 LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvbG9hZGVyL29ubG9hZC13aWxsU2VuZFJl cXVlc3QtbnVsbC1mb3Itc2NyaXB0LWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwLi5jZmJlZjM3Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFz dC9sb2FkZXIvb25sb2FkLXdpbGxTZW5kUmVxdWVzdC1udWxsLWZvci1zY3JpcHQtZXhwZWN0ZWQu dHh0CkBAIC0wLDAgKzEsMyBAQAorVGVzdCBmb3IgQnVnIDMzNjg3OiB3aW5kb3cub25sb2FkIG5l dmVyIGZpcmVzIGlmIHBhZ2UgY29udGFpbnMgYSA8c2NyaXB0IHNyYz1mb28+IHdob3NlIGxvYWQg aXMgY2FuY2VsbGVkIGJ5IHJlc291cmNlIGxvYWQgZGVsZWdhdGUgcmV0dXJuaW5nIG51bGwgZnJv bSB3aWxsU2VuZFJlcXVlc3QuIElmIHRoZSB0ZXN0IHBhc3NlcywgeW91IHNob3VsZCBzZWUgdGhl IHdvcmQgIlBBU1NFRCIgYmVsb3cuCisKK1BBU1NFRApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv ZmFzdC9sb2FkZXIvb25sb2FkLXdpbGxTZW5kUmVxdWVzdC1udWxsLWZvci1zY3JpcHQuaHRtbCBi L0xheW91dFRlc3RzL2Zhc3QvbG9hZGVyL29ubG9hZC13aWxsU2VuZFJlcXVlc3QtbnVsbC1mb3It c2NyaXB0Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uZjMwMjY3Zgot LS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvbG9hZGVyL29ubG9hZC13aWxsU2Vu ZFJlcXVlc3QtbnVsbC1mb3Itc2NyaXB0Lmh0bWwKQEAgLTAsMCArMSwzMCBAQAorPCFET0NUWVBF IGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorICAgIDx0aXRsZT5UZXN0IGZvciBCdWcgMzM2ODc6IHdp bmRvdy5vbmxvYWQgbmV2ZXIgZmlyZXMgaWYgcGFnZSBjb250YWlucyBhICZsdDtzY3JpcHQgc3Jj PWZvbz4KKyAgICB3aG9zZSBsb2FkIGlzIGNhbmNlbGxlZCBieSByZXNvdXJjZSBsb2FkIGRlbGVn YXRlIHJldHVybmluZyBudWxsIGZyb20gd2lsbFNlbmRSZXF1ZXN0PC90aXRsZT4KKyAgICA8c2Ny aXB0PgorICAgICAgICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7CisgICAgICAg ICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisgICAgICAgICAgICBsYXlv dXRUZXN0Q29udHJvbGxlci5zZXRXaWxsU2VuZFJlcXVlc3RSZXR1cm5zTnVsbCh0cnVlKTsKKyAg ICAgICAgfQorCisgICAgICAgIHdpbmRvdy5vbmxvYWQgPSBmdW5jdGlvbigpIHsKKyAgICAgICAg ICAgIHZhciByZXN1bHQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgicmVzdWx0Iik7CisgICAg ICAgICAgICBpZiAoIXdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgeworICAgICAgICAgICAg ICAgIHJlc3VsdC5pbm5lclRleHQgPSAiVGhpcyB0ZXN0IGNhbiBvbmx5IGJlIHJ1biBpbiBEdW1w UmVuZGVyVHJlZS4iOworICAgICAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgICAgIH0KKyAg ICAgICAgICAgIHJlc3VsdC5pbm5lclRleHQgPSAiUEFTU0VEIjsKKyAgICAgICAgfTsKKyAgICA8 L3NjcmlwdD4KKyAgICA8c2NyaXB0IHNyYz0iaHR0cDovL3d3dy5leGFtcGxlLmNvbS8iPjwvc2Ny aXB0PgorPC9oZWFkPgorPGJvZHk+CisgICAgPHA+VGVzdCBmb3IgPGEgaHJlZj0iaHR0cDovL3dl YmtpdC5vcmcvYi8zMzY4NyI+QnVnIDMzNjg3OiB3aW5kb3cub25sb2FkIG5ldmVyIGZpcmVzIGlm IHBhZ2UKKyAgICBjb250YWlucyBhICZsdDtzY3JpcHQgc3JjPWZvbz4gd2hvc2UgbG9hZCBpcyBj YW5jZWxsZWQgYnkgcmVzb3VyY2UgbG9hZCBkZWxlZ2F0ZSByZXR1cm5pbmcgbnVsbAorICAgIGZy b20gd2lsbFNlbmRSZXF1ZXN0PC9hPi4gSWYgdGhlIHRlc3QgcGFzc2VzLCB5b3Ugc2hvdWxkIHNl ZSB0aGUgd29yZCAiUEFTU0VEIiBiZWxvdy48L3A+CisgICAgPGRpdiBpZD1yZXN1bHQ+RkFJTEVE PC9kaXY+Cis8L2JvZHk+Cis8L2h0bWw+CisKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9n IGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODJjMDA5Yy4uYjg1MzA1ZSAxMDA2NDQKLS0tIGEv V2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBA QAorMjAxMC0wMS0xNCAgQWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CisKKyAgICAgICAg TWFrZSBDYWNoZTo6cmVxdWVzdFJlc291cmNlIHJldHVybiAwIGlmIHRoZSByZXNvdXJjZSdzIGxv YWQgZmFpbHMKKyAgICAgICAgaW1tZWRpYXRlbHkKKworICAgICAgICBGaXhlcyA8aHR0cDovL3dl YmtpdC5vcmcvYi8zMzY4Nz4gd2luZG93Lm9ubG9hZCBuZXZlciBmaXJlcyBpZiBwYWdlCisgICAg ICAgIGNvbnRhaW5zIGEgPHNjcmlwdCBzcmM9Zm9vPiB3aG9zZSBsb2FkIGlzIGNhbmNlbGxlZCBi eSByZXNvdXJjZSBsb2FkCisgICAgICAgIGRlbGVnYXRlIHJldHVybmluZyBudWxsIGZyb20gd2ls bFNlbmRSZXF1ZXN0CisKKyAgICAgICAgVGVzdDogZmFzdC9sb2FkZXIvb25sb2FkLXdpbGxTZW5k UmVxdWVzdC1udWxsLWZvci1zY3JpcHQuaHRtbAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogbG9hZGVyL0NhY2hlLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkNhY2hlOjpyZXF1ZXN0UmVzb3VyY2UpOiBNb3ZlZCBjb2RlIHRvIGhhbmRsZSBpbW1lZGlh dGUgbG9hZAorICAgICAgICBmYWlsdXJlIG91dCBvZiB0aGUgImNhY2hlIGlzIGRpc2FibGVkIiBi bG9jayBzbyB0aGF0IGl0IHdpbGwgcnVuIGV2ZW4KKyAgICAgICAgd2hlbiB0aGUgY2FjaGUgaXMg ZW5hYmxlZC4KKwogMjAxMC0wMS0xNCAgS2VudCBIYW5zZW4gIDxrZW50LmhhbnNlbkBub2tpYS5j b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9XZWJD b3JlL2xvYWRlci9DYWNoZS5jcHAgYi9XZWJDb3JlL2xvYWRlci9DYWNoZS5jcHAKaW5kZXggMGI5 NzZiOC4uNDczYmZiYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9sb2FkZXIvQ2FjaGUuY3BwCisrKyBi L1dlYkNvcmUvbG9hZGVyL0NhY2hlLmNwcApAQCAtMTI0LDE5ICsxMjQsMjEgQEAgQ2FjaGVkUmVz b3VyY2UqIENhY2hlOjpyZXF1ZXN0UmVzb3VyY2UoRG9jTG9hZGVyKiBkb2NMb2FkZXIsIENhY2hl ZFJlc291cmNlOjpUeXAKICAgICAgICAgCiAgICAgICAgIHJlc291cmNlLT5sb2FkKGRvY0xvYWRl cik7CiAgICAgICAgIAorICAgICAgICBpZiAocmVzb3VyY2UtPmVycm9yT2NjdXJyZWQoKSkgewor ICAgICAgICAgICAgLy8gV2UgZG9uJ3Qgc3VwcG9ydCBpbW1lZGlhdGUgbG9hZHMsIGJ1dCB3ZSBk byBzdXBwb3J0IGltbWVkaWF0ZSBmYWlsdXJlLgorICAgICAgICAgICAgLy8gSW4gdGhhdCBjYXNl IHdlIHNob3VsZCB0byBkZWxldGUgdGhlIHJlc291cmNlIG5vdyBhbmQgcmV0dXJuIDAgYmVjYXVz ZSBvdGhlcndpc2UKKyAgICAgICAgICAgIC8vIGl0IHdvdWxkIGxlYWsgaWYgbm8gcmVmL2RlcmVm IHdhcyBldmVyIGRvbmUgb24gaXQuCisgICAgICAgICAgICByZXNvdXJjZS0+c2V0SW5DYWNoZShm YWxzZSk7CisgICAgICAgICAgICBkZWxldGUgcmVzb3VyY2U7CisgICAgICAgICAgICByZXR1cm4g MDsKKyAgICAgICAgfQorCiAgICAgICAgIGlmICghZGlzYWJsZWQoKSkKICAgICAgICAgICAgIG1f cmVzb3VyY2VzLnNldCh1cmwuc3RyaW5nKCksIHJlc291cmNlKTsgIC8vIFRoZSBzaXplIHdpbGwg YmUgYWRkZWQgaW4gbGF0ZXIgb25jZSB0aGUgcmVzb3VyY2UgaXMgbG9hZGVkIGFuZCBjYWxscyBi YWNrIHRvIHVzIHdpdGggdGhlIG5ldyBzaXplLgogICAgICAgICBlbHNlIHsKICAgICAgICAgICAg IC8vIEtpY2sgdGhlIHJlc291cmNlIG91dCBvZiB0aGUgY2FjaGUsIGJlY2F1c2UgdGhlIGNhY2hl IGlzIGRpc2FibGVkLgogICAgICAgICAgICAgcmVzb3VyY2UtPnNldEluQ2FjaGUoZmFsc2UpOwog ICAgICAgICAgICAgcmVzb3VyY2UtPnNldERvY0xvYWRlcihkb2NMb2FkZXIpOwotICAgICAgICAg ICAgaWYgKHJlc291cmNlLT5lcnJvck9jY3VycmVkKCkpIHsKLSAgICAgICAgICAgICAgICAvLyBX ZSBkb24ndCBzdXBwb3J0IGltbWVkaWF0ZSBsb2FkcywgYnV0IHdlIGRvIHN1cHBvcnQgaW1tZWRp YXRlIGZhaWx1cmUuCi0gICAgICAgICAgICAgICAgLy8gSW4gdGhhdCBjYXNlIHdlIHNob3VsZCB0 byBkZWxldGUgdGhlIHJlc291cmNlIG5vdyBhbmQgcmV0dXJuIDAgYmVjYXVzZSBvdGhlcndpc2UK LSAgICAgICAgICAgICAgICAvLyBpdCB3b3VsZCBsZWFrIGlmIG5vIHJlZi9kZXJlZiB3YXMgZXZl ciBkb25lIG9uIGl0LgotICAgICAgICAgICAgICAgIGRlbGV0ZSByZXNvdXJjZTsKLSAgICAgICAg ICAgICAgICByZXR1cm4gMDsKLSAgICAgICAgICAgIH0KICAgICAgICAgfQogICAgIH0KIAo=