33679 2010-01-14 09:52:51 -0800 [Android] Android requires Geolocation::suspend/resume to be public 2010-01-15 12:53:28 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Android Android RESOLVED FIXED P2 Normal --- 1 steveblock steveblock android-webkit-unforking commit-queue eric sam steveblock oldest_to_newest 180756 0 steveblock 2010-01-14 09:52:51 -0800 Android requires Geolocation::suspend/resume to be public. These were made private in https://bugs.webkit.org/show_bug.cgi?id=32499 180766 1 46582 steveblock 2010-01-14 10:04:49 -0800 Created attachment 46582 Patch 1 for Bug 33679 180773 2 46584 steveblock 2010-01-14 10:25:08 -0800 Created attachment 46584 Patch 2 for Bug 33679 180775 3 46585 steveblock 2010-01-14 10:29:51 -0800 Created attachment 46585 Patch 3 for Bug 33679 181020 4 46585 eric 2010-01-14 17:19:17 -0800 Comment on attachment 46585 Patch 3 for Bug 33679 Why don't the other ports need these public? 181021 5 eric 2010-01-14 17:19:44 -0800 Who else works on Geolocation (outside of Android) who should be CC'd on geolocation bugs? 181163 6 steveblock 2010-01-15 02:19:05 -0800 (In reply to comment #4) > (From update of attachment 46585 [details]) > Why don't the other ports need these public? I'm not sure, but I don't think that any other ports have complete Geolocation implementations fully upstreamed to WebKit. Android uses these methods to disable the GPS when a page using Geolocation is not in the foreground, to save battery. > Who else works on Geolocation (outside of Android) who should be CC'd on > geolocation bugs? Nobody. Sam (already cc'ed) wrote the change in Bug 32499 which introduced this breakage, and said he'd put back the suspend/resume methods. 181265 7 46585 eric 2010-01-15 10:07:41 -0800 Comment on attachment 46585 Patch 3 for Bug 33679 OK. 181334 8 46585 commit-queue 2010-01-15 12:53:21 -0800 Comment on attachment 46585 Patch 3 for Bug 33679 Clearing flags on attachment: 46585 Committed r53342: <http://trac.webkit.org/changeset/53342> 181335 9 commit-queue 2010-01-15 12:53:28 -0800 All reviewed patches have been landed. Closing bug. 46582 2010-01-14 10:04:49 -0800 2010-01-14 10:25:08 -0800 Patch 1 for Bug 33679 geolocationSuspendResumePublic.txt text/plain 1614 steveblock SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MzI2OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDEtMTQgIFN0ZXZlIEJsb2NrICA8c3RldmVibG9ja0Bnb29n bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IE1ha2UgR2VvbG9jYXRpb246OnN1c3BlbmQvcmVzdW1lIHB1YmxpYy4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMzNjc5CisKKyAgICAgICAgVGhlc2Ug d2VyZSBtYWRlIHByaXZhdGUgaW4gQnVnIDMyNDk5LCBidXQgYXJlIHJlcXVpcmVkIGJ5IEFuZHJv aWQgdG8gYmUgcHVibGljLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgYnVpbGQgZml4IG9ubHku CisKKyAgICAgICAgKiBwYWdlL0dlb2xvY2F0aW9uLmg6IE1vZGlmaWVkLiBNYWtlIHN1c3BlbmQg YW5kIHJlc3VtZSBwdWJsaWMKKwogMjAxMC0wMS0xNCAgTWFydGluIFJvYmluc29uICA8bWFydGlu LmphbWVzLnJvYmluc29uQGdtYWlsLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBYYW4gTG9w ZXouCkluZGV4OiBXZWJDb3JlL3BhZ2UvR2VvbG9jYXRpb24uaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJD b3JlL3BhZ2UvR2VvbG9jYXRpb24uaAkocmV2aXNpb24gNTMyNjkpCisrKyBXZWJDb3JlL3BhZ2Uv R2VvbG9jYXRpb24uaAkod29ya2luZyBjb3B5KQpAQCAtNjgsNyArNjgsMTAgQEAgcHVibGljOgog ICAgIHZvaWQgZ2V0Q3VycmVudFBvc2l0aW9uKFBhc3NSZWZQdHI8UG9zaXRpb25DYWxsYmFjaz4s IFBhc3NSZWZQdHI8UG9zaXRpb25FcnJvckNhbGxiYWNrPiwgUGFzc1JlZlB0cjxQb3NpdGlvbk9w dGlvbnM+KTsKICAgICBpbnQgd2F0Y2hQb3NpdGlvbihQYXNzUmVmUHRyPFBvc2l0aW9uQ2FsbGJh Y2s+LCBQYXNzUmVmUHRyPFBvc2l0aW9uRXJyb3JDYWxsYmFjaz4sIFBhc3NSZWZQdHI8UG9zaXRp b25PcHRpb25zPik7CiAgICAgdm9pZCBjbGVhcldhdGNoKGludCB3YXRjaElkKTsKLSAgICAKKwor ICAgIHZvaWQgc3VzcGVuZCgpOworICAgIHZvaWQgcmVzdW1lKCk7CisKICAgICB2b2lkIHNldElz QWxsb3dlZChib29sKTsKICAgICBib29sIGlzQWxsb3dlZCgpIGNvbnN0IHsgcmV0dXJuIG1fYWxs b3dHZW9sb2NhdGlvbiA9PSBZZXM7IH0KICAgICBib29sIGlzRGVuaWVkKCkgY29uc3QgeyByZXR1 cm4gbV9hbGxvd0dlb2xvY2F0aW9uID09IE5vOyB9CkBAIC0xMzcsOCArMTQwLDYgQEAgcHJpdmF0 ZToKIAogICAgIGJvb2wgc3RhcnRVcGRhdGluZyhQb3NpdGlvbk9wdGlvbnMqKTsKICAgICB2b2lk IHN0b3BVcGRhdGluZygpOwotICAgIHZvaWQgc3VzcGVuZCgpOwotICAgIHZvaWQgcmVzdW1lKCk7 CiAKICNpZiAhRU5BQkxFKENMSUVOVF9CQVNFRF9HRU9MT0NBVElPTikKICAgICAvLyBHZW9sb2Nh dGlvblNlcnZpY2VDbGllbnQK 46584 2010-01-14 10:25:08 -0800 2010-01-14 10:29:51 -0800 Patch 2 for Bug 33679 geolocationSuspendResumePublic2.txt text/plain 2340 steveblock SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MzI2OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMDEtMTQgIFN0ZXZlIEJsb2NrICA8c3RldmVibG9ja0Bnb29n bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IE1ha2UgR2VvbG9jYXRpb246OnN1c3BlbmQvcmVzdW1lIHB1YmxpYy4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMzNjc5CisKKyAgICAgICAgVGhlc2Ug d2VyZSBtYWRlIHByaXZhdGUgaW4gQnVnIDMyNDk5LCBidXQgYXJlIHJlcXVpcmVkIGJ5IEFuZHJv aWQgdG8gYmUgcHVibGljLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgYnVpbGQgZml4IG9ubHku CisKKyAgICAgICAgKiBwYWdlL0dlb2xvY2F0aW9uLmNwcDogTW9kaWZpZWQKKyAgICAgICAgKFdl YkNvcmU6Okdlb2xvY2F0aW9uOjpzdXNwZW5kKTogQWRkZWQgYmFjayBpbgorICAgICAgICAoV2Vi Q29yZTo6R2VvbG9jYXRpb246OnJlc3VtZSk6IEFkZGVkIGJhY2sgaW4KKyAgICAgICAgKiBwYWdl L0dlb2xvY2F0aW9uLmg6IE1vZGlmaWVkLiBNYWtlIHN1c3BlbmQgYW5kIHJlc3VtZSBwdWJsaWMK KwogMjAxMC0wMS0xNCAgTWFydGluIFJvYmluc29uICA8bWFydGluLmphbWVzLnJvYmluc29uQGdt YWlsLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBYYW4gTG9wZXouCkluZGV4OiBXZWJDb3Jl L3BhZ2UvR2VvbG9jYXRpb24uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGFnZS9HZW9sb2Nh dGlvbi5jcHAJKHJldmlzaW9uIDUzMjY5KQorKysgV2ViQ29yZS9wYWdlL0dlb2xvY2F0aW9uLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMjc4LDYgKzI3OCwxOCBAQCB2b2lkIEdlb2xvY2F0aW9uOjpj bGVhcldhdGNoKGludCB3YXRjaElkCiAgICAgICAgIHN0b3BVcGRhdGluZygpOwogfQogCit2b2lk IEdlb2xvY2F0aW9uOjpzdXNwZW5kKCkKK3sKKyAgICBpZiAoaGFzTGlzdGVuZXJzKCkpCisgICAg ICAgIG1fc2VydmljZS0+c3VzcGVuZCgpOworfQorCit2b2lkIEdlb2xvY2F0aW9uOjpyZXN1bWUo KQoreworICAgIGlmIChoYXNMaXN0ZW5lcnMoKSkKKyAgICAgICAgbV9zZXJ2aWNlLT5yZXN1bWUo KTsKK30KKwogdm9pZCBHZW9sb2NhdGlvbjo6c2V0SXNBbGxvd2VkKGJvb2wgYWxsb3dlZCkKIHsK ICAgICBtX2FsbG93R2VvbG9jYXRpb24gPSBhbGxvd2VkID8gWWVzIDogTm87CkluZGV4OiBXZWJD b3JlL3BhZ2UvR2VvbG9jYXRpb24uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvR2VvbG9j YXRpb24uaAkocmV2aXNpb24gNTMyNjkpCisrKyBXZWJDb3JlL3BhZ2UvR2VvbG9jYXRpb24uaAko d29ya2luZyBjb3B5KQpAQCAtNjgsNyArNjgsMTAgQEAgcHVibGljOgogICAgIHZvaWQgZ2V0Q3Vy cmVudFBvc2l0aW9uKFBhc3NSZWZQdHI8UG9zaXRpb25DYWxsYmFjaz4sIFBhc3NSZWZQdHI8UG9z aXRpb25FcnJvckNhbGxiYWNrPiwgUGFzc1JlZlB0cjxQb3NpdGlvbk9wdGlvbnM+KTsKICAgICBp bnQgd2F0Y2hQb3NpdGlvbihQYXNzUmVmUHRyPFBvc2l0aW9uQ2FsbGJhY2s+LCBQYXNzUmVmUHRy PFBvc2l0aW9uRXJyb3JDYWxsYmFjaz4sIFBhc3NSZWZQdHI8UG9zaXRpb25PcHRpb25zPik7CiAg ICAgdm9pZCBjbGVhcldhdGNoKGludCB3YXRjaElkKTsKLSAgICAKKworICAgIHZvaWQgc3VzcGVu ZCgpOworICAgIHZvaWQgcmVzdW1lKCk7CisKICAgICB2b2lkIHNldElzQWxsb3dlZChib29sKTsK ICAgICBib29sIGlzQWxsb3dlZCgpIGNvbnN0IHsgcmV0dXJuIG1fYWxsb3dHZW9sb2NhdGlvbiA9 PSBZZXM7IH0KICAgICBib29sIGlzRGVuaWVkKCkgY29uc3QgeyByZXR1cm4gbV9hbGxvd0dlb2xv Y2F0aW9uID09IE5vOyB9CkBAIC0xMzcsOCArMTQwLDYgQEAgcHJpdmF0ZToKIAogICAgIGJvb2wg c3RhcnRVcGRhdGluZyhQb3NpdGlvbk9wdGlvbnMqKTsKICAgICB2b2lkIHN0b3BVcGRhdGluZygp OwotICAgIHZvaWQgc3VzcGVuZCgpOwotICAgIHZvaWQgcmVzdW1lKCk7CiAKICNpZiAhRU5BQkxF KENMSUVOVF9CQVNFRF9HRU9MT0NBVElPTikKICAgICAvLyBHZW9sb2NhdGlvblNlcnZpY2VDbGll bnQK 46585 2010-01-14 10:29:51 -0800 2010-01-15 12:53:21 -0800 Patch 3 for Bug 33679 geolocationSuspendResumePublic3.txt text/plain 2434 steveblock SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MzI2OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMDEtMTQgIFN0ZXZlIEJsb2NrICA8c3RldmVibG9ja0Bnb29n bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IE1ha2UgR2VvbG9jYXRpb246OnN1c3BlbmQvcmVzdW1lIHB1YmxpYy4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMzNjc5CisKKyAgICAgICAgVGhlc2Ug d2VyZSBtYWRlIHByaXZhdGUgaW4gQnVnIDMyNDk5LCBidXQgYXJlIHJlcXVpcmVkIGJ5IEFuZHJv aWQgdG8gYmUgcHVibGljLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgYnVpbGQgZml4IG9ubHku CisKKyAgICAgICAgKiBwYWdlL0dlb2xvY2F0aW9uLmNwcDogTW9kaWZpZWQKKyAgICAgICAgKFdl YkNvcmU6Okdlb2xvY2F0aW9uOjpzdXNwZW5kKTogQWRkZWQgYmFjayBpbgorICAgICAgICAoV2Vi Q29yZTo6R2VvbG9jYXRpb246OnJlc3VtZSk6IEFkZGVkIGJhY2sgaW4KKyAgICAgICAgKiBwYWdl L0dlb2xvY2F0aW9uLmg6IE1vZGlmaWVkLiBNYWtlIHN1c3BlbmQgYW5kIHJlc3VtZSBwdWJsaWMK KwogMjAxMC0wMS0xNCAgTWFydGluIFJvYmluc29uICA8bWFydGluLmphbWVzLnJvYmluc29uQGdt YWlsLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBYYW4gTG9wZXouCkluZGV4OiBXZWJDb3Jl L3BhZ2UvR2VvbG9jYXRpb24uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGFnZS9HZW9sb2Nh dGlvbi5jcHAJKHJldmlzaW9uIDUzMjY5KQorKysgV2ViQ29yZS9wYWdlL0dlb2xvY2F0aW9uLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMjc4LDYgKzI3OCwyMiBAQCB2b2lkIEdlb2xvY2F0aW9uOjpj bGVhcldhdGNoKGludCB3YXRjaElkCiAgICAgICAgIHN0b3BVcGRhdGluZygpOwogfQogCit2b2lk IEdlb2xvY2F0aW9uOjpzdXNwZW5kKCkKK3sKKyNpZiAhRU5BQkxFKENMSUVOVF9CQVNFRF9HRU9M T0NBVElPTikKKyAgICBpZiAoaGFzTGlzdGVuZXJzKCkpCisgICAgICAgIG1fc2VydmljZS0+c3Vz cGVuZCgpOworI2VuZGlmCit9CisKK3ZvaWQgR2VvbG9jYXRpb246OnJlc3VtZSgpCit7CisjaWYg IUVOQUJMRShDTElFTlRfQkFTRURfR0VPTE9DQVRJT04pCisgICAgaWYgKGhhc0xpc3RlbmVycygp KQorICAgICAgICBtX3NlcnZpY2UtPnJlc3VtZSgpOworI2VuZGlmCit9CisKIHZvaWQgR2VvbG9j YXRpb246OnNldElzQWxsb3dlZChib29sIGFsbG93ZWQpCiB7CiAgICAgbV9hbGxvd0dlb2xvY2F0 aW9uID0gYWxsb3dlZCA/IFllcyA6IE5vOwpJbmRleDogV2ViQ29yZS9wYWdlL0dlb2xvY2F0aW9u LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wYWdlL0dlb2xvY2F0aW9uLmgJKHJldmlzaW9uIDUz MjY5KQorKysgV2ViQ29yZS9wYWdlL0dlb2xvY2F0aW9uLmgJKHdvcmtpbmcgY29weSkKQEAgLTY4 LDcgKzY4LDEwIEBAIHB1YmxpYzoKICAgICB2b2lkIGdldEN1cnJlbnRQb3NpdGlvbihQYXNzUmVm UHRyPFBvc2l0aW9uQ2FsbGJhY2s+LCBQYXNzUmVmUHRyPFBvc2l0aW9uRXJyb3JDYWxsYmFjaz4s IFBhc3NSZWZQdHI8UG9zaXRpb25PcHRpb25zPik7CiAgICAgaW50IHdhdGNoUG9zaXRpb24oUGFz c1JlZlB0cjxQb3NpdGlvbkNhbGxiYWNrPiwgUGFzc1JlZlB0cjxQb3NpdGlvbkVycm9yQ2FsbGJh Y2s+LCBQYXNzUmVmUHRyPFBvc2l0aW9uT3B0aW9ucz4pOwogICAgIHZvaWQgY2xlYXJXYXRjaChp bnQgd2F0Y2hJZCk7Ci0gICAgCisKKyAgICB2b2lkIHN1c3BlbmQoKTsKKyAgICB2b2lkIHJlc3Vt ZSgpOworCiAgICAgdm9pZCBzZXRJc0FsbG93ZWQoYm9vbCk7CiAgICAgYm9vbCBpc0FsbG93ZWQo KSBjb25zdCB7IHJldHVybiBtX2FsbG93R2VvbG9jYXRpb24gPT0gWWVzOyB9CiAgICAgYm9vbCBp c0RlbmllZCgpIGNvbnN0IHsgcmV0dXJuIG1fYWxsb3dHZW9sb2NhdGlvbiA9PSBObzsgfQpAQCAt MTM3LDggKzE0MCw2IEBAIHByaXZhdGU6CiAKICAgICBib29sIHN0YXJ0VXBkYXRpbmcoUG9zaXRp b25PcHRpb25zKik7CiAgICAgdm9pZCBzdG9wVXBkYXRpbmcoKTsKLSAgICB2b2lkIHN1c3BlbmQo KTsKLSAgICB2b2lkIHJlc3VtZSgpOwogCiAjaWYgIUVOQUJMRShDTElFTlRfQkFTRURfR0VPTE9D QVRJT04pCiAgICAgLy8gR2VvbG9jYXRpb25TZXJ2aWNlQ2xpZW50Cg==