33663 2010-01-14 02:57:39 -0800 check-webkit-style underscore check should be disabled for Qt methods starting with qt_ 2010-01-17 18:06:25 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED Qt P3 Normal --- 1 kenneth webkit-unassigned abarth cjerdonek commit-queue eric hamaji levin robert oldest_to_newest 180647 0 kenneth 2010-01-14 02:57:39 -0800 check-webkit-style underscore check should be disabled for Qt methods starting with qt_, as Qt uses that for private API, such as for the DRT only. 180657 1 eric 2010-01-14 03:09:06 -0800 We could even restrict this allowance to the qt directory, although allowing qt_ anywhere is really not a problem either. 180661 2 kenneth 2010-01-14 03:32:08 -0800 I would still like the underscore check so make sure that the patches we receive do not use names like _privateMessage() etc. 181632 3 46763 abarth 2010-01-17 15:46:45 -0800 Created attachment 46763 Patch 181644 4 abarth 2010-01-17 16:06:41 -0800 *** Bug 33116 has been marked as a duplicate of this bug. *** 181673 5 46763 hamaji 2010-01-17 17:35:09 -0800 Comment on attachment 46763 Patch Thanks for fixing this issue! 181680 6 46763 commit-queue 2010-01-17 18:06:16 -0800 Comment on attachment 46763 Patch Clearing flags on attachment: 46763 Committed r53381: <http://trac.webkit.org/changeset/53381> 181681 7 commit-queue 2010-01-17 18:06:25 -0800 All reviewed patches have been landed. Closing bug. 46763 2010-01-17 15:46:45 -0800 2010-01-17 18:06:16 -0800 Patch bug-33663-20100117154644.patch text/plain 2491 abarth SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDUzMzczKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDEtMTcgIEFkYW0gQmFydGggIDxhYmFy dGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBjaGVjay13ZWJraXQtc3R5bGUgdW5kZXJzY29yZSBjaGVjayBzaG91bGQgYmUgZGlz YWJsZWQgZm9yIFF0IG1ldGhvZHMgc3RhcnRpbmcgd2l0aCBxdF8KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMzNjYzCisKKyAgICAgICAgKiBTY3JpcHRz L3dlYmtpdHB5L3N0eWxlL2NwcF9zdHlsZS5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5 L3N0eWxlL2NwcF9zdHlsZV91bml0dGVzdC5weToKKwogMjAxMC0wMS0xNSAgSm9uIEhvbmV5Y3V0 dCAgPGpob25leWN1dHRAYXBwbGUuY29tPgogCiAgICAgICAgIGdldF9hY2NQYXJlbnQgc2hvdWxk IHRyeSB0byByZXRyaWV2ZSBwYXJlbnQgQWNjZXNzaWJpbGl0eU9iamVjdCwgYmVmb3JlCkluZGV4 OiBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NwcF9zdHlsZS5weQo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NwcF9zdHlsZS5weQko cmV2aXNpb24gNTMzNzIpCisrKyBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2Nw cF9zdHlsZS5weQkod29ya2luZyBjb3B5KQpAQCAtMjQ5MSw2ICsyNDkxLDggQEAgZGVmIGNoZWNr X2lkZW50aWZpZXJfbmFtZV9pbl9kZWNsYXJhdGlvbgogICAgICAgICAgICAgIyBWYXJpb3VzIGV4 Y2VwdGlvbnMgdG8gdGhlIHJ1bGU6IEphdmFTY3JpcHQgb3AgY29kZXMgZnVuY3Rpb25zLCBjb25z dF9pdGVyYXRvci4KICAgICAgICAgICAgIGlmIChub3QgKGZpbGVuYW1lLmZpbmQoJ0phdmFTY3Jp cHRDb3JlJykgPj0gMCBhbmQgbW9kaWZpZWRfaWRlbnRpZmllci5maW5kKCdfb3BfJykgPj0gMCkK ICAgICAgICAgICAgICAgICBhbmQgbm90IG1vZGlmaWVkX2lkZW50aWZpZXIuc3RhcnRzd2l0aCgn dHN0XycpCisgICAgICAgICAgICAgICAgYW5kIG5vdCBtb2RpZmllZF9pZGVudGlmaWVyLnN0YXJ0 c3dpdGgoJ3F0XycpCisgICAgICAgICAgICAgICAgYW5kIG5vdCBtb2RpZmllZF9pZGVudGlmaWVy LmZpbmQoJzo6cXRfJykgPj0gMAogICAgICAgICAgICAgICAgIGFuZCBub3QgbW9kaWZpZWRfaWRl bnRpZmllciA9PSAiY29uc3RfaXRlcmF0b3IiKToKICAgICAgICAgICAgICAgICBlcnJvcihmaWxl bmFtZSwgbGluZV9udW1iZXIsICdyZWFkYWJpbGl0eS9uYW1pbmcnLCA0LCBpZGVudGlmaWVyICsg IiBpcyBpbmNvcnJlY3RseSBuYW1lZC4gRG9uJ3QgdXNlIHVuZGVyc2NvcmVzIGluIHlvdXIgaWRl bnRpZmllciBuYW1lcy4iKQogCkluZGV4OiBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0 eWxlL2NwcF9zdHlsZV91bml0dGVzdC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9TY3Jp cHRzL3dlYmtpdHB5L3N0eWxlL2NwcF9zdHlsZV91bml0dGVzdC5weQkocmV2aXNpb24gNTMzNzIp CisrKyBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NwcF9zdHlsZV91bml0dGVz dC5weQkod29ya2luZyBjb3B5KQpAQCAtMzU0Nyw2ICszNTQ3LDEwIEBAIGNsYXNzIFdlYktpdFN0 eWxlVGVzdChDcHBTdHlsZVRlc3RCYXNlKToKICAgICAgICAgIyBUaGVyZSBpcyBhbiBleGNlcHRp b24gZm9yIHNvbWUgdW5pdCB0ZXN0cyB0aGF0IGJlZ2luIHdpdGggInRzdF8iLgogICAgICAgICBz ZWxmLmFzc2VydF9saW50KCd2b2lkIHRzdF9RV2ViRnJhbWU6OmFycmF5T2JqZWN0RW51bWVyYWJs ZShpbnQgdmFyMSwgaW50IHZhcjIpJywgJycpCiAKKyAgICAgICAgIyBUaGUgUXQgQVBJIHVzZXMg bmFtZXMgdGhhdCBiZWdpbiB3aXRoICJxdF8iLgorICAgICAgICBzZWxmLmFzc2VydF9saW50KCd2 b2lkIFFURnJhbWU6OnF0X2RydF9pc19hd2Vzb21lKGludCB2YXIxLCBpbnQgdmFyMiknLCAnJykK KyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgndm9pZCBxdF9kcnRfaXNfYXdlc29tZShpbnQgdmFy MSwgaW50IHZhcjIpOycsICcnKQorCiAgICAgICAgICMgY29uc3RfaXRlcmF0b3IgaXMgYWxsb3dl ZCBhcyB3ZWxsLgogICAgICAgICBzZWxmLmFzc2VydF9saW50KCd0eXBlZGVmIFZlY3RvclR5cGU6 OmNvbnN0X2l0ZXJhdG9yIGNvbnN0X2l0ZXJhdG9yOycsICcnKQogCg==