33660 2010-01-14 01:50:58 -0800 [Chromium] Fix a bug that a selected word is not recognized as a spell-check source. 2010-01-31 17:45:51 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 tkent webkit-unassigned eric fishd yaar oldest_to_newest 180613 0 tkent 2010-01-14 01:50:58 -0800 [Chromium] Fix a bug that a selected word is not recognized as a spell-check source. 180616 1 46549 tkent 2010-01-14 01:52:57 -0800 Created attachment 46549 Patch 180637 2 tkent 2010-01-14 02:37:34 -0800 The current implementation of isASingleWord() means: "true if the text has no characters." 181025 3 eric 2010-01-14 17:22:26 -0800 You should CC people who you think could best review this. I'm not familiar with this code. 181067 4 tkent 2010-01-14 18:33:43 -0800 isASingleWord() implementation was changed during upstreaming WebKit API. The last revision in Chromium repository seems to have a correct implementation. http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/context_menu_client_impl.cc?annotate=29390&pathrev=29813 181097 5 tkent 2010-01-14 21:41:57 -0800 (In reply to comment #4) > isASingleWord() implementation was changed during upstreaming WebKit API. > The last revision in Chromium repository seems to have a correct > implementation. > > http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/context_menu_client_impl.cc?annotate=29390&pathrev=29813 Correction: It was changed by Chromium r29814, http://src.chromium.org/viewvc/chrome?view=rev&revision=29814, Moving it from webkit/glue/ to webkit/api/src. 186174 6 46549 jorlow 2010-01-31 00:05:39 -0800 Comment on attachment 46549 Patch I don't know this code super well, but assuming this is just up-streaming a downstream fix (that was presumably reviewed): r=me 186267 7 tkent 2010-01-31 17:45:51 -0800 Landed as r54119 <http://trac.webkit.org/changeset/54119> 46549 2010-01-14 01:52:57 -0800 2010-01-31 00:05:39 -0800 Patch bug-33660-20100114185255.patch text/plain 1587 tkent ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDU0ZDA3ZTAuLjY4ZDJlODIgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE1IEBACisyMDEwLTAxLTE0ICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbQ2hyb21pdW1d IEZpeCBhIGJ1ZyB0aGF0IGEgc2VsZWN0ZWQgd29yZCBpcyBub3QgcmVjb2duaXplZCBhcyBhCisg ICAgICAgIHNwZWxsLWNoZWNrIHNvdXJjZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTMzNjYwCisKKyAgICAgICAgKiBzcmMvQ29udGV4dE1lbnVDbGll bnRJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6aXNBU2luZ2xlV29yZCk6IFVzZSB3b3JkQnJl YWtJdGVyYXRvcigpLCBhbmQgY29ycmVjdGx5IGNoZWNrCisgICAgICAgIHRoZSByZXR1cm4gdmFs dWUgb2YgdGV4dEJyZWFrTmV4dCgpLgorCiAyMDEwLTAxLTEzICBKb24gSG9uZXljdXR0ICA8amhv bmV5Y3V0dEBhcHBsZS5jb20+CiAKICAgICAgICAgTVNBQTogc2VsZWN0ZWQsIHNlbGVjdGFibGUs IGV4dGVuZGVkIHNlbGVjdGFibGUsIGFuZCBtdWx0aXBsZQpkaWZmIC0tZ2l0IGEvV2ViS2l0L2No cm9taXVtL3NyYy9Db250ZXh0TWVudUNsaWVudEltcGwuY3BwIGIvV2ViS2l0L2Nocm9taXVtL3Ny Yy9Db250ZXh0TWVudUNsaWVudEltcGwuY3BwCmluZGV4IGYyMzkxOWUuLjA3Nzk5OTQgMTAwNjQ0 Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9zcmMvQ29udGV4dE1lbnVDbGllbnRJbXBsLmNwcAorKysg Yi9XZWJLaXQvY2hyb21pdW0vc3JjL0NvbnRleHRNZW51Q2xpZW50SW1wbC5jcHAKQEAgLTc5LDEx ICs3OSwxMSBAQCBzdGF0aWMgV2ViVVJMIHVybEZyb21GcmFtZShGcmFtZSogZnJhbWUpCiAgICAg cmV0dXJuIFdlYlVSTCgpOwogfQogCi0vLyBIZWxwZXIgZnVuY3Rpb24gdG8gZGV0ZXJtaW5lIHdo ZXRoZXIgdGV4dCBpcyBhIHNpbmdsZSB3b3JkIG9yIGEgc2VudGVuY2UuCisvLyBIZWxwZXIgZnVu Y3Rpb24gdG8gZGV0ZXJtaW5lIHdoZXRoZXIgdGV4dCBpcyBhIHNpbmdsZSB3b3JkLgogc3RhdGlj IGJvb2wgaXNBU2luZ2xlV29yZChjb25zdCBTdHJpbmcmIHRleHQpCiB7Ci0gICAgVGV4dEJyZWFr SXRlcmF0b3IqIGl0ID0gY2hhcmFjdGVyQnJlYWtJdGVyYXRvcih0ZXh0LmNoYXJhY3RlcnMoKSwg dGV4dC5sZW5ndGgoKSk7Ci0gICAgcmV0dXJuIGl0ICYmIHRleHRCcmVha05leHQoaXQpID09IFRl eHRCcmVha0RvbmU7CisgICAgVGV4dEJyZWFrSXRlcmF0b3IqIGl0ID0gd29yZEJyZWFrSXRlcmF0 b3IodGV4dC5jaGFyYWN0ZXJzKCksIHRleHQubGVuZ3RoKCkpOworICAgIHJldHVybiBpdCAmJiB0 ZXh0QnJlYWtOZXh0KGl0KSA9PSB0ZXh0Lmxlbmd0aCgpOwogfQogCiAvLyBIZWxwZXIgZnVuY3Rp b24gdG8gZ2V0IG1pc3NwZWxsZWQgd29yZCBvbiB3aGljaCBjb250ZXh0IG1lbnUK