33648 2010-01-13 20:13:06 -0800 [Chromium] Adds WebKit::WebSecurityOrigin::createFromDatabaseIdentifier. 2010-01-14 18:44:19 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 0 bulach webkit-unassigned commit-queue darin jorlow oldest_to_newest 180527 0 bulach 2010-01-13 20:13:06 -0800 Adds WebKit::WebSecurityOrigin::createFromDatabaseIdentifier. 180529 1 46536 bulach 2010-01-13 20:18:54 -0800 Created attachment 46536 Patch 180563 2 jorlow 2010-01-13 23:07:36 -0800 > Index: WebKit/chromium/ChangeLog > =================================================================== > --- WebKit/chromium/ChangeLog (revision 53232) > +++ WebKit/chromium/ChangeLog (working copy) > @@ -1,3 +1,13 @@ > +2010-01-13 Marcus Bulach <bulach@chromium.org> > + > + Reviewed by NOBODY (OOPS!). > + > + Adds WebKit::WebSecurityOrigin::createFromDatabaseIdentifier. Need to add the bug number to the change log. > Index: WebKit/chromium/public/WebSecurityOrigin.h > =================================================================== > --- WebKit/chromium/public/WebSecurityOrigin.h (revision 53224) > +++ WebKit/chromium/public/WebSecurityOrigin.h (working copy) > @@ -55,6 +55,8 @@ public: > return *this; > } > > + WEBKIT_API static WebSecurityOrigin* createFromDatabaseIdentifier(const WebString& database); databaseIdentifier is probably a better name > Index: WebKit/chromium/src/WebSecurityOrigin.cpp > =================================================================== > --- WebKit/chromium/src/WebSecurityOrigin.cpp (revision 53224) > +++ WebKit/chromium/src/WebSecurityOrigin.cpp (working copy) > @@ -42,6 +42,11 @@ namespace WebKit { > class WebSecurityOriginPrivate : public SecurityOrigin { > }; > > +WebSecurityOrigin* WebSecurityOrigin::createFromDatabaseIdentifier(const WebString& database) > +{ > + return new WebSecurityOrigin(SecurityOrigin::createFromDatabaseIdentifier(database)); ditto, ditto 180712 3 46536 dglazkov 2010-01-14 07:41:57 -0800 Comment on attachment 46536 Patch r- based on Jeremy's comments. 180752 4 46577 bulach 2010-01-14 09:49:48 -0800 Created attachment 46577 Patch Thanks for the quick review! I renamed the param and added the bug number to the ChangeLog entry. Would you mind another look please? Thanks, Marcus 180943 5 46577 dglazkov 2010-01-14 14:56:04 -0800 Comment on attachment 46577 Patch ok. 181072 6 46577 commit-queue 2010-01-14 18:44:14 -0800 Comment on attachment 46577 Patch Clearing flags on attachment: 46577 Committed r53314: <http://trac.webkit.org/changeset/53314> 181074 7 commit-queue 2010-01-14 18:44:19 -0800 All reviewed patches have been landed. Closing bug. 46536 2010-01-13 20:18:54 -0800 2010-01-14 09:49:48 -0800 Patch wsopatch.txt text/plain 1724 bulach SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTMyMzIpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDEtMTMgIE1hcmN1 cyBCdWxhY2ggIDxidWxhY2hAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZHMgV2ViS2l0OjpXZWJTZWN1cml0eU9yaWdpbjo6 Y3JlYXRlRnJvbURhdGFiYXNlSWRlbnRpZmllci4KKworICAgICAgICAqIHB1YmxpYy9XZWJTZWN1 cml0eU9yaWdpbi5oOgorICAgICAgICAqIHNyYy9XZWJTZWN1cml0eU9yaWdpbi5jcHA6CisgICAg ICAgIChXZWJLaXQ6OldlYlNlY3VyaXR5T3JpZ2luOjpjcmVhdGVGcm9tRGF0YWJhc2VJZGVudGlm aWVyKToKKwogMjAxMC0wMS0xMyAgSm9uIEhvbmV5Y3V0dCAgPGpob25leWN1dHRAYXBwbGUuY29t PgogCiAgICAgICAgIE1TQUE6IHNlbGVjdGVkLCBzZWxlY3RhYmxlLCBleHRlbmRlZCBzZWxlY3Rh YmxlLCBhbmQgbXVsdGlwbGUKSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViU2VjdXJp dHlPcmlnaW4uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlNlY3Vy aXR5T3JpZ2luLmgJKHJldmlzaW9uIDUzMjI0KQorKysgV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9X ZWJTZWN1cml0eU9yaWdpbi5oCSh3b3JraW5nIGNvcHkpCkBAIC01NSw2ICs1NSw4IEBAIHB1Ymxp YzoKICAgICAgICAgcmV0dXJuICp0aGlzOwogICAgIH0KIAorICAgIFdFQktJVF9BUEkgc3RhdGlj IFdlYlNlY3VyaXR5T3JpZ2luKiBjcmVhdGVGcm9tRGF0YWJhc2VJZGVudGlmaWVyKGNvbnN0IFdl YlN0cmluZyYgZGF0YWJhc2UpOworCiAgICAgV0VCS0lUX0FQSSB2b2lkIHJlc2V0KCk7CiAgICAg V0VCS0lUX0FQSSB2b2lkIGFzc2lnbihjb25zdCBXZWJTZWN1cml0eU9yaWdpbiYpOwogCkluZGV4 OiBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYlNlY3VyaXR5T3JpZ2luLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYlNlY3VyaXR5T3JpZ2luLmNwcAkocmV2aXNpb24gNTMy MjQpCisrKyBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYlNlY3VyaXR5T3JpZ2luLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtNDIsNiArNDIsMTEgQEAgbmFtZXNwYWNlIFdlYktpdCB7CiBjbGFzcyBXZWJT ZWN1cml0eU9yaWdpblByaXZhdGUgOiBwdWJsaWMgU2VjdXJpdHlPcmlnaW4gewogfTsKIAorV2Vi U2VjdXJpdHlPcmlnaW4qIFdlYlNlY3VyaXR5T3JpZ2luOjpjcmVhdGVGcm9tRGF0YWJhc2VJZGVu dGlmaWVyKGNvbnN0IFdlYlN0cmluZyYgZGF0YWJhc2UpCit7CisgICAgcmV0dXJuIG5ldyBXZWJT ZWN1cml0eU9yaWdpbihTZWN1cml0eU9yaWdpbjo6Y3JlYXRlRnJvbURhdGFiYXNlSWRlbnRpZmll cihkYXRhYmFzZSkpOworfQorCiB2b2lkIFdlYlNlY3VyaXR5T3JpZ2luOjpyZXNldCgpCiB7CiAg ICAgYXNzaWduKDApOwo= 46577 2010-01-14 09:49:48 -0800 2010-01-14 18:44:14 -0800 Patch wsopatch.txt text/plain 1809 bulach SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTMyMzIpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDEtMTMgIE1hcmN1 cyBCdWxhY2ggIDxidWxhY2hAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZHMgV2ViS2l0OjpXZWJTZWN1cml0eU9yaWdpbjo6 Y3JlYXRlRnJvbURhdGFiYXNlSWRlbnRpZmllci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTMzNjQ4CisKKyAgICAgICAgKiBwdWJsaWMvV2ViU2VjdXJp dHlPcmlnaW4uaDoKKyAgICAgICAgKiBzcmMvV2ViU2VjdXJpdHlPcmlnaW4uY3BwOgorICAgICAg ICAoV2ViS2l0OjpXZWJTZWN1cml0eU9yaWdpbjo6Y3JlYXRlRnJvbURhdGFiYXNlSWRlbnRpZmll cik6CisKIDIwMTAtMDEtMTMgIEpvbiBIb25leWN1dHQgIDxqaG9uZXljdXR0QGFwcGxlLmNvbT4K IAogICAgICAgICBNU0FBOiBzZWxlY3RlZCwgc2VsZWN0YWJsZSwgZXh0ZW5kZWQgc2VsZWN0YWJs ZSwgYW5kIG11bHRpcGxlCkluZGV4OiBXZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlNlY3VyaXR5 T3JpZ2luLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJTZWN1cml0 eU9yaWdpbi5oCShyZXZpc2lvbiA1MzIyNCkKKysrIFdlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2Vi U2VjdXJpdHlPcmlnaW4uaAkod29ya2luZyBjb3B5KQpAQCAtNTUsNiArNTUsOCBAQCBwdWJsaWM6 CiAgICAgICAgIHJldHVybiAqdGhpczsKICAgICB9CiAKKyAgICBXRUJLSVRfQVBJIHN0YXRpYyBX ZWJTZWN1cml0eU9yaWdpbiogY3JlYXRlRnJvbURhdGFiYXNlSWRlbnRpZmllcihjb25zdCBXZWJT dHJpbmcmIGRhdGFiYXNlSWRlbnRpZmllcik7CisKICAgICBXRUJLSVRfQVBJIHZvaWQgcmVzZXQo KTsKICAgICBXRUJLSVRfQVBJIHZvaWQgYXNzaWduKGNvbnN0IFdlYlNlY3VyaXR5T3JpZ2luJik7 CiAKSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViU2VjdXJpdHlPcmlnaW4uY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViU2VjdXJpdHlPcmlnaW4uY3BwCShyZXZp c2lvbiA1MzIyNCkKKysrIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViU2VjdXJpdHlPcmlnaW4uY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC00Miw2ICs0MiwxMSBAQCBuYW1lc3BhY2UgV2ViS2l0IHsKIGNs YXNzIFdlYlNlY3VyaXR5T3JpZ2luUHJpdmF0ZSA6IHB1YmxpYyBTZWN1cml0eU9yaWdpbiB7CiB9 OwogCitXZWJTZWN1cml0eU9yaWdpbiogV2ViU2VjdXJpdHlPcmlnaW46OmNyZWF0ZUZyb21EYXRh YmFzZUlkZW50aWZpZXIoY29uc3QgV2ViU3RyaW5nJiBkYXRhYmFzZUlkZW50aWZpZXIpCit7Cisg ICAgcmV0dXJuIG5ldyBXZWJTZWN1cml0eU9yaWdpbihTZWN1cml0eU9yaWdpbjo6Y3JlYXRlRnJv bURhdGFiYXNlSWRlbnRpZmllcihkYXRhYmFzZUlkZW50aWZpZXIpKTsKK30KKwogdm9pZCBXZWJT ZWN1cml0eU9yaWdpbjo6cmVzZXQoKQogewogICAgIGFzc2lnbigwKTsK