33634 2010-01-13 16:03:30 -0800 REGRESSION(53133): webkit-patch land dies if it can't find a bug id. 2010-02-01 19:22:06 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 kbr webkit-unassigned abarth eric hamaji oldest_to_newest 180442 0 kbr 2010-01-13 16:03:30 -0800 "webkit-patch land" does not work for a new committer updating committers.py. Here is the Python traceback: Traceback (most recent call last): File "/Users/kbr/src/chrome2/src/third_party/WebKit/WebKitTools/Scripts/webkit-patch", line 108, in <module> WebKitPatch().main() File "/Users/kbr/src/chrome2/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/multicommandtool.py", line 299, in main return command.check_arguments_and_execute(options, args, self) File "/Users/kbr/src/chrome2/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/multicommandtool.py", line 113, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/Users/kbr/src/chrome2/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/commands/abstractsequencedcommand.py", line 43, in execute self._sequence.run_and_handle_errors(tool, options, self._prepare_state(options, args, tool)) File "/Users/kbr/src/chrome2/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/stepsequence.py", line 66, in run_and_handle_errors self._run(tool, options, state) File "/Users/kbr/src/chrome2/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/stepsequence.py", line 60, in _run step(tool, options).run(state) File "/Users/kbr/src/chrome2/src/third_party/WebKit/WebKitTools/Scripts/webkitpy/steps/updatechangelogswithreviewer.py", line 54, in run bug_id = state.get("bug_id") or state["patch"].bug_id() KeyError: 'patch' 180454 1 eric 2010-01-13 16:14:08 -0800 It's failing to find "bug_id", it should never end up down the "patch" path here. I suspect this happens when your ChangeLog is missing a bug id and is a recent regression from my Attachment refactoring: http://trac.webkit.org/changeset/53133 180471 2 46527 abarth 2010-01-13 16:46:53 -0800 Created attachment 46527 Patch 180472 3 abarth 2010-01-13 16:49:12 -0800 Committed r53215: <http://trac.webkit.org/changeset/53215> 186762 4 hamaji 2010-02-01 19:22:06 -0800 *** Bug 33578 has been marked as a duplicate of this bug. *** 46527 2010-01-13 16:46:53 -0800 2010-01-13 16:47:59 -0800 Patch bug-33634-20100113164652.patch text/plain 2795 abarth ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAzMjhhYjIyLi44ZDJiZWI0IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDEt MTMgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSRUdSRVNTSU9OKDUzMTMzKTogd2Via2l0LXBh dGNoIGxhbmQgZGllcyBpZiBpdCBjYW4ndCBmaW5kIGEgYnVnIGlkLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzM2MzQKKworICAgICAgICBEZWFsIHdp dGggdGhlIGNhc2Ugb2Ygbm8gYnVnIHBhdGNoIG9iamVjdCBpbiB0aGUgc3RhdGUuCisKKyAgICAg ICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0ZXBzL3VwZGF0ZWNoYW5nZWxvZ3N3aXRocmV2aWV3X3Vu aXR0ZXN0cy5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0ZXBzL3VwZGF0ZWNoYW5n ZWxvZ3N3aXRocmV2aWV3ZXIucHk6CisKIDIwMTAtMDEtMTMgIEtlbm5ldGggUnVzc2VsbCAgPGti ckBnb29nbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQ7IGFkZGVkIG15c2VsZiB0byB0aGUg Y29tbWl0dGVycyBsaXN0LgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRw eS9zdGVwcy91cGRhdGVjaGFuZ2Vsb2dzd2l0aHJldmlld191bml0dGVzdHMucHkgYi9XZWJLaXRU b29scy9TY3JpcHRzL3dlYmtpdHB5L3N0ZXBzL3VwZGF0ZWNoYW5nZWxvZ3N3aXRocmV2aWV3X3Vu aXR0ZXN0cy5weQppbmRleCA0M2RhYTIyLi4xMDJhNDU0IDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9TY3JpcHRzL3dlYmtpdHB5L3N0ZXBzL3VwZGF0ZWNoYW5nZWxvZ3N3aXRocmV2aWV3X3VuaXR0 ZXN0cy5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0ZXBzL3VwZGF0ZWNo YW5nZWxvZ3N3aXRocmV2aWV3X3VuaXR0ZXN0cy5weQpAQCAtMjksMTIgKzI5LDE4IEBACiBpbXBv cnQgdW5pdHRlc3QKIAogZnJvbSB3ZWJraXRweS5zdGVwcy51cGRhdGVjaGFuZ2Vsb2dzd2l0aHJl dmlld2VyIGltcG9ydCBVcGRhdGVDaGFuZ2VMb2dzV2l0aFJldmlld2VyCitmcm9tIHdlYmtpdHB5 Lm1vY2sgaW1wb3J0IE1vY2sKIGZyb20gd2Via2l0cHkubW9ja19idWd6aWxsYXRvb2wgaW1wb3J0 IE1vY2tCdWd6aWxsYVRvb2wKIGZyb20gd2Via2l0cHkub3V0cHV0Y2FwdHVyZSBpbXBvcnQgT3V0 cHV0Q2FwdHVyZQogCi1jbGFzcyBVcGRhdGVDaGFuZ2VMb2dzV2l0aFJldmlld2VyU3RlcFRlc3Qo dW5pdHRlc3QuVGVzdENhc2UpOgorY2xhc3MgVXBkYXRlQ2hhbmdlTG9nc1dpdGhSZXZpZXdlclRl c3QodW5pdHRlc3QuVGVzdENhc2UpOgogICAgIGRlZiB0ZXN0X2d1ZXNzX3Jldmlld2VyX2Zyb21f YnVnKHNlbGYpOgogICAgICAgICBjYXB0dXJlID0gT3V0cHV0Q2FwdHVyZSgpCi0gICAgICAgIHN0 ZXAgPSBVcGRhdGVDaGFuZ2VMb2dzV2l0aFJldmlld2VyKE1vY2tCdWd6aWxsYVRvb2woKSwgW10p CisgICAgICAgIHN0ZXAgPSBVcGRhdGVDaGFuZ2VMb2dzV2l0aFJldmlld2VyKE1vY2tCdWd6aWxs YVRvb2woKSwgTW9jaygpKQogICAgICAgICBleHBlY3RlZF9zdGRlcnIgPSAiMCByZXZpZXdlZCBw YXRjaGVzIG9uIGJ1ZyA3NSwgY2Fubm90IGluZmVyIHJldmlld2VyLlxuIgogICAgICAgICBjYXB0 dXJlLmFzc2VydF9vdXRwdXRzKHNlbGYsIHN0ZXAuX2d1ZXNzX3Jldmlld2VyX2Zyb21fYnVnLCBb NzVdLCBleHBlY3RlZF9zdGRlcnI9ZXhwZWN0ZWRfc3RkZXJyKQorCisgICAgZGVmIHRlc3RfZW1w dHlfc3RhdGUoc2VsZik6CisgICAgICAgIGNhcHR1cmUgPSBPdXRwdXRDYXB0dXJlKCkKKyAgICAg ICAgc3RlcCA9IFVwZGF0ZUNoYW5nZUxvZ3NXaXRoUmV2aWV3ZXIoTW9ja0J1Z3ppbGxhVG9vbCgp LCBNb2NrKCkpCisgICAgICAgIGNhcHR1cmUuYXNzZXJ0X291dHB1dHMoc2VsZiwgc3RlcC5ydW4s IFt7fV0pCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0ZXBzL3Vw ZGF0ZWNoYW5nZWxvZ3N3aXRocmV2aWV3ZXIucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtp dHB5L3N0ZXBzL3VwZGF0ZWNoYW5nZWxvZ3N3aXRocmV2aWV3ZXIucHkKaW5kZXggM2M4Nzk3YS4u OTBmZGMzNSAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdGVwcy91 cGRhdGVjaGFuZ2Vsb2dzd2l0aHJldmlld2VyLnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvc3RlcHMvdXBkYXRlY2hhbmdlbG9nc3dpdGhyZXZpZXdlci5weQpAQCAtNTEsNyAr NTEsOSBAQCBjbGFzcyBVcGRhdGVDaGFuZ2VMb2dzV2l0aFJldmlld2VyKEFic3RyYWN0U3RlcCk6 CiAgICAgICAgIHJldHVybiBwYXRjaC5yZXZpZXdlcigpLmZ1bGxfbmFtZQogCiAgICAgZGVmIHJ1 bihzZWxmLCBzdGF0ZSk6Ci0gICAgICAgIGJ1Z19pZCA9IHN0YXRlLmdldCgiYnVnX2lkIikgb3Ig c3RhdGVbInBhdGNoIl0uYnVnX2lkKCkKKyAgICAgICAgYnVnX2lkID0gc3RhdGUuZ2V0KCJidWdf aWQiKQorICAgICAgICBpZiBub3QgYnVnX2lkIGFuZCBzdGF0ZS5nZXQoInBhdGNoIik6CisgICAg ICAgICAgICBidWdfaWQgPSBzdGF0ZS5nZXQoInBhdGNoIikuYnVnX2lkKCkKIAogICAgICAgICBy ZXZpZXdlciA9IHNlbGYuX29wdGlvbnMucmV2aWV3ZXIKICAgICAgICAgaWYgbm90IHJldmlld2Vy Ogo=