33628 2010-01-13 15:40:48 -0800 LayoutTests/storage/quota-tracking.html needs to be cleaned up 2010-01-13 16:22:46 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 dumi dumi dglazkov michaeln oldest_to_newest 180432 0 dumi 2010-01-13 15:40:48 -0800 Things that need to be cleaned up in quota-tracking.html: -- Remove all trailing whitespaces -- Refactor errorFunction(). Right now, it takes two parameters (tx, error) and is used as the error function for both executeSql() and transaction(). The problem is that transaction()'s error callback uses only one parameter. So if a transaction fails, the error gets assigned to the 'tx' parameter, and the 'error' parameter is left undefined; this leads to an exception when errorFunction() tries to log 'error.message'. 180445 1 46520 dumi 2010-01-13 16:04:10 -0800 Created attachment 46520 patch 180448 2 46520 dglazkov 2010-01-13 16:09:15 -0800 Comment on attachment 46520 patch LG, except: > + Cleaning up quota-tracking.html. This could use a bit more description. 180450 3 dumi 2010-01-13 16:09:56 -0800 (In reply to comment #2) > (From update of attachment 46520 [details]) > LG, except: > > > > + Cleaning up quota-tracking.html. > > This could use a bit more description. Will add more details before landing. 180456 4 dumi 2010-01-13 16:22:46 -0800 Landed as r53214. 46520 2010-01-13 16:04:10 -0800 2010-01-13 16:09:15 -0800 patch patch text/plain 2666 dumi SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDUzMjEwKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDEtMTMgIER1bWl0cnUgRGFuaWxpdWMg IDxkdW1pQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBDbGVhbmluZyB1cCBxdW90YS10cmFja2luZy5odG1sLgorCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzYyOAorCisgICAgICAg ICogc3RvcmFnZS9xdW90YS10cmFja2luZy5odG1sOgorCiAyMDEwLTAxLTEzICBEaXJrIFNjaHVs emUgIDxrcml0QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQmV0aCBEYWtpbi4K SW5kZXg6IExheW91dFRlc3RzL3N0b3JhZ2UvcXVvdGEtdHJhY2tpbmcuaHRtbAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9zdG9yYWdlL3F1b3RhLXRyYWNraW5nLmh0bWwJKHJldmlzaW9uIDUz MjEwKQorKysgTGF5b3V0VGVzdHMvc3RvcmFnZS9xdW90YS10cmFja2luZy5odG1sCSh3b3JraW5n IGNvcHkpCkBAIC0xNiw3ICsxNiw3IEBAIGZ1bmN0aW9uIGZpbmlzaFRlc3QoKQogICAgICAgICBs YXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCk7CiB9CiAKLWZ1bmN0aW9uIGVycm9yRnVu Y3Rpb24odHgsIGVycm9yKQorZnVuY3Rpb24gZXJyb3JGdW5jdGlvbihlcnJvcikKIHsKICAgICBs b2coIlRlc3QgZmFpbGVkIC0gIiArIGVycm9yLm1lc3NhZ2UpOwogICAgIGZpbmlzaFRlc3QoKTsK QEAgLTM1LDExICszNSwxMyBAQCBmdW5jdGlvbiBjaGVja0NvbXBsZXRpb24oZGIpCiAKIGZ1bmN0 aW9uIGFkZERhdGEoZGIpCiB7Ci0gICAgZGIudHJhbnNhY3Rpb24oZnVuY3Rpb24odHgpIHsgCisg ICAgZGIudHJhbnNhY3Rpb24oZnVuY3Rpb24odHgpIHsKICAgICAgICAgbG9nKCJJbnNlcnRpbmcg c29tZSBkYXRhIik7Ci0gICAgICAgIHR4LmV4ZWN1dGVTcWwoIklOU0VSVCBJTlRPIERhdGFUZXN0 IChyYW5kb21EYXRhKSBWQUxVRVMgKFpFUk9CTE9CKDE3NDA4KSkiLCBbXSwgZnVuY3Rpb24odHgs IHJlc3VsdCkgeyB9LCBlcnJvckZ1bmN0aW9uKTsgCi0gICAgfSwgZXJyb3JGdW5jdGlvbiwgZnVu Y3Rpb24oKSB7IAotICAgICAgICBjaGVja0NvbXBsZXRpb24oZGIpOyAKKyAgICAgICAgdHguZXhl Y3V0ZVNxbCgiSU5TRVJUIElOVE8gRGF0YVRlc3QgKHJhbmRvbURhdGEpIFZBTFVFUyAoWkVST0JM T0IoMTc0MDgpKSIsIFtdLAorICAgICAgICAgICAgICAgICAgICAgIGZ1bmN0aW9uKHR4LCByZXN1 bHQpIHsgfSwKKyAgICAgICAgICAgICAgICAgICAgICBmdW5jdGlvbih0eCwgZXJyb3IpIHsgZXJy b3JGdW5jdGlvbihlcnJvcik7IH0pOworICAgIH0sIGVycm9yRnVuY3Rpb24sIGZ1bmN0aW9uKCkg eworICAgICAgICBjaGVja0NvbXBsZXRpb24oZGIpOwogICAgIH0pOwogfQogCkBAIC00Nyw5ICs0 OSwxMSBAQCBmdW5jdGlvbiB0ZXN0RGF0YWJhc2UoZGIpCiB7CiAgICAgZGIudHJhbnNhY3Rpb24o ZnVuY3Rpb24odHgpIHsKICAgICAgICAgbG9nKCJBZGRpbmcgYSB0YWJsZSIpOwotICAgICAgICB0 eC5leGVjdXRlU3FsKCJDUkVBVEUgVEFCTEUgRGF0YVRlc3QgKHJhbmRvbURhdGEpIiwgW10sIGZ1 bmN0aW9uKHR4LCByZXN1bHQpIHsgfSwgZXJyb3JGdW5jdGlvbik7IAotICAgIH0sIGVycm9yRnVu Y3Rpb24sIGZ1bmN0aW9uKCkgeyAKLSAgICAgICAgYWRkRGF0YShkYik7IAorICAgICAgICB0eC5l eGVjdXRlU3FsKCJDUkVBVEUgVEFCTEUgRGF0YVRlc3QgKHJhbmRvbURhdGEpIiwgW10sCisgICAg ICAgICAgICAgICAgICAgICAgZnVuY3Rpb24odHgsIHJlc3VsdCkgeyB9LAorICAgICAgICAgICAg ICAgICAgICAgIGZ1bmN0aW9uKHR4LCBlcnJvcikgeyBlcnJvckZ1bmN0aW9uKGVycm9yKTsgfSk7 CisgICAgfSwgZXJyb3JGdW5jdGlvbiwgZnVuY3Rpb24oKSB7CisgICAgICAgIGFkZERhdGEoZGIp OwogICAgIH0pOwogfQogCkBAIC02MiwxMiArNjYsMTIgQEAgZnVuY3Rpb24gcnVuVGVzdCgpCiAg ICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKICAgICAgICAgbGF5b3V0 VGVzdENvbnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOwogICAgIH0KLSAgICAKKwogICAgIGRhdGFi YXNlMSA9IG9wZW5EYXRhYmFzZSgiUXVvdGFNYW5hZ2VtZW50RGF0YWJhc2UxIiwgIjEuMCIsICJU ZXN0IGZvciBxdW90YSBtYW5hZ2VtZW50IDxyZGFyOi8vNTYyODQ2OD4iLCAxKTsKICAgICBkYXRh YmFzZTIgPSBvcGVuRGF0YWJhc2UoIlF1b3RhTWFuYWdlbWVudERhdGFiYXNlMiIsICIxLjAiLCAi VGVzdCBmb3IgcXVvdGEgbWFuYWdlbWVudCA8cmRhcjovLzU2Mjg0Njg+IiwgMSk7CiAgICAgZGF0 YWJhc2UxLmNvbXBsZXRlID0gZmFsc2U7CiAgICAgZGF0YWJhc2UyLmNvbXBsZXRlID0gZmFsc2U7 Ci0gICAgCisKICAgICB0ZXN0RGF0YWJhc2UoZGF0YWJhc2UxKTsKIH0KIAo=