33614 2010-01-13 12:19:17 -0800 [Qt] Missing fileSystemPath() method in Qt KURL implementation 2010-02-10 01:22:50 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC Linux RESOLVED FIXED Qt P2 Normal --- 33617 1 diegohcg webkit-unassigned commit-queue eric hausmann kenneth tonikitoo webkit.review.bot oldest_to_newest 180331 0 diegohcg 2010-01-13 12:19:17 -0800 The method fileSystemPath() is not implemented in Qt KURL side. This method is currently return a empty string which can fails some operations like set a user remote css. 180355 1 46491 diegohcg 2010-01-13 12:47:40 -0800 Created attachment 46491 Proposed patch 180380 2 webkit.review.bot 2010-01-13 13:26:29 -0800 Attachment 46491 did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/185686 180395 3 46502 diegohcg 2010-01-13 14:01:26 -0800 Created attachment 46502 Proposed patch v0.2 Make check of Qt version to user QUrl::fromUserInput method 180404 4 46506 diegohcg 2010-01-13 14:19:46 -0800 Created attachment 46506 Proposed patch v0.3 Use m_strig instead of non-existent input variable 180522 5 tonikitoo 2010-01-13 19:46:08 -0800 LGTM ! @kenneth, could you please officially review ? good work. (In reply to comment #4) > Created an attachment (id=46506) [details] > Proposed patch v0.3 > > Use m_strig instead of non-existent input variable 180652 6 46506 kenneth 2010-01-14 03:01:10 -0800 Comment on attachment 46506 Proposed patch v0.3 > > String KURL::fileSystemPath() const > { > - notImplemented(); > + if (m_string.isEmpty()) > + return String(); > + > +#if QT_VERSION >= QT_VERSION_CHECK(4, 6, 0) > + QUrl url = QUrl::fromUserInput(m_string); Why use this? This might change an invalid URL into a valid one. This doesn't seem right and at least needs a comment > +#else > + QUrl url = QUrl(m_string); > +#endif > + if (url.isValid()) > + return String(url.path()); > + > return String(); > } > 180686 7 46558 diegohcg 2010-01-14 05:20:16 -0800 Created attachment 46558 Proposed patch v0.4 Not using the QUrl::fromUserInput method anymore. It's really does not make sense to use it in this situation as commented by Kenneth. 180702 8 46558 kenneth 2010-01-14 06:41:43 -0800 Comment on attachment 46558 Proposed patch v0.4 Shouldn't you somehow verify that m_string is a file path, like comparing url.scheme() (or what it is called in KURL) with "file" > > String KURL::fileSystemPath() const > { > - notImplemented(); > + if (m_string.isEmpty()) > + return String(); > + > + QUrl url = QUrl(m_string); > + if (url.isValid()) > + return String(url.path()); > + > return String(); > } > 180706 9 tonikitoo 2010-01-14 07:17:16 -0800 (In reply to comment #8) > (From update of attachment 46558 [details]) > Shouldn't you somehow verify that m_string is a file path, like comparing > url.scheme() (or what it is called in KURL) with "file" hum, diego , kenneth , does not isValid take care of this? > > > > > String KURL::fileSystemPath() const > > { > > - notImplemented(); > > + if (m_string.isEmpty()) > > + return String(); > > + > > + QUrl url = QUrl(m_string); > > + if (url.isValid()) > > + return String(url.path()); > > + > > return String(); > > } > > 180710 10 46564 diegohcg 2010-01-14 07:39:55 -0800 Created attachment 46564 Proposed patch v0.5 Using KURL methods instead of QUrl. Reviewed by Kenneth 180717 11 46567 diegohcg 2010-01-14 07:49:57 -0800 Created attachment 46567 Final patch Correct patch 180725 12 46567 commit-queue 2010-01-14 08:08:01 -0800 Comment on attachment 46567 Final patch Rejecting patch 46567 from commit-queue. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/platform/qt/KURLQt.cpp A repository hook failed: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output: svnlook: Can't write to stream: Broken pipe The following ChangeLog files contain OOPS: trunk/WebCore/ChangeLog Please don't ever say "OOPS" in a ChangeLog file. at /usr/local/git/libexec/git-core/git-svn line 558 Full output: http://webkit-commit-queue.appspot.com/results/186439 180814 13 tonikitoo 2010-01-14 11:21:43 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/platform/qt/KURLQt.cpp Committed r53276 180820 14 eric 2010-01-14 11:40:27 -0800 Ideally the "no new tests" line should be replaced either by pointers to new tests, or explanations why testing is impossible or infeasible. :) http://webkit.org/coding/contributing.html#changelogs http://trac.webkit.org/changeset/53276 180822 15 tonikitoo 2010-01-14 11:43:26 -0800 (In reply to comment #14) > Ideally the "no new tests" line should be replaced either by pointers to new > tests, or explanations why testing is impossible or infeasible. :) > http://webkit.org/coding/contributing.html#changelogs > > http://trac.webkit.org/changeset/53276 eric, i see your concern. But specifically in this case, no tests were added, *but* one existent will be unskipped. see bug 33617 , which i am landing manually. 180828 16 eric 2010-01-14 11:49:27 -0800 Sounds fine. :) Ideally we should mention that the one will be unskipped. None of this is a big deal. I just saw this commit-queue failure, pulled up the bug, noticed the nit and decided to comment. 189278 17 hausmann 2010-02-10 01:22:50 -0800 (In reply to comment #13) > Committing to http://svn.webkit.org/repository/webkit/trunk ... > M WebCore/ChangeLog > M WebCore/platform/qt/KURLQt.cpp > Committed r53276 Cherry-picked into qtwebkit-4.6 with commit 36fe058a9001e6d47f0fd41c6304cdfdf3a735ed 46491 2010-01-13 12:47:40 -0800 2010-01-13 14:19:46 -0800 Proposed patch fileSystemPath.diff text/plain 1063 diegohcg ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MzljYTRmZS4uN2E3NjM5NyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wMS0xMyAgRGllZ28gR29uemFs ZXogIDxkaWVnby5nb256YWxlekBvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gTWlzc2luZyBmaWxlU3lzdGVtUGF0aCgp IG1ldGhvZCBpbiBRdCBLVVJMIGltcGxlbWVudGF0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzYxNAorCisgICAgICAgICogcGxhdGZvcm0vcXQv S1VSTFF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OktVUkw6OmZpbGVTeXN0ZW1QYXRoKToKKwog MjAxMC0wMS0xMyAgSmVyZW15IE9ybG93ICA8am9ybG93QGNocm9taXVtLm9yZz4KIAogICAgICAg ICBObyByZXZpZXdlci4gIE1vcmUgb3IgbGVzcyBhIGJ1aWxkIGZpeC4gIE15IDUzMTgwIGJyb2tl IHNvbWUgCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL3F0L0tVUkxRdC5jcHAgYi9XZWJD b3JlL3BsYXRmb3JtL3F0L0tVUkxRdC5jcHAKaW5kZXggMDc2M2ZlMC4uZDlkZjNmNiAxMDA2NDQK LS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9xdC9LVVJMUXQuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZv cm0vcXQvS1VSTFF0LmNwcApAQCAtOTUsNyArOTUsMTMgQEAgS1VSTDo6b3BlcmF0b3IgUVVybCgp IGNvbnN0CiAKIFN0cmluZyBLVVJMOjpmaWxlU3lzdGVtUGF0aCgpIGNvbnN0CiB7Ci0gICAgbm90 SW1wbGVtZW50ZWQoKTsKKyAgICBpZiAobV9zdHJpbmcuaXNFbXB0eSgpKQorICAgICAgICByZXR1 cm4gU3RyaW5nKCk7CisKKyAgICBRVXJsIHVybCA9IFFVcmw6OmZyb21Vc2VySW5wdXQobV9zdHJp bmcpOworICAgIGlmICh1cmwuaXNWYWxpZCgpKQorICAgICAgICByZXR1cm4gU3RyaW5nKHVybC5w YXRoKCkpOworCiAgICAgcmV0dXJuIFN0cmluZygpOwogfQogCg== 46502 2010-01-13 14:01:26 -0800 2010-01-13 14:19:46 -0800 Proposed patch v0.2 fileSystemPath.diff text/plain 1152 diegohcg ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MzljYTRmZS4uN2E3NjM5NyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wMS0xMyAgRGllZ28gR29uemFs ZXogIDxkaWVnby5nb256YWxlekBvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gTWlzc2luZyBmaWxlU3lzdGVtUGF0aCgp IG1ldGhvZCBpbiBRdCBLVVJMIGltcGxlbWVudGF0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzYxNAorCisgICAgICAgICogcGxhdGZvcm0vcXQv S1VSTFF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OktVUkw6OmZpbGVTeXN0ZW1QYXRoKToKKwog MjAxMC0wMS0xMyAgSmVyZW15IE9ybG93ICA8am9ybG93QGNocm9taXVtLm9yZz4KIAogICAgICAg ICBObyByZXZpZXdlci4gIE1vcmUgb3IgbGVzcyBhIGJ1aWxkIGZpeC4gIE15IDUzMTgwIGJyb2tl IHNvbWUgCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL3F0L0tVUkxRdC5jcHAgYi9XZWJD b3JlL3BsYXRmb3JtL3F0L0tVUkxRdC5jcHAKaW5kZXggMDc2M2ZlMC4uODE3M2VhNSAxMDA2NDQK LS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9xdC9LVVJMUXQuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZv cm0vcXQvS1VSTFF0LmNwcApAQCAtOTUsNyArOTUsMTcgQEAgS1VSTDo6b3BlcmF0b3IgUVVybCgp IGNvbnN0CiAKIFN0cmluZyBLVVJMOjpmaWxlU3lzdGVtUGF0aCgpIGNvbnN0CiB7Ci0gICAgbm90 SW1wbGVtZW50ZWQoKTsKKyAgICBpZiAobV9zdHJpbmcuaXNFbXB0eSgpKQorICAgICAgICByZXR1 cm4gU3RyaW5nKCk7CisKKyNpZiBRVF9WRVJTSU9OID49IFFUX1ZFUlNJT05fQ0hFQ0soNCwgNiwg MCkKKyAgICBRVXJsIHVybCA9IFFVcmw6OmZyb21Vc2VySW5wdXQoaW5wdXQpOworI2Vsc2UKKyAg ICBRVXJsIHVybCA9IFFVcmwobV9zdHJpbmcpOworI2VuZGlmCisgICAgaWYgKHVybC5pc1ZhbGlk KCkpCisgICAgICAgIHJldHVybiBTdHJpbmcodXJsLnBhdGgoKSk7CisKICAgICByZXR1cm4gU3Ry aW5nKCk7CiB9CiAK 46506 2010-01-13 14:19:46 -0800 2010-01-14 05:20:16 -0800 Proposed patch v0.3 fileSystemPath.diff text/plain 1155 diegohcg ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MzljYTRmZS4uN2E3NjM5NyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wMS0xMyAgRGllZ28gR29uemFs ZXogIDxkaWVnby5nb256YWxlekBvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gTWlzc2luZyBmaWxlU3lzdGVtUGF0aCgp IG1ldGhvZCBpbiBRdCBLVVJMIGltcGxlbWVudGF0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzYxNAorCisgICAgICAgICogcGxhdGZvcm0vcXQv S1VSTFF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OktVUkw6OmZpbGVTeXN0ZW1QYXRoKToKKwog MjAxMC0wMS0xMyAgSmVyZW15IE9ybG93ICA8am9ybG93QGNocm9taXVtLm9yZz4KIAogICAgICAg ICBObyByZXZpZXdlci4gIE1vcmUgb3IgbGVzcyBhIGJ1aWxkIGZpeC4gIE15IDUzMTgwIGJyb2tl IHNvbWUgCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL3F0L0tVUkxRdC5jcHAgYi9XZWJD b3JlL3BsYXRmb3JtL3F0L0tVUkxRdC5jcHAKaW5kZXggMDc2M2ZlMC4uODZmOTY0MSAxMDA2NDQK LS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9xdC9LVVJMUXQuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZv cm0vcXQvS1VSTFF0LmNwcApAQCAtOTUsNyArOTUsMTcgQEAgS1VSTDo6b3BlcmF0b3IgUVVybCgp IGNvbnN0CiAKIFN0cmluZyBLVVJMOjpmaWxlU3lzdGVtUGF0aCgpIGNvbnN0CiB7Ci0gICAgbm90 SW1wbGVtZW50ZWQoKTsKKyAgICBpZiAobV9zdHJpbmcuaXNFbXB0eSgpKQorICAgICAgICByZXR1 cm4gU3RyaW5nKCk7CisKKyNpZiBRVF9WRVJTSU9OID49IFFUX1ZFUlNJT05fQ0hFQ0soNCwgNiwg MCkKKyAgICBRVXJsIHVybCA9IFFVcmw6OmZyb21Vc2VySW5wdXQobV9zdHJpbmcpOworI2Vsc2UK KyAgICBRVXJsIHVybCA9IFFVcmwobV9zdHJpbmcpOworI2VuZGlmCisgICAgaWYgKHVybC5pc1Zh bGlkKCkpCisgICAgICAgIHJldHVybiBTdHJpbmcodXJsLnBhdGgoKSk7CisKICAgICByZXR1cm4g U3RyaW5nKCk7CiB9CiAK 46558 2010-01-14 05:20:16 -0800 2010-01-14 07:39:55 -0800 Proposed patch v0.4 fileSystemPath-with-Changelog.diff text/plain 1064 diegohcg ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZmUyNTZjNC4uNWM5NjMxZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wMS0xNCAgRGllZ28gR29uemFs ZXogIDxkaWVnby5nb256YWxlekBvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gTWlzc2luZyBmaWxlU3lzdGVtUGF0aCgp IG1ldGhvZCBpbiBRdCBLVVJMIGltcGxlbWVudGF0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzYxNAorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4g KE9PUFMhKQorCisgICAgICAgICogcGxhdGZvcm0vcXQvS1VSTFF0LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OktVUkw6OmZpbGVTeXN0ZW1QYXRoKToKKwogMjAxMC0wMS0xNCAgQW5kcmVhcyBLbGlu ZyAgPGFuZHJlYXMua2xpbmdAbm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbm5l dGggUm9oZGUgQ2hyaXN0aWFuc2VuLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9xdC9L VVJMUXQuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9xdC9LVVJMUXQuY3BwCmluZGV4IDA3NjNmZTAu LjVjNmI3OTUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vcXQvS1VSTFF0LmNwcAorKysg Yi9XZWJDb3JlL3BsYXRmb3JtL3F0L0tVUkxRdC5jcHAKQEAgLTk1LDcgKzk1LDEzIEBAIEtVUkw6 Om9wZXJhdG9yIFFVcmwoKSBjb25zdAogCiBTdHJpbmcgS1VSTDo6ZmlsZVN5c3RlbVBhdGgoKSBj b25zdAogewotICAgIG5vdEltcGxlbWVudGVkKCk7CisgICAgaWYgKG1fc3RyaW5nLmlzRW1wdHko KSkKKyAgICAgICAgcmV0dXJuIFN0cmluZygpOworCisgICAgUVVybCB1cmwgPSBRVXJsKG1fc3Ry aW5nKTsKKyAgICBpZiAodXJsLmlzVmFsaWQoKSkKKyAgICAgICAgcmV0dXJuIFN0cmluZyh1cmwu cGF0aCgpKTsKKwogICAgIHJldHVybiBTdHJpbmcoKTsKIH0KIAo= 46564 2010-01-14 07:39:55 -0800 2010-01-14 07:49:57 -0800 Proposed patch v0.5 fileSystemPath-with-Changelog.diff text/plain 2080 diegohcg ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZmUyNTZjNC4uNWM5NjMxZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wMS0xNCAgRGllZ28gR29uemFs ZXogIDxkaWVnby5nb256YWxlekBvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gTWlzc2luZyBmaWxlU3lzdGVtUGF0aCgp IG1ldGhvZCBpbiBRdCBLVVJMIGltcGxlbWVudGF0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzYxNAorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4g KE9PUFMhKQorCisgICAgICAgICogcGxhdGZvcm0vcXQvS1VSTFF0LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OktVUkw6OmZpbGVTeXN0ZW1QYXRoKToKKwogMjAxMC0wMS0xNCAgQW5kcmVhcyBLbGlu ZyAgPGFuZHJlYXMua2xpbmdAbm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbm5l dGggUm9oZGUgQ2hyaXN0aWFuc2VuLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9xdC9L VVJMUXQuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9xdC9LVVJMUXQuY3BwCmluZGV4IDA3NjNmZTAu LjVjNmI3OTUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vcXQvS1VSTFF0LmNwcAorKysg Yi9XZWJDb3JlL3BsYXRmb3JtL3F0L0tVUkxRdC5jcHAKQEAgLTk1LDcgKzk1LDEzIEBAIEtVUkw6 Om9wZXJhdG9yIFFVcmwoKSBjb25zdAogCiBTdHJpbmcgS1VSTDo6ZmlsZVN5c3RlbVBhdGgoKSBj b25zdAogewotICAgIG5vdEltcGxlbWVudGVkKCk7CisgICAgaWYgKG1fc3RyaW5nLmlzRW1wdHko KSkKKyAgICAgICAgcmV0dXJuIFN0cmluZygpOworCisgICAgUVVybCB1cmwgPSBRVXJsKG1fc3Ry aW5nKTsKKyAgICBpZiAodXJsLmlzVmFsaWQoKSkKKyAgICAgICAgcmV0dXJuIFN0cmluZyh1cmwu cGF0aCgpKTsKKwogICAgIHJldHVybiBTdHJpbmcoKTsKIH0KIApkaWZmIC0tZ2l0IGEvV2ViQ29y ZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBmZTI1NmM0Li41Yzk2MzFlIDEw MDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE1IEBACisyMDEwLTAxLTE0ICBEaWVnbyBHb256YWxleiAgPGRpZWdvLmdvbnphbGV6 QG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgW1F0XSBNaXNzaW5nIGZpbGVTeXN0ZW1QYXRoKCkgbWV0aG9kIGluIFF0IEtVUkwg aW1wbGVtZW50YXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTMzNjE0CisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiAoT09QUyEpCisKKyAgICAgICAg KiBwbGF0Zm9ybS9xdC9LVVJMUXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6S1VSTDo6ZmlsZVN5 c3RlbVBhdGgpOgorCiAyMDEwLTAxLTE0ICBBbmRyZWFzIEtsaW5nICA8YW5kcmVhcy5rbGluZ0Bu b2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5z ZW4uCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL3F0L0tVUkxRdC5jcHAgYi9XZWJDb3Jl L3BsYXRmb3JtL3F0L0tVUkxRdC5jcHAKaW5kZXggMDc2M2ZlMC4uMWY2MjAwNiAxMDA2NDQKLS0t IGEvV2ViQ29yZS9wbGF0Zm9ybS9xdC9LVVJMUXQuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0v cXQvS1VSTFF0LmNwcApAQCAtOTUsOCArOTUsMTAgQEAgS1VSTDo6b3BlcmF0b3IgUVVybCgpIGNv bnN0CiAKIFN0cmluZyBLVVJMOjpmaWxlU3lzdGVtUGF0aCgpIGNvbnN0CiB7Ci0gICAgbm90SW1w bGVtZW50ZWQoKTsKLSAgICByZXR1cm4gU3RyaW5nKCk7CisgICAgaWYgKCFpc1ZhbGlkKCkgfHwg IXByb3RvY29sSXMoImZpbGUiKSkKKyAgICAgICAgcmV0dXJuIFN0cmluZygpOworCisgICAgcmV0 dXJuIFN0cmluZyhwYXRoKCkpOwogfQogCiB9Cg== 46567 2010-01-14 07:49:57 -0800 2010-01-14 08:08:01 -0800 Final patch fileSystemPath-with-Changelog.diff text/plain 1016 diegohcg ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZmUyNTZjNC4uNWM5NjMxZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wMS0xNCAgRGllZ28gR29uemFs ZXogIDxkaWVnby5nb256YWxlekBvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gTWlzc2luZyBmaWxlU3lzdGVtUGF0aCgp IG1ldGhvZCBpbiBRdCBLVVJMIGltcGxlbWVudGF0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzYxNAorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4g KE9PUFMhKQorCisgICAgICAgICogcGxhdGZvcm0vcXQvS1VSTFF0LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OktVUkw6OmZpbGVTeXN0ZW1QYXRoKToKKwogMjAxMC0wMS0xNCAgQW5kcmVhcyBLbGlu ZyAgPGFuZHJlYXMua2xpbmdAbm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbm5l dGggUm9oZGUgQ2hyaXN0aWFuc2VuLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9xdC9L VVJMUXQuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9xdC9LVVJMUXQuY3BwCmluZGV4IDA3NjNmZTAu LjFmNjIwMDYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vcXQvS1VSTFF0LmNwcAorKysg Yi9XZWJDb3JlL3BsYXRmb3JtL3F0L0tVUkxRdC5jcHAKQEAgLTk1LDggKzk1LDEwIEBAIEtVUkw6 Om9wZXJhdG9yIFFVcmwoKSBjb25zdAogCiBTdHJpbmcgS1VSTDo6ZmlsZVN5c3RlbVBhdGgoKSBj b25zdAogewotICAgIG5vdEltcGxlbWVudGVkKCk7Ci0gICAgcmV0dXJuIFN0cmluZygpOworICAg IGlmICghaXNWYWxpZCgpIHx8ICFwcm90b2NvbElzKCJmaWxlIikpCisgICAgICAgIHJldHVybiBT dHJpbmcoKTsKKworICAgIHJldHVybiBTdHJpbmcocGF0aCgpKTsKIH0KIAogfQo=