33612 2010-01-13 12:01:54 -0800 Use the CaseFoldingHash function in DatabaseAuthorizer to store the list of whitelisted sqlite functions 2010-01-13 13:09:46 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dumi dumi abarth darin oldest_to_newest 180320 0 dumi 2010-01-13 12:01:54 -0800 DatabaseAuthorizer should use a CaseFoldingHash function to store the list of whitelisted sqlite functions, instead of doing m_whitelistedFunctions.contains(functionName.lower()). Also, the indenting in DatabaseAuthorizer::allowFunction() should be fixed. 180328 1 46483 dumi 2010-01-13 12:15:21 -0800 Created attachment 46483 patch 180335 2 46483 darin 2010-01-13 12:23:06 -0800 Comment on attachment 46483 patch Code change is fine. But normally we include the change log entry in the patch for review. 180339 3 46486 dumi 2010-01-13 12:27:28 -0800 Created attachment 46486 patch (In reply to comment #2) > (From update of attachment 46483 [details]) > Code change is fine. But normally we include the change log entry in the patch > for review. D'oh! I knew something was missing from this patch... Please take a look at the new one. 180371 4 dumi 2010-01-13 13:09:46 -0800 Landed as r53198. 46483 2010-01-13 12:15:21 -0800 2010-01-13 12:27:28 -0800 patch patch text/plain 1139 dumi SW5kZXg6IFdlYkNvcmUvc3RvcmFnZS9EYXRhYmFzZUF1dGhvcml6ZXIuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYkNvcmUvc3RvcmFnZS9EYXRhYmFzZUF1dGhvcml6ZXIuY3BwCShyZXZpc2lvbiA1MzE5 NCkKKysrIFdlYkNvcmUvc3RvcmFnZS9EYXRhYmFzZUF1dGhvcml6ZXIuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC0zNDQsMTAgKzM0NCwxMCBAQCBpbnQgRGF0YWJhc2VBdXRob3JpemVyOjphbGxvd0Rl dGFjaChjb25zCiAKIGludCBEYXRhYmFzZUF1dGhvcml6ZXI6OmFsbG93RnVuY3Rpb24oY29uc3Qg U3RyaW5nJiBmdW5jdGlvbk5hbWUpCiB7Ci0gIGlmIChtX3NlY3VyaXR5RW5hYmxlZCAmJiAhbV93 aGl0ZWxpc3RlZEZ1bmN0aW9ucy5jb250YWlucyhmdW5jdGlvbk5hbWUubG93ZXIoKSkpCi0gICAg cmV0dXJuIFNRTEF1dGhEZW55OworICAgIGlmIChtX3NlY3VyaXR5RW5hYmxlZCAmJiAhbV93aGl0 ZWxpc3RlZEZ1bmN0aW9ucy5jb250YWlucyhmdW5jdGlvbk5hbWUpKQorICAgICAgICByZXR1cm4g U1FMQXV0aERlbnk7CiAKLSAgcmV0dXJuIFNRTEF1dGhBbGxvdzsKKyAgICByZXR1cm4gU1FMQXV0 aEFsbG93OwogfQogCiB2b2lkIERhdGFiYXNlQXV0aG9yaXplcjo6ZGlzYWJsZSgpCkluZGV4OiBX ZWJDb3JlL3N0b3JhZ2UvRGF0YWJhc2VBdXRob3JpemVyLmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29y ZS9zdG9yYWdlL0RhdGFiYXNlQXV0aG9yaXplci5oCShyZXZpc2lvbiA1MzE5NCkKKysrIFdlYkNv cmUvc3RvcmFnZS9EYXRhYmFzZUF1dGhvcml6ZXIuaAkod29ya2luZyBjb3B5KQpAQCAtMTA0LDcg KzEwNCw3IEBAIHByaXZhdGU6CiAgICAgYm9vbCBtX2xhc3RBY3Rpb25DaGFuZ2VkRGF0YWJhc2Ug OiAxOwogICAgIGJvb2wgbV9yZWFkT25seSA6IDE7CiAKLSAgICBIYXNoU2V0PFN0cmluZz4gbV93 aGl0ZWxpc3RlZEZ1bmN0aW9uczsKKyAgICBIYXNoU2V0PFN0cmluZywgQ2FzZUZvbGRpbmdIYXNo PiBtX3doaXRlbGlzdGVkRnVuY3Rpb25zOwogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQo= 46486 2010-01-13 12:27:28 -0800 2010-01-13 12:34:41 -0800 patch patch text/plain 1910 dumi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MzE5NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDEtMTMgIER1bWl0cnUgRGFuaWxpdWMgIDxkdW1pQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBSZWZhY3RvcmluZyBEYXRhYmFzZUF1dGhvcml6ZXIgdG8gdXNlIGEgQ2FzZUZvbGRpbmdIYXNo IGZ1bmN0aW9uCisgICAgICAgIGZvciB0aGUgc2V0IG9mIHdoaXRlbGlzdGVkIHNxbGl0ZSBmdW5j dGlvbnMsIGFuZCBmaXhpbmcgc29tZQorICAgICAgICBpbmRlbnRpbmcgaXNzdWVzLgorCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzYxMgorCisgICAg ICAgICogc3RvcmFnZS9EYXRhYmFzZUF1dGhvcml6ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 RGF0YWJhc2VBdXRob3JpemVyOjphbGxvd0Z1bmN0aW9uKToKKyAgICAgICAgKiBzdG9yYWdlL0Rh dGFiYXNlQXV0aG9yaXplci5oOgorCiAyMDEwLTAxLTEzICBKZXJlbXkgT3Jsb3cgIDxqb3Jsb3dA Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIE5vIHJldmlld2VyLiAgTW9yZSBvciBsZXNzIGEgYnVp bGQgZml4LiAgTXkgNTMxODAgYnJva2Ugc29tZSAKSW5kZXg6IFdlYkNvcmUvc3RvcmFnZS9EYXRh YmFzZUF1dGhvcml6ZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvc3RvcmFnZS9EYXRhYmFz ZUF1dGhvcml6ZXIuY3BwCShyZXZpc2lvbiA1MzE5NCkKKysrIFdlYkNvcmUvc3RvcmFnZS9EYXRh YmFzZUF1dGhvcml6ZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNDQsMTAgKzM0NCwxMCBAQCBp bnQgRGF0YWJhc2VBdXRob3JpemVyOjphbGxvd0RldGFjaChjb25zCiAKIGludCBEYXRhYmFzZUF1 dGhvcml6ZXI6OmFsbG93RnVuY3Rpb24oY29uc3QgU3RyaW5nJiBmdW5jdGlvbk5hbWUpCiB7Ci0g IGlmIChtX3NlY3VyaXR5RW5hYmxlZCAmJiAhbV93aGl0ZWxpc3RlZEZ1bmN0aW9ucy5jb250YWlu cyhmdW5jdGlvbk5hbWUubG93ZXIoKSkpCi0gICAgcmV0dXJuIFNRTEF1dGhEZW55OworICAgIGlm IChtX3NlY3VyaXR5RW5hYmxlZCAmJiAhbV93aGl0ZWxpc3RlZEZ1bmN0aW9ucy5jb250YWlucyhm dW5jdGlvbk5hbWUpKQorICAgICAgICByZXR1cm4gU1FMQXV0aERlbnk7CiAKLSAgcmV0dXJuIFNR TEF1dGhBbGxvdzsKKyAgICByZXR1cm4gU1FMQXV0aEFsbG93OwogfQogCiB2b2lkIERhdGFiYXNl QXV0aG9yaXplcjo6ZGlzYWJsZSgpCkluZGV4OiBXZWJDb3JlL3N0b3JhZ2UvRGF0YWJhc2VBdXRo b3JpemVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9zdG9yYWdlL0RhdGFiYXNlQXV0aG9yaXpl ci5oCShyZXZpc2lvbiA1MzE5NCkKKysrIFdlYkNvcmUvc3RvcmFnZS9EYXRhYmFzZUF1dGhvcml6 ZXIuaAkod29ya2luZyBjb3B5KQpAQCAtMTA0LDcgKzEwNCw3IEBAIHByaXZhdGU6CiAgICAgYm9v bCBtX2xhc3RBY3Rpb25DaGFuZ2VkRGF0YWJhc2UgOiAxOwogICAgIGJvb2wgbV9yZWFkT25seSA6 IDE7CiAKLSAgICBIYXNoU2V0PFN0cmluZz4gbV93aGl0ZWxpc3RlZEZ1bmN0aW9uczsKKyAgICBI YXNoU2V0PFN0cmluZywgQ2FzZUZvbGRpbmdIYXNoPiBtX3doaXRlbGlzdGVkRnVuY3Rpb25zOwog fTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQo=