33606 2010-01-13 09:54:37 -0800 style checker needs to know about GObject-specific requirements inside WebCore/bindings/gobject/ 2010-01-18 02:13:52 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 gustavo webkit-unassigned abarth commit-queue oldest_to_newest 180266 0 gustavo 2010-01-13 09:54:37 -0800 Xan is working on finally pushing the DOM bindings patch forward again, and we will end up having the WebCore/bindings/gobject/ directory, which will contain many GObject definitions. GObject definitions require a couple of functions to initialize the class structure, and the instance structure, and they need to use lowercased, underscore-separated names (to respect the names given by a define). Here's an example: https://bugs.webkit.org/show_bug.cgi?id=33590#c11 181636 1 46764 abarth 2010-01-17 15:52:31 -0800 Created attachment 46764 Patch 181708 2 46764 commit-queue 2010-01-17 19:36:41 -0800 Comment on attachment 46764 Patch Rejecting patch 46764 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Darin Adler', '--force']" exit_code: 1 patching file WebKitTools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebKitTools/Scripts/webkitpy/style/cpp_style.py Hunk #1 FAILED at 2491. 1 out of 1 hunk FAILED -- saving rejects to file WebKitTools/Scripts/webkitpy/style/cpp_style.py.rej patching file WebKitTools/Scripts/webkitpy/style/cpp_style_unittest.py Hunk #1 succeeded at 3570 with fuzz 2 (offset 23 lines). Full output: http://webkit-commit-queue.appspot.com/results/195516 181777 3 46799 abarth 2010-01-18 01:30:01 -0800 Created attachment 46799 Patch for landing 181800 4 46799 abarth 2010-01-18 02:13:47 -0800 Comment on attachment 46799 Patch for landing Clearing flags on attachment: 46799 Committed r53399: <http://trac.webkit.org/changeset/53399> 181801 5 abarth 2010-01-18 02:13:52 -0800 All reviewed patches have been landed. Closing bug. 46764 2010-01-17 15:52:31 -0800 2010-01-18 01:30:39 -0800 Patch bug-33606-20100117155230.patch text/plain 2536 abarth SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDUzMzczKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDEtMTcgIEFkYW0gQmFydGggIDxhYmFy dGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBzdHlsZSBjaGVja2VyIG5lZWRzIHRvIGtub3cgYWJvdXQgR09iamVjdC1zcGVjaWZp YyByZXF1aXJlbWVudHMgaW5zaWRlIFdlYkNvcmUvYmluZGluZ3MvZ29iamVjdC8KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMzNjA2CisKKyAgICAgICAg QWRkIGFuIGV4Y2VwdGlvbiB0byB0aGUgdW5kZXJzY29yZSBydWxlIGZvciBjZXJ0YWluIEdPYmpl Y3Qtc3BlY2lmaWMKKyAgICAgICAgbmFtZXMuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5 L3N0eWxlL2NwcF9zdHlsZS5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2Nw cF9zdHlsZV91bml0dGVzdC5weToKKwogMjAxMC0wMS0xNSAgSm9uIEhvbmV5Y3V0dCAgPGpob25l eWN1dHRAYXBwbGUuY29tPgogCiAgICAgICAgIGdldF9hY2NQYXJlbnQgc2hvdWxkIHRyeSB0byBy ZXRyaWV2ZSBwYXJlbnQgQWNjZXNzaWJpbGl0eU9iamVjdCwgYmVmb3JlCkluZGV4OiBXZWJLaXRU b29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NwcF9zdHlsZS5weQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NwcF9zdHlsZS5weQkocmV2aXNpb24g NTMzNzIpCisrKyBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NwcF9zdHlsZS5w eQkod29ya2luZyBjb3B5KQpAQCAtMjQ5MSw2ICsyNDkxLDcgQEAgZGVmIGNoZWNrX2lkZW50aWZp ZXJfbmFtZV9pbl9kZWNsYXJhdGlvbgogICAgICAgICAgICAgIyBWYXJpb3VzIGV4Y2VwdGlvbnMg dG8gdGhlIHJ1bGU6IEphdmFTY3JpcHQgb3AgY29kZXMgZnVuY3Rpb25zLCBjb25zdF9pdGVyYXRv ci4KICAgICAgICAgICAgIGlmIChub3QgKGZpbGVuYW1lLmZpbmQoJ0phdmFTY3JpcHRDb3JlJykg Pj0gMCBhbmQgbW9kaWZpZWRfaWRlbnRpZmllci5maW5kKCdfb3BfJykgPj0gMCkKICAgICAgICAg ICAgICAgICBhbmQgbm90IG1vZGlmaWVkX2lkZW50aWZpZXIuc3RhcnRzd2l0aCgndHN0XycpCisg ICAgICAgICAgICAgICAgYW5kIG5vdCBtb2RpZmllZF9pZGVudGlmaWVyLnN0YXJ0c3dpdGgoJ3dl YmtpdF9kb21fb2JqZWN0XycpCiAgICAgICAgICAgICAgICAgYW5kIG5vdCBtb2RpZmllZF9pZGVu dGlmaWVyID09ICJjb25zdF9pdGVyYXRvciIpOgogICAgICAgICAgICAgICAgIGVycm9yKGZpbGVu YW1lLCBsaW5lX251bWJlciwgJ3JlYWRhYmlsaXR5L25hbWluZycsIDQsIGlkZW50aWZpZXIgKyAi IGlzIGluY29ycmVjdGx5IG5hbWVkLiBEb24ndCB1c2UgdW5kZXJzY29yZXMgaW4geW91ciBpZGVu dGlmaWVyIG5hbWVzLiIpCiAKSW5kZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5 bGUvY3BwX3N0eWxlX3VuaXR0ZXN0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL1Njcmlw dHMvd2Via2l0cHkvc3R5bGUvY3BwX3N0eWxlX3VuaXR0ZXN0LnB5CShyZXZpc2lvbiA1MzM3MikK KysrIFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY3BwX3N0eWxlX3VuaXR0ZXN0 LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0zNTQ3LDYgKzM1NDcsMTAgQEAgY2xhc3MgV2ViS2l0U3R5 bGVUZXN0KENwcFN0eWxlVGVzdEJhc2UpOgogICAgICAgICAjIFRoZXJlIGlzIGFuIGV4Y2VwdGlv biBmb3Igc29tZSB1bml0IHRlc3RzIHRoYXQgYmVnaW4gd2l0aCAidHN0XyIuCiAgICAgICAgIHNl bGYuYXNzZXJ0X2xpbnQoJ3ZvaWQgdHN0X1FXZWJGcmFtZTo6YXJyYXlPYmplY3RFbnVtZXJhYmxl KGludCB2YXIxLCBpbnQgdmFyMiknLCAnJykKIAorICAgICAgICAjIEdPYmplY3QgcmVxdWlyZXMg Y2VydGFpbiBtYWdpY2FsIG5hbWVzIGluIGNsYXNzIGRlY2xhcmF0aW9ucy4KKyAgICAgICAgc2Vs Zi5hc3NlcnRfbGludCgndm9pZCB3ZWJraXRfZG9tX29iamVjdF9pbml0KCk7JywgJycpCisgICAg ICAgIHNlbGYuYXNzZXJ0X2xpbnQoJ3ZvaWQgd2Via2l0X2RvbV9vYmplY3RfY2xhc3NfaW5pdCgp OycsICcnKQorCiAgICAgICAgICMgY29uc3RfaXRlcmF0b3IgaXMgYWxsb3dlZCBhcyB3ZWxsLgog ICAgICAgICBzZWxmLmFzc2VydF9saW50KCd0eXBlZGVmIFZlY3RvclR5cGU6OmNvbnN0X2l0ZXJh dG9yIGNvbnN0X2l0ZXJhdG9yOycsICcnKQogCg== 46799 2010-01-18 01:30:01 -0800 2010-01-18 02:13:47 -0800 Patch for landing bug-33606-20100118013000.patch text/plain 2526 abarth SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDUzMzk2KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDEtMTcgIEFkYW0gQmFydGggIDxhYmFy dGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KKworICAg ICAgICBzdHlsZSBjaGVja2VyIG5lZWRzIHRvIGtub3cgYWJvdXQgR09iamVjdC1zcGVjaWZpYyBy ZXF1aXJlbWVudHMKKyAgICAgICAgaW5zaWRlIFdlYkNvcmUvYmluZGluZ3MvZ29iamVjdC8KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMzNjA2CisKKyAg ICAgICAgQWRkIGFuIGV4Y2VwdGlvbiB0byB0aGUgdW5kZXJzY29yZSBydWxlIGZvciBjZXJ0YWlu CisgICAgICAgIEdPYmplY3Qtc3BlY2lmaWMgbmFtZXMuCisKKyAgICAgICAgKiBTY3JpcHRzL3dl YmtpdHB5L3N0eWxlL2NwcF9zdHlsZS5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0 eWxlL2NwcF9zdHlsZV91bml0dGVzdC5weToKKwogMjAxMC0wMS0xOCAgQWRhbSBCYXJ0aCAgPGFi YXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgImJ1aWxkIiBmaXguCkluZGV4 OiBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NwcF9zdHlsZS5weQo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NwcF9zdHlsZS5weQko cmV2aXNpb24gNTMzOTYpCisrKyBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2Nw cF9zdHlsZS5weQkod29ya2luZyBjb3B5KQpAQCAtMjQ2NCw2ICsyNDY0LDcgQEAgZGVmIGNoZWNr X2lkZW50aWZpZXJfbmFtZV9pbl9kZWNsYXJhdGlvbgogICAgICAgICAgICAgIyBWYXJpb3VzIGV4 Y2VwdGlvbnMgdG8gdGhlIHJ1bGU6IEphdmFTY3JpcHQgb3AgY29kZXMgZnVuY3Rpb25zLCBjb25z dF9pdGVyYXRvci4KICAgICAgICAgICAgIGlmIChub3QgKGZpbGVuYW1lLmZpbmQoJ0phdmFTY3Jp cHRDb3JlJykgPj0gMCBhbmQgbW9kaWZpZWRfaWRlbnRpZmllci5maW5kKCdfb3BfJykgPj0gMCkK ICAgICAgICAgICAgICAgICBhbmQgbm90IG1vZGlmaWVkX2lkZW50aWZpZXIuc3RhcnRzd2l0aCgn dHN0XycpCisgICAgICAgICAgICAgICAgYW5kIG5vdCBtb2RpZmllZF9pZGVudGlmaWVyLnN0YXJ0 c3dpdGgoJ3dlYmtpdF9kb21fb2JqZWN0XycpCiAgICAgICAgICAgICAgICAgYW5kIG5vdCBtb2Rp ZmllZF9pZGVudGlmaWVyLnN0YXJ0c3dpdGgoJ3F0XycpCiAgICAgICAgICAgICAgICAgYW5kIG5v dCBtb2RpZmllZF9pZGVudGlmaWVyLmZpbmQoJzo6cXRfJykgPj0gMAogICAgICAgICAgICAgICAg IGFuZCBub3QgbW9kaWZpZWRfaWRlbnRpZmllciA9PSAiY29uc3RfaXRlcmF0b3IiKToKSW5kZXg6 IFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY3BwX3N0eWxlX3VuaXR0ZXN0LnB5 Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY3BwX3N0 eWxlX3VuaXR0ZXN0LnB5CShyZXZpc2lvbiA1MzM5NikKKysrIFdlYktpdFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvc3R5bGUvY3BwX3N0eWxlX3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0z NTYzLDYgKzM1NjMsMTAgQEAgY2xhc3MgV2ViS2l0U3R5bGVUZXN0KENwcFN0eWxlVGVzdEJhc2Up OgogICAgICAgICBzZWxmLmFzc2VydF9saW50KCd2b2lkIHRoaXNfb3BfY29kZShpbnQgdmFyMSwg aW50IHZhcjIpJywgJycsICdKYXZhU2NyaXB0Q29yZS9mb28uY3BwJykKICAgICAgICAgc2VsZi5h c3NlcnRfbGludCgndm9pZCB0aGlzX29wX2NvZGUoaW50IHZhcjEsIGludCB2YXIyKScsICd0aGlz X29wX2NvZGUnICsgbmFtZV9lcnJvcl9tZXNzYWdlKQogCisgICAgICAgICMgR09iamVjdCByZXF1 aXJlcyBjZXJ0YWluIG1hZ2ljYWwgbmFtZXMgaW4gY2xhc3MgZGVjbGFyYXRpb25zLgorICAgICAg ICBzZWxmLmFzc2VydF9saW50KCd2b2lkIHdlYmtpdF9kb21fb2JqZWN0X2luaXQoKTsnLCAnJykK KyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgndm9pZCB3ZWJraXRfZG9tX29iamVjdF9jbGFzc19p bml0KCk7JywgJycpCisKICAgICAgICAgIyBUaGVyZSBpcyBhbiBleGNlcHRpb24gZm9yIHNvbWUg dW5pdCB0ZXN0cyB0aGF0IGJlZ2luIHdpdGggInRzdF8iLgogICAgICAgICBzZWxmLmFzc2VydF9s aW50KCd2b2lkIHRzdF9RV2ViRnJhbWU6OmFycmF5T2JqZWN0RW51bWVyYWJsZShpbnQgdmFyMSwg aW50IHZhcjIpJywgJycpCiAK