33597 2010-01-13 06:55:19 -0800 [Android] [Qt] The JSC ScriptController does not consider Touch Events user gestures. 2010-01-13 09:03:49 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Android OS X 10.5 RESOLVED FIXED P2 Normal --- 32485 1 benm benm android-webkit-unforking commit-queue hausmann kim.1.gronholm webkit.review.bot oldest_to_newest 180195 0 benm 2010-01-13 06:55:19 -0800 As with other UI events (such as keyboard and mouse events) the ScriptController should consider touch events when determining if an event is a user gesture. I have a small patch ready to fix this. 180201 1 46456 benm 2010-01-13 07:18:05 -0800 Created attachment 46456 Proposed Patch. 180202 2 webkit.review.bot 2010-01-13 07:20:49 -0800 Attachment 46456 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/ChangeLog:10: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 180204 3 46457 benm 2010-01-13 07:23:47 -0800 Created attachment 46457 Patch sans-tab. 180209 4 46457 hausmann 2010-01-13 07:38:43 -0800 Comment on attachment 46457 Patch sans-tab. r=me 180213 5 46457 benm 2010-01-13 07:41:56 -0800 Comment on attachment 46457 Patch sans-tab. cq+ for landing. 180252 6 46457 commit-queue 2010-01-13 09:03:43 -0800 Comment on attachment 46457 Patch sans-tab. Clearing flags on attachment: 46457 Committed r53191: <http://trac.webkit.org/changeset/53191> 180253 7 commit-queue 2010-01-13 09:03:49 -0800 All reviewed patches have been landed. Closing bug. 46456 2010-01-13 07:18:05 -0800 2010-01-13 07:23:47 -0800 Proposed Patch. 33597.txt text/plain 1635 benm SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MzE4MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDEtMTMgIEJlbiBNdXJkb2NoICA8YmVubUBnb29nbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtBbmRy b2lkXSBbUXRdIFRoZSBKU0MgU2NyaXB0Q29udHJvbGxlciBkb2VzIG5vdCBjb25zaWRlciBUb3Vj aCBFdmVudHMgdXNlciBnZXN0dXJlcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTMzNTk3CisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9TY3JpcHRDb250 cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdENvbnRyb2xsZXI6OnByb2Nlc3Np bmdVc2VyR2VzdHVyZUV2ZW50KTogQWRkIHRoZSB0b3VjaAorCWV2ZW50IHR5cGVzICh0b3VjaHN0 YXJ0LCB0b3VjaG1vdmUgYW5kIHRvdWNoZW5kKSB0byB0aGUgc2V0IG9mIGV2ZW50cyB0aGF0IGFy ZSBjb25zaWRlcmVkIHVzZXIgZ2VzdHVyZXMuCisKIDIwMTAtMDEtMTMgIEpvY2VseW4gVHVyY290 dGUgIDxqb2NlbHluLnR1cmNvdHRlQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBT aW1vbiBIYXVzbWFubi4KSW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvanMvU2NyaXB0Q29udHJvbGxl ci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy9qcy9TY3JpcHRDb250cm9sbGVy LmNwcAkocmV2aXNpb24gNTMxODIpCisrKyBXZWJDb3JlL2JpbmRpbmdzL2pzL1NjcmlwdENvbnRy b2xsZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNDcsNiArMjQ3LDExIEBAIGJvb2wgU2NyaXB0 Q29udHJvbGxlcjo6cHJvY2Vzc2luZ1VzZXJHZXMKICAgICAgICAgICAgIC8vIGtleWJvYXJkIGV2 ZW50cwogICAgICAgICAgICAgfHwgdHlwZSA9PSBldmVudE5hbWVzKCkua2V5ZG93bkV2ZW50IHx8 IHR5cGUgPT0gZXZlbnROYW1lcygpLmtleXByZXNzRXZlbnQKICAgICAgICAgICAgIHx8IHR5cGUg PT0gZXZlbnROYW1lcygpLmtleXVwRXZlbnQKKyNpZiBFTkFCTEUoVE9VQ0hfRVZFTlRTKQorICAg ICAgICAgICAgLy8gdG91Y2ggZXZlbnRzCisgICAgICAgICAgICB8fCB0eXBlID09IGV2ZW50TmFt ZXMoKS50b3VjaHN0YXJ0RXZlbnQgfHwgdHlwZSA9PSBldmVudE5hbWVzKCkudG91Y2htb3ZlRXZl bnQKKyAgICAgICAgICAgIHx8IHR5cGUgPT0gZXZlbnROYW1lcygpLnRvdWNoZW5kRXZlbnQKKyNl bmRpZgogICAgICAgICAgICAgLy8gb3RoZXIgYWNjZXB0ZWQgZXZlbnRzCiAgICAgICAgICAgICB8 fCB0eXBlID09IGV2ZW50TmFtZXMoKS5zZWxlY3RFdmVudCB8fCB0eXBlID09IGV2ZW50TmFtZXMo KS5jaGFuZ2VFdmVudAogICAgICAgICAgICAgfHwgdHlwZSA9PSBldmVudE5hbWVzKCkuZm9jdXNF dmVudCB8fCB0eXBlID09IGV2ZW50TmFtZXMoKS5ibHVyRXZlbnQK 46457 2010-01-13 07:23:47 -0800 2010-01-13 09:03:43 -0800 Patch sans-tab. 33597.txt text/plain 1633 benm SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MzE4MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMDEtMTMgIEJlbiBNdXJkb2NoICA8YmVubUBnb29nbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtBbmRy b2lkXSBbUXRdIFRoZSBKU0MgU2NyaXB0Q29udHJvbGxlciBkb2VzIG5vdCBjb25zaWRlciBUb3Vj aCBFdmVudHMgdXNlciBnZXN0dXJlcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTMzNTk3CisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9TY3JpcHRDb250 cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdENvbnRyb2xsZXI6OnByb2Nlc3Np bmdVc2VyR2VzdHVyZUV2ZW50KTogQWRkIHRoZSB0b3VjaCBldmVudCB0eXBlcyAodG91Y2hzdGFy dCwgdG91Y2htb3ZlIGFuZCB0b3VjaGVuZCkgdG8gdGhlIHNldCBvZiBldmVudHMgdGhhdCBhcmUg Y29uc2lkZXJlZCB1c2VyIGdlc3R1cmVzLgorCiAyMDEwLTAxLTEzICBKb2NlbHluIFR1cmNvdHRl ICA8am9jZWx5bi50dXJjb3R0ZUBub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2lt b24gSGF1c21hbm4uCkluZGV4OiBXZWJDb3JlL2JpbmRpbmdzL2pzL1NjcmlwdENvbnRyb2xsZXIu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvYmluZGluZ3MvanMvU2NyaXB0Q29udHJvbGxlci5j cHAJKHJldmlzaW9uIDUzMTgyKQorKysgV2ViQ29yZS9iaW5kaW5ncy9qcy9TY3JpcHRDb250cm9s bGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjQ3LDYgKzI0NywxMSBAQCBib29sIFNjcmlwdENv bnRyb2xsZXI6OnByb2Nlc3NpbmdVc2VyR2VzCiAgICAgICAgICAgICAvLyBrZXlib2FyZCBldmVu dHMKICAgICAgICAgICAgIHx8IHR5cGUgPT0gZXZlbnROYW1lcygpLmtleWRvd25FdmVudCB8fCB0 eXBlID09IGV2ZW50TmFtZXMoKS5rZXlwcmVzc0V2ZW50CiAgICAgICAgICAgICB8fCB0eXBlID09 IGV2ZW50TmFtZXMoKS5rZXl1cEV2ZW50CisjaWYgRU5BQkxFKFRPVUNIX0VWRU5UUykKKyAgICAg ICAgICAgIC8vIHRvdWNoIGV2ZW50cworICAgICAgICAgICAgfHwgdHlwZSA9PSBldmVudE5hbWVz KCkudG91Y2hzdGFydEV2ZW50IHx8IHR5cGUgPT0gZXZlbnROYW1lcygpLnRvdWNobW92ZUV2ZW50 CisgICAgICAgICAgICB8fCB0eXBlID09IGV2ZW50TmFtZXMoKS50b3VjaGVuZEV2ZW50CisjZW5k aWYKICAgICAgICAgICAgIC8vIG90aGVyIGFjY2VwdGVkIGV2ZW50cwogICAgICAgICAgICAgfHwg dHlwZSA9PSBldmVudE5hbWVzKCkuc2VsZWN0RXZlbnQgfHwgdHlwZSA9PSBldmVudE5hbWVzKCku Y2hhbmdlRXZlbnQKICAgICAgICAgICAgIHx8IHR5cGUgPT0gZXZlbnROYW1lcygpLmZvY3VzRXZl bnQgfHwgdHlwZSA9PSBldmVudE5hbWVzKCkuYmx1ckV2ZW50Cg==