33591 2010-01-13 05:01:08 -0800 [Qt/Win] Flash in QGraphicsWebView does not process hover correctly. 2010-01-15 01:52:56 -0800 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) PC Windows Vista RESOLVED FIXED Qt P2 Normal --- 1 girish girish hausmann oldest_to_newest 180166 0 girish 2010-01-13 05:01:08 -0800 Mouse hover does not work as expected with the flash in some sites. - http://www.bbc.co.uk/ Hover over the map - http://www.barbie.com/ Hover over the menu items (Games, Videos) 180184 1 46451 girish 2010-01-13 06:00:19 -0800 Created attachment 46451 Fix mouse hover for flash in QGraphicsWebView 180512 2 46451 girish 2010-01-13 19:08:24 -0800 Comment on attachment 46451 Fix mouse hover for flash in QGraphicsWebView > commit 9b2485eb48ef403f6609334fc4d00b0aec901e8a > Author: Girish Ramakrishnan <girish@forwardbias.in> > Date: Wed Jan 13 19:25:11 2010 +0530 > > [Qt/Win] Flash in QGraphicsWebView does not process hover correctly. > > https://bugs.webkit.org/show_bug.cgi?id=33591 > > Mouse hover does not work as expected with the flash in some sites. > - http://www.bbc.co.uk/ Hover over the map > - http://www.barbie.com/ Hover over the menu items (Games, Videos) > The problem appears to be that Flash queries NPNVnetscapeWindow on every > mouse hover. I do not how flash uses this value but returning 0 when flash > is in windowless mode solves the problem (When using QGraphicsWebView we > inject wmode opaque, thereby putting the plugin in windowless mode). > > diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog > index 1968af0..34cf27a 100644 > --- a/WebCore/ChangeLog > +++ b/WebCore/ChangeLog > @@ -1,3 +1,22 @@ > +2010-01-13 Girish Ramakrishnan <girish@forwardbias.in> > + > + Reviewed by NOBODY (OOPS!). > + > + [Qt/Win] Flash in QGraphicsWebView does not process hover correctly. > + > + https://bugs.webkit.org/show_bug.cgi?id=33591 > + > + Mouse hover does not work as expected with the flash in some sites. > + - http://www.bbc.co.uk/ Hover over the map > + - http://www.barbie.com/ Hover over the menu items (Games, Videos) > + The problem appears to be that Flash queries NPNVnetscapeWindow on every > + mouse hover. I do not how flash uses this value but returning 0 when flash > + is in windowless mode solves the problem (When using QGraphicsWebView we > + inject wmode opaque, thereby putting the plugin in windowless mode). > + > + * plugins/win/PluginViewWin.cpp: > + (windowHandleForPageClient): > + > 2009-12-29 Kent Tamura <tkent@chromium.org> > > Reviewed by Maciej Stachowiak. > diff --git a/WebCore/plugins/win/PluginViewWin.cpp b/WebCore/plugins/win/PluginViewWin.cpp > index 763536c..336681e 100644 > --- a/WebCore/plugins/win/PluginViewWin.cpp > +++ b/WebCore/plugins/win/PluginViewWin.cpp > @@ -94,7 +94,9 @@ static inline HWND windowHandleForPageClient(PlatformPageClient client) > #if PLATFORM(QT) > if (!client) > return 0; > - return client->ownerWidget()->winId(); > + if (QWidget *pluginParent = qobject_cast<QWidget*>(client->pluginParent())) > + return pluginParent->winId(); > + return 0; Reviewing my own patch, there is a coding style violation. Other than that, does this look ok? 181095 3 46640 girish 2010-01-14 21:13:44 -0800 Created attachment 46640 Code style fixes 181121 4 46640 hausmann 2010-01-15 00:12:47 -0800 Comment on attachment 46640 Code style fixes r=me 181151 5 girish 2010-01-15 01:43:38 -0800 Landed in r53327 181158 6 hausmann 2010-01-15 01:52:56 -0800 Cherry-picked into qtwebkit-4.6 with commit 24c008da2c13b72c441a2a47a3b17627c4fc4a9e 46451 2010-01-13 06:00:19 -0800 2010-01-14 21:13:44 -0800 Fix mouse hover for flash in QGraphicsWebView mouse_hover text/plain 2470 girish Y29tbWl0IDliMjQ4NWViNDhlZjQwM2Y2NjA5MzM0ZmM0ZDAwYjBhZWM5MDFlOGEKQXV0aG9yOiBH aXJpc2ggUmFtYWtyaXNobmFuIDxnaXJpc2hAZm9yd2FyZGJpYXMuaW4+CkRhdGU6ICAgV2VkIEph biAxMyAxOToyNToxMSAyMDEwICswNTMwCgogICAgW1F0L1dpbl0gRmxhc2ggaW4gUUdyYXBoaWNz V2ViVmlldyBkb2VzIG5vdCBwcm9jZXNzIGhvdmVyIGNvcnJlY3RseS4KICAgIAogICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMzNTkxCiAgICAKICAgIE1vdXNlIGhv dmVyIGRvZXMgbm90IHdvcmsgYXMgZXhwZWN0ZWQgd2l0aCB0aGUgZmxhc2ggaW4gc29tZSBzaXRl cy4KICAgICAgICAtIGh0dHA6Ly93d3cuYmJjLmNvLnVrLyBIb3ZlciBvdmVyIHRoZSBtYXAKICAg ICAgICAtIGh0dHA6Ly93d3cuYmFyYmllLmNvbS8gSG92ZXIgb3ZlciB0aGUgbWVudSBpdGVtcyAo R2FtZXMsIFZpZGVvcykKICAgIFRoZSBwcm9ibGVtIGFwcGVhcnMgdG8gYmUgdGhhdCBGbGFzaCBx dWVyaWVzIE5QTlZuZXRzY2FwZVdpbmRvdyBvbiBldmVyeQogICAgbW91c2UgaG92ZXIuIEkgZG8g bm90IGhvdyBmbGFzaCB1c2VzIHRoaXMgdmFsdWUgYnV0IHJldHVybmluZyAwIHdoZW4gZmxhc2gK ICAgIGlzIGluIHdpbmRvd2xlc3MgbW9kZSBzb2x2ZXMgdGhlIHByb2JsZW0gKFdoZW4gdXNpbmcg UUdyYXBoaWNzV2ViVmlldyB3ZQogICAgaW5qZWN0IHdtb2RlIG9wYXF1ZSwgdGhlcmVieSBwdXR0 aW5nIHRoZSBwbHVnaW4gaW4gd2luZG93bGVzcyBtb2RlKS4KCmRpZmYgLS1naXQgYS9XZWJDb3Jl L0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDE5NjhhZjAuLjM0Y2YyN2EgMTAw NjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMjIgQEAKKzIwMTAtMDEtMTMgIEdpcmlzaCBSYW1ha3Jpc2huYW4gIDxnaXJpc2hAZm9y d2FyZGJpYXMuaW4+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgW1F0L1dpbl0gRmxhc2ggaW4gUUdyYXBoaWNzV2ViVmlldyBkb2VzIG5vdCBwcm9jZXNz IGhvdmVyIGNvcnJlY3RseS4KKyAgICAgICAgCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zMzU5MQorICAgICAgICAKKyAgICAgICAgTW91c2UgaG92ZXIg ZG9lcyBub3Qgd29yayBhcyBleHBlY3RlZCB3aXRoIHRoZSBmbGFzaCBpbiBzb21lIHNpdGVzLgor ICAgICAgICAtIGh0dHA6Ly93d3cuYmJjLmNvLnVrLyBIb3ZlciBvdmVyIHRoZSBtYXAKKyAgICAg ICAgLSBodHRwOi8vd3d3LmJhcmJpZS5jb20vIEhvdmVyIG92ZXIgdGhlIG1lbnUgaXRlbXMgKEdh bWVzLCBWaWRlb3MpCisgICAgICAgIFRoZSBwcm9ibGVtIGFwcGVhcnMgdG8gYmUgdGhhdCBGbGFz aCBxdWVyaWVzIE5QTlZuZXRzY2FwZVdpbmRvdyBvbiBldmVyeQorICAgICAgICBtb3VzZSBob3Zl ci4gSSBkbyBub3QgaG93IGZsYXNoIHVzZXMgdGhpcyB2YWx1ZSBidXQgcmV0dXJuaW5nIDAgd2hl biBmbGFzaAorICAgICAgICBpcyBpbiB3aW5kb3dsZXNzIG1vZGUgc29sdmVzIHRoZSBwcm9ibGVt IChXaGVuIHVzaW5nIFFHcmFwaGljc1dlYlZpZXcgd2UKKyAgICAgICAgaW5qZWN0IHdtb2RlIG9w YXF1ZSwgdGhlcmVieSBwdXR0aW5nIHRoZSBwbHVnaW4gaW4gd2luZG93bGVzcyBtb2RlKS4KKwor ICAgICAgICAqIHBsdWdpbnMvd2luL1BsdWdpblZpZXdXaW4uY3BwOgorICAgICAgICAod2luZG93 SGFuZGxlRm9yUGFnZUNsaWVudCk6CisKIDIwMDktMTItMjkgIEtlbnQgVGFtdXJhICA8dGtlbnRA Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hY2llaiBTdGFjaG93aWFrLgpk aWZmIC0tZ2l0IGEvV2ViQ29yZS9wbHVnaW5zL3dpbi9QbHVnaW5WaWV3V2luLmNwcCBiL1dlYkNv cmUvcGx1Z2lucy93aW4vUGx1Z2luVmlld1dpbi5jcHAKaW5kZXggNzYzNTM2Yy4uMzM2NjgxZSAx MDA2NDQKLS0tIGEvV2ViQ29yZS9wbHVnaW5zL3dpbi9QbHVnaW5WaWV3V2luLmNwcAorKysgYi9X ZWJDb3JlL3BsdWdpbnMvd2luL1BsdWdpblZpZXdXaW4uY3BwCkBAIC05NCw3ICs5NCw5IEBAIHN0 YXRpYyBpbmxpbmUgSFdORCB3aW5kb3dIYW5kbGVGb3JQYWdlQ2xpZW50KFBsYXRmb3JtUGFnZUNs aWVudCBjbGllbnQpCiAjaWYgUExBVEZPUk0oUVQpCiAgICAgaWYgKCFjbGllbnQpCiAgICAgICAg IHJldHVybiAwOwotICAgIHJldHVybiBjbGllbnQtPm93bmVyV2lkZ2V0KCktPndpbklkKCk7Cisg ICAgaWYgKFFXaWRnZXQgKnBsdWdpblBhcmVudCA9IHFvYmplY3RfY2FzdDxRV2lkZ2V0Kj4oY2xp ZW50LT5wbHVnaW5QYXJlbnQoKSkpCisgICAgICAgIHJldHVybiBwbHVnaW5QYXJlbnQtPndpbklk KCk7CisgICAgcmV0dXJuIDA7CiAjZWxpZiBQTEFURk9STShXWCkKICAgICBpZiAoIWNsaWVudCkK ICAgICAgICAgcmV0dXJuIDA7Cg== 46640 2010-01-14 21:13:44 -0800 2010-01-15 00:12:47 -0800 Code style fixes take2 text/plain 2470 girish Y29tbWl0IDY0ZWJjOTMyMjkxYjFiNmY0N2RhMzk2MTQ2YmEwZWFmN2JmMTM1NzkKQXV0aG9yOiBH aXJpc2ggUmFtYWtyaXNobmFuIDxnaXJpc2hAZm9yd2FyZGJpYXMuaW4+CkRhdGU6ICAgV2VkIEph biAxMyAxOToyNToxMSAyMDEwICswNTMwCgogICAgW1F0L1dpbl0gRmxhc2ggaW4gUUdyYXBoaWNz V2ViVmlldyBkb2VzIG5vdCBwcm9jZXNzIGhvdmVyIGNvcnJlY3RseS4KICAgIAogICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMzNTkxCiAgICAKICAgIE1vdXNlIGhv dmVyIGRvZXMgbm90IHdvcmsgYXMgZXhwZWN0ZWQgd2l0aCB0aGUgZmxhc2ggaW4gc29tZSBzaXRl cy4KICAgICAgICAtIGh0dHA6Ly93d3cuYmJjLmNvLnVrLyBIb3ZlciBvdmVyIHRoZSBtYXAKICAg ICAgICAtIGh0dHA6Ly93d3cuYmFyYmllLmNvbS8gSG92ZXIgb3ZlciB0aGUgbWVudSBpdGVtcyAo R2FtZXMsIFZpZGVvcykKICAgIFRoZSBwcm9ibGVtIGFwcGVhcnMgdG8gYmUgdGhhdCBGbGFzaCBx dWVyaWVzIE5QTlZuZXRzY2FwZVdpbmRvdyBvbiBldmVyeQogICAgbW91c2UgaG92ZXIuIEkgZG8g bm90IGhvdyBmbGFzaCB1c2VzIHRoaXMgdmFsdWUgYnV0IHJldHVybmluZyAwIHdoZW4gZmxhc2gK ICAgIGlzIGluIHdpbmRvd2xlc3MgbW9kZSBzb2x2ZXMgdGhlIHByb2JsZW0gKFdoZW4gdXNpbmcg UUdyYXBoaWNzV2ViVmlldyB3ZQogICAgaW5qZWN0IHdtb2RlIG9wYXF1ZSwgdGhlcmVieSBwdXR0 aW5nIHRoZSBwbHVnaW4gaW4gd2luZG93bGVzcyBtb2RlKS4KCmRpZmYgLS1naXQgYS9XZWJDb3Jl L0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDE5NjhhZjAuLjM0Y2YyN2EgMTAw NjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMjIgQEAKKzIwMTAtMDEtMTMgIEdpcmlzaCBSYW1ha3Jpc2huYW4gIDxnaXJpc2hAZm9y d2FyZGJpYXMuaW4+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgW1F0L1dpbl0gRmxhc2ggaW4gUUdyYXBoaWNzV2ViVmlldyBkb2VzIG5vdCBwcm9jZXNz IGhvdmVyIGNvcnJlY3RseS4KKyAgICAgICAgCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zMzU5MQorICAgICAgICAKKyAgICAgICAgTW91c2UgaG92ZXIg ZG9lcyBub3Qgd29yayBhcyBleHBlY3RlZCB3aXRoIHRoZSBmbGFzaCBpbiBzb21lIHNpdGVzLgor ICAgICAgICAtIGh0dHA6Ly93d3cuYmJjLmNvLnVrLyBIb3ZlciBvdmVyIHRoZSBtYXAKKyAgICAg ICAgLSBodHRwOi8vd3d3LmJhcmJpZS5jb20vIEhvdmVyIG92ZXIgdGhlIG1lbnUgaXRlbXMgKEdh bWVzLCBWaWRlb3MpCisgICAgICAgIFRoZSBwcm9ibGVtIGFwcGVhcnMgdG8gYmUgdGhhdCBGbGFz aCBxdWVyaWVzIE5QTlZuZXRzY2FwZVdpbmRvdyBvbiBldmVyeQorICAgICAgICBtb3VzZSBob3Zl ci4gSSBkbyBub3QgaG93IGZsYXNoIHVzZXMgdGhpcyB2YWx1ZSBidXQgcmV0dXJuaW5nIDAgd2hl biBmbGFzaAorICAgICAgICBpcyBpbiB3aW5kb3dsZXNzIG1vZGUgc29sdmVzIHRoZSBwcm9ibGVt IChXaGVuIHVzaW5nIFFHcmFwaGljc1dlYlZpZXcgd2UKKyAgICAgICAgaW5qZWN0IHdtb2RlIG9w YXF1ZSwgdGhlcmVieSBwdXR0aW5nIHRoZSBwbHVnaW4gaW4gd2luZG93bGVzcyBtb2RlKS4KKwor ICAgICAgICAqIHBsdWdpbnMvd2luL1BsdWdpblZpZXdXaW4uY3BwOgorICAgICAgICAod2luZG93 SGFuZGxlRm9yUGFnZUNsaWVudCk6CisKIDIwMDktMTItMjkgIEtlbnQgVGFtdXJhICA8dGtlbnRA Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hY2llaiBTdGFjaG93aWFrLgpk aWZmIC0tZ2l0IGEvV2ViQ29yZS9wbHVnaW5zL3dpbi9QbHVnaW5WaWV3V2luLmNwcCBiL1dlYkNv cmUvcGx1Z2lucy93aW4vUGx1Z2luVmlld1dpbi5jcHAKaW5kZXggNzYzNTM2Yy4uNTFiMWZhZCAx MDA2NDQKLS0tIGEvV2ViQ29yZS9wbHVnaW5zL3dpbi9QbHVnaW5WaWV3V2luLmNwcAorKysgYi9X ZWJDb3JlL3BsdWdpbnMvd2luL1BsdWdpblZpZXdXaW4uY3BwCkBAIC05NCw3ICs5NCw5IEBAIHN0 YXRpYyBpbmxpbmUgSFdORCB3aW5kb3dIYW5kbGVGb3JQYWdlQ2xpZW50KFBsYXRmb3JtUGFnZUNs aWVudCBjbGllbnQpCiAjaWYgUExBVEZPUk0oUVQpCiAgICAgaWYgKCFjbGllbnQpCiAgICAgICAg IHJldHVybiAwOwotICAgIHJldHVybiBjbGllbnQtPm93bmVyV2lkZ2V0KCktPndpbklkKCk7Cisg ICAgaWYgKFFXaWRnZXQqIHBsdWdpblBhcmVudCA9IHFvYmplY3RfY2FzdDxRV2lkZ2V0Kj4oY2xp ZW50LT5wbHVnaW5QYXJlbnQoKSkpCisgICAgICAgIHJldHVybiBwbHVnaW5QYXJlbnQtPndpbklk KCk7CisgICAgcmV0dXJuIDA7CiAjZWxpZiBQTEFURk9STShXWCkKICAgICBpZiAoIWNsaWVudCkK ICAgICAgICAgcmV0dXJuIDA7Cg==