33586 2010-01-13 04:22:48 -0800 [Android] appendClassName in jni_runtime.cpp uses JSC-specific UString type 2010-01-13 10:30:17 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Android Android RESOLVED FIXED P2 Normal --- 32154 1 steveblock steveblock android-webkit-unforking barraclough commit-queue steveblock oldest_to_newest 180150 0 steveblock 2010-01-13 04:22:48 -0800 appendClassName is a static helper function used in jni_runtime.cpp. This file is largely script engine independent. However, appendClassName uses the JSC-specific UString type, which causes problems on Android, where we can build with JSC or V8. The function should be updated to use a non-JSC-specific type. 180256 1 steveblock 2010-01-13 09:30:13 -0800 jni_runtime was recently (http://trac.webkit.org/changeset/52329) updated to use JSC::StringBuilder, rather than UString, but the problem still stands. 180264 2 46471 steveblock 2010-01-13 09:51:16 -0800 Created attachment 46471 Patch 1 for Bug 33586 Uses WebCore::SringBuilder in place of JSC::StringBuilder. Note that this also avoids the use of UString::ascii, which according to UString.h, should only be used for debugging purposes. 180283 3 46471 commit-queue 2010-01-13 10:30:12 -0800 Comment on attachment 46471 Patch 1 for Bug 33586 Clearing flags on attachment: 46471 Committed r53193: <http://trac.webkit.org/changeset/53193> 180284 4 commit-queue 2010-01-13 10:30:17 -0800 All reviewed patches have been landed. Closing bug. 46471 2010-01-13 09:51:16 -0800 2010-01-13 10:30:12 -0800 Patch 1 for Bug 33586 appendClassName.txt text/plain 1920 steveblock SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MzE5MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDEtMTMgIFN0ZXZlIEJsb2NrICA8c3RldmVibG9ja0Bnb29n bGUuY29tPgorCisgICAgICAgIFVwZGF0ZSBhcHBlbmRDbGFzc05hbWUgaW4gam5pX3J1bnRpbWUu Y3BwIHRvIHVzZSBXZWJDb3JlOjpTdHJpbmdCdWlsZGVyLCByYXRoZXIgdGhhbiBKU0M6OlN0cmlu Z0J1aWxkZXIuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0zMzU4NgorCisgICAgICAgIEF2b2lkaW5nIHRoZSBKU0MgdmVyc2lvbiBvZiBTdHJpbmdCdWls ZGVyIGFsbG93cyB0aGlzIGZpbGUgdG8gYmUgdXNlZCB3aXRoIGJvdGggSlNDIGFuZCBWOCBvbiBB bmRyb2lkLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgcmVmYWN0b3Jpbmcgb25seS4KKworICAg ICAgICAqIGJyaWRnZS9qbmkvam5pX3J1bnRpbWUuY3BwOiBNb2RpZmllZC4KKyAgICAgICAgKEph dmFNZXRob2Q6OnNpZ25hdHVyZSk6IE1vZGlmaWVkLiBVc2UgV2ViQ29yZTo6U3RyaW5nQnVpbGRl ci4KKwogMjAxMC0wMS0xMyAgQmVuIE11cmRvY2ggIDxiZW5tQGdvb2dsZS5jb20+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgU2ltb24gSGF1c21hbm4uCkluZGV4OiBXZWJDb3JlL2JyaWRnZS9qbmkv am5pX3J1bnRpbWUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvYnJpZGdlL2puaS9qbmlfcnVu dGltZS5jcHAJKHJldmlzaW9uIDUzMTgyKQorKysgV2ViQ29yZS9icmlkZ2Uvam5pL2puaV9ydW50 aW1lLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjgsNiArMjgsOCBAQAogCiAjaWYgRU5BQkxFKE1B Q19KQVZBX0JSSURHRSkKIAorI2luY2x1ZGUgIkNTdHJpbmcuaCIKKyNpbmNsdWRlICJTdHJpbmdC dWlsZGVyLmgiCiAjaW5jbHVkZSAiam5pX3V0aWxpdHkuaCIKICNpbmNsdWRlICJqbmlfdXRpbGl0 eV9wcml2YXRlLmgiCiAjaW5jbHVkZSAicnVudGltZV9hcnJheS5oIgpAQCAtMzUsNyArMzcsNiBA QAogI2luY2x1ZGUgInJ1bnRpbWVfcm9vdC5oIgogI2luY2x1ZGUgPHJ1bnRpbWUvRXJyb3IuaD4K ICNpbmNsdWRlIDxydW50aW1lL0pTTG9jay5oPgotI2luY2x1ZGUgPHJ1bnRpbWUvU3RyaW5nQnVp bGRlci5oPgogCiAjaWZkZWYgTkRFQlVHCiAjZGVmaW5lIEpTX0xPRyhmb3JtYXRBbmRBcmdzLi4u KSAoKHZvaWQpMCkKQEAgLTQ4LDYgKzQ5LDcgQEAKIAogdXNpbmcgbmFtZXNwYWNlIEpTQzsKIHVz aW5nIG5hbWVzcGFjZSBKU0M6OkJpbmRpbmdzOwordXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAK IAogSmF2YVBhcmFtZXRlcjo6SmF2YVBhcmFtZXRlciAoSk5JRW52ICplbnYsIGpzdHJpbmcgdHlw ZSkKQEAgLTM0OCw4ICszNTAsOCBAQCBjb25zdCBjaGFyICpKYXZhTWV0aG9kOjpzaWduYXR1cmUo KSBjb25zCiAgICAgICAgICAgICB9CiAgICAgICAgIH0KICAgICAgICAgCi0gICAgICAgIFVTdHJp bmcgc2lnbmF0dXJlVVN0cmluZyA9IHNpZ25hdHVyZUJ1aWxkZXIucmVsZWFzZSgpOwotICAgICAg ICBfc2lnbmF0dXJlID0gc3RyZHVwKHNpZ25hdHVyZVVTdHJpbmcuYXNjaWkoKSk7CisgICAgICAg IFN0cmluZyBzaWduYXR1cmVTdHJpbmcgPSBzaWduYXR1cmVCdWlsZGVyLnRvU3RyaW5nKCk7Cisg ICAgICAgIF9zaWduYXR1cmUgPSBzdHJkdXAoc2lnbmF0dXJlU3RyaW5nLnV0ZjgoKS5kYXRhKCkp OwogICAgIH0KICAgICAKICAgICByZXR1cm4gX3NpZ25hdHVyZTsK