33584 2010-01-13 02:34:38 -0800 [V8] Slow named property lookup on DOMWindow because of missing fast case 2010-01-13 23:35:13 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ager webkit-unassigned commit-queue dglazkov eric jamesr oldest_to_newest 180136 0 ager 2010-01-13 02:34:38 -0800 In the V8 named getter on DOMWindow objects, we always search the DOM using namedItems(propertyName) on the document. We should check that the document is an HTMLDocument and use fast checks to determine if elements with that name exists before searching the DOM for all occurrences. See http://crbug.com/32040 for an example where this hits us. 180138 1 46442 ager 2010-01-13 02:42:53 -0800 Created attachment 46442 Add fast case checks to V8 named getter on DOMWindow objects. 180237 2 46442 dglazkov 2010-01-13 08:27:38 -0800 Comment on attachment 46442 Add fast case checks to V8 named getter on DOMWindow objects. looks great! 180568 3 46442 commit-queue 2010-01-13 23:35:08 -0800 Comment on attachment 46442 Add fast case checks to V8 named getter on DOMWindow objects. Clearing flags on attachment: 46442 Committed r53241: <http://trac.webkit.org/changeset/53241> 180569 4 commit-queue 2010-01-13 23:35:13 -0800 All reviewed patches have been landed. Closing bug. 46442 2010-01-13 02:42:53 -0800 2010-01-13 23:35:07 -0800 Add fast case checks to V8 named getter on DOMWindow objects. named-getter.txt text/plain 2272 ager SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MzE4MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMDEtMTMgIE1hZHMgQWdlciAgPGFnZXJAY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtWOF0g U2xvdyBuYW1lZCBwcm9wZXJ0eSBsb29rdXAgb24gRE9NV2luZG93IGJlY2F1c2Ugb2YgbWlzc2lu ZyBmYXN0IGNhc2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTMzNTg0CisKKyAgICAgICAgQWRkIGZhc3QgY2FzZSBjaGVja3MgdG8gVjggbmFtZWQgcHJv cGVydHkgZ2V0dGVyIG9uIERPTVdpbmRvdworICAgICAgICBvYmplY3RzLiAgSWYgdGhlIHByb3Bl cnR5IGlzIG5vdCBpbiB0aGUgRE9NIHRoZXJlIGlzIG5vIHJlYXNvbiB0bworICAgICAgICBzZWFy Y2ggdGhlIERPTSBmb3IgYWxsIG9jY3VycmVuY2VzLgorCisgICAgICAgIENvdmVyZWQgYnkgbGF5 b3V0IHRlc3RzLgorCisgICAgICAgICogYmluZGluZ3MvdjgvY3VzdG9tL1Y4RE9NV2luZG93Q3Vz dG9tLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlY4RE9NV2luZG93OjpuYW1lZFByb3BlcnR5R2V0 dGVyKToKKwogMjAxMC0wMS0xMyAgTWlpa2thIEhlaWtraW5lbiA8bWlpa2thLmhlaWtraW5lbkBk aWdpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2ltb24gSGF1c21hbm4uCkluZGV4OiBX ZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOERPTVdpbmRvd0N1c3RvbS5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhET01XaW5kb3dDdXN0b20uY3BwCShy ZXZpc2lvbiA1MzE4MikKKysrIFdlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4RE9NV2luZG93 Q3VzdG9tLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDAsNiArNDAsNyBAQAogI2luY2x1ZGUgIkZy YW1lTG9hZFJlcXVlc3QuaCIKICNpbmNsdWRlICJGcmFtZVZpZXcuaCIKICNpbmNsdWRlICJIVE1M Q29sbGVjdGlvbi5oIgorI2luY2x1ZGUgIkhUTUxEb2N1bWVudC5oIgogI2luY2x1ZGUgIk1lZGlh UGxheWVyLmgiCiAjaW5jbHVkZSAiUGFnZS5oIgogI2luY2x1ZGUgIlBsYXRmb3JtU2NyZWVuLmgi CkBAIC04MTIsMTMgKzgxMywxNCBAQCB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gVjhET01XaW5kb3c6 Om5hbWVkCiAgICAgLy8gU2VhcmNoIG5hbWVkIGl0ZW1zIGluIHRoZSBkb2N1bWVudC4KICAgICBE b2N1bWVudCogZG9jID0gZnJhbWUtPmRvY3VtZW50KCk7CiAKLSAgICBpZiAoZG9jKSB7Ci0gICAg ICAgIFJlZlB0cjxIVE1MQ29sbGVjdGlvbj4gaXRlbXMgPSBkb2MtPndpbmRvd05hbWVkSXRlbXMo cHJvcE5hbWUpOwotICAgICAgICBpZiAoaXRlbXMtPmxlbmd0aCgpID49IDEpIHsKLSAgICAgICAg ICAgIGlmIChpdGVtcy0+bGVuZ3RoKCkgPT0gMSkKLSAgICAgICAgICAgICAgICByZXR1cm4gVjhE T01XcmFwcGVyOjpjb252ZXJ0Tm9kZVRvVjhPYmplY3QoaXRlbXMtPmZpcnN0SXRlbSgpKTsKLSAg ICAgICAgICAgIGVsc2UKKyAgICBpZiAoZG9jICYmIGRvYy0+aXNIVE1MRG9jdW1lbnQoKSkgewor ICAgICAgICBpZiAoc3RhdGljX2Nhc3Q8SFRNTERvY3VtZW50Kj4oZG9jKS0+aGFzTmFtZWRJdGVt KHByb3BOYW1lLmltcGwoKSkgfHwgZG9jLT5oYXNFbGVtZW50V2l0aElkKHByb3BOYW1lLmltcGwo KSkpIHsKKyAgICAgICAgICAgIFJlZlB0cjxIVE1MQ29sbGVjdGlvbj4gaXRlbXMgPSBkb2MtPndp bmRvd05hbWVkSXRlbXMocHJvcE5hbWUpOworICAgICAgICAgICAgaWYgKGl0ZW1zLT5sZW5ndGgo KSA+PSAxKSB7CisgICAgICAgICAgICAgICAgaWYgKGl0ZW1zLT5sZW5ndGgoKSA9PSAxKQorICAg ICAgICAgICAgICAgICAgICByZXR1cm4gVjhET01XcmFwcGVyOjpjb252ZXJ0Tm9kZVRvVjhPYmpl Y3QoaXRlbXMtPmZpcnN0SXRlbSgpKTsKICAgICAgICAgICAgICAgICByZXR1cm4gVjhET01XcmFw cGVyOjpjb252ZXJ0VG9WOE9iamVjdChWOENsYXNzSW5kZXg6OkhUTUxDT0xMRUNUSU9OLCBpdGVt cy5yZWxlYXNlKCkpOworICAgICAgICAgICAgfQogICAgICAgICB9CiAgICAgfQogCg==