33575 2010-01-12 22:11:34 -0800 [Gtk] Compiler warning: comparisons like 'X<=Y<=Z' do not have their mathematical meaning 2010-01-15 03:55:17 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 captain.magnus pnormand eric pnormand xan.lopez oldest_to_newest 180091 0 captain.magnus 2010-01-12 22:11:34 -0800 Compiler complains about "comparisons like 'X<=Y<=Z' do not have their mathematical meaning" in WebCore/platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp Here's a patch. Not sure if I got it right though :-) Index: WebCore/platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp =================================================================== --- WebCore/platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp.orig 2010-01-05 08:53:00.000000000 +1100 +++ WebCore/platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp 2010-01-13 16:59:29.000000000 +1100 @@ -852,11 +852,11 @@ static HashSet<String> mimeTypeCache() if (G_VALUE_TYPE(layer) == GST_TYPE_INT_RANGE) { gint minLayer = gst_value_get_int_range_min(layer); gint maxLayer = gst_value_get_int_range_max(layer); - if (minLayer <= 1 <= maxLayer) + if (minLayer <= 1 && 1 <= maxLayer) cache.add(String("audio/mp1")); - if (minLayer <= 2 <= maxLayer) + if (minLayer <= 2 && 2 <= maxLayer) cache.add(String("audio/mp2")); - if (minLayer <= 3 <= maxLayer) + if (minLayer <= 3 && 3 <= maxLayer) cache.add(String("audio/mp3")); } } 180367 1 ap 2010-01-13 13:01:20 -0800 That's clearly a bug. Would you be willing to submit a patch for review, as described in <http://webkit.org/coding/contributing.html>? 180676 2 pnormand 2010-01-14 04:57:07 -0800 Thanks Magnus for spotting this, it is my mistake :( I will try your patch and attach it here if you don't mind 180683 3 46556 pnormand 2010-01-14 05:13:02 -0800 Created attachment 46556 fix compiler warnings 180689 4 46556 xan.lopez 2010-01-14 05:27:41 -0800 Comment on attachment 46556 fix compiler warnings LGTM. 180769 5 captain.magnus 2010-01-14 10:08:02 -0800 (In reply to comment #2) > Thanks Magnus for spotting this, it is my mistake :( I will try your patch and > attach it here if you don't mind Philippe, I don't mind. Just wasn't sure that the logic was according to my patch. 180864 6 eric 2010-01-14 12:54:31 -0800 Attachment 46556 was posted by a committer and has review+, assigning to Philippe Normand for commit. 181193 7 pnormand 2010-01-15 03:55:17 -0800 Landed as r53329. Thanks! 46556 2010-01-14 05:13:02 -0800 2010-01-14 05:27:40 -0800 fix compiler warnings fix-compiler-warnings.patch text/plain 2310 pnormand RnJvbSA0OTY3YWQyY2ViYWJkODk5N2VjNjM2YzZlZmQ0NGNkODFhNTcwY2E1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUaHUsIDE0IEphbiAyMDEwIDE0OjEyOjEyICswMTAwClN1YmplY3Q6IFtQQVRDSF0g Zml4IGNvbXBpbGVyIHdhcm5pbmdzCgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIHwgICAxMiArKysrKysrKysrKysKIC4uLi9ncmFwaGljcy9n dGsvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcCAgIHwgICAgNiArKystLS0KIDIgZmls ZXMgY2hhbmdlZCwgMTUgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQg YS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGZlMjU2YzQuLjYx MmFhNzcgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDEtMTQgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9y bWFuZEBpZ2FsaWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFtHdGtdIENvbXBpbGVyIHdhcm5pbmc6IGNvbXBhcmlzb25zIGxpa2UgJ1g8PVk8 PVonIGRvIG5vdCBoYXZlIHRoZWlyIG1hdGhlbWF0aWNhbCBtZWFuaW5nCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzU3NQorCisgICAgICAgIFBhdGNo IGZyb20gTWFnbnVzIEJvbWFuIDxjYXB0YWluLm1hZ251c0BnbWFpbC5jb20+CisKKyAgICAgICAg KiBwbGF0Zm9ybS9ncmFwaGljcy9ndGsvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6Om1pbWVUeXBlQ2FjaGUpOiBmaXggY29tcGlsZXIgd2FybmluZ3Mu CisKIDIwMTAtMDEtMTQgIEFuZHJlYXMgS2xpbmcgIDxhbmRyZWFzLmtsaW5nQG5va2lhLmNvbT4K IAogICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbi4KZGlmZiAt LWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL01lZGlhUGxheWVyUHJpdmF0ZUdT dHJlYW1lci5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9NZWRpYVBsYXllclBy aXZhdGVHU3RyZWFtZXIuY3BwCmluZGV4IGI5OWJkMjYuLmYwZmY1MTkgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5j cHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ndGsvTWVkaWFQbGF5ZXJQcml2YXRl R1N0cmVhbWVyLmNwcApAQCAtODY5LDExICs4NjksMTEgQEAgc3RhdGljIEhhc2hTZXQ8U3RyaW5n PiBtaW1lVHlwZUNhY2hlKCkKICAgICAgICAgICAgICAgICAgICAgICAgIGlmIChHX1ZBTFVFX1RZ UEUobGF5ZXIpID09IEdTVF9UWVBFX0lOVF9SQU5HRSkgewogICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGdpbnQgbWluTGF5ZXIgPSBnc3RfdmFsdWVfZ2V0X2ludF9yYW5nZV9taW4obGF5ZXIp OwogICAgICAgICAgICAgICAgICAgICAgICAgICAgIGdpbnQgbWF4TGF5ZXIgPSBnc3RfdmFsdWVf Z2V0X2ludF9yYW5nZV9tYXgobGF5ZXIpOwotICAgICAgICAgICAgICAgICAgICAgICAgICAgIGlm IChtaW5MYXllciA8PSAxIDw9IG1heExheWVyKQorICAgICAgICAgICAgICAgICAgICAgICAgICAg IGlmIChtaW5MYXllciA8PSAxICYmIDEgPD0gbWF4TGF5ZXIpCiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGNhY2hlLmFkZChTdHJpbmcoImF1ZGlvL21wMSIpKTsKLSAgICAgICAgICAg ICAgICAgICAgICAgICAgICBpZiAobWluTGF5ZXIgPD0gMiA8PSBtYXhMYXllcikKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICBpZiAobWluTGF5ZXIgPD0gMiAmJiAyIDw9IG1heExheWVyKQog ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjYWNoZS5hZGQoU3RyaW5nKCJhdWRpby9t cDIiKSk7Ci0gICAgICAgICAgICAgICAgICAgICAgICAgICAgaWYgKG1pbkxheWVyIDw9IDMgPD0g bWF4TGF5ZXIpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgaWYgKG1pbkxheWVyIDw9IDMg JiYgMyA8PSBtYXhMYXllcikKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY2FjaGUu YWRkKFN0cmluZygiYXVkaW8vbXAzIikpOwogICAgICAgICAgICAgICAgICAgICAgICAgfQogICAg ICAgICAgICAgICAgICAgICB9Ci0tIAoxLjYuMy4z