33560 2010-01-12 16:39:40 -0800 [chromium] setReplacing call in WebFrameImpl.cpp is causing problems with multipart code 2010-01-12 17:29:49 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 tony tony commit-queue fishd oldest_to_newest 180029 0 tony 2010-01-12 16:39:40 -0800 In bug 31446 comment 7, Darin asks if WebFrameImpl::loadData call to setReplacing could that interact in an interesting way with this code. Turns out he was right! This is causing an assert to trigger with the code added in r53143 because we're trying to replace a document that already exists. Fix coming up. 180035 1 46413 tony 2010-01-12 16:46:48 -0800 Created attachment 46413 Patch 180045 2 46413 abarth 2010-01-12 17:12:43 -0800 Comment on attachment 46413 Patch I think this is ok, but I'm not 100% sure. 180051 3 46413 commit-queue 2010-01-12 17:29:44 -0800 Comment on attachment 46413 Patch Clearing flags on attachment: 46413 Committed r53171: <http://trac.webkit.org/changeset/53171> 180052 4 commit-queue 2010-01-12 17:29:49 -0800 All reviewed patches have been landed. Closing bug. 46413 2010-01-12 16:46:48 -0800 2010-01-12 17:29:44 -0800 Patch bug-33560-20100112164647.patch text/plain 1339 tony ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Yzg5YWUwZC4uOGY4ZDEwZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wMS0xMiAgVG9ueSBDaGFuZyAg PHRvbnlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEZpeCBhbiBhc3NlcnQgYmVpbmcgdHJpZ2dlcmVkIGJ5IGhvdyB0aGUgQ2hy b21pdW0gcG9ydCBzZXRzIHRoZQorICAgICAgICByZXBsYWNpbmcgZmxhZyBmb3IgZXJyb3IgcGFn ZXMuICBUaGlzIHdhcyBjYXVzZWQgYnkgcjUzMTQzLgorCisgICAgICAgIENvdmVyZWQgYnkgZXhp c3RpbmcgQ2hyb21pdW0gVUkgdGVzdHMuCisKKyAgICAgICAgKiBsb2FkZXIvRnJhbWVMb2FkZXIu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXI6OmNoZWNrTG9hZENvbXBsZXRlRm9y VGhpc0ZyYW1lKToKKwogMjAxMC0wMS0xMiAgQnJpYW4gV2VpbnN0ZWluICA8YndlaW5zdGVpbkBh cHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2ZSBIeWF0dC4KZGlmZiAtLWdpdCBh L1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcCBiL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9h ZGVyLmNwcAppbmRleCAyNjgzMjA5Li4zMTRjYTMzIDEwMDY0NAotLS0gYS9XZWJDb3JlL2xvYWRl ci9GcmFtZUxvYWRlci5jcHAKKysrIGIvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCkBA IC0yOTIyLDcgKzI5MjIsOCBAQCB2b2lkIEZyYW1lTG9hZGVyOjpjaGVja0xvYWRDb21wbGV0ZUZv clRoaXNGcmFtZSgpCiAgICAgICAgICAgICAgICAgc3RvcExvYWRpbmdTdWJmcmFtZXMoKTsKICAg ICAgICAgICAgICAgICBwZGwtPnN0b3BMb2FkaW5nKCk7CiAKLSAgICAgICAgICAgICAgICBpZiAo aXNSZXBsYWNpbmcoKSkKKyAgICAgICAgICAgICAgICAvLyBJZiB3ZSdyZSBpbiB0aGUgbWlkZGxl IG9mIGxvYWRpbmcgbXVsdGlwYXJ0IGRhdGEsIHdlIG5lZWQgdG8gcmVzdG9yZSB0aGUgZG9jdW1l bnQgbG9hZGVyLgorICAgICAgICAgICAgICAgIGlmIChpc1JlcGxhY2luZygpICYmICFtX2RvY3Vt ZW50TG9hZGVyLmdldCgpKQogICAgICAgICAgICAgICAgICAgICBzZXREb2N1bWVudExvYWRlciht X3Byb3Zpc2lvbmFsRG9jdW1lbnRMb2FkZXIuZ2V0KCkpOwogCiAgICAgICAgICAgICAgICAgLy8g RmluaXNoIHJlc2V0dGluZyB0aGUgbG9hZCBzdGF0ZSwgYnV0IG9ubHkgaWYgYW5vdGhlciBsb2Fk IGhhc24ndCBiZWVuIHN0YXJ0ZWQgYnkgdGhlCg==