33532 2010-01-12 05:35:31 -0800 [GTK] un-needed seeks 2010-01-14 00:34:29 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned oldest_to_newest 179802 0 pnormand 2010-01-12 05:35:31 -0800 I found out that our player performs un-needed seeks: - seek(0): un-needed when currentTime is 0 already - setRate(1): un-needed at beginning of playback as it is already the default in playbin. 179804 1 46365 pnormand 2010-01-12 05:41:05 -0800 Created attachment 46365 avoid un-needed seeks 180301 2 46365 xan.lopez 2010-01-13 11:11:55 -0800 Comment on attachment 46365 avoid un-needed seeks lgtm 180587 3 pnormand 2010-01-14 00:34:29 -0800 Landed as r53244. Thanks! 46365 2010-01-12 05:41:05 -0800 2010-01-13 11:11:54 -0800 avoid un-needed seeks avoid-un-needed-seeks.patch text/plain 3579 pnormand RnJvbSAxNmFhMDc0Nzg1NjU1ZTUxZWM5YjhmNjc1ZjQ5MTZhN2YxY2MxNDFkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUdWUsIDEyIEphbiAyMDEwIDEyOjQ1OjM5ICswMTAwClN1YmplY3Q6IFtQQVRDSF0g YXZvaWQgdW4tbmVlZGVkIHNlZWtzCgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIHwgICAxNiArKysrKysrKysrKysrKysrCiAuLi4vZ3JhcGhp Y3MvZ3RrL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAgICB8ICAgMTEgKysrKysrKysr Ky0KIC4uLi9ncmFwaGljcy9ndGsvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmggICAgIHwg ICAgMSArCiAzIGZpbGVzIGNoYW5nZWQsIDI3IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0p CgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRl eCBjOGJiYjgwLi45NDI1NTY5IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9X ZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEwLTAxLTEyICBQaGlsaXBwZSBO b3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBbR1RLXSB1bi1uZWVkZWQgc2Vla3MKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMzNTMyCisKKyAgICAgICAgQXZv aWQgdW4tbmVlZGVkIHNlZWtzLiBEb24ndCBzZWVrIGF0IGN1cnJlbnQgcGxheWJhY2sgcG9zaXRp b24gYW5kCisgICAgICAgIGRvbid0IHVwZGF0ZSB0aGUgcmF0ZSBpZiBpdCBpcyBhbHJlYWR5IHNl dCB0byB0YXJnZXQgdmFsdWUuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9ndGsvTWVk aWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxh eWVyUHJpdmF0ZTo6TWVkaWFQbGF5ZXJQcml2YXRlKToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlh UGxheWVyUHJpdmF0ZTo6c2Vlayk6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZh dGU6OnNldFJhdGUpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2d0ay9NZWRpYVBsYXll clByaXZhdGVHU3RyZWFtZXIuaDoKKwogMjAxMC0wMS0xMiAgQmVuIE11cmRvY2ggIDxiZW5tQGdv b2dsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQg YS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFt ZXIuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ndGsvTWVkaWFQbGF5ZXJQcml2YXRl R1N0cmVhbWVyLmNwcAppbmRleCAwOTg0YTQ2Li40YmNmYjY5IDEwMDY0NAotLS0gYS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCisr KyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJl YW1lci5jcHAKQEAgLTIwOSw2ICsyMDksNyBAQCBNZWRpYVBsYXllclByaXZhdGU6Ok1lZGlhUGxh eWVyUHJpdmF0ZShNZWRpYVBsYXllciogcGxheWVyKQogICAgICwgbV9idWZmZXIoMCkKICAgICAs IG1fcGF1c2VkKHRydWUpCiAgICAgLCBtX3NlZWtpbmcoZmFsc2UpCisgICAgLCBtX3BsYXliYWNr UmF0ZSgxKQogICAgICwgbV9lcnJvck9jY3VyZWQoZmFsc2UpCiAgICAgLCBtX3ZvbHVtZUlkbGVJ ZCgtMSkKIHsKQEAgLTMyMSw3ICszMjIsOSBAQCBmbG9hdCBNZWRpYVBsYXllclByaXZhdGU6OmN1 cnJlbnRUaW1lKCkgY29uc3QKIAogdm9pZCBNZWRpYVBsYXllclByaXZhdGU6OnNlZWsoZmxvYXQg dGltZSkKIHsKLSAgICBHc3RDbG9ja1RpbWUgc2VjID0gKEdzdENsb2NrVGltZSkodGltZSAqIEdT VF9TRUNPTkQpOworICAgIC8vIEF2b2lkIHVzZWxlc3Mgc2Vla2luZy4KKyAgICBpZiAodGltZSA9 PSBwbGF5YmFja1Bvc2l0aW9uKG1fcGxheUJpbikpCisgICAgICAgIHJldHVybjsKIAogICAgIGlm ICghbV9wbGF5QmluKQogICAgICAgICByZXR1cm47CkBAIC0zMzIsNiArMzM1LDcgQEAgdm9pZCBN ZWRpYVBsYXllclByaXZhdGU6OnNlZWsoZmxvYXQgdGltZSkKICAgICBpZiAobV9lcnJvck9jY3Vy ZWQpCiAgICAgICAgIHJldHVybjsKIAorICAgIEdzdENsb2NrVGltZSBzZWMgPSAoR3N0Q2xvY2tU aW1lKSh0aW1lICogR1NUX1NFQ09ORCk7CiAgICAgTE9HX1ZFUkJPU0UoTWVkaWEsICJTZWVrOiAl IiBHU1RfVElNRV9GT1JNQVQsIEdTVF9USU1FX0FSR1Moc2VjKSk7CiAgICAgaWYgKCFnc3RfZWxl bWVudF9zZWVrKG1fcGxheUJpbiwgbV9wbGF5ZXItPnJhdGUoKSwKICAgICAgICAgICAgIEdTVF9G T1JNQVRfVElNRSwKQEAgLTQ0NCw2ICs0NDgsMTAgQEAgdm9pZCBNZWRpYVBsYXllclByaXZhdGU6 OnZvbHVtZUNoYW5nZWQoKQogCiB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZTo6c2V0UmF0ZShmbG9h dCByYXRlKQogeworICAgIC8vIEF2b2lkIHVzZWxlc3MgcGxheWJhY2sgcmF0ZSB1cGRhdGUuCisg ICAgaWYgKG1fcGxheWJhY2tSYXRlID09IHJhdGUpCisgICAgICAgIHJldHVybjsKKwogICAgIEdz dFN0YXRlIHN0YXRlOwogICAgIEdzdFN0YXRlIHBlbmRpbmc7CiAKQEAgLTQ1NSw2ICs0NjMsNyBA QCB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZTo6c2V0UmF0ZShmbG9hdCByYXRlKQogICAgIGlmICht X2lzU3RyZWFtaW5nKQogICAgICAgICByZXR1cm47CiAKKyAgICBtX3BsYXliYWNrUmF0ZSA9IHJh dGU7CiAgICAgbV9jaGFuZ2luZ1JhdGUgPSB0cnVlOwogICAgIGZsb2F0IGN1cnJlbnRQb3NpdGlv biA9IHBsYXliYWNrUG9zaXRpb24obV9wbGF5QmluKSAqIEdTVF9TRUNPTkQ7CiAgICAgR3N0U2Vl a0ZsYWdzIGZsYWdzID0gKEdzdFNlZWtGbGFncykoR1NUX1NFRUtfRkxBR19GTFVTSCk7CmRpZmYg LS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9NZWRpYVBsYXllclByaXZhdGVH U3RyZWFtZXIuaCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL01lZGlhUGxheWVyUHJp dmF0ZUdTdHJlYW1lci5oCmluZGV4IDQ3MTc5OTkuLjkxN2MyNTMgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5oCisr KyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJl YW1lci5oCkBAIC0xNDAsNiArMTQwLDcgQEAgY2xhc3MgTWVkaWFQbGF5ZXJQcml2YXRlIDogcHVi bGljIE1lZGlhUGxheWVyUHJpdmF0ZUludGVyZmFjZSB7CiAKICAgICAgICAgICAgIGJvb2wgbV9w YXVzZWQ7CiAgICAgICAgICAgICBib29sIG1fc2Vla2luZzsKKyAgICAgICAgICAgIGZsb2F0IG1f cGxheWJhY2tSYXRlOwogICAgICAgICAgICAgYm9vbCBtX2Vycm9yT2NjdXJlZDsKICAgICAgICAg ICAgIGd1aW50IG1fdm9sdW1lSWRsZUlkOwogICAgIH07Ci0tIAoxLjYuMy4z