33525 2010-01-12 01:48:12 -0800 Remove copy/paste code from subclasses of AbstractReviewQueue 2010-01-12 01:50:23 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth webkit-unassigned oldest_to_newest 179736 0 abarth 2010-01-12 01:48:12 -0800 Remove copy/paste code from subclasses of AbstractReviewQueue 179737 1 46351 abarth 2010-01-12 01:48:36 -0800 Created attachment 46351 Patch 179738 2 46351 eric 2010-01-12 01:49:46 -0800 Comment on attachment 46351 Patch OK. 179739 3 abarth 2010-01-12 01:50:23 -0800 Committed r53123: <http://trac.webkit.org/changeset/53123> 46351 2010-01-12 01:48:36 -0800 2010-01-12 01:49:46 -0800 Patch bug-33525-20100112014835.patch text/plain 3811 abarth ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA1MDJiNWE5Li4yMzAzZWFiIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTUgQEAKIDIwMTAtMDEt MTIgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAorICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgY29weS9wYXN0ZSBjb2RlIGZyb20g c3ViY2xhc3NlcyBvZiBBYnN0cmFjdFJldmlld1F1ZXVlCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzUyNQorCisgICAgICAgICogU2NyaXB0cy93ZWJr aXRweS9jb21tYW5kcy9lYXJseV93YXJuaW5nX3N5c3RlbS5weToKKyAgICAgICAgKiBTY3JpcHRz L3dlYmtpdHB5L2NvbW1hbmRzL3F1ZXVlcy5weToKKworMjAxMC0wMS0xMiAgQWRhbSBCYXJ0aCAg PGFiYXJ0aEB3ZWJraXQub3JnPgorCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgog CiAgICAgICAgIEFkZCBHdXN0YXZvIGFuZCBYYW4gYXMgZ3RrLWV3cyB3YXRjaGVycwpkaWZmIC0t Z2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tYW5kcy9lYXJseV93YXJuaW5n X3N5c3RlbS5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbWFuZHMvZWFybHlf d2FybmluZ19zeXN0ZW0ucHkKaW5kZXggMDI2YjU3Ny4uZWIyMjUzMyAxMDA2NDQKLS0tIGEvV2Vi S2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tYW5kcy9lYXJseV93YXJuaW5nX3N5c3RlbS5w eQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1hbmRzL2Vhcmx5X3dhcm5p bmdfc3lzdGVtLnB5CkBAIC00OSwyMSArNDksMTYgQEAgY2xhc3MgQWJzdHJhY3RFYXJseVdhcm5p bmdTeXN0ZW0oQWJzdHJhY3RSZXZpZXdRdWV1ZSk6CiAgICAgICAgICAgICByZXR1cm4gRmFsc2UK ICAgICAgICAgcmV0dXJuIFRydWUKIAotICAgIGRlZiBwcm9jZXNzX3dvcmtfaXRlbShzZWxmLCBw YXRjaCk6Ci0gICAgICAgIHRyeToKLSAgICAgICAgICAgIHNlbGYucnVuX3dlYmtpdF9wYXRjaChb Ci0gICAgICAgICAgICAgICAgImJ1aWxkLWF0dGFjaG1lbnQiLAotICAgICAgICAgICAgICAgIHNl bGYucG9ydC5mbGFnKCksCi0gICAgICAgICAgICAgICAgIi0tZm9yY2UtY2xlYW4iLAotICAgICAg ICAgICAgICAgICItLXF1aWV0IiwKLSAgICAgICAgICAgICAgICAiLS1ub24taW50ZXJhY3RpdmUi LAotICAgICAgICAgICAgICAgICItLXBhcmVudC1jb21tYW5kPSVzIiAlIHNlbGYubmFtZSwKLSAg ICAgICAgICAgICAgICAiLS1uby11cGRhdGUiLAotICAgICAgICAgICAgICAgIHBhdGNoWyJpZCJd XSkKLSAgICAgICAgICAgIHNlbGYuX2RpZF9wYXNzKHBhdGNoKQotICAgICAgICBleGNlcHQgU2Ny aXB0RXJyb3IsIGU6Ci0gICAgICAgICAgICBzZWxmLl9kaWRfZmFpbChwYXRjaCkKLSAgICAgICAg ICAgIHJhaXNlIGUKKyAgICBkZWYgX3Jldmlld19wYXRjaChzZWxmLCBwYXRjaCk6CisgICAgICAg IHNlbGYucnVuX3dlYmtpdF9wYXRjaChbCisgICAgICAgICAgICAiYnVpbGQtYXR0YWNobWVudCIs CisgICAgICAgICAgICBzZWxmLnBvcnQuZmxhZygpLAorICAgICAgICAgICAgIi0tZm9yY2UtY2xl YW4iLAorICAgICAgICAgICAgIi0tcXVpZXQiLAorICAgICAgICAgICAgIi0tbm9uLWludGVyYWN0 aXZlIiwKKyAgICAgICAgICAgICItLXBhcmVudC1jb21tYW5kPSVzIiAlIHNlbGYubmFtZSwKKyAg ICAgICAgICAgICItLW5vLXVwZGF0ZSIsCisgICAgICAgICAgICBwYXRjaFsiaWQiXV0pCiAKICAg ICBAY2xhc3NtZXRob2QKICAgICBkZWYgaGFuZGxlX3NjcmlwdF9lcnJvcihjbHMsIHRvb2wsIHN0 YXRlLCBzY3JpcHRfZXJyb3IpOgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJr aXRweS9jb21tYW5kcy9xdWV1ZXMucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2Nv bW1hbmRzL3F1ZXVlcy5weQppbmRleCA2NGMxM2M5Li5jMmJkZDM2IDEwMDY0NAotLS0gYS9XZWJL aXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1hbmRzL3F1ZXVlcy5weQorKysgYi9XZWJLaXRU b29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1hbmRzL3F1ZXVlcy5weQpAQCAtMjA3LDYgKzIwNyw5 IEBAIGNsYXNzIEFic3RyYWN0UmV2aWV3UXVldWUoQWJzdHJhY3RRdWV1ZSwgUGVyc2lzdGVudFBh dGNoQ29sbGVjdGlvbkRlbGVnYXRlLCBTdGVwCiAgICAgZGVmIF9faW5pdF9fKHNlbGYsIG9wdGlv bnM9Tm9uZSk6CiAgICAgICAgIEFic3RyYWN0UXVldWUuX19pbml0X18oc2VsZiwgb3B0aW9ucykK IAorICAgIGRlZiBfcmV2aWV3X3BhdGNoKHNlbGYsIHBhdGNoKToKKyAgICAgICAgcmFpc2UgTm90 SW1wbGVtZW50ZWRFcnJvciwgInN1YmNsYXNzZXMgbXVzdCBpbXBsZW1lbnQiCisKICAgICAjIFBl cnNpc3RlbnRQYXRjaENvbGxlY3Rpb25EZWxlZ2F0ZSBtZXRob2RzCiAKICAgICBkZWYgY29sbGVj dGlvbl9uYW1lKHNlbGYpOgpAQCAtMjM0LDcgKzIzNywxMiBAQCBjbGFzcyBBYnN0cmFjdFJldmll d1F1ZXVlKEFic3RyYWN0UXVldWUsIFBlcnNpc3RlbnRQYXRjaENvbGxlY3Rpb25EZWxlZ2F0ZSwg U3RlcAogICAgICAgICByYWlzZSBOb3RJbXBsZW1lbnRlZEVycm9yLCAic3ViY2xhc3NlcyBtdXN0 IGltcGxlbWVudCIKIAogICAgIGRlZiBwcm9jZXNzX3dvcmtfaXRlbShzZWxmLCBwYXRjaCk6Ci0g ICAgICAgIHJhaXNlIE5vdEltcGxlbWVudGVkRXJyb3IsICJzdWJjbGFzc2VzIG11c3QgaW1wbGVt ZW50IgorICAgICAgICB0cnk6CisgICAgICAgICAgICBzZWxmLl9yZXZpZXdfcGF0Y2gocGF0Y2gp CisgICAgICAgICAgICBzZWxmLl9kaWRfcGFzcyhwYXRjaCkKKyAgICAgICAgZXhjZXB0IFNjcmlw dEVycm9yLCBlOgorICAgICAgICAgICAgc2VsZi5fZGlkX2ZhaWwocGF0Y2gpCisgICAgICAgICAg ICByYWlzZSBlCiAKICAgICBkZWYgaGFuZGxlX3VuZXhwZWN0ZWRfZXJyb3Ioc2VsZiwgcGF0Y2gs IG1lc3NhZ2UpOgogICAgICAgICBsb2cobWVzc2FnZSkKQEAgLTI1NSwxMyArMjYzLDggQEAgY2xh c3MgU3R5bGVRdWV1ZShBYnN0cmFjdFJldmlld1F1ZXVlKToKICAgICAgICAgc2VsZi5fdXBkYXRl X3N0YXR1cygiQ2hlY2tpbmcgc3R5bGUiLCBwYXRjaCkKICAgICAgICAgcmV0dXJuIFRydWUKIAot ICAgIGRlZiBwcm9jZXNzX3dvcmtfaXRlbShzZWxmLCBwYXRjaCk6Ci0gICAgICAgIHRyeToKLSAg ICAgICAgICAgIHNlbGYucnVuX3dlYmtpdF9wYXRjaChbImNoZWNrLXN0eWxlIiwgIi0tZm9yY2Ut Y2xlYW4iLCAiLS1ub24taW50ZXJhY3RpdmUiLCAiLS1wYXJlbnQtY29tbWFuZD1zdHlsZS1xdWV1 ZSIsIHBhdGNoWyJpZCJdXSkKLSAgICAgICAgICAgIHNlbGYuX2RpZF9wYXNzKHBhdGNoKQotICAg ICAgICBleGNlcHQgU2NyaXB0RXJyb3IsIGU6Ci0gICAgICAgICAgICBzZWxmLl9kaWRfZmFpbChw YXRjaCkKLSAgICAgICAgICAgIHJhaXNlIGUKKyAgICBkZWYgX3Jldmlld19wYXRjaChzZWxmLCBw YXRjaCk6CisgICAgICAgIHNlbGYucnVuX3dlYmtpdF9wYXRjaChbImNoZWNrLXN0eWxlIiwgIi0t Zm9yY2UtY2xlYW4iLCAiLS1ub24taW50ZXJhY3RpdmUiLCAiLS1wYXJlbnQtY29tbWFuZD1zdHls ZS1xdWV1ZSIsIHBhdGNoWyJpZCJdXSkKIAogICAgIEBjbGFzc21ldGhvZAogICAgIGRlZiBoYW5k bGVfc2NyaXB0X2Vycm9yKGNscywgdG9vbCwgc3RhdGUsIHNjcmlwdF9lcnJvcik6Cg==