33521 2010-01-11 23:38:19 -0800 webkit-patch shouldn't waste my time for with a component prompt 2010-01-15 13:15:41 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth webkit-unassigned ddkilzer eric mjs oldest_to_newest 179696 0 abarth 2010-01-11 23:38:19 -0800 webkit-patch shouldn't waste my time for with a component prompt 179698 1 46339 abarth 2010-01-11 23:39:51 -0800 Created attachment 46339 Patch 179699 2 46339 eric 2010-01-11 23:41:08 -0800 Comment on attachment 46339 Patch LGTM. 179730 3 46339 abarth 2010-01-12 01:41:45 -0800 Comment on attachment 46339 Patch Clearing flags on attachment: 46339 Committed r53121: <http://trac.webkit.org/changeset/53121> 179731 4 abarth 2010-01-12 01:41:51 -0800 All reviewed patches have been landed. Closing bug. 181324 5 ddkilzer 2010-01-15 12:41:41 -0800 This change in behavior will make it harder to find bugs by component in the future. Is there still a way to get the component prompted for if you want to fill it out? 181345 6 abarth 2010-01-15 13:15:41 -0800 > Is there still a way to get the component prompted for if you want to fill it > out? You can specify it on the command line using the --component flag. If you'd like it to prompt you, can can pass --component=prompt (or actually any bogus value). 46339 2010-01-11 23:39:51 -0800 2010-01-12 01:41:45 -0800 Patch bug-33521-20100111233949.patch text/plain 1656 abarth ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA3ZTkyNGMyLi5hYzI2MGY5IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMDEt MTEgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICB3ZWJraXQtcGF0Y2ggc2hvdWxkbid0IHdhc3Rl IG15IHRpbWUgZm9yIHdpdGggYSBjb21wb25lbnQgcHJvbXB0CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzUyMQorCisgICAgICAgIFRoZSBjb21wb25l bnQgZmllbGQgaXNuJ3QgdmVyeSB1c2VmdWwgZm9yIGJ1Z3MgY3JlYXRlZCB3aXRoCisgICAgICAg IHdlYmtpdC1wYXRjaCBiZWNhdXNlIHRoZXkncmUgbGlrZWx5IHRvIGJlIHJlc29sdmVkIHF1aWNr bHkuICBJbnN0ZWFkIG9mCisgICAgICAgIGFsd2F5cyBwcm9tcHRpbmcgZm9yIGEgY29tcG9uZW50 LCB3ZSBzaG91bGQganVzdCBkZWZhdWx0IHRvIHRoZSAiTmV3CisgICAgICAgIEJ1Z3MiIGNvbXBv bmVudC4gIElmIHRoZSBidWcgc3RheXMgYXJvdW5kIGZvciBtb3JlIHRoYW4gZml2ZSBtaW51dGVz LAorICAgICAgICB3ZSBjYW4gYXNzaWduIGl0IGEgcHJvcGVyIGNvbXBvbmVudC4KKworICAgICAg ICAqIFNjcmlwdHMvd2Via2l0cHkvYnVnemlsbGEucHk6CisKIDIwMTAtMDEtMTEgIEtldmluIE9s bGl2aWVyICA8a2V2aW5vQHRoZW9sbGl2aWVycy5jb20+CiAKICAgICAgICAgW3d4XSBCdWlsZCBm aXggYWZ0ZXIgaW50cm9kdWN0aW9uIG9mIEpTX05PX0VYUE9SVApkaWZmIC0tZ2l0IGEvV2ViS2l0 VG9vbHMvU2NyaXB0cy93ZWJraXRweS9idWd6aWxsYS5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMv d2Via2l0cHkvYnVnemlsbGEucHkKaW5kZXggNzdlYjVlNS4uYjkxMWEwNCAxMDA2NDQKLS0tIGEv V2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9idWd6aWxsYS5weQorKysgYi9XZWJLaXRUb29s cy9TY3JpcHRzL3dlYmtpdHB5L2J1Z3ppbGxhLnB5CkBAIC0zOTksNyArMzk5LDkgQEAgY2xhc3Mg QnVnemlsbGEob2JqZWN0KToKICAgICAgICAgc2VsZi5icm93c2VyLnNlbGVjdF9mb3JtKG5hbWU9 IkNyZWF0ZSIpCiAgICAgICAgIGNvbXBvbmVudF9pdGVtcyA9IHNlbGYuYnJvd3Nlci5maW5kX2Nv bnRyb2woJ2NvbXBvbmVudCcpLml0ZW1zCiAgICAgICAgIGNvbXBvbmVudF9uYW1lcyA9IG1hcChs YW1iZGEgaXRlbTogaXRlbS5uYW1lLCBjb21wb25lbnRfaXRlbXMpCi0gICAgICAgIGlmIG5vdCBj b21wb25lbnQgb3IgY29tcG9uZW50IG5vdCBpbiBjb21wb25lbnRfbmFtZXM6CisgICAgICAgIGlm IG5vdCBjb21wb25lbnQ6CisgICAgICAgICAgICBjb21wb25lbnQgPSAiTmV3IEJ1Z3MiCisgICAg ICAgIGlmIGNvbXBvbmVudCBub3QgaW4gY29tcG9uZW50X25hbWVzOgogICAgICAgICAgICAgY29t cG9uZW50ID0gc2VsZi5wcm9tcHRfZm9yX2NvbXBvbmVudChjb21wb25lbnRfbmFtZXMpCiAgICAg ICAgIHNlbGYuYnJvd3NlclsnY29tcG9uZW50J10gPSBbY29tcG9uZW50XQogICAgICAgICBpZiBj YzoK