33499 2010-01-11 16:10:24 -0800 [Chromium] Need to clear accepted index on abandon if user accepts the selected index 2010-01-11 17:22:59 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 victorw webkit-unassigned commit-queue dglazkov oldest_to_newest 179596 0 victorw 2010-01-11 16:10:24 -0800 This is for chromium only. Regression from http://trac.webkit.org/changeset/52001 If user accepts an item from dropdown list, m_acceptedIndexOnAbandon is not cleared and the dropdown will crash if it is destroyed. This is To repro: 1) http://code.google.com/p/chromium/issues/entry 2) Select the "template" drop-down 3) Hit B, Hit <enter> 4) Boom 179607 1 46318 victorw 2010-01-11 16:23:57 -0800 Created attachment 46318 proposed patch 179608 2 46318 dglazkov 2010-01-11 16:32:10 -0800 Comment on attachment 46318 proposed patch r=me. 179612 3 46318 dglazkov 2010-01-11 16:47:01 -0800 Comment on attachment 46318 proposed patch cq, take it away. 179632 4 46318 commit-queue 2010-01-11 17:22:54 -0800 Comment on attachment 46318 proposed patch Clearing flags on attachment: 46318 Committed r53113: <http://trac.webkit.org/changeset/53113> 179633 5 commit-queue 2010-01-11 17:22:59 -0800 All reviewed patches have been landed. Closing bug. 46318 2010-01-11 16:23:57 -0800 2010-01-11 17:22:53 -0800 proposed patch clear_select.patch text/plain 1424 victorw SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MzEwOSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMDEtMTEgIFZpY3RvciBXYW5nICA8dmljdG9yd0BjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Q2xlYXIgbV9hY2NlcHRlZEluZGV4T25BYmFuZG9uIGZsYWcgd2hlbiB1c2VyIGFjY2VwdHMgdGhl IHNlbGVjdGVkIGluZGV4LgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0zMzQ5OQorCisgICAgICAgIFRFU1Q6IG1hbnVhbC10ZXN0cy9jaHJvbWl1bS9v bmNoYW5nZS1yZWxvYWQtcG9wdXAuaHRtbAorICAgICAgICBJdCBzaG91bGQgYmUgY292ZXJlZCBi eSB0aGUgYWJvdmUgdGVzdC4gVGhlIGN1cnJlbnQKKyAgICAgICAgdGVzdCBzaGVsbCBkb2VzIG5v dCBzdXBwb3J0IHNlbmRpbmcga2V5Ym9hcmQgZXZlbnRzIHRvIHBvcHVwCisgICAgICAgIGxpc3Qg c28gdXNlIG1hbnVhbCB0ZXN0IGZvciBpdC4KKworICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVt L1BvcHVwTWVudUNocm9taXVtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBvcHVwTGlzdEJveDo6 YWNjZXB0SW5kZXgpOgorCiAyMDEwLTAxLTExICBBbmRyZWFzIEtsaW5nICA8YW5kcmVhcy5rbGlu Z0Bub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBX ZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVtLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9taXVtLmNwcAkocmV2 aXNpb24gNTMxMDIpCisrKyBXZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1BvcHVwTWVudUNocm9t aXVtLmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTExLDYgKzkxMSwxMCBAQCBpbnQgUG9wdXBMaXN0 Qm94Ojpwb2ludFRvUm93SW5kZXgoY29uc3QgCiAKIHZvaWQgUG9wdXBMaXN0Qm94OjphY2NlcHRJ bmRleChpbnQgaW5kZXgpCiB7CisgICAgLy8gQ2xlYXIgbV9hY2NlcHRlZEluZGV4T25BYmFuZG9u IG9uY2UgdXNlciBhY2NlcHRzIHRoZSBzZWxlY3RlZCBpbmRleC4KKyAgICBpZiAobV9hY2NlcHRl ZEluZGV4T25BYmFuZG9uID49IDApCisgICAgICAgIG1fYWNjZXB0ZWRJbmRleE9uQWJhbmRvbiA9 IC0xOworCiAgICAgaWYgKGluZGV4ID49IG51bUl0ZW1zKCkpCiAgICAgICAgIHJldHVybjsKIAo=