33468 2010-01-11 07:42:40 -0800 PluginView::m_mode not initialized when constructed with null PluginPackage 2010-02-01 10:32:48 -0800 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 kling webkit-unassigned adele commit-queue webkit oldest_to_newest 179358 0 46275 kling 2010-01-11 07:42:40 -0800 Created attachment 46275 Proposed patch Valgrind complains like so: ==19266== Conditional jump or move depends on uninitialised value(s) ==19266== at 0x6BFD294: WebCore::PluginView::setFrameRect(WebCore::IntRect const&) (PluginView.cpp:133) ==19266== by 0x6D13EA5: WebCore::RenderWidget::setWidgetGeometry(WebCore::IntRect const&) (RenderWidget.cpp:159) ==19266== by 0x6D14DFC: WebCore::RenderWidget::updateWidgetPosition() (RenderWidget.cpp:308) ==19266== by 0x6D0B4FF: WebCore::RenderView::updateWidgetPositions() (RenderView.cpp:543) ==19266== by 0x6B1E6F3: WebCore::FrameView::performPostLayoutTasks() (FrameView.cpp:1380) ==19266== by 0x6B1C05E: WebCore::FrameView::layout(bool) (FrameView.cpp:732) ==19266== by 0x6B1D21A: WebCore::FrameView::visibleContentsResized() (FrameView.cpp:1010) ==19266== by 0x6BC6D06: WebCore::ScrollView::updateScrollbars(WebCore::IntSize const&) (ScrollView.cpp:403) ==19266== by 0x6BC6347: WebCore::ScrollView::setContentsSize(WebCore::IntSize const&) (ScrollView.cpp:239) ==19266== by 0x6B1B0CF: WebCore::FrameView::setContentsSize(WebCore::IntSize const&) (FrameView.cpp:372) ==19266== by 0x6B1B244: WebCore::FrameView::adjustViewSize() (FrameView.cpp:392) ==19266== by 0x6B1BEE7: WebCore::FrameView::layout(bool) (FrameView.cpp:698) For something like: <object type="application/some-invalid-type"></object> 179360 1 46276 kling 2010-01-11 07:48:57 -0800 Created attachment 46276 Proposed patch with bug ID in ChangeLog 179370 2 46276 darin 2010-01-11 08:20:53 -0800 Comment on attachment 46276 Proposed patch with bug ID in ChangeLog If we're fixing this, why not use member construction syntax instead of assignment? 179380 3 46280 kling 2010-01-11 08:46:57 -0800 Created attachment 46280 Same thing, but using member construction syntax Good point. 179381 4 46281 kling 2010-01-11 08:49:35 -0800 Created attachment 46281 Same thing yet again, but not adding a new bug.. 179395 5 46281 darin 2010-01-11 09:35:06 -0800 Comment on attachment 46281 Same thing yet again, but not adding a new bug.. Another way to fix this is to get rid of m_mode and replace it with a function. The value of m_mode never changes and so is always based on m_loadManually and is used in only 3 places in the tree. I'm especially mystified by the code in Qt's PluginView::setNPWindowIfNeeded that checks for m_mode values other than NP_EMBED and NP_FULL. Seems clearly to be dead code. 179594 6 46281 commit-queue 2010-01-11 16:10:05 -0800 Comment on attachment 46281 Same thing yet again, but not adding a new bug.. Clearing flags on attachment: 46281 Committed r53109: <http://trac.webkit.org/changeset/53109> 179595 7 commit-queue 2010-01-11 16:10:09 -0800 All reviewed patches have been landed. Closing bug. 182079 8 adele 2010-01-18 18:07:13 -0800 This change caused the following bug: REGRESSION (r53109): Find My iPhone message dialog is offset from original position once it gets focus https://bugs.webkit.org/show_bug.cgi?id=33821 182317 9 adele 2010-01-19 10:49:20 -0800 Please ignore my last comment. There was an error in my testing. 186479 10 kling 2010-02-01 10:32:48 -0800 *** Bug 25933 has been marked as a duplicate of this bug. *** 46275 2010-01-11 07:42:40 -0800 2010-01-11 07:48:57 -0800 Proposed patch bug-XXXXX.diff text/plain 1270 kling ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZDU1NjBkMC4uZTMyZDM0OSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wMS0xMSAgQW5kcmVhcyBLbGlu ZyAgPGFuZHJlYXMua2xpbmdAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEZpeGVkIGFuIHVuaW5pdGlhbGl6ZWQgUGx1Z2luVmlldyBt ZW1iZXIgKG1fbW9kZSkgd2hpY2ggd2Fzbid0CisgICAgICAgIHNldCB3aGVuIGNvbnN0cnVjdGVk IHdpdGggYSBudWxsIFBsdWdpblBhY2thZ2UqCisKKyAgICAgICAgKiBwbHVnaW5zL1BsdWdpblZp ZXcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGx1Z2luVmlldzo6UGx1Z2luVmlldyk6CisKIDIw MTAtMDEtMTEgIEpvYW5tYXJpZSBEaWdncyAgPGpvYW5tYXJpZS5kaWdnc0BnbWFpbC5jb20+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgWGFuIExvcGV6LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbHVn aW5zL1BsdWdpblZpZXcuY3BwIGIvV2ViQ29yZS9wbHVnaW5zL1BsdWdpblZpZXcuY3BwCmluZGV4 IGU3OWViODguLjllYTU2NzYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5WaWV3 LmNwcAorKysgYi9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luVmlldy5jcHAKQEAgLTgzMiw2ICs4MzIs OCBAQCBQbHVnaW5WaWV3OjpQbHVnaW5WaWV3KEZyYW1lKiBwYXJlbnRGcmFtZSwgY29uc3QgSW50 U2l6ZSYgc2l6ZSwgUGx1Z2luUGFja2FnZSogcAogICAgICwgbV9pc0hhbHRlZChmYWxzZSkKICAg ICAsIG1faGFzQmVlbkhhbHRlZChmYWxzZSkKIHsKKyAgICBtX21vZGUgPSBtX2xvYWRNYW51YWxs eSA/IE5QX0ZVTEwgOiBOUF9FTUJFRDsKKwogICAgIGlmICghbV9wbHVnaW4pIHsKICAgICAgICAg bV9zdGF0dXMgPSBQbHVnaW5TdGF0dXNDYW5Ob3RGaW5kUGx1Z2luOwogICAgICAgICByZXR1cm47 CkBAIC04NDgsOCArODUwLDYgQEAgUGx1Z2luVmlldzo6UGx1Z2luVmlldyhGcmFtZSogcGFyZW50 RnJhbWUsIGNvbnN0IEludFNpemUmIHNpemUsIFBsdWdpblBhY2thZ2UqIHAKICAgICBtZW1zZXQo Jm1fbnBDZ0NvbnRleHQsIDAsIHNpemVvZihtX25wQ2dDb250ZXh0KSk7CiAjZW5kaWYKIAotICAg IG1fbW9kZSA9IG1fbG9hZE1hbnVhbGx5ID8gTlBfRlVMTCA6IE5QX0VNQkVEOwotCiAgICAgcmVz aXplKHNpemUpOwogfQogCg== 46276 2010-01-11 07:48:57 -0800 2010-01-11 08:46:57 -0800 Proposed patch with bug ID in ChangeLog bug-33468.diff text/plain 1327 kling ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZDU1NjBkMC4uMjk5NTFjMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wMS0xMSAgQW5kcmVhcyBLbGlu ZyAgPGFuZHJlYXMua2xpbmdAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEZpeGVkIGFuIHVuaW5pdGlhbGl6ZWQgUGx1Z2luVmlldyBt ZW1iZXIgKG1fbW9kZSkgd2hpY2ggd2Fzbid0CisgICAgICAgIHNldCB3aGVuIGNvbnN0cnVjdGVk IHdpdGggYSBudWxsIFBsdWdpblBhY2thZ2UqCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTMzNDY4CisKKyAgICAgICAgKiBwbHVnaW5zL1BsdWdpblZp ZXcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGx1Z2luVmlldzo6UGx1Z2luVmlldyk6CisKIDIw MTAtMDEtMTEgIEpvYW5tYXJpZSBEaWdncyAgPGpvYW5tYXJpZS5kaWdnc0BnbWFpbC5jb20+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgWGFuIExvcGV6LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbHVn aW5zL1BsdWdpblZpZXcuY3BwIGIvV2ViQ29yZS9wbHVnaW5zL1BsdWdpblZpZXcuY3BwCmluZGV4 IGU3OWViODguLjllYTU2NzYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5WaWV3 LmNwcAorKysgYi9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luVmlldy5jcHAKQEAgLTgzMiw2ICs4MzIs OCBAQCBQbHVnaW5WaWV3OjpQbHVnaW5WaWV3KEZyYW1lKiBwYXJlbnRGcmFtZSwgY29uc3QgSW50 U2l6ZSYgc2l6ZSwgUGx1Z2luUGFja2FnZSogcAogICAgICwgbV9pc0hhbHRlZChmYWxzZSkKICAg ICAsIG1faGFzQmVlbkhhbHRlZChmYWxzZSkKIHsKKyAgICBtX21vZGUgPSBtX2xvYWRNYW51YWxs eSA/IE5QX0ZVTEwgOiBOUF9FTUJFRDsKKwogICAgIGlmICghbV9wbHVnaW4pIHsKICAgICAgICAg bV9zdGF0dXMgPSBQbHVnaW5TdGF0dXNDYW5Ob3RGaW5kUGx1Z2luOwogICAgICAgICByZXR1cm47 CkBAIC04NDgsOCArODUwLDYgQEAgUGx1Z2luVmlldzo6UGx1Z2luVmlldyhGcmFtZSogcGFyZW50 RnJhbWUsIGNvbnN0IEludFNpemUmIHNpemUsIFBsdWdpblBhY2thZ2UqIHAKICAgICBtZW1zZXQo Jm1fbnBDZ0NvbnRleHQsIDAsIHNpemVvZihtX25wQ2dDb250ZXh0KSk7CiAjZW5kaWYKIAotICAg IG1fbW9kZSA9IG1fbG9hZE1hbnVhbGx5ID8gTlBfRlVMTCA6IE5QX0VNQkVEOwotCiAgICAgcmVz aXplKHNpemUpOwogfQogCg== 46280 2010-01-11 08:46:57 -0800 2010-01-11 08:49:35 -0800 Same thing, but using member construction syntax bug-33468.diff text/plain 1453 kling ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZDU1NjBkMC4uMjk5NTFjMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wMS0xMSAgQW5kcmVhcyBLbGlu ZyAgPGFuZHJlYXMua2xpbmdAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEZpeGVkIGFuIHVuaW5pdGlhbGl6ZWQgUGx1Z2luVmlldyBt ZW1iZXIgKG1fbW9kZSkgd2hpY2ggd2Fzbid0CisgICAgICAgIHNldCB3aGVuIGNvbnN0cnVjdGVk IHdpdGggYSBudWxsIFBsdWdpblBhY2thZ2UqCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTMzNDY4CisKKyAgICAgICAgKiBwbHVnaW5zL1BsdWdpblZp ZXcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGx1Z2luVmlldzo6UGx1Z2luVmlldyk6CisKIDIw MTAtMDEtMTEgIEpvYW5tYXJpZSBEaWdncyAgPGpvYW5tYXJpZS5kaWdnc0BnbWFpbC5jb20+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgWGFuIExvcGV6LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbHVn aW5zL1BsdWdpblZpZXcuY3BwIGIvV2ViQ29yZS9wbHVnaW5zL1BsdWdpblZpZXcuY3BwCmluZGV4 IGU3OWViODguLmE5YjllNjMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5WaWV3 LmNwcAorKysgYi9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luVmlldy5jcHAKQEAgLTc4OSw2ICs3ODks NyBAQCBQbHVnaW5WaWV3OjpQbHVnaW5WaWV3KEZyYW1lKiBwYXJlbnRGcmFtZSwgY29uc3QgSW50 U2l6ZSYgc2l6ZSwgUGx1Z2luUGFja2FnZSogcAogICAgICwgbV9yZXF1ZXN0VGltZXIodGhpcywg JlBsdWdpblZpZXc6OnJlcXVlc3RUaW1lckZpcmVkKQogICAgICwgbV9pbnZhbGlkYXRlVGltZXIo dGhpcywgJlBsdWdpblZpZXc6OmludmFsaWRhdGVUaW1lckZpcmVkKQogICAgICwgbV9wb3BQb3B1 cHNTdGF0ZVRpbWVyKHRoaXMsICZQbHVnaW5WaWV3Ojpwb3BQb3B1cHNTdGF0ZVRpbWVyRmlyZWQp CisgICAgLCBtX21vZGUobV9sb2FkTWFudWFsbHkgPyBOUF9GVUxMIDogTlBfRU1CRUQpCiAgICAg LCBtX3BhcmFtTmFtZXMoMCkKICAgICAsIG1fcGFyYW1WYWx1ZXMoMCkKICAgICAsIG1fbWltZVR5 cGUobWltZVR5cGUpCkBAIC04NDgsOCArODQ5LDYgQEAgUGx1Z2luVmlldzo6UGx1Z2luVmlldyhG cmFtZSogcGFyZW50RnJhbWUsIGNvbnN0IEludFNpemUmIHNpemUsIFBsdWdpblBhY2thZ2UqIHAK ICAgICBtZW1zZXQoJm1fbnBDZ0NvbnRleHQsIDAsIHNpemVvZihtX25wQ2dDb250ZXh0KSk7CiAj ZW5kaWYKIAotICAgIG1fbW9kZSA9IG1fbG9hZE1hbnVhbGx5ID8gTlBfRlVMTCA6IE5QX0VNQkVE OwotCiAgICAgcmVzaXplKHNpemUpOwogfQogCg== 46281 2010-01-11 08:49:35 -0800 2010-01-11 16:10:04 -0800 Same thing yet again, but not adding a new bug.. bug-33468.diff text/plain 1451 kling ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZDU1NjBkMC4uMjk5NTFjMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wMS0xMSAgQW5kcmVhcyBLbGlu ZyAgPGFuZHJlYXMua2xpbmdAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEZpeGVkIGFuIHVuaW5pdGlhbGl6ZWQgUGx1Z2luVmlldyBt ZW1iZXIgKG1fbW9kZSkgd2hpY2ggd2Fzbid0CisgICAgICAgIHNldCB3aGVuIGNvbnN0cnVjdGVk IHdpdGggYSBudWxsIFBsdWdpblBhY2thZ2UqCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTMzNDY4CisKKyAgICAgICAgKiBwbHVnaW5zL1BsdWdpblZp ZXcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGx1Z2luVmlldzo6UGx1Z2luVmlldyk6CisKIDIw MTAtMDEtMTEgIEpvYW5tYXJpZSBEaWdncyAgPGpvYW5tYXJpZS5kaWdnc0BnbWFpbC5jb20+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgWGFuIExvcGV6LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbHVn aW5zL1BsdWdpblZpZXcuY3BwIGIvV2ViQ29yZS9wbHVnaW5zL1BsdWdpblZpZXcuY3BwCmluZGV4 IGU3OWViODguLjNiZTFiMDUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5WaWV3 LmNwcAorKysgYi9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luVmlldy5jcHAKQEAgLTc4OSw2ICs3ODks NyBAQCBQbHVnaW5WaWV3OjpQbHVnaW5WaWV3KEZyYW1lKiBwYXJlbnRGcmFtZSwgY29uc3QgSW50 U2l6ZSYgc2l6ZSwgUGx1Z2luUGFja2FnZSogcAogICAgICwgbV9yZXF1ZXN0VGltZXIodGhpcywg JlBsdWdpblZpZXc6OnJlcXVlc3RUaW1lckZpcmVkKQogICAgICwgbV9pbnZhbGlkYXRlVGltZXIo dGhpcywgJlBsdWdpblZpZXc6OmludmFsaWRhdGVUaW1lckZpcmVkKQogICAgICwgbV9wb3BQb3B1 cHNTdGF0ZVRpbWVyKHRoaXMsICZQbHVnaW5WaWV3Ojpwb3BQb3B1cHNTdGF0ZVRpbWVyRmlyZWQp CisgICAgLCBtX21vZGUobG9hZE1hbnVhbGx5ID8gTlBfRlVMTCA6IE5QX0VNQkVEKQogICAgICwg bV9wYXJhbU5hbWVzKDApCiAgICAgLCBtX3BhcmFtVmFsdWVzKDApCiAgICAgLCBtX21pbWVUeXBl KG1pbWVUeXBlKQpAQCAtODQ4LDggKzg0OSw2IEBAIFBsdWdpblZpZXc6OlBsdWdpblZpZXcoRnJh bWUqIHBhcmVudEZyYW1lLCBjb25zdCBJbnRTaXplJiBzaXplLCBQbHVnaW5QYWNrYWdlKiBwCiAg ICAgbWVtc2V0KCZtX25wQ2dDb250ZXh0LCAwLCBzaXplb2YobV9ucENnQ29udGV4dCkpOwogI2Vu ZGlmCiAKLSAgICBtX21vZGUgPSBtX2xvYWRNYW51YWxseSA/IE5QX0ZVTEwgOiBOUF9FTUJFRDsK LQogICAgIHJlc2l6ZShzaXplKTsKIH0KIAo=