33449 2010-01-10 08:24:42 -0800 REGRESSION: Inspect Element selects the wrong element 2010-01-10 13:31:09 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 ain pfeldman bweinstein joepeck keishi pfeldman pmuellr rik timothy oldest_to_newest 179139 0 ain 2010-01-10 08:24:42 -0800 Steps to reproduce: 1. Close Web Inspector 2. Go to http://www.bbc.co.uk/ for instance 3. Select a word 4. Right-click a selection and select Inspect Element Inspector window appears with body element selected, not the element selection was in. NB! It works properly on the 2nd try. It might be related to another report: https://bugs.webkit.org/show_bug.cgi?id=22511 179142 1 timothy 2010-01-10 09:01:20 -0800 This seems to be a regression related to Pavel's change to select the previous selected node on reload. I see the Inspector select and reveal the "Inspect Element" node breifly then it jumps to the previous selected node. In the reporters case it was <body>. But I was reproducing this with a random element on the BBC's page. 179143 2 timothy 2010-01-10 09:03:33 -0800 Note: I was closing the Inspector each time. Making it happen every time. The reporter kept the Inspector open, that is why it worked the second time. 179158 3 46238 pfeldman 2010-01-10 11:48:31 -0800 Created attachment 46238 [PATCH] Proposed fix 179169 4 pfeldman 2010-01-10 13:31:09 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/ElementsPanel.js M WebCore/inspector/front-end/treeoutline.js Committed r53053 46238 2010-01-10 11:48:31 -0800 2010-01-10 12:14:03 -0800 [PATCH] Proposed fix inspect_element text/plain 2155 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MDdmYWE2Ny4uYTA3ODA4NCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMCBAQAogMjAxMC0wMS0xMCAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBJbnNwZWN0IEVsZW1lbnQgc2VsZWN0 cyB0aGUgd3JvbmcgZWxlbWVudC4KKyAgICAgICAgRHJpdmUtYnkgZml4IHRoYXQgZm9jdXNlcyBk b20gdHJlZSB1cG9uIHNldHR0aW5nIGZvY3Vlc0RPTU5vZGUuCisKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMzNDQ5CisKKyAgICAgICAgKiBpbnNwZWN0 b3IvZnJvbnQtZW5kL0VsZW1lbnRzUGFuZWwuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRWxl bWVudHNQYW5lbC5wcm90b3R5cGUuc2V0RG9jdW1lbnQuc2VsZWN0TGFzdFNlbGVjdGVkTm9kZSk6 CisgICAgICAgIChXZWJJbnNwZWN0b3IuRWxlbWVudHNQYW5lbC5wcm90b3R5cGUuc2V0RG9jdW1l bnQpOgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvdHJlZW91dGxpbmUuanM6CisgICAg ICAgIChUcmVlRWxlbWVudC5wcm90b3R5cGUuc2VsZWN0KToKKworMjAxMC0wMS0xMCAgUGF2ZWwg RmVsZG1hbiAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKwogICAgICAgICBSZXZpZXdlZCBieSBU aW1vdGh5IEhhdGNoZXIuCiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogSW50cm9kdWNlIHN1cHBv cnQgZm9yIGZsZXhpYmxlIGxpbmUgaGVpZ2h0IGluIHRoZSB0ZXh0IGVkaXRvci4KZGlmZiAtLWdp dCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FbGVtZW50c1BhbmVsLmpzIGIvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzUGFuZWwuanMKaW5kZXggOTA2MzlmZS4uYThl NzJjYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzUGFu ZWwuanMKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0VsZW1lbnRzUGFuZWwuanMK QEAgLTIyNyw2ICsyMjcsMTAgQEAgV2ViSW5zcGVjdG9yLkVsZW1lbnRzUGFuZWwucHJvdG90eXBl ID0gewogCiAgICAgICAgIGZ1bmN0aW9uIHNlbGVjdExhc3RTZWxlY3RlZE5vZGUobm9kZUlkKQog ICAgICAgICB7CisgICAgICAgICAgICBpZiAodGhpcy5mb2N1c2VkRE9NTm9kZSkgeworICAgICAg ICAgICAgICAgIC8vIEZvY3VzZWQgbm9kZSBoYXMgYmVlbiBleHBsaWNpdGx5IHNldCB3aGlsZSBy ZWFjaGluZyBvdXQgZm9yIHRoZSBsYXN0IHNlbGVjdGVkIG5vZGUuCisgICAgICAgICAgICAgICAg cmV0dXJuOworICAgICAgICAgICAgfQogICAgICAgICAgICAgdmFyIG5vZGUgPSBub2RlSWQgPyBX ZWJJbnNwZWN0b3IuZG9tQWdlbnQubm9kZUZvcklkKG5vZGVJZCkgOiAwOwogICAgICAgICAgICAg c2VsZWN0Tm9kZS5jYWxsKHRoaXMsIG5vZGUpOwogICAgICAgICB9CmRpZmYgLS1naXQgYS9XZWJD b3JlL2luc3BlY3Rvci9mcm9udC1lbmQvdHJlZW91dGxpbmUuanMgYi9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvdHJlZW91dGxpbmUuanMKaW5kZXggZjM0M2M3Yy4uYjZlMzViYiAxMDA2NDQK LS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL3RyZWVvdXRsaW5lLmpzCisrKyBiL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC90cmVlb3V0bGluZS5qcwpAQCAtNzc2LDYgKzc3Niw3 IEBAIFRyZWVFbGVtZW50LnByb3RvdHlwZS5zZWxlY3QgPSBmdW5jdGlvbihzdXByZXNzT25TZWxl Y3QpCiAgICAgICAgIHRoaXMudHJlZU91dGxpbmUuc2VsZWN0ZWRUcmVlRWxlbWVudC5kZXNlbGVj dCgpOwogCiAgICAgdGhpcy5zZWxlY3RlZCA9IHRydWU7CisgICAgdGhpcy50cmVlT3V0bGluZS5f Y2hpbGRyZW5MaXN0Tm9kZS5mb2N1cygpOwogICAgIHRoaXMudHJlZU91dGxpbmUuc2VsZWN0ZWRU cmVlRWxlbWVudCA9IHRoaXM7CiAgICAgaWYgKHRoaXMuX2xpc3RJdGVtTm9kZSkKICAgICAgICAg dGhpcy5fbGlzdEl0ZW1Ob2RlLmFkZFN0eWxlQ2xhc3MoInNlbGVjdGVkIik7Cg==