3344 2005-06-08 04:17:04 -0700 10.3.9 Build Failure: isnan failure in kjs_window.cpp 2006-01-30 03:18:11 -0800 1 1 1 Unclassified WebKit JavaScriptCore 412 Mac OS X 10.3 RESOLVED WORKSFORME P2 Normal --- 3354 1 crschmidt mjs snu yibinlu oldest_to_newest 11068 0 crschmidt 2005-06-08 04:17:06 -0700 Another build error: in file: /Users/crschmidt/webkit/WebCore/khtml/ecma/kjs_window.cpp /Users/crschmidt/webkit/WebCore/khtml/ecma/kjs_window.cpp:93: error: `isnan' not declared /Users/crschmidt/webkit/WebCore/khtml/ecma/kjs_window.cpp: In function `int KJS::intFeature(const QMap<QString, QString>&, const char*, int, int, int)': /Users/crschmidt/webkit/WebCore/khtml/ecma/kjs_window.cpp:557: error: `isnan' undeclared (first use this function) /Users/crschmidt/webkit/WebCore/khtml/ecma/kjs_window.cpp:557: error: (Each undeclared identifier is reported only once for each function it appears in.) Interestingly enough, there seems to be some kind of indication in the file of why this might happen: // Must include <cmath> instead of <math.h> because of a bug in the // gcc 3.3 library version of <math.h> where if you include both // <cmath> and <math.h> the macros necessary for functions like // isnan are not defined. But <cmath> is being included. Not sure why exactly this is/isn't working, but I do know that Panther is using gcc-3.3, whereas building on Tiger used gcc-4.0. This one is an error, rather than a warning, so it can't be just skipped over. I was able to continue building by pulling the isnan calls out (as well as the using std::isnan), although obviously the code in this file will suffer as a result. (Not sure what the end result of this really is, just trying to get it to build to find where things which need to change are). (Brought over from Bug 3331). 11116 1 yibinlu 2005-06-08 20:08:02 -0700 I worked it around by applying this: -using std::isnan; +extern "C" int isnan(double); 11118 2 crschmidt 2005-06-08 20:20:20 -0700 Confirmed: Robin's fix allows the file to build correctly. 11831 3 2308 snu 2005-06-13 18:41:04 -0700 Created attachment 2308 proposed fix 12283 4 porten 2005-06-16 14:47:17 -0700 FWIW, the KDE version already uses an easy fix for this problem. The code is #ifdefed with HAVE_FLOAT_H. It's just that it's also protected by !APPLE_CHANGES so I think all that's needed is to apply the same change to operations.h. 12549 5 2308 darin 2005-06-18 16:53:21 -0700 Comment on attachment 2308 proposed fix I don't like solutions that involve changing the project file, because it makes it likely that we'll never remember to remove the hack. Also, setting the internal _GLIBCPP flag in the project file is not how the library's intended to be used. There must be some other solution to compiling this on Panther. I'd prefer another approach. If we search and can't come up with anything, then feel free to set the review flag on this patch again and I'll reconsider. 12553 6 snu 2005-06-18 16:57:10 -0700 This solution is the one that the Xcode Tools team suggested, fwiw. 12556 7 snu 2005-06-18 17:04:05 -0700 (In reply to comment #6) > This solution is the one that the Xcode Tools team suggested, fwiw. Just to clarify: this suggestion was made by Chris Espinosa and seemingly endorsed by Scott Tooker on the xcode-users mailing list, and not necessarily the position of the Xcode Tools team. See http:// lists.apple.com/archives/xcode-users/2005/May/msg00765.html 19432 8 darin 2005-09-11 22:05:51 -0700 I think this is fixed in TOT. 30618 9 mjs 2006-01-30 03:18:11 -0800 Seems to work ok on TOT. 2308 2005-06-13 18:41:04 -0700 2005-06-18 16:53:21 -0700 proposed fix 3344.patch text/plain 785 snu SW5kZXg6IFdlYkNvcmUucGJwcm9qL3Byb2plY3QucGJ4cHJvago9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxl OiAvY3ZzL3Jvb3QvV2ViQ29yZS9XZWJDb3JlLnBicHJvai9wcm9qZWN0LnBieHByb2osdgpyZXRy aWV2aW5nIHJldmlzaW9uIDEuNTUyCmRpZmYgLXUgLXIxLjU1MiBwcm9qZWN0LnBieHByb2oKLS0t IHByb2plY3QucGJ4cHJvagkyMDA1LzA2LzA4IDA5OjU1OjEyCTEuNTUyCisrKyBwcm9qZWN0LnBi eHByb2oJMjAwNS8wNi8xNCAwMTo0MDoxNQpAQCAtMjMwNyw3ICsyMzA3LDcgQEAKIAkJCQlHQ0Nf T1BUSU1JWkFUSU9OX0xFVkVMID0gczsKIAkJCQlHQ0NfUFJFQ09NUElMRV9QUkVGSVhfSEVBREVS ID0gWUVTOwogCQkJCUdDQ19QUkVGSVhfSEVBREVSID0gV2ViQ29yZVByZWZpeC5oOwotCQkJCUdD Q19QUkVQUk9DRVNTT1JfREVGSU5JVElPTlMgPSAiJChERUJVR19ERUZJTkVTKSBBUFBMRV9DSEFO R0VTIEtIVE1MX05PX0NQTFVTUExVU19ET00iOworCQkJCUdDQ19QUkVQUk9DRVNTT1JfREVGSU5J VElPTlMgPSAiX0dMSUJDUFBfVVNFX0M5OT0xICQoREVCVUdfREVGSU5FUykgQVBQTEVfQ0hBTkdF UyBLSFRNTF9OT19DUExVU1BMVVNfRE9NIjsKIAkJCQlHQ0NfVFJFQVRfV0FSTklOR1NfQVNfRVJS T1JTID0gWUVTOwogCQkJCUdDQ19XQVJOX0FCT1VUX01JU1NJTkdfUFJPVE9UWVBFUyA9IFlFUzsK IAkJCQlHQ0NfV0FSTl9OT05fVklSVFVBTF9ERVNUUlVDVE9SID0gWUVTOwo=