33427 2010-01-09 13:04:09 -0800 Web Inspector: Do not repaint line numbers while editing within line. 2010-01-10 11:07:39 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman bweinstein joepeck rik timothy oldest_to_newest 179028 0 pfeldman 2010-01-09 13:04:09 -0800 (making typing even snappier) 179029 1 46213 pfeldman 2010-01-09 13:06:03 -0800 Created attachment 46213 [PATCH] Proposed change 179030 2 46213 timothy 2010-01-09 13:10:58 -0800 Comment on attachment 46213 [PATCH] Proposed change > + if (oldRange.isEmpty() && newRange.isEmpty() && oldRange.startLine === newRange.startLine) > + // Nothing to repaint. > + return; This should have braces, even in the comment case, since it is multiline. See style guide, Braces clause 3. 179155 3 pfeldman 2010-01-10 11:07:39 -0800 (In reply to comment #2) > (From update of attachment 46213 [details]) > > + if (oldRange.isEmpty() && newRange.isEmpty() && oldRange.startLine === newRange.startLine) > > + // Nothing to repaint. > > + return; > > This should have braces, even in the comment case, since it is multiline. See > style guide, Braces clause 3. Done. Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/TextEditor.js Committed r53051 46213 2010-01-09 13:06:03 -0800 2010-01-09 13:10:57 -0800 [PATCH] Proposed change line_numbers text/plain 6404 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OGExOGRhZS4uZDY3MWViMCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMC0wMS0wOSAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBEbyBub3QgcmVwYWludCBsaW5lIG51 bWJlcnMgd2hpbGUgZWRpdGluZyB3aXRoaW4gbGluZS4KKworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzM0MjcKKworICAgICAgICAqIGluc3BlY3Rvci9m cm9udC1lbmQvVGV4dEVkaXRvci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UZXh0RWRpdG9y LnByb3RvdHlwZS5fdGV4dENoYW5nZWQpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRleHRFZGl0 b3IucHJvdG90eXBlLl9zZWxlY3Rpb25DaGFuZ2VkKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5U ZXh0RWRpdG9yLnByb3RvdHlwZS5fcmVwYWludEFsbCk6CisgICAgICAgIChXZWJJbnNwZWN0b3Iu VGV4dEVkaXRvci5wcm90b3R5cGUuX3BhaW50TGluZXMpOgorICAgICAgICAoV2ViSW5zcGVjdG9y LlRleHRFZGl0b3IucHJvdG90eXBlLl9wYWludExpbmVzQ29udGludWF0aW9uKToKKyAgICAgICAg KFdlYkluc3BlY3Rvci5UZXh0RWRpdG9yLnByb3RvdHlwZS5fcGFpbnRMaW5lTnVtYmVycyk6Cisg ICAgICAgIChXZWJJbnNwZWN0b3IuVGV4dEVkaXRvci5wcm90b3R5cGUuX3VwZGF0ZUN1cnNvcik6 CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGV4dEVkaXRvci5wcm90b3R5cGUuX2NvcHkpOgorCiAy MDEwLTAxLTA4ICBQYXZlbCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IFRpbW90aHkgSGF0Y2hlci4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5z cGVjdG9yL2Zyb250LWVuZC9UZXh0RWRpdG9yLmpzIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQt ZW5kL1RleHRFZGl0b3IuanMKaW5kZXggOTNiNTNkMC4uNmZjNDZlMyAxMDA2NDQKLS0tIGEvV2Vi Q29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RleHRFZGl0b3IuanMKKysrIGIvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL1RleHRFZGl0b3IuanMKQEAgLTE0NCwxMiArMTQ0LDE4IEBAIFdlYklu c3BlY3Rvci5UZXh0RWRpdG9yLnByb3RvdHlwZSA9IHsKIAogICAgICAgICB0aGlzLl9pbnZhbGlk YXRlSGlnaGxpZ2h0KG5ld1JhbmdlLnN0YXJ0TGluZSk7CiAgICAgICAgIHRoaXMuX3VwZGF0ZVNp emUobmV3UmFuZ2Uuc3RhcnRMaW5lLCBNYXRoLm1heChuZXdSYW5nZS5lbmRMaW5lLCBvbGRSYW5n ZS5lbmRMaW5lKSk7CisgICAgICAgIGlmIChvbGRSYW5nZS5saW5lc0NvdW50ICE9PSBuZXdSYW5n ZS5saW5lc0NvdW50KQorICAgICAgICAgICAgdGhpcy5fcGFpbnRMaW5lTnVtYmVycygpOwogICAg ICAgICB0aGlzLl9wYWludCgpOwogICAgIH0sCiAKICAgICAvLyBXZWJJbnNwZWN0b3IuVGV4dFNl bGVjdGlvbk1vZGVsIGxpc3RlbmVyCiAgICAgX3NlbGVjdGlvbkNoYW5nZWQ6IGZ1bmN0aW9uKG9s ZFJhbmdlLCBuZXdSYW5nZSkKICAgICB7CisgICAgICAgIGlmIChvbGRSYW5nZS5pc0VtcHR5KCkg JiYgbmV3UmFuZ2UuaXNFbXB0eSgpICYmIG9sZFJhbmdlLnN0YXJ0TGluZSA9PT0gbmV3UmFuZ2Uu c3RhcnRMaW5lKQorICAgICAgICAgICAgLy8gTm90aGluZyB0byByZXBhaW50LgorICAgICAgICAg ICAgcmV0dXJuOworCiAgICAgICAgIHRoaXMuX2ludmFsaWRhdGVMaW5lcyhvbGRSYW5nZS5zdGFy dExpbmUsIG9sZFJhbmdlLmVuZExpbmUgKyAxKTsKICAgICAgICAgdGhpcy5faW52YWxpZGF0ZUxp bmVzKG5ld1JhbmdlLnN0YXJ0TGluZSwgbmV3UmFuZ2UuZW5kTGluZSArIDEpOwogICAgICAgICB0 aGlzLl9wYWludCgpOwpAQCAtMTk3LDYgKzIwMyw3IEBAIFdlYkluc3BlY3Rvci5UZXh0RWRpdG9y LnByb3RvdHlwZSA9IHsKICAgICBfcmVwYWludEFsbDogZnVuY3Rpb24oKQogICAgIHsKICAgICAg ICAgdGhpcy5faW52YWxpZGF0ZUxpbmVzKDAsIHRoaXMuX3RleHRNb2RlbC5saW5lc0NvdW50KTsK KyAgICAgICAgdGhpcy5fcGFpbnRMaW5lTnVtYmVycygpOwogICAgICAgICB0aGlzLl9wYWludCgp OwogICAgICAgICB0aGlzLl91cGRhdGVDdXJzb3IodGhpcy5fc2VsZWN0aW9uLmVuZExpbmUsIHRo aXMuX3NlbGVjdGlvbi5lbmRDb2x1bW4pOwogICAgIH0sCkBAIC0yMzgsNiArMjQ1LDEyIEBAIFdl Ykluc3BlY3Rvci5UZXh0RWRpdG9yLnByb3RvdHlwZSA9IHsKICAgICAgICAgaWYgKGZpcnN0TGlu ZSA+IGxhc3RMaW5lKQogICAgICAgICAgICAgcmV0dXJuOwogCisgICAgICAgIC8vIENsaXAgZWRp dG9yIGFyZWEuCisgICAgICAgIHRoaXMuX2N0eC5zYXZlKCk7CisgICAgICAgIHRoaXMuX2N0eC5i ZWdpblBhdGgoKTsKKyAgICAgICAgdGhpcy5fY3R4LnJlY3QodGhpcy5fbGluZU51bWJlck9mZnNl dCAtIDEsIDAsIHRoaXMuX2NhbnZhcy53aWR0aCAtIHRoaXMuX2xpbmVOdW1iZXJPZmZzZXQgKyAx LCB0aGlzLl9jYW52YXMuaGVpZ2h0KTsKKyAgICAgICAgdGhpcy5fY3R4LmNsaXAoKTsKKwogICAg ICAgICBpZiAodGhpcy5fZGVidWdNb2RlKSB7CiAgICAgICAgICAgICBXZWJJbnNwZWN0b3IubG9n KCJSZXBhaW50ICVkOiVkIiwgZmlyc3RMaW5lLCBsYXN0TGluZSk7CiAgICAgICAgICAgICB0aGlz Ll9jdHguZmlsbFN0eWxlID0gInJnYigyNTUsMjU1LDApIjsKQEAgLTI0OSwyNiArMjYyLDE1IEBA IFdlYkluc3BlY3Rvci5UZXh0RWRpdG9yLnByb3RvdHlwZSA9IHsKICAgICB9LAogCiAgICAgX3Bh aW50TGluZXNDb250aW51YXRpb246IGZ1bmN0aW9uKGZpcnN0TGluZSwgbGFzdExpbmUpIHsKLSAg ICAgICAgLy8gQ2xlYXIgYWxsLgorICAgICAgICAvLyBGaXJzdCBjbGVhciB0aGUgcmVnaW9uLCB0 aGVuIHVwZGF0ZSBsYXN0IGxpbmUgdG8gZml0IG1vZGVsICh0aGlzIGNsZWFycyByZW1vdmVkIGxp bmVzIGZyb20gdGhlIGVuZCBvZiB0aGUgZG9jdW1lbnQpLgogICAgICAgICB2YXIgaGVpZ2h0ID0g KGxhc3RMaW5lIC0gZmlyc3RMaW5lKSAqIHRoaXMuX2xpbmVIZWlnaHQ7Ci0gICAgICAgIHRoaXMu X2N0eC5maWxsU3R5bGUgPSAicmdiKDI1NSwyNTUsMjU1KSI7Ci0gICAgICAgIHRoaXMuX2N0eC5m aWxsUmVjdCgwLCB0aGlzLl9saW5lSGVpZ2h0ICogZmlyc3RMaW5lIC0gdGhpcy5fc2Nyb2xsVG9w LCB0aGlzLl9jYW52YXMud2lkdGgsIGhlaWdodCk7Ci0KKyAgICAgICAgLy8gRG8gbm90IGNsZWFy IHJlZ2lvbiB3aGVuIHBhaW50Q3VycmVudExpbmUgaXMgbGlrZWx5IHRvIGRvIGFsbCB0aGUgbmVj ZXNzYXJ5IHdvcmsuCisgICAgICAgIGlmIChmaXJzdExpbmUgKyAxICE9IGxhc3RMaW5lIHx8IHRo aXMuX3NlbGVjdGlvbi5lbmRMaW5lICE9IGZpcnN0TGluZSkgeworICAgICAgICAgICAgdGhpcy5f Y3R4LmZpbGxTdHlsZSA9ICJyZ2IoMjU1LDI1NSwyNTUpIjsKKyAgICAgICAgICAgIHRoaXMuX2N0 eC5maWxsUmVjdCgwLCB0aGlzLl9saW5lSGVpZ2h0ICogZmlyc3RMaW5lIC0gdGhpcy5fc2Nyb2xs VG9wLCB0aGlzLl9jYW52YXMud2lkdGgsIGhlaWdodCk7CisgICAgICAgIH0KICAgICAgICAgbGFz dExpbmUgPSBNYXRoLm1pbihsYXN0TGluZSwgdGhpcy5fdGV4dE1vZGVsLmxpbmVzQ291bnQpOwog Ci0gICAgICAgIC8vIFBhaW50IGxpbmUgbnVtYmVycyBhbmQgc2VwYXJhdG9yLgotICAgICAgICB0 aGlzLl9jdHguZmlsbFN0eWxlID0gInJnYigyMzUsMjM1LDIzNSkiOwotICAgICAgICB0aGlzLl9j dHguZmlsbFJlY3QodGhpcy5fbGluZU51bWJlck9mZnNldCAtIDIsIDAsIDEsIHRoaXMuX2NhbnZh cy53aWR0aCk7Ci0gICAgICAgIHRoaXMuX2N0eC5maWxsU3R5bGUgPSAicmdiKDE1NSwxNTUsMTU1 KSI7Ci0gICAgICAgIGZvciAodmFyIGkgPSBmaXJzdExpbmU7IGkgPCBsYXN0TGluZTsgKytpKQot ICAgICAgICAgICB0aGlzLl9jdHguZmlsbFRleHQoaSArIDEsICh0aGlzLl9saW5lTnVtYmVyRGln aXRzIC0gdGhpcy5fZGVjaW1hbERpZ2l0cyhpICsgMSkgKyAxKSAqIHRoaXMuX2RpZ2l0V2lkdGgs IHRoaXMuX2xpbmVIZWlnaHQgKiAoaSArIDEpIC0gdGhpcy5fc2Nyb2xsVG9wKTsKLQotICAgICAg ICAvLyBDbGlwIGVkaXRvciBhcmVhLgotICAgICAgICB0aGlzLl9jdHguc2F2ZSgpOwotICAgICAg ICB0aGlzLl9jdHguYmVnaW5QYXRoKCk7Ci0gICAgICAgIHRoaXMuX2N0eC5yZWN0KHRoaXMuX2xp bmVOdW1iZXJPZmZzZXQgLSAxLCAwLCB0aGlzLl9jYW52YXMud2lkdGggLSB0aGlzLl9saW5lTnVt YmVyT2Zmc2V0ICsgMSwgdGhpcy5fY2FudmFzLmhlaWdodCk7Ci0gICAgICAgIHRoaXMuX2N0eC5j bGlwKCk7Ci0KICAgICAgICAgaWYgKHRoaXMuX3NlbGVjdGlvbi5zdGFydExpbmUgPT09IHRoaXMu X3NlbGVjdGlvbi5lbmRMaW5lICYmIGZpcnN0TGluZSA8PSB0aGlzLl9zZWxlY3Rpb24uc3RhcnRM aW5lICYmIHRoaXMuX3NlbGVjdGlvbi5zdGFydExpbmUgPCBsYXN0TGluZSkKICAgICAgICAgICAg IHRoaXMuX3BhaW50Q3VycmVudExpbmUodGhpcy5fc2VsZWN0aW9uLnN0YXJ0TGluZSk7CiAKQEAg LTMxMSw2ICszMTMsMjUgQEAgV2ViSW5zcGVjdG9yLlRleHRFZGl0b3IucHJvdG90eXBlID0gewog ICAgICAgICB0aGlzLl9jdHgucmVzdG9yZSgpOwogICAgIH0sCiAKKyAgICBfcGFpbnRMaW5lTnVt YmVyczogZnVuY3Rpb24oKQorICAgIHsKKyAgICAgICAgdGhpcy5fY3R4LmZvbnQgPSB0aGlzLl9m b250OworICAgICAgICB0aGlzLl9jdHgudGV4dEJhc2VsaW5lID0gImJvdHRvbSI7CisKKyAgICAg ICAgdGhpcy5fY3R4LmZpbGxTdHlsZSA9ICJyZ2IoMjU1LDI1NSwyNTUpIjsKKyAgICAgICAgdGhp cy5fY3R4LmZpbGxSZWN0KDAsIDAsIHRoaXMuX2xpbmVOdW1iZXJPZmZzZXQgLSAzLCB0aGlzLl9j YW52YXMuaGVpZ2h0KTsKKworICAgICAgICB0aGlzLl9jdHguZmlsbFN0eWxlID0gInJnYigyMzUs MjM1LDIzNSkiOworICAgICAgICB0aGlzLl9jdHguZmlsbFJlY3QodGhpcy5fbGluZU51bWJlck9m ZnNldCAtIDIsIDAsIDEsIHRoaXMuX2NhbnZhcy5oZWlnaHQpOworCisgICAgICAgIHZhciBmaXJz dExpbmUgPSBNYXRoLm1pbih0aGlzLl90ZXh0TW9kZWwubGluZXNDb3VudCwgTWF0aC5mbG9vcih0 aGlzLl9zY3JvbGxUb3AgLyB0aGlzLl9saW5lSGVpZ2h0KSAtIDEpOworICAgICAgICB2YXIgbGFz dExpbmUgPSBNYXRoLm1pbih0aGlzLl90ZXh0TW9kZWwubGluZXNDb3VudCwgTWF0aC5jZWlsKCh0 aGlzLl9zY3JvbGxUb3AgKyB0aGlzLl9jYW52YXMuaGVpZ2h0KSAvIHRoaXMuX2xpbmVIZWlnaHQp ICsgMSk7CisKKyAgICAgICAgdGhpcy5fY3R4LmZpbGxTdHlsZSA9ICJyZ2IoMTU1LDE1NSwxNTUp IjsKKyAgICAgICAgZm9yICh2YXIgaSA9IGZpcnN0TGluZTsgaSA8IGxhc3RMaW5lOyArK2kpCisg ICAgICAgICAgIHRoaXMuX2N0eC5maWxsVGV4dChpICsgMSwgKHRoaXMuX2xpbmVOdW1iZXJEaWdp dHMgLSB0aGlzLl9kZWNpbWFsRGlnaXRzKGkgKyAxKSArIDEpICogdGhpcy5fZGlnaXRXaWR0aCwg dGhpcy5fbGluZUhlaWdodCAqIChpICsgMSkgLSB0aGlzLl9zY3JvbGxUb3ApOworICAgIH0sCisK ICAgICBfcGFpbnRDdXJyZW50TGluZTogZnVuY3Rpb24obGluZSkKICAgICB7CiAgICAgICAgIHRo aXMuX2N0eC5maWxsU3R5bGUgPSAicmdiKDIzMiwgMjQyLCAyNTQpIjsKQEAgLTU0OSw3ICs1NzAs NyBAQCBXZWJJbnNwZWN0b3IuVGV4dEVkaXRvci5wcm90b3R5cGUgPSB7CiAKICAgICBfdXBkYXRl Q3Vyc29yOiBmdW5jdGlvbihsaW5lLCBjb2x1bW4pCiAgICAgewotICAgICAgICBpZiAobGluZSA+ IHRoaXMuX3RleHRNb2RlbC5saW5lc0NvdW50KQorICAgICAgICBpZiAobGluZSA+PSB0aGlzLl90 ZXh0TW9kZWwubGluZXNDb3VudCkKICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgdmFyIG9m ZnNldCA9IHRoaXMuX2NvbHVtblRvT2Zmc2V0KGxpbmUsIGNvbHVtbik7CiAgICAgICAgIGlmIChv ZmZzZXQgPj0gdGhpcy5fY29udGFpbmVyLnNjcm9sbExlZnQpCkBAIC02MjIsNyArNjQzLDcgQEAg V2ViSW5zcGVjdG9yLlRleHRFZGl0b3IucHJvdG90eXBlID0gewogCiAgICAgICAgIGUucHJldmVu dERlZmF1bHQoKTsKICAgICAgICAgZS5jbGlwYm9hcmREYXRhLmNsZWFyRGF0YSgpOwotICAgICAg ICBlLmNsaXBib2FyZERhdGEuc2V0RGF0YSgidGV4dC9wbGFpbiIsIHRleHQpOworICAgICAgICBl LmNsaXBib2FyZERhdGEuc2V0RGF0YSgiVGV4dCIsIHRleHQpOwogICAgIH0sCiAKICAgICBfYmVm b3JlQ3V0OiBmdW5jdGlvbihlKQo=