33414 2010-01-08 18:12:34 -0800 Let webkit-patch work with options in $EDITOR 2010-01-10 21:11:35 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth webkit-unassigned commit-queue webkit.review.bot oldest_to_newest 178911 0 abarth 2010-01-08 18:12:34 -0800 Let webkit-patch work with options in $EDITOR 178912 1 46188 abarth 2010-01-08 18:13:33 -0800 Created attachment 46188 Patch 178915 2 webkit.review.bot 2010-01-08 18:18:33 -0800 Attachment 46188 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKitTools/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] WebKitTools/ChangeLog:9: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 178917 3 46189 abarth 2010-01-08 18:23:14 -0800 Created attachment 46189 Patch 178918 4 abarth 2010-01-08 18:23:50 -0800 Interesting failure mode. We're checking style before editing the changelog. :) 178974 5 mrowe 2010-01-09 03:32:47 -0800 This naive approach will do the wrong thing if the path to your editor’s binary happens to contain a space. <http://subversion.tigris.org/faq.html#svn-editor> talks about how SVN handles this. Python’s shlex module may be useful to address this. 179016 6 46189 abarth 2010-01-09 09:58:23 -0800 Comment on attachment 46189 Patch Good point. I looked around for a python module to help, but I couldn't find one. shlex looks perfect. 179017 7 46211 abarth 2010-01-09 10:01:41 -0800 Created attachment 46211 Patch 179072 8 46211 eric 2010-01-09 15:48:17 -0800 Comment on attachment 46211 Patch Sweet! Seems we need a test case though. One should be very easy to write, no? 179091 9 abarth 2010-01-09 16:44:50 -0800 It's hard to write a test case because this code is calling system APIs directly. We could introduce another abstraction layer, but the point of this code is to be the abstraction layer around these APIs... 179247 10 46211 darin 2010-01-10 20:49:23 -0800 Comment on attachment 46211 Patch rs=me 179269 11 46211 commit-queue 2010-01-10 21:11:28 -0800 Comment on attachment 46211 Patch Clearing flags on attachment: 46211 Committed r53063: <http://trac.webkit.org/changeset/53063> 179270 12 commit-queue 2010-01-10 21:11:35 -0800 All reviewed patches have been landed. Closing bug. 46188 2010-01-08 18:13:33 -0800 2010-01-08 18:23:10 -0800 Patch bug-33414-20100108181331.patch text/plain 1187 abarth ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAzODdkZmRhLi45MTAzYjU0IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcgQEAKIDIwMTAtMDEt MDggIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAorICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBMZXQgd2Via2l0LXBhdGNoIHdvcmsgd2l0aCBv cHRpb25zIGluICRFRElUT1IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTMzNDE0CisKKwkJVGhlICRFRElUT1IgZXZpcm9ubWVudCB2YXJpYWJsZSBtaWdo dCBoYXZlIGNvbW1hbmQgbGluZSBvcHRpb25zIGxpa2UKKwkJYmJlZGl0IC13LiAgVGhpcyBwYXRj aCBsZXRzIHVzIHJ1biB0aG9zZSAkRURJVE9Scy4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0 cHkvdXNlci5weToKKworMjAxMC0wMS0wOCAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3Jn PgorCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgogCiAgICAgICAgIERvbid0IHBv c3Qgc3R5bGUtcXVldWUgcGFzcyBtZXNzYWdlcyB0byBidWdzCmRpZmYgLS1naXQgYS9XZWJLaXRU b29scy9TY3JpcHRzL3dlYmtpdHB5L3VzZXIucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtp dHB5L3VzZXIucHkKaW5kZXggNTBhNGUwZC4uM2YwZjMxMCAxMDA2NDQKLS0tIGEvV2ViS2l0VG9v bHMvU2NyaXB0cy93ZWJraXRweS91c2VyLnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvdXNlci5weQpAQCAtMzYsNyArMzYsOCBAQCBjbGFzcyBVc2VyKG9iamVjdCk6CiAKICAg ICBkZWYgZWRpdChzZWxmLCBmaWxlcyk6CiAgICAgICAgIGVkaXRvciA9IG9zLmVudmlyb24uZ2V0 KCJFRElUT1IiKSBvciAidmkiCi0gICAgICAgIHN1YnByb2Nlc3MuY2FsbChbZWRpdG9yXSArIGZp bGVzKQorICAgICAgICBhcmdzID0gZWRpdG9yLnNwbGl0KCIgIikKKyAgICAgICAgc3VicHJvY2Vz cy5jYWxsKGFyZ3MgKyBmaWxlcykKIAogICAgIGRlZiBwYWdlKHNlbGYsIG1lc3NhZ2UpOgogICAg ICAgICBwYWdlciA9IG9zLmVudmlyb24uZ2V0KCJQQUdFUiIpIG9yICJsZXNzIgo= 46189 2010-01-08 18:23:14 -0800 2010-01-09 10:01:37 -0800 Patch bug-33414-20100108182313.patch text/plain 1199 abarth ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAzODdkZmRhLi41ZDM0NzYzIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcgQEAKIDIwMTAtMDEt MDggIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAorICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBMZXQgd2Via2l0LXBhdGNoIHdvcmsgd2l0aCBv cHRpb25zIGluICRFRElUT1IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTMzNDE0CisKKyAgICAgICAgVGhlICRFRElUT1IgZXZpcm9ubWVudCB2YXJpYWJs ZSBtaWdodCBoYXZlIGNvbW1hbmQgbGluZSBvcHRpb25zIGxpa2UKKyAgICAgICAgYmJlZGl0IC13 LiAgVGhpcyBwYXRjaCBsZXRzIHVzIHJ1biB0aG9zZSAkRURJVE9Scy4KKworICAgICAgICAqIFNj cmlwdHMvd2Via2l0cHkvdXNlci5weToKKworMjAxMC0wMS0wOCAgQWRhbSBCYXJ0aCAgPGFiYXJ0 aEB3ZWJraXQub3JnPgorCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgogCiAgICAg ICAgIERvbid0IHBvc3Qgc3R5bGUtcXVldWUgcGFzcyBtZXNzYWdlcyB0byBidWdzCmRpZmYgLS1n aXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3VzZXIucHkgYi9XZWJLaXRUb29scy9T Y3JpcHRzL3dlYmtpdHB5L3VzZXIucHkKaW5kZXggNTBhNGUwZC4uM2YwZjMxMCAxMDA2NDQKLS0t IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS91c2VyLnB5CisrKyBiL1dlYktpdFRvb2xz L1NjcmlwdHMvd2Via2l0cHkvdXNlci5weQpAQCAtMzYsNyArMzYsOCBAQCBjbGFzcyBVc2VyKG9i amVjdCk6CiAKICAgICBkZWYgZWRpdChzZWxmLCBmaWxlcyk6CiAgICAgICAgIGVkaXRvciA9IG9z LmVudmlyb24uZ2V0KCJFRElUT1IiKSBvciAidmkiCi0gICAgICAgIHN1YnByb2Nlc3MuY2FsbChb ZWRpdG9yXSArIGZpbGVzKQorICAgICAgICBhcmdzID0gZWRpdG9yLnNwbGl0KCIgIikKKyAgICAg ICAgc3VicHJvY2Vzcy5jYWxsKGFyZ3MgKyBmaWxlcykKIAogICAgIGRlZiBwYWdlKHNlbGYsIG1l c3NhZ2UpOgogICAgICAgICBwYWdlciA9IG9zLmVudmlyb24uZ2V0KCJQQUdFUiIpIG9yICJsZXNz Igo= 46211 2010-01-09 10:01:41 -0800 2010-01-10 21:11:28 -0800 Patch bug-33414-20100109100139.patch text/plain 1300 abarth ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAyYjY2MGFhLi4xOWJlOTEwIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDEt MDkgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBMZXQgd2Via2l0LXBhdGNoIHdvcmsgd2l0aCBv cHRpb25zIGluICRFRElUT1IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTMzNDE0CisKKyAgICAgICAgVGhlICRFRElUT1IgZXZpcm9ubWVudCB2YXJpYWJs ZSBtaWdodCBoYXZlIGNvbW1hbmQgbGluZSBvcHRpb25zIGxpa2UKKyAgICAgICAgYmJlZGl0IC13 LiAgVGhpcyBwYXRjaCBsZXRzIHVzIHJ1biB0aG9zZSAkRURJVE9Scy4KKworICAgICAgICAqIFNj cmlwdHMvd2Via2l0cHkvdXNlci5weToKKwogMjAxMC0wMS0wOCAgRXJpYyBTZWlkZWwgIDxlcmlj QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KZGlmZiAtLWdp dCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdXNlci5weSBiL1dlYktpdFRvb2xzL1Nj cmlwdHMvd2Via2l0cHkvdXNlci5weQppbmRleCA1MGE0ZTBkLi44ZGJmNzRjIDEwMDY0NAotLS0g YS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3VzZXIucHkKKysrIGIvV2ViS2l0VG9vbHMv U2NyaXB0cy93ZWJraXRweS91c2VyLnB5CkBAIC0yNyw2ICsyNyw3IEBACiAjIE9GIFRISVMgU09G VFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0Uu CiAKIGltcG9ydCBvcworaW1wb3J0IHNobGV4CiBpbXBvcnQgc3VicHJvY2VzcwogaW1wb3J0IHdl YmJyb3dzZXIKIApAQCAtMzYsNyArMzcsOCBAQCBjbGFzcyBVc2VyKG9iamVjdCk6CiAKICAgICBk ZWYgZWRpdChzZWxmLCBmaWxlcyk6CiAgICAgICAgIGVkaXRvciA9IG9zLmVudmlyb24uZ2V0KCJF RElUT1IiKSBvciAidmkiCi0gICAgICAgIHN1YnByb2Nlc3MuY2FsbChbZWRpdG9yXSArIGZpbGVz KQorICAgICAgICBhcmdzID0gc2hsZXguc3BsaXQoZWRpdG9yKQorICAgICAgICBzdWJwcm9jZXNz LmNhbGwoYXJncyArIGZpbGVzKQogCiAgICAgZGVmIHBhZ2Uoc2VsZiwgbWVzc2FnZSk6CiAgICAg ICAgIHBhZ2VyID0gb3MuZW52aXJvbi5nZXQoIlBBR0VSIikgb3IgImxlc3MiCg==