33410 2010-01-08 16:25:40 -0800 Fix "View Plain Diff"/"View Formatted Diff" button 2010-01-08 18:17:34 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ddkilzer webkit-unassigned abarth aroben eric oldest_to_newest 178868 0 ddkilzer 2010-01-08 16:25:40 -0800 Fix "View Plain Diff"/"View Formatted Diff" button 178869 1 46175 ddkilzer 2010-01-08 16:26:09 -0800 Created attachment 46175 Patch v1 178878 2 46175 abarth 2010-01-08 16:47:45 -0800 Comment on attachment 46175 Patch v1 Looks good. Kind of fun to know how bugzilla works inside. 178914 3 ddkilzer 2010-01-08 18:17:34 -0800 Committed r53033: <http://trac.webkit.org/changeset/53033> 46175 2010-01-08 16:26:09 -0800 2010-01-08 16:47:45 -0800 Patch v1 bug-33410-20100108162608.patch text/plain 2536 ddkilzer SW5kZXg6IEJ1Z3NTaXRlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBCdWdzU2l0ZS9DaGFuZ2VM b2cJKHJldmlzaW9uIDUzMDIwKQorKysgQnVnc1NpdGUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkp CkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDEtMDggIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFw cGxlLmNvbT4KKworICAgICAgICBGaXggIlZpZXcgUGxhaW4gRGlmZiIvIlZpZXcgRm9ybWF0dGVk IERpZmYiIGJ1dHRvbgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFRoaXMgYnV0dG9uIHdhcyBicm9rZW4gZHVyaW5nIGEgcHJldmlvdXMgQnVnemlsbGEg dXBncmFkZSBhZnRlcgorICAgICAgICBjaGFuZ2VzIHdlcmUgbWFkZSB0byB0aGUgbmFtZXMgb2Yg b2JqZWN0cyBleHBvc2VkIG9uIHRlbXBsYXRlcy4KKworICAgICAgICAqIHRlbXBsYXRlL2VuL2N1 c3RvbS9hdHRhY2htZW50L3Jldmlld2Zvcm0uaHRtbC50bXBsOiBDaGFuZ2VkCisgICAgICAgIGF0 dGFjaGlkIHRvIGF0dGFjaG1lbnQuaWQgYW5kIGlzcGF0Y2ggdG8gYXR0YWNobWVudC5pc3BhdGNo LgorICAgICAgICBBbHNvIHR3ZWFrZWQgdGhlIGZvcm1hdCB0byB1c2UgNCB0YWJsZSBjb2x1bW5z IGluc3RlYWQgb2YgNS4KKwogMjAxMC0wMS0wOCAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBw bGUuY29tPgogCiAgICAgICAgIEluY2x1ZGVkIFVOQ09ORklSTUVEIGJ1Z3MgYnkgZGVmYXVsdCBp biBhZHZhbmNlZCBzZWFyY2ggcXVlcnkKSW5kZXg6IEJ1Z3NTaXRlL3RlbXBsYXRlL2VuL2N1c3Rv bS9hdHRhY2htZW50L3Jldmlld2Zvcm0uaHRtbC50bXBsCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEJ1Z3NTaXRl L3RlbXBsYXRlL2VuL2N1c3RvbS9hdHRhY2htZW50L3Jldmlld2Zvcm0uaHRtbC50bXBsCShyZXZp c2lvbiA1MzAxNikKKysrIEJ1Z3NTaXRlL3RlbXBsYXRlL2VuL2N1c3RvbS9hdHRhY2htZW50L3Jl dmlld2Zvcm0uaHRtbC50bXBsCSh3b3JraW5nIGNvcHkpCkBAIC0zNSw3ICszNSw3IEBACiAgIGZ1 bmN0aW9uIHZpZXdQcmV0dHlQYXRjaCgpCiAgICAgewogICAgICAgdmlld2luZ19mb3JtYXR0ZWRf ZGlmZiA9ICF2aWV3aW5nX2Zvcm1hdHRlZF9kaWZmOwotICAgICAgdmFyIHNyYyA9ICJhdHRhY2ht ZW50LmNnaT9pZD1bJSBhdHRhY2hpZCAlXSI7CisgICAgICB2YXIgc3JjID0gImF0dGFjaG1lbnQu Y2dpP2lkPVslIGF0dGFjaG1lbnQuaWQgJV0iOwogICAgICAgdmFyIGJ1dHRvblRleHQgPSAiVmll dyBGb3JtYXR0ZWQgRGlmZiI7CiAgICAgICBpZiAodmlld2luZ19mb3JtYXR0ZWRfZGlmZikgewog ICAgICAgICBzcmMgKz0gIiZhY3Rpb249cHJldHR5cGF0Y2giCkBAIC0xMDAsMjIgKzEwMCwyMCBA QAogWyUgRU5EICVdCiA8L3RkPgogPHRkPgotQmFjayB0byA8YSBocmVmPSJzaG93X2J1Zy5jZ2k/ aWQ9WyUgYXR0YWNobWVudC5idWdfaWQgJV0iIHRhcmdldD0iX3RvcCI+WyUgdGVybXMuQnVnICVd ICNbJSBhdHRhY2htZW50LmJ1Z19pZCAlXTwvYT4KLTwvdGQ+Ci08dGQ+Ci0gICAgWyUgSUYgaXNw YXRjaCAlXQotICAgICAgPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPgotICAgICAgICA8 IS0tCisgICAgPGRpdj5CYWNrIHRvIDxhIGhyZWY9InNob3dfYnVnLmNnaT9pZD1bJSBhdHRhY2ht ZW50LmJ1Z19pZCAlXSIgdGFyZ2V0PSJfdG9wIj5bJSB0ZXJtcy5CdWcgJV0gI1slIGF0dGFjaG1l bnQuYnVnX2lkICVdPC9hPjwvZGl2PgorWyUgSUYgYXR0YWNobWVudC5pc3BhdGNoICVdCisgICAg PHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPgorICAgIDwhLS0KICAgICAgICAgaWYgKHR5 cGVvZiBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCA9PSAiZnVuY3Rpb24iKSB7Ci0gICAgICAgICAg ZG9jdW1lbnQud3JpdGUoJzxidXR0b24gdHlwZT0iYnV0dG9uIiBpZD0idmlld1ByZXR0eVBhdGNo QnV0dG9uIiBvbmNsaWNrPSJ2aWV3UHJldHR5UGF0Y2goKTsiPlZpZXcgUGxhaW4gRGlmZjwvYnV0 dG9uPicpOworICAgICAgICAgIGRvY3VtZW50LndyaXRlKCc8cD48YnV0dG9uIHR5cGU9ImJ1dHRv biIgaWQ9InZpZXdQcmV0dHlQYXRjaEJ1dHRvbiIgb25jbGljaz0idmlld1ByZXR0eVBhdGNoKCk7 Ij5WaWV3IFBsYWluIERpZmY8L2J1dHRvbj48L3A+Jyk7CiAgICAgICAgIH0KLSAgICAgICAgLy8t LT4KLSAgICAgIDwvc2NyaXB0PgotICAgIFslIEVORCAlXQorICAgIC8vLS0+CisgICAgPC9zY3Jp cHQ+CitbJSBFTkQgJV0KIDwvdGQ+CiA8L3RyPgogPHRyPgotPHRkIGNvbHNwYW49IjUiPgorPHRk IGNvbHNwYW49IjQiPgogRW50ZXIgY29tbWVudHMgYmVsb3c6PGJyPgogPHRleHRhcmVhIGlkPWNv bW1lbnQgbmFtZT0iY29tbWVudCIgd3JhcD0ic29mdCI+WyUgcXVvdGVkcGF0Y2ggRklMVEVSIGh0 bWwgJV08L3RleHRhcmVhPjxicj4KIDwvdHI+Cg==