33393 2010-01-08 11:53:32 -0800 Remove unnecessary #include in FastMalloc.cpp 2010-01-08 14:09:50 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 yong.li.webkit webkit-unassigned webkit.review.bot oldest_to_newest 178730 0 yong.li.webkit 2010-01-08 11:53:32 -0800 #if FORCE_SYSTEM_MALLOC #include <stdlib.h> #if !OS(WINDOWS) #include <pthread.h> #else #include "windows.h" #endif Not sure if <stdlib.h> is needed, but <pthread.h> or "windows.h" is definitely unnecessary. 178735 1 46150 yong.li.webkit 2010-01-08 12:01:40 -0800 Created attachment 46150 the patch 178738 2 webkit.review.bot 2010-01-08 12:05:41 -0800 style-queue ran check-webkit-style on attachment 46150 without any errors. 178752 3 46150 eric 2010-01-08 12:37:39 -0800 Comment on attachment 46150 the patch OK. Which platforms use FORCE_SYSTEM_MALLOC at the moment? 178772 4 46150 darin 2010-01-08 13:38:37 -0800 Comment on attachment 46150 the patch It's clear that the <stdlib.h> include is not needed because FastMalloc.h includes it. There is no use of pthread down here and there is an include of pthread.h above for the case where we need it. But how did you determine the windows.h include was not needed? I'll take your word for it. 178779 5 yong.li.webkit 2010-01-08 13:47:28 -0800 (In reply to comment #4) > (From update of attachment 46150 [details]) > It's clear that the <stdlib.h> include is not needed because FastMalloc.h > includes it. There is no use of pthread down here and there is an include of > pthread.h above for the case where we need it. But how did you determine the > windows.h include was not needed? I'll take your word for it. I cannot see any #if OS(WINOS) or something similar inside #ifdef FORCE_SYSTEM_MALLOC block. Also, I successfully made FastMalloc build for win32 with forcing FORCE_SYSTEM_MALLOC=1 :) Will commit it soon and monitor the buildbots. 178797 6 yong.li.webkit 2010-01-08 14:09:50 -0800 landed @ r53008 bug closed 46150 2010-01-08 12:01:40 -0800 2010-01-08 14:10:15 -0800 the patch 33393.patch text/plain 948 yong.li.webkit ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCAwMTdjMGRhLi40YjgyZmRkIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTAtMDEtMDggIFlvbmcgTGkgIDx5b2xpQHJpbS5jb20+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIHVubmVjZXNzYXJ5ICNpbmNs dWRlIGZyb20gRmFzdE1hbGxvYy5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTMzMzkzCisKKyAgICAgICAgKiB3dGYvRmFzdE1hbGxvYy5jcHA6CisK IDIwMTAtMDEtMDYgIEdhdmluIEJhcnJhY2xvdWdoICA8YmFycmFjbG91Z2hAYXBwbGUuY29tPgog CiAgICAgICAgIFFUIGJ1aWxkIGZpeC4KZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL3d0Zi9G YXN0TWFsbG9jLmNwcCBiL0phdmFTY3JpcHRDb3JlL3d0Zi9GYXN0TWFsbG9jLmNwcAppbmRleCBh NTYzM2VhLi41Y2Q4NWYzIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS93dGYvRmFzdE1hbGxv Yy5jcHAKKysrIGIvSmF2YVNjcmlwdENvcmUvd3RmL0Zhc3RNYWxsb2MuY3BwCkBAIC0xOTEsMTMg KzE5MSw2IEBAIFRyeU1hbGxvY1JldHVyblZhbHVlIHRyeUZhc3RaZXJvZWRNYWxsb2Moc2l6ZV90 IG4pCiAKICNpZiBGT1JDRV9TWVNURU1fTUFMTE9DCiAKLSNpbmNsdWRlIDxzdGRsaWIuaD4KLSNp ZiAhT1MoV0lORE9XUykKLSAgICAjaW5jbHVkZSA8cHRocmVhZC5oPgotI2Vsc2UKLSAgICAjaW5j bHVkZSAid2luZG93cy5oIgotI2VuZGlmCi0KIG5hbWVzcGFjZSBXVEYgewogCiBUcnlNYWxsb2NS ZXR1cm5WYWx1ZSB0cnlGYXN0TWFsbG9jKHNpemVfdCBuKSAK