33392 2010-01-08 11:47:07 -0800 WebGL content disappears when style changes 2024-01-17 01:06:56 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Mac OS X 10.5 RESOLVED CONFIGURATION CHANGED P2 Normal --- 1 simon.fraser dino bfulgham kkinnunen simon.fraser oldest_to_newest 178729 0 46148 simon.fraser 2010-01-08 11:47:07 -0800 Created attachment 46148 Testcase The attached testcase has a WebGL canvas that draws a triangle. When you hover over it, it gains a border. In WebKit, at that point the contents of the canvas are lost. This does not happen in Firefox. 178758 1 cmarrin 2010-01-08 13:24:10 -0800 This actually works as expected on nightly. There is a bug with resizing, but it's filed (https://bugs.webkit.org/show_bug.cgi?id=30073) 178785 2 simon.fraser 2010-01-08 13:51:27 -0800 Reopening, since this will be an issue once the patch in bug 33361 is landed. The issue is that, for a directly composited WebGL layer, HTMLCanvasElement::paint() may never be called, so the beginPaint()/reshape()/endPaint() calls will never be called on the WebGLRenderingContext. Now, some style change can happen that requires that the canvas's layer gets backing store and paints (say, a border is added). Then this method will call WebGLRenderingContext::reshape(), which causes the canvas to be cleared. 2005537 3 kkinnunen 2024-01-17 01:06:56 -0800 Works now 46148 2010-01-08 11:47:07 -0800 2010-01-08 11:47:07 -0800 Testcase webgl-background-color.html text/html 5757 simon.fraser PCFET0NUWVBFIGh0bWw+CjxodG1sPgogIDxoZWFkPgogICAgPHNjcmlwdCBpZD0idnNoYWRlciIg dHlwZT0ieC1zaGFkZXIveC12ZXJ0ZXgiPgogICAgICAgIGF0dHJpYnV0ZSB2ZWM0IHZQb3NpdGlv bjsKICAgICAgICB2b2lkIG1haW4oKQogICAgICAgIHsKICAgICAgICAgICAgZ2xfUG9zaXRpb24g PSB2UG9zaXRpb247CiAgICAgICAgfQogICAgPC9zY3JpcHQ+CgogICAgPHNjcmlwdCBpZD0iZnNo YWRlciIgdHlwZT0ieC1zaGFkZXIveC1mcmFnbWVudCI+CiAgICAgICAgdm9pZCBtYWluKCkKICAg ICAgICB7CiAgICAgICAgICAgIGdsX0ZyYWdDb2xvciA9IHZlYzQoMS4wLCAxLjAsIDEuMCwgMSk7 CiAgICAgICAgfQogICAgPC9zY3JpcHQ+CgogICAgPHNjcmlwdD4KICAgICAgICBmdW5jdGlvbiBp bml0V2ViR0woY2FudmFzTmFtZSwgdnNoYWRlciwgZnNoYWRlciwgYXR0cmlicywgY2xlYXJDb2xv ciwgY2xlYXJEZXB0aCkKICAgICAgICB7CiAgICAgICAgICAgIHZhciBjYW52YXMgPSBkb2N1bWVu dC5nZXRFbGVtZW50QnlJZChjYW52YXNOYW1lKTsKICAgICAgICAgICAgdmFyIGdsID0gY2FudmFz LmdldENvbnRleHQoImV4cGVyaW1lbnRhbC13ZWJnbCIpOwogICAgICAgICAgICBpZiAoIWdsKSB7 CiAgICAgICAgICAgICAgICBhbGVydCgiTm8gV2ViR0wgY29udGV4dCBmb3VuZCIpOwogICAgICAg ICAgICAgICAgcmV0dXJuIG51bGw7CiAgICAgICAgICAgIH0KCiAgICAgICAgICAgIC8vIEFkZCBh IGNvbnNvbGUKICAgICAgICAgICAgZ2wuY29uc29sZSA9ICgiY29uc29sZSIgaW4gd2luZG93KSA/ IHdpbmRvdy5jb25zb2xlIDogeyBsb2c6IGZ1bmN0aW9uKCkgeyB9IH07CgogICAgICAgICAgICAv LyBjcmVhdGUgb3VyIHNoYWRlcnMKICAgICAgICAgICAgdmFyIHZlcnRleFNoYWRlciA9IGxvYWRT aGFkZXIoZ2wsIHZzaGFkZXIpOwogICAgICAgICAgICB2YXIgZnJhZ21lbnRTaGFkZXIgPSBsb2Fk U2hhZGVyKGdsLCBmc2hhZGVyKTsKCiAgICAgICAgICAgIGlmICghdmVydGV4U2hhZGVyIHx8ICFm cmFnbWVudFNoYWRlcikKICAgICAgICAgICAgICAgIHJldHVybiBudWxsOwoKICAgICAgICAgICAg Ly8gQ3JlYXRlIHRoZSBwcm9ncmFtIG9iamVjdAogICAgICAgICAgICBnbC5wcm9ncmFtID0gZ2wu Y3JlYXRlUHJvZ3JhbSgpOwoKICAgICAgICAgICAgaWYgKCFnbC5wcm9ncmFtKQogICAgICAgICAg ICAgICAgcmV0dXJuIG51bGw7CgogICAgICAgICAgICAvLyBBdHRhY2ggb3VyIHR3byBzaGFkZXJz IHRvIHRoZSBwcm9ncmFtCiAgICAgICAgICAgIGdsLmF0dGFjaFNoYWRlciAoZ2wucHJvZ3JhbSwg dmVydGV4U2hhZGVyKTsKICAgICAgICAgICAgZ2wuYXR0YWNoU2hhZGVyIChnbC5wcm9ncmFtLCBm cmFnbWVudFNoYWRlcik7CgogICAgICAgICAgICAvLyBCaW5kIGF0dHJpYnV0ZXMKICAgICAgICAg ICAgZm9yICh2YXIgaSBpbiBhdHRyaWJzKQogICAgICAgICAgICAgICAgZ2wuYmluZEF0dHJpYkxv Y2F0aW9uIChnbC5wcm9ncmFtLCBpLCBhdHRyaWJzW2ldKTsKCiAgICAgICAgICAgIC8vIExpbmsg dGhlIHByb2dyYW0KICAgICAgICAgICAgZ2wubGlua1Byb2dyYW0oZ2wucHJvZ3JhbSk7CgogICAg ICAgICAgICAvLyBDaGVjayB0aGUgbGluayBzdGF0dXMKICAgICAgICAgICAgdmFyIGxpbmtlZCA9 IGdsLmdldFByb2dyYW1QYXJhbWV0ZXIoZ2wucHJvZ3JhbSwgZ2wuTElOS19TVEFUVVMpOwogICAg ICAgICAgICBpZiAoIWxpbmtlZCkgewogICAgICAgICAgICAgICAgLy8gc29tZXRoaW5nIHdlbnQg d3Jvbmcgd2l0aCB0aGUgbGluawogICAgICAgICAgICAgICAgdmFyIGVycm9yID0gZ2wuZ2V0UHJv Z3JhbUluZm9Mb2cgKGdsLnByb2dyYW0pOwogICAgICAgICAgICAgICAgZ2wuY29uc29sZS5sb2co IkVycm9yIGluIHByb2dyYW0gbGlua2luZzoiK2Vycm9yKTsKCiAgICAgICAgICAgICAgICBnbC5k ZWxldGVQcm9ncmFtKGdsLnByb2dyYW0pOwogICAgICAgICAgICAgICAgZ2wuZGVsZXRlUHJvZ3Jh bShmcmFnbWVudFNoYWRlcik7CiAgICAgICAgICAgICAgICBnbC5kZWxldGVQcm9ncmFtKHZlcnRl eFNoYWRlcik7CgogICAgICAgICAgICAgICAgcmV0dXJuIG51bGw7CiAgICAgICAgICAgIH0KCiAg ICAgICAgICAgIGdsLnVzZVByb2dyYW0oZ2wucHJvZ3JhbSk7CgogICAgICAgICAgICBnbC5jbGVh ckNvbG9yKGNsZWFyQ29sb3JbMF0sIGNsZWFyQ29sb3JbMV0sIGNsZWFyQ29sb3JbMl0sIGNsZWFy Q29sb3JbM10pOwogICAgICAgICAgICBnbC5jbGVhckRlcHRoKGNsZWFyRGVwdGgpOwoKICAgICAg ICAgICAgZ2wuZW5hYmxlKGdsLkRFUFRIX1RFU1QpOwogICAgICAgICAgICBnbC5lbmFibGUoZ2wu QkxFTkQpOwogICAgICAgICAgICBnbC5ibGVuZEZ1bmMoZ2wuU1JDX0FMUEhBLCBnbC5PTkUpOwoK ICAgICAgICAgICAgcmV0dXJuIGdsOwogICAgICAgIH0KCiAgICAgICAgLy8KICAgICAgICAvLyBs b2FkU2hhZGVyCiAgICAgICAgLy8KICAgICAgICAvLyAnc2hhZGVySWQnIGlzIHRoZSBpZCBvZiBh IDxzY3JpcHQ+IGVsZW1lbnQgY29udGFpbmluZyB0aGUgc2hhZGVyIHNvdXJjZSBzdHJpbmcuCiAg ICAgICAgLy8gTG9hZCB0aGlzIHNoYWRlciBhbmQgcmV0dXJuIHRoZSBXZWJHTFNoYWRlciBvYmpl Y3QgY29ycmVzcG9uZGluZyB0byBpdC4KICAgICAgICAvLwogICAgICAgIGZ1bmN0aW9uIGxvYWRT aGFkZXIoY3R4LCBzaGFkZXJJZCkKICAgICAgICB7CiAgICAgICAgICAgIHZhciBzaGFkZXJTY3Jp cHQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZChzaGFkZXJJZCk7CiAgICAgICAgICAgIGlmICgh c2hhZGVyU2NyaXB0KSB7CiAgICAgICAgICAgICAgICBjdHguY29uc29sZS5sb2coIioqKiBFcnJv cjogc2hhZGVyIHNjcmlwdCAnIitzaGFkZXJJZCsiJyBub3QgZm91bmQiKTsKICAgICAgICAgICAg ICAgIHJldHVybiBudWxsOwogICAgICAgICAgICB9CgogICAgICAgICAgICBpZiAoc2hhZGVyU2Ny aXB0LnR5cGUgPT0gIngtc2hhZGVyL3gtdmVydGV4IikKICAgICAgICAgICAgICAgIHZhciBzaGFk ZXJUeXBlID0gY3R4LlZFUlRFWF9TSEFERVI7CiAgICAgICAgICAgIGVsc2UgaWYgKHNoYWRlclNj cmlwdC50eXBlID09ICJ4LXNoYWRlci94LWZyYWdtZW50IikKICAgICAgICAgICAgICAgIHZhciBz aGFkZXJUeXBlID0gY3R4LkZSQUdNRU5UX1NIQURFUjsKICAgICAgICAgICAgZWxzZSB7CiAgICAg ICAgICAgICAgICBjdHguY29uc29sZS5sb2coIioqKiBFcnJvcjogc2hhZGVyIHNjcmlwdCAnIitz aGFkZXJJZCsiJyBvZiB1bmRlZmluZWQgdHlwZSAnIitzaGFkZXJTY3JpcHQudHlwZSsiJyIpOwog ICAgICAgICAgICAgICAgcmV0dXJuIG51bGw7CiAgICAgICAgICAgIH0KCiAgICAgICAgICAgIC8v IENyZWF0ZSB0aGUgc2hhZGVyIG9iamVjdAogICAgICAgICAgICB2YXIgc2hhZGVyID0gY3R4LmNy ZWF0ZVNoYWRlcihzaGFkZXJUeXBlKTsKICAgICAgICAgICAgaWYgKHNoYWRlciA9PSBudWxsKSB7 CiAgICAgICAgICAgICAgICBjdHguY29uc29sZS5sb2coIioqKiBFcnJvcjogdW5hYmxlIHRvIGNy ZWF0ZSBzaGFkZXIgJyIrc2hhZGVySWQrIiciKTsgICAgICAgCiAgICAgICAgICAgICAgICByZXR1 cm4gbnVsbDsKICAgICAgICAgICAgfQoKICAgICAgICAgICAgLy8gTG9hZCB0aGUgc2hhZGVyIHNv dXJjZQogICAgICAgICAgICBjdHguc2hhZGVyU291cmNlKHNoYWRlciwgc2hhZGVyU2NyaXB0LnRl eHQpOwoKICAgICAgICAgICAgLy8gQ29tcGlsZSB0aGUgc2hhZGVyCiAgICAgICAgICAgIGN0eC5j b21waWxlU2hhZGVyKHNoYWRlcik7CgogICAgICAgICAgICAvLyBDaGVjayB0aGUgY29tcGlsZSBz dGF0dXMKICAgICAgICAgICAgdmFyIGNvbXBpbGVkID0gY3R4LmdldFNoYWRlclBhcmFtZXRlcihz aGFkZXIsIGN0eC5DT01QSUxFX1NUQVRVUyk7CiAgICAgICAgICAgIGlmICghY29tcGlsZWQpIHsK ICAgICAgICAgICAgICAgIC8vIFNvbWV0aGluZyB3ZW50IHdyb25nIGR1cmluZyBjb21waWxhdGlv bjsgZ2V0IHRoZSBlcnJvcgogICAgICAgICAgICAgICAgdmFyIGVycm9yID0gY3R4LmdldFNoYWRl ckluZm9Mb2coc2hhZGVyKTsKICAgICAgICAgICAgICAgIGN0eC5jb25zb2xlLmxvZygiKioqIEVy cm9yIGNvbXBpbGluZyBzaGFkZXIgJyIrc2hhZGVySWQrIic6IitlcnJvcik7CiAgICAgICAgICAg ICAgICBjdHguZGVsZXRlU2hhZGVyKHNoYWRlcik7CiAgICAgICAgICAgICAgICByZXR1cm4gbnVs bDsKICAgICAgICAgICAgfQoKICAgICAgICAgICAgcmV0dXJuIHNoYWRlcjsKICAgICAgICB9CiAg ICAKICAgICAgICBmdW5jdGlvbiBkcmF3Q2FudmFzKGNhbnZhc0lEKQogICAgICAgIHsKICAgICAg ICAgIHZhciBnbCA9IGluaXRXZWJHTChjYW52YXNJRCwgInZzaGFkZXIiLCAiZnNoYWRlciIsIFsg InZQb3NpdGlvbiJdLCBbIDAsIDAsIDAsIDAuNSBdLCAxKTsKICAgICAgICAgIGdsLnZpZXdwb3J0 KDAsIDAsIDIwMCwgMjAwKTsKICAgICAgICAgIGdsLmNsZWFyKGdsLkNPTE9SX0JVRkZFUl9CSVQg fCBnbC5ERVBUSF9CVUZGRVJfQklUKTsKICAgICAgICAgIAogICAgICAgICAgdmFyIHZlcnRleE9i amVjdCA9IGdsLmNyZWF0ZUJ1ZmZlcigpOwogICAgICAgICAgZ2wuYmluZEJ1ZmZlcihnbC5BUlJB WV9CVUZGRVIsIHZlcnRleE9iamVjdCk7CiAgICAgICAgICBnbC5idWZmZXJEYXRhKGdsLkFSUkFZ X0JVRkZFUiwgbmV3IFdlYkdMRmxvYXRBcnJheShbIDAsMC41LDAsIC0wLjUsLTAuNSwwLCAwLjUs LTAuNSwwIF0pLCBnbC5TVEFUSUNfRFJBVyk7CiAgICAgICAgICBnbC5lbmFibGVWZXJ0ZXhBdHRy aWJBcnJheSgwKTsKICAgICAgICAgIGdsLnZlcnRleEF0dHJpYlBvaW50ZXIoMCwgMywgZ2wuRkxP QVQsIGZhbHNlLCAwLCAwKTsKICAgICAgICAgIAogICAgICAgICAgZ2wuY2xlYXIoZ2wuQ09MT1Jf QlVGRkVSX0JJVCB8IGdsLkRFUFRIX0JVRkZFUl9CSVQpOwogICAgICAgICAgZ2wuZHJhd0FycmF5 cyhnbC5UUklBTkdMRVMsIDAsIDMpOwogICAgICAgIH0KCiAgICAgICAgZnVuY3Rpb24gaW5pdCgp CiAgICAgICAgewogICAgICAgICAgLy8gd2luZG93LnNldEludGVydmFsKGZ1bmN0aW9uKCkgewog ICAgICAgICAgLy8gICBkcmF3Q2FudmFzKCdsZWZ0Jyk7CiAgICAgICAgICAvLyB9LCAxMDApOwoK ICAgICAgICAgIGRyYXdDYW52YXMoJ2xlZnQnKTsKICAgICAgIH0KICAgIDwvc2NyaXB0PgogICAg PHN0eWxlIHR5cGU9InRleHQvY3NzIiBtZWRpYT0ic2NyZWVuIj4KCiAgICAgIGJvZHkgewogICAg ICAgIGJhY2tncm91bmQtY29sb3I6IHNpbHZlcjsKICAgICAgfQogICAgICBjYW52YXMgewogICAg ICAgIHBvc2l0aW9uOiBhYnNvbHV0ZTsKICAgICAgICB0b3A6IDIwcHg7CiAgICAgICAgbWFyZ2lu OiAyMHB4OwogICAgICAgIHdpZHRoOiAyNDBweDsKICAgICAgICBoZWlnaHQ6IDIwMHB4OwogICAg ICAgIHBhZGRpbmc6IDAgMjBweDsKLyogICAgICAgIGJhY2tncm91bmQtY29sb3I6IHJnYmEoMCwg MCwgMjU1LCAwLjUpOyovCiAgICAgICAgLXdlYmtpdC1ib3gtc2l6aW5nOiBib3JkZXItYm94Owog ICAgICB9CiAgICAgIAogICAgICBjYW52YXM6aG92ZXIgewogICAgICAgIGJvcmRlcjogNHB4IHNv bGlkIGJsdWU7CiAgICAgIH0KICAgICAgCiAgICA8L3N0eWxlPgogIDwvaGVhZD4KICA8Ym9keSBv bmxvYWQ9ImluaXQoKSI+CiAgIAogICAgPGNhbnZhcyBpZD0ibGVmdCIgc3R5bGU9ImxlZnQ6IDIw cHgiIHdpZHRoPSIyMDAiIGhlaWdodD0iMjAwIj48L2NhbnZhcz4KICA8L2JvZHk+CjwvaHRtbD4K