33390 2010-01-08 10:32:40 -0800 bindings/v8/DOMData is missing a virtual destructor 2010-01-09 10:03:22 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Android Android RESOLVED FIXED P2 Normal --- 0 andreip webkit-unassigned abarth android-webkit-unforking commit-queue oldest_to_newest 178711 0 andreip 2010-01-08 10:32:40 -0800 DOMData is the base class for ChildThreadDOMData and MainThreadDOMData classes but it does not have a virtual destructor. While this isn't currently causing any leaks, since there are no instances of ChildThreadDOMData or MainThreadDOMData that are manipulated via a DOMData pointer, the ARM GCC compiler generates the following compilation error: "/WebCore/bindings/v8/DOMData.h:45: error: 'class WebCore::DOMData' has virtual functions and accessible non-virtual destructor" We therefore need to add a virtual destructor to DOMData. 178893 1 abarth 2010-01-08 17:24:19 -0800 Do you have a patch for this, or should I write one? 178896 2 46184 abarth 2010-01-08 17:27:04 -0800 Created attachment 46184 Patch 178897 3 abarth 2010-01-08 17:28:02 -0800 (Please wait for the chromium-ews because I didn't compile this locally.) 178953 4 46184 dimich 2010-01-08 23:13:56 -0800 Comment on attachment 46184 Patch r=me, cq+ 178958 5 46184 commit-queue 2010-01-08 23:40:10 -0800 Comment on attachment 46184 Patch Clearing flags on attachment: 46184 Committed r53037: <http://trac.webkit.org/changeset/53037> 178959 6 commit-queue 2010-01-08 23:40:15 -0800 All reviewed patches have been landed. Closing bug. 178977 7 andreip 2010-01-09 04:24:01 -0800 (In reply to comment #1) > Do you have a patch for this, or should I write one? Yes, I had the patch. I just got interrupted before I could upload it, then had to leave to catch my train. I woke up this morning and found the bug fixed. Thank you :) I'll try to upload my patches faster in the future. 179018 8 abarth 2010-01-09 10:03:22 -0800 > I'll try to upload my patches faster in the future. No worries. It just seemed like a trivial bug in code I wrote, so I fixed it. 46184 2010-01-08 17:27:04 -0800 2010-01-08 23:40:09 -0800 Patch bug-33390-20100108172703.patch text/plain 1893 abarth ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NTVhYzBlZS4uMDljOGJjMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNSBAQAorMjAxMC0wMS0wOCAgQWRhbSBCYXJ0aCAg PGFiYXJ0aEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIGJpbmRpbmdzL3Y4L0RPTURhdGEgaXMgbWlzc2luZyBhIHZpcnR1YWwgZGVz dHJ1Y3RvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MzMzOTAKKworICAgICAgICBET01EYXRhIGlzIHRoZSBiYXNlIGNsYXNzIGZvciBDaGlsZFRocmVh ZERPTURhdGEgYW5kIE1haW5UaHJlYWRET01EYXRhIGNsYXNzZXMKKyAgICAgICAgYnV0IGl0IGRv ZXMgbm90IGhhdmUgYSB2aXJ0dWFsIGRlc3RydWN0b3IuIFdoaWxlIHRoaXMgaXNuJ3QgY3VycmVu dGx5IGNhdXNpbmcKKyAgICAgICAgYW55IGxlYWtzLCBzaW5jZSB0aGVyZSBhcmUgbm8gaW5zdGFu Y2VzIG9mIENoaWxkVGhyZWFkRE9NRGF0YSBvcgorICAgICAgICBNYWluVGhyZWFkRE9NRGF0YSB0 aGF0IGFyZSBtYW5pcHVsYXRlZCB2aWEgYSBET01EYXRhIHBvaW50ZXIsIHRoZSBBUk0gR0NDCisg ICAgICAgIGNvbXBpbGVyIGdlbmVyYXRlcyB0aGUgZm9sbG93aW5nIGNvbXBpbGF0aW9uIGVycm9y OgorCisgICAgICAgICIvV2ViQ29yZS9iaW5kaW5ncy92OC9ET01EYXRhLmg6NDU6IGVycm9yOiAn Y2xhc3MgV2ViQ29yZTo6RE9NRGF0YScgaGFzIHZpcnR1YWwKKyAgICAgICAgZnVuY3Rpb25zIGFu ZCBhY2Nlc3NpYmxlIG5vbi12aXJ0dWFsIGRlc3RydWN0b3IiCisKKyAgICAgICAgV2UgdGhlcmVm b3JlIG5lZWQgdG8gYWRkIGEgdmlydHVhbCBkZXN0cnVjdG9yIHRvIERPTURhdGEuCisKKyAgICAg ICAgKiBiaW5kaW5ncy92OC9ET01EYXRhLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRPTURhdGE6 On5ET01EYXRhKToKKyAgICAgICAgKiBiaW5kaW5ncy92OC9ET01EYXRhLmg6CisKIDIwMTAtMDEt MDggIEtlbm5ldGggUnVzc2VsbCAgPGtickBnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IERpbWl0cmkgR2xhemtvdi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvYmluZGluZ3MvdjgvRE9N RGF0YS5jcHAgYi9XZWJDb3JlL2JpbmRpbmdzL3Y4L0RPTURhdGEuY3BwCmluZGV4IDU0YmNjNTUu LmVjOWE5MzggMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvYmluZGluZ3MvdjgvRE9NRGF0YS5jcHAKKysr IGIvV2ViQ29yZS9iaW5kaW5ncy92OC9ET01EYXRhLmNwcApAQCAtNDQsNiArNDQsMTAgQEAgRE9N RGF0YTo6RE9NRGF0YSgpCiB7CiB9CiAKK0RPTURhdGE6On5ET01EYXRhKCkKK3sKK30KKwogRE9N RGF0YSogRE9NRGF0YTo6Z2V0Q3VycmVudCgpCiB7CiAgICAgaWYgKFdURjo6aXNNYWluVGhyZWFk KCkpCmRpZmYgLS1naXQgYS9XZWJDb3JlL2JpbmRpbmdzL3Y4L0RPTURhdGEuaCBiL1dlYkNvcmUv YmluZGluZ3MvdjgvRE9NRGF0YS5oCmluZGV4IGI1OGYxMzguLjkzNDgwY2EgMTAwNjQ0Ci0tLSBh L1dlYkNvcmUvYmluZGluZ3MvdjgvRE9NRGF0YS5oCisrKyBiL1dlYkNvcmUvYmluZGluZ3Mvdjgv RE9NRGF0YS5oCkBAIC00NSw2ICs0NSw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICBjbGFz cyBET01EYXRhIDogcHVibGljIE5vbmNvcHlhYmxlIHsKICAgICBwdWJsaWM6CiAgICAgICAgIERP TURhdGEoKTsKKyAgICAgICAgdmlydHVhbCB+RE9NRGF0YSgpOwogCiAgICAgICAgIHN0YXRpYyBE T01EYXRhKiBnZXRDdXJyZW50KCk7CiAgICAgICAgIHZpcnR1YWwgRE9NRGF0YVN0b3JlJiBnZXRT dG9yZSgpID0gMDsK