33376 2010-01-08 04:08:38 -0800 commit-queue should run run-javascriptcore-tests 2010-01-08 04:59:14 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned abarth commit-queue kent.hansen webkit.review.bot oldest_to_newest 178631 0 eric 2010-01-08 04:08:38 -0800 commit-queue should run run-javascriptcore-tests the commit-queue landed 2 patches which broke lots of javascriptcore tests tongiht. This could have been prevented if we just ran run-javascriptcore-tests. :( 178637 1 eric 2010-01-08 04:32:55 -0800 I'm not sure what port flags will need to be passed otherwise this would be simple. 178638 2 eric 2010-01-08 04:33:19 -0800 Then again, i'm not sure that it matters, since no other port besides mac will use this at first. 178640 3 46132 eric 2010-01-08 04:43:13 -0800 Created attachment 46132 Patch 178643 4 webkit.review.bot 2010-01-08 04:48:47 -0800 style-queue ran check-webkit-style on attachment 46132 without any errors. 178645 5 commit-queue 2010-01-08 04:59:14 -0800 Committed r52989: <http://trac.webkit.org/changeset/52989> 46132 2010-01-08 04:43:13 -0800 2010-01-08 04:55:09 -0800 Patch bug-33376-20100108044311.patch text/plain 2484 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBlZDIyMTIxLi41MDczMDQyIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDEt MDggIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGNvbW1pdC1xdWV1ZSBzaG91bGQgcnVuIHJ1bi1q YXZhc2NyaXB0Y29yZS10ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MzMzNzYKKworICAgICAgICBJIGFsc28gbWFkZSBpdCBydW4gdGhlIHB5dGhv biBhbmQgcGVybCB1bml0IHRlc3RzLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9zdGVw cy9ydW50ZXN0cy5weToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3dlYmtpdHBvcnQucHk6 CisKIDIwMTAtMDEtMDcgIEFuZHJhcyBCZWNzaSAgPGFiZWNzaUBpbmYudS1zemVnZWQuaHU+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9XZWJLaXRUb29s cy9TY3JpcHRzL3dlYmtpdHB5L3N0ZXBzL3J1bnRlc3RzLnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0 cy93ZWJraXRweS9zdGVwcy9ydW50ZXN0cy5weQppbmRleCBkYTBhNjkxLi40YzE2NzkzIDEwMDY0 NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0ZXBzL3J1bnRlc3RzLnB5Cisr KyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3RlcHMvcnVudGVzdHMucHkKQEAgLTQ1 LDYgKzQ1LDEyIEBAIGNsYXNzIFJ1blRlc3RzKEFic3RyYWN0U3RlcCk6CiAgICAgICAgICAgICBy ZXR1cm4KICAgICAgICAgaWYgbm90IHNlbGYuX29wdGlvbnMudGVzdDoKICAgICAgICAgICAgIHJl dHVybgorCisgICAgICAgICMgUnVuIHRoZSBzY3JpcHRpbmcgdW5pdCB0ZXN0cyBmaXJzdCBiZWNh dXNlIHRoZXkncmUgcXVpY2tlc3QuCisgICAgICAgIHNlbGYuX3Rvb2wuZXhlY3V0aXZlLnJ1bl9h bmRfdGhyb3dfaWZfZmFpbChzZWxmLnBvcnQoKS5ydW5fcHl0aG9uX3VuaXR0ZXN0c19jb21tYW5k KCkpCisgICAgICAgIHNlbGYuX3Rvb2wuZXhlY3V0aXZlLnJ1bl9hbmRfdGhyb3dfaWZfZmFpbChz ZWxmLnBvcnQoKS5ydW5fcGVybF91bml0dGVzdHNfY29tbWFuZCgpKQorICAgICAgICBzZWxmLl90 b29sLmV4ZWN1dGl2ZS5ydW5fYW5kX3Rocm93X2lmX2ZhaWwoc2VsZi5wb3J0KCkucnVuX2phdmFz Y3JpcHRjb3JlX3Rlc3RzX2NvbW1hbmQoKSkKKwogICAgICAgICBhcmdzID0gc2VsZi5wb3J0KCku cnVuX3dlYmtpdF90ZXN0c19jb21tYW5kKCkKICAgICAgICAgaWYgc2VsZi5fb3B0aW9ucy5ub25f aW50ZXJhY3RpdmU6CiAgICAgICAgICAgICBhcmdzLmFwcGVuZCgiLS1uby1sYXVuY2gtc2FmYXJp IikKQEAgLTUyLDMgKzU4LDQgQEAgY2xhc3MgUnVuVGVzdHMoQWJzdHJhY3RTdGVwKToKICAgICAg ICAgaWYgc2VsZi5fb3B0aW9ucy5xdWlldDoKICAgICAgICAgICAgIGFyZ3MuYXBwZW5kKCItLXF1 aWV0IikKICAgICAgICAgc2VsZi5fdG9vbC5leGVjdXRpdmUucnVuX2FuZF90aHJvd19pZl9mYWls KGFyZ3MpCisKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvd2Via2l0 cG9ydC5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvd2Via2l0cG9ydC5weQppbmRl eCAyNmQ5ZDU0Li5iNDY4YzlkIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtp dHB5L3dlYmtpdHBvcnQucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS93ZWJr aXRwb3J0LnB5CkBAIC03MSw5ICs3MSwyMSBAQCBjbGFzcyBXZWJLaXRQb3J0KG9iamVjdCk6CiAg ICAgICAgIHJldHVybiBjb21tYW5kCiAKICAgICBAY2xhc3NtZXRob2QKKyAgICBkZWYgcnVuX2ph dmFzY3JpcHRjb3JlX3Rlc3RzX2NvbW1hbmQoY2xzKToKKyAgICAgICAgcmV0dXJuIFtjbHMuc2Ny aXB0X3BhdGgoInJ1bi1qYXZhc2NyaXB0Y29yZS10ZXN0cyIpXQorCisgICAgQGNsYXNzbWV0aG9k CiAgICAgZGVmIHJ1bl93ZWJraXRfdGVzdHNfY29tbWFuZChjbHMpOgogICAgICAgICByZXR1cm4g W2Nscy5zY3JpcHRfcGF0aCgicnVuLXdlYmtpdC10ZXN0cyIpXQogCisgICAgQGNsYXNzbWV0aG9k CisgICAgZGVmIHJ1bl9weXRob25fdW5pdHRlc3RzX2NvbW1hbmQoY2xzKToKKyAgICAgICAgcmV0 dXJuIFtjbHMuc2NyaXB0X3BhdGgoInRlc3Qtd2Via2l0cHkiKV0KKworICAgIEBjbGFzc21ldGhv ZAorICAgIGRlZiBydW5fcGVybF91bml0dGVzdHNfY29tbWFuZChjbHMpOgorICAgICAgICByZXR1 cm4gW2Nscy5zY3JpcHRfcGF0aCgidGVzdC13ZWJraXRwZXJsIildCisKIAogY2xhc3MgTWFjUG9y dChXZWJLaXRQb3J0KToKICAgICBAY2xhc3NtZXRob2QK