33349 2010-01-07 15:29:21 -0800 http/tests/security/xss-DENIED-window-open-javascript-url.html timed out on Windows Debug Bot 2011-10-13 15:37:27 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED WORKSFORME P2 Normal --- 32528 1 eric abarth abarth ap aroben bweinstein commit-queue dbates ossy oldest_to_newest 178410 0 eric 2010-01-07 15:29:21 -0800 http/tests/security/xss-DENIED-window-open-javascript-url.html timed out on Windows Debug Bot Sigh. http://build.webkit.org/results/Windows%20Debug%20(Tests)/r52946%20(8254)/results.html Added by abarth 3 weeks ago: http://trac.webkit.org/browser/trunk/LayoutTests/http/tests/security/xss-DENIED-window-open-javascript-url.html 179063 1 eric 2010-01-09 15:25:29 -0800 Hit this again just now: http://build.webkit.org/results/Windows%20Debug%20(Tests)/r53039%20(8329)/results.html 179064 2 eric 2010-01-09 15:27:35 -0800 Strange that this has occurred in batches of twos today. First: http://build.webkit.org/results/Windows%20Debug%20(Tests)/r53034%20(8324)/ http://build.webkit.org/results/Windows%20Debug%20(Tests)/r53035%20(8325)/ Then: http://build.webkit.org/results/Windows%20Debug%20(Tests)/r53039%20(8329)/ http://build.webkit.org/results/Windows%20Debug%20(Tests)/r53040%20(8330)/ I wonder if that's cooincidence or somehow related to how this fails. 179067 3 eric 2010-01-09 15:31:51 -0800 This seems to be the most common failure on the Windows Debug bot. Earlier it was not occurring in "paired" failures, so the pairs I mention above are just coincidence. This test failed in 6 of the last 15 runs. 179115 4 eric 2010-01-09 19:42:25 -0800 Another failure: http://build.webkit.org/results/Windows%20Debug%20(Tests)/r53047%20(8338)/results.html I'll post a patch to skip this one on Monday if we don't have other theories. Seems silly to keep the windows bot red like this. Maybe Adam has an idea why this could be so flakey for windows? 179121 5 46229 abarth 2010-01-09 23:38:23 -0800 Created attachment 46229 Patch 179188 6 46229 zimmermann 2010-01-10 16:18:07 -0800 Comment on attachment 46229 Patch This just happened again: http://build.webkit.org/results/Windows%20Debug%20(Tests)/r53054%20(8348)/results.html. r+ to skip the test. 179190 7 46229 commit-queue 2010-01-10 16:38:24 -0800 Comment on attachment 46229 Patch Clearing flags on attachment: 46229 Committed r53055: <http://trac.webkit.org/changeset/53055> 179191 8 commit-queue 2010-01-10 16:38:30 -0800 All reviewed patches have been landed. Closing bug. 179285 9 eric 2010-01-10 21:27:01 -0800 Looks like this did not fix the problem:http://build.webkit.org/results/Windows%20Debug%20(Tests)/r53062%20(8359)/results.html 179290 10 abarth 2010-01-10 21:58:33 -0800 Strange. Maybe the load event isn't firing somehow? If the load event fires, I don't see how it could possibly time out. 179298 11 46263 dbates 2010-01-11 00:35:06 -0800 Created attachment 46263 Patch Here is my attempt. We can remove the use of layoutTestController.waitUntilDone() and instead test whether the parent of the newly opened window is equal to the current window. If so, then the test passed. Notice, since this is a JavaScript URL, the parent of the newly opened window will be about:blank, if successful. And about:blank is different from the current window. Hence, we say the test fails when the parent of the newly opened window is not equal to the current window. 179299 12 46263 abarth 2010-01-11 00:42:02 -0800 Comment on attachment 46263 Patch Thats an interesting test, but not what the test is supposed to be testing. We're trying to see if the JavaScript runs at all. The problem is the JavaScript runs asynchronously. It's hard to tell whether the JavaScript isn't going to run or just plain hasn't run yet. 179527 13 eric 2010-01-11 13:57:29 -0800 Another failure: http://build.webkit.org/results/Windows%20Debug%20(Tests)/r53095%20(8391)/results.html 179613 14 abarth 2010-01-11 16:49:15 -0800 This is failing often enough that we can try reducing the test case. Maybe remove the window.open call and see what happens? 179615 15 bweinstein 2010-01-11 16:50:59 -0800 (In reply to comment #14) > This is failing often enough that we can try reducing the test case. Maybe > remove the window.open call and see what happens? I would test it, but I have been unable to reproduce this on my machine. Does it need to be run with all of run-webkit-tests, or has anyone been able to reproduce this on their own machine? 179637 16 eric 2010-01-11 17:34:24 -0800 This test just doesn't like us. Failed again: http://build.webkit.org/results/Windows%20Debug%20(Tests)/r53111%20(8401)/results.html 180573 17 eric 2010-01-13 23:50:45 -0800 Not that you really need my reminder, but for book-keeping. Still a common failure: http://build.webkit.org/results/Windows%20Debug%20(Tests)/r53240%20(8501)/results.html bug 32528 looks like a duplicate, or at least related. 181394 18 eric 2010-01-15 14:22:11 -0800 Still our most common windows debug failure: http://build.webkit.org/results/Windows%20Debug%20(Tests)/r53343%20(8577)/results.html Dan/Adam: Should we just skip this, or do we have any clue why this is failing? 181484 19 abarth 2010-01-15 23:31:00 -0800 Instead of skipping the test, we should investigate why it fails. For example, you could try a patch that removes code from the test until it passes consistently. 187282 20 ossy 2010-02-02 23:59:41 -0800 Unfortunately it timed out at all times. :( (r54260-r54271) http://build.webkit.org/results/Windows%20Debug%20%28Tests%29/r54271%20%289357%29/results.html http://build.webkit.org/results/Windows%20Debug%20%28Tests%29/r54270%20%289356%29/results.html http://build.webkit.org/results/Windows%20Debug%20%28Tests%29/r54269%20%289355%29/results.html 187283 21 abarth 2010-02-03 00:00:35 -0800 Please skip this test. Assign the bug to me. I won't forget it. <-- famous last words. 187285 22 ossy 2010-02-03 00:12:31 -0800 (In reply to comment #21) > Please skip this test. Assign the bug to me. I won't forget it. <-- famous > last words. Done by http://trac.webkit.org/changeset/54275 198451 23 abarth 2010-03-10 18:38:35 -0800 Committed r55826: <http://trac.webkit.org/changeset/55826> 198453 24 abarth 2010-03-10 18:39:15 -0800 We have another test that has this same problem. I've removed the test, but we should bring it back once we figure out how to test this case! 483564 25 abarth 2011-10-13 15:37:27 -0700 This doesn't appear to have been a problem recently. 46229 2010-01-09 23:38:23 -0800 2010-01-11 00:35:06 -0800 Patch bug-33349-20100109233821.patch text/plain 1730 abarth ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA5MjJhMjM2Li41YzM3ZTQwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMDEt MDkgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwL3Rlc3RzL3NlY3VyaXR5L3hzcy1ERU5J RUQtd2luZG93LW9wZW4tamF2YXNjcmlwdC11cmwuaHRtbCB0aW1lZCBvdXQgb24gV2luZG93cyBE ZWJ1ZyBCb3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTMzMzQ5CisKKyAgICAgICAgUHJldmlvdXNseSB3ZSB3ZXJlIHVzaW5nIEphdmFTY3JpcHQgVVJM cyB0byByZXR1cm4gdG8gdGhlIG1haW4gZXZlbnQKKyAgICAgICAgbG9vcCwgYnV0IHRoYXQgaXMg cG90ZW50aWFsbHkgdW5yZWxpYWJsZSBiZWNhdXNlIHRoZXJlIGNhbiBiZSBvbmx5IG9uZQorICAg ICAgICBzY2hlZHVsZWQgcmVkaXJlY3QgaW4gZmxpZ2h0IHBlciBmcmFtZS4gIExldCdzIHRyeSB1 c2luZyBzZXRUaW1lb3V0CisgICAgICAgIGluc3RlYWQuICBOb3RpY2UgdGhhdCB0aGVyZSBpc24n dCBhIHJhY2UgY29uZGl0aW9uIGhlcmUgYmVjYXVzZSB0aGUKKyAgICAgICAgZXZlbnQgbG9vcCB3 aWxsIGFsd2F5cyBkaXNwYXRjaCB0aGUgYWN0aW9ucyBpbiB0aGUgcHJvcGVyIG9yZGVyLgorCisg ICAgICAgICogaHR0cC90ZXN0cy9zZWN1cml0eS94c3MtREVOSUVELXdpbmRvdy1vcGVuLWphdmFz Y3JpcHQtdXJsLmh0bWw6CisKIDIwMTAtMDEtMDkgIERhbmllbCBCYXRlcyAgPGRiYXRlc0B3ZWJr aXQub3JnPgogCiAgICAgICAgIFJ1YmJlci1zdGFtcGVkIGJ5IEFkYW0gQmFydGguCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3NlY3VyaXR5L3hzcy1ERU5JRUQtd2luZG93LW9w ZW4tamF2YXNjcmlwdC11cmwuaHRtbCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvc2VjdXJpdHkv eHNzLURFTklFRC13aW5kb3ctb3Blbi1qYXZhc2NyaXB0LXVybC5odG1sCmluZGV4IGJiNTliNzUu LjBjNWExYmIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvc2VjdXJpdHkveHNz LURFTklFRC13aW5kb3ctb3Blbi1qYXZhc2NyaXB0LXVybC5odG1sCisrKyBiL0xheW91dFRlc3Rz L2h0dHAvdGVzdHMvc2VjdXJpdHkveHNzLURFTklFRC13aW5kb3ctb3Blbi1qYXZhc2NyaXB0LXVy bC5odG1sCkBAIC03LDggKzcsMTAgQEAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikg ewogICAgIGxheW91dFRlc3RDb250cm9sbGVyLndhaXRVbnRpbERvbmUoKTsKIH0KIGZ1bmN0aW9u IHJ1blRlc3QoKSB7CisgICAgLy8gU2NoZWR1bGUgYSByZXR1cm4gdG8gdGhlIG1haW4gZXZlbnQg bG9vcCBzbyB0aGF0IHRoZSBqYXZhc2NyaXB0OiBVUkwKKyAgICAvLyBoYXMgYSBjaGFuY2UgdG8g cnVuLgorICAgIHNldFRpbWVvdXQoZG9uZSwgMCk7CiAgICAgd2luZG93Lm9wZW4oImphdmFzY3Jp cHQ6YWxlcnQoJ0ZBSUwnKSIsICJ0ZyIpOwotICAgIHdpbmRvdy5vcGVuKCJqYXZhc2NyaXB0OmRv bmUoKSIsICJfc2VsZiIpOwogfQogZnVuY3Rpb24gZG9uZSgpIHsKICAgICBpZiAod2luZG93Lmxh eW91dFRlc3RDb250cm9sbGVyKQo= 46263 2010-01-11 00:35:06 -0800 2010-06-11 11:12:25 -0700 Patch rewriteXSSTest.patch text/plain 3606 dbates SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDUzMDY3KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDEtMTAgIERhbmllbCBCYXRlcyAgPGRi YXRlc0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFJlbW92ZWQgdXNlIG9mIGxheW91dFRlc3RDb250cm9sbGVyLndhaXRVbnRpbERv bmUoKSBhbmQgc2V0VGltZW91dC4KKyAgICAgICAgSW5zdGVhZCwgd2UgdGVzdCB3aGV0aGVyIHRo ZSBwYXJlbnQgb2YgdGhlIG5ld2x5IG9wZW5lZCB3aW5kb3cgaXMgZXF1YWwKKyAgICAgICAgdG8g dGhlIGN1cnJlbnQgd2luZG93LiBJZiBzbywgdGhlIHRlc3QgcGFzc2VkLiBPdGhlcndpc2UsIGl0 IGZhaWxlZC4KKworICAgICAgICAqIGh0dHAvdGVzdHMvc2VjdXJpdHkveHNzLURFTklFRC13aW5k b3ctb3Blbi1qYXZhc2NyaXB0LXVybC1leHBlY3RlZC50eHQ6CisgICAgICAgICogaHR0cC90ZXN0 cy9zZWN1cml0eS94c3MtREVOSUVELXdpbmRvdy1vcGVuLWphdmFzY3JpcHQtdXJsLmh0bWw6CisK IDIwMTAtMDEtMTAgIERhbmllbCBCYXRlcyAgPGRiYXRlc0B3ZWJraXQub3JnPgogCiAgICAgICAg IFVucmV2aWV3ZWQsIGZpeCB0eXBvLgpJbmRleDogTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9zZWN1 cml0eS94c3MtREVOSUVELXdpbmRvdy1vcGVuLWphdmFzY3JpcHQtdXJsLWV4cGVjdGVkLnR4dAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3NlY3VyaXR5L3hzcy1ERU5JRUQt d2luZG93LW9wZW4tamF2YXNjcmlwdC11cmwtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiA1MzA2NykK KysrIExheW91dFRlc3RzL2h0dHAvdGVzdHMvc2VjdXJpdHkveHNzLURFTklFRC13aW5kb3ctb3Bl bi1qYXZhc2NyaXB0LXVybC1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTEsNCArMSw3 IEBACiBDT05TT0xFIE1FU1NBR0U6IGxpbmUgMTogVW5zYWZlIEphdmFTY3JpcHQgYXR0ZW1wdCB0 byBhY2Nlc3MgZnJhbWUgd2l0aCBVUkwgaHR0cDovL2xvY2FsaG9zdDo4MDgwL3NlY3VyaXR5L3Jl c291cmNlcy9pbm5vY2VudC12aWN0aW0uaHRtbCBmcm9tIGZyYW1lIHdpdGggVVJMIGh0dHA6Ly8x MjcuMC4wLjE6ODAwMC9zZWN1cml0eS94c3MtREVOSUVELXdpbmRvdy1vcGVuLWphdmFzY3JpcHQt dXJsLmh0bWwuIERvbWFpbnMsIHByb3RvY29scyBhbmQgcG9ydHMgbXVzdCBtYXRjaC4KIAotVGhp cyB0ZXN0IHBhc3NlcyBpZiB0aGVyZSBpcyBubyBhbGVydCBkaWFsb2cuCitUaGlzIHRlc3RzIHRo YXQgY2FsbGluZyB3aW5kb3cub3BlbigpIHdpdGggYSBKYXZhU2NyaXB0IFVSTCB3aXRoIHJlc3Bl Y3QgdG8gYW4gPGlmcmFtZT4gZmFpbHMgaWYgdGhlIHNvdXJjZSBvZiB0aGUgPGlmcmFtZT4gZG9l cyBub3QgaGF2ZSB0aGUgc2FtZS1vcmlnaW4gYXMgdGhlIHBhZ2UuCisKKworUEFTUzogRGlkIG5v dCBvcGVuIHdpbmRvdyB3aXRoIEphdmFTY3JpcHQgVVJMLgogCkluZGV4OiBMYXlvdXRUZXN0cy9o dHRwL3Rlc3RzL3NlY3VyaXR5L3hzcy1ERU5JRUQtd2luZG93LW9wZW4tamF2YXNjcmlwdC11cmwu aHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3NlY3VyaXR5L3hzcy1E RU5JRUQtd2luZG93LW9wZW4tamF2YXNjcmlwdC11cmwuaHRtbAkocmV2aXNpb24gNTMwNjcpCisr KyBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL3NlY3VyaXR5L3hzcy1ERU5JRUQtd2luZG93LW9wZW4t amF2YXNjcmlwdC11cmwuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMiwyNiArMiwzMiBAQAogPGh0 bWw+CiA8aGVhZD4KIDxzY3JpcHQ+Ci1pZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7 CitpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQogICAgIGxheW91dFRlc3RDb250cm9s bGVyLmR1bXBBc1RleHQoKTsKLSAgICBsYXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25l KCk7Ci19CisKIGZ1bmN0aW9uIHJ1blRlc3QoKSB7Ci0gICAgLy8gU2NoZWR1bGUgYSByZXR1cm4g dG8gdGhlIG1haW4gZXZlbnQgbG9vcCBzbyB0aGF0IHRoZSBqYXZhc2NyaXB0OiBVUkwKLSAgICAv LyBoYXMgYSBjaGFuY2UgdG8gcnVuLgotICAgIHNldFRpbWVvdXQoZG9uZSwgMCk7Ci0gICAgd2lu ZG93Lm9wZW4oImphdmFzY3JpcHQ6YWxlcnQoJ0ZBSUwnKSIsICJ0ZyIpOworICAgIHZhciBvcGVu ZWRXaW5kb3cgPSB3aW5kb3cub3BlbigiamF2YXNjcmlwdDphbGVydCgnRkFJTCcpIiwgInRnIik7 CisKKyAgICAvLyBOb3RlLCB0aGUgcGFyZW50IG9mIHRoZSBuZXdseSBvcGVuZWQgd2luZG93IHNo b3VsZCBiZSBhYm91dDpibGFuaworICAgIC8vIGlmIHN1Y2Nlc3NmdWwgc2luY2UgdGhpcyBpcyBh IEphdmFTY3JpcHQgVVJMLiBTbywgaWYgdGhlCisgICAgLy8gcGFyZW50IGlzIHRoZSBjdXJyZW50 IHdpbmRvdyB0aGVuIHdlIGRlbmllZCB0aGUgSmF2YVNjcmlwdCBVUkwuCisgICAgaWYgKG9wZW5l ZFdpbmRvdy5wYXJlbnQgPT09IHdpbmRvdykKKyAgICAgICAgbG9nKCJQQVNTOiBEaWQgbm90IG9w ZW4gd2luZG93IHdpdGggSmF2YVNjcmlwdCBVUkwuIik7CisgICAgZWxzZQorICAgICAgICBsb2co IkZBSUw6IFNob3VsZCBub3QgaGF2ZSBvcGVuZWQgd2luZG93IHdpdGggSmF2YVNjcmlwdCBVUkwu IEJ1dCBkaWQuIikKIH0KLWZ1bmN0aW9uIGRvbmUoKSB7Ci0gICAgaWYgKHdpbmRvdy5sYXlvdXRU ZXN0Q29udHJvbGxlcikKLSAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIubm90aWZ5RG9uZSgp OworCitmdW5jdGlvbiBsb2cobWVzc2FnZSkKK3sKKyAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJ ZCgiY29uc29sZSIpLmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZVRleHROb2RlKG1lc3NhZ2Ug KyAiXG4iKSk7CiB9CiA8L3NjcmlwdD4KIDwvaGVhZD4KIDxib2R5PgotVGhpcyB0ZXN0IHBhc3Nl cyBpZiB0aGVyZSBpcyBubyBhbGVydCBkaWFsb2cuPGJyPgorPHA+VGhpcyB0ZXN0cyB0aGF0IGNh bGxpbmcgd2luZG93Lm9wZW4oKSB3aXRoIGEgSmF2YVNjcmlwdCBVUkwgd2l0aCByZXNwZWN0IHRv IGFuICZsdDtpZnJhbWUmZ3Q7IGZhaWxzIGlmIHRoZSBzb3VyY2Ugb2YgdGhlICZsdDtpZnJhbWUm Z3Q7IGRvZXMgbm90IGhhdmUgdGhlIHNhbWUtb3JpZ2luIGFzIHRoZSBwYWdlLjwvcD4KIDxpZnJh bWUgb25sb2FkPSJydW5UZXN0KCkiIG5hbWU9InRnIgogICAgICAgICBzcmM9Imh0dHA6Ly9sb2Nh bGhvc3Q6ODA4MC9zZWN1cml0eS9yZXNvdXJjZXMvaW5ub2NlbnQtdmljdGltLmh0bWwiCi0gICAg PjwvaWZyYW1lPiAKKyAgICA+PC9pZnJhbWU+Cis8cHJlIGlkPSJjb25zb2xlIj48L3ByZT4KIDwv Ym9keT4KIDwvaHRtbD4K