33348 2010-01-07 15:10:14 -0800 REGRESSION (r48075): Clicking and dragging in a widget's text field doesn't create a selection; drags widget instead ( Translation, Weather, Ski Report ) 2010-01-07 15:34:19 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 mjs webkit-unassigned webkit.review.bot oldest_to_newest 178398 0 mjs 2010-01-07 15:10:14 -0800 REGRESSION (r48075): Clicking and dragging in a widget's text field doesn't create a selection; drags widget instead ( Translation, Weather, Ski Report ) 178400 1 46090 mjs 2010-01-07 15:11:38 -0800 Created attachment 46090 Patch 178403 2 46090 simon.fraser 2010-01-07 15:15:00 -0800 Comment on attachment 46090 Patch > Index: WebKit/mac/WebView/WebView.mm > =================================================================== > --- WebKit/mac/WebView/WebView.mm (revision 52952) > +++ WebKit/mac/WebView/WebView.mm (working copy) > @@ -1301,6 +1301,8 @@ static bool fastDocumentTeardownEnabled( > settings->setApplicationChromeMode([preferences applicationChromeModeEnabled]); > if ([preferences userStyleSheetEnabled]) { > NSString* location = [[preferences userStyleSheetLocation] _web_originalDataAsString]; > + if ([location isEqual:@"apple-dashboard://stylesheet"]) Prefer isEqualToString. r=me 178404 3 webkit.review.bot 2010-01-07 15:15:17 -0800 style-queue ran check-webkit-style on attachment 46090 without any errors. 178411 4 mjs 2010-01-07 15:34:19 -0800 Committed r52953: <http://trac.webkit.org/changeset/52953> 46090 2010-01-07 15:11:38 -0800 2010-01-07 15:14:59 -0800 Patch bug-33348-20100107151137.patch text/plain 1775 mjs SW5kZXg6IFdlYktpdC9tYWMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9tYWMvQ2hh bmdlTG9nCShyZXZpc2lvbiA1Mjk1MikKKysrIFdlYktpdC9tYWMvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDEtMDcgIE1hY2llaiBTdGFjaG93aWFrICA8 bWpzQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBSRUdSRVNTSU9OIChyNDgwNzUpOiBDbGlja2luZyBhbmQgZHJhZ2dpbmcgaW4gYSB3 aWRnZXQncyB0ZXh0IGZpZWxkIGRvZXNuJ3QgY3JlYXRlIGEgc2VsZWN0aW9uOyBkcmFncyB3aWRn ZXQgaW5zdGVhZCAoIFRyYW5zbGF0aW9uLCBXZWF0aGVyLCBTa2kgUmVwb3J0ICkKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMzMzQ4CisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS83MzEwNjE2PgorICAgICAgICAKKyAgICAgICAgKiBXZWJWaWV3L1dlYlZp ZXcubW06CisgICAgICAgICgtW1dlYlZpZXcgX3ByZWZlcmVuY2VzQ2hhbmdlZE5vdGlmaWNhdGlv bjpdKTogV2Ugb25seSB3YW50IHRvCisgICAgICAgIGhhbmRsZSBmaWxlOiBVUkxzIGZvciB0aGUg dXNlciBzdHlsZXNoZWV0IG5vdywgc28gc3BlY2lhbC1jYXNlIHRoZQorICAgICAgICBEYXNoYm9h cmRDbGllbnQncyBmdW5reSB1c2VyIHN0eWxlc2hlZXQgVVJMIGJ5IG1hcHBpbmcgaXQgdG8gdGhl CisgICAgICAgIGVxdWl2YWxlbnQgZmlsZSBVUkwuCisKIDIwMTAtMDEtMDcgIEtldmluIERlY2tl ciAgPGtkZWNrZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEZyYXNl ci4KSW5kZXg6IFdlYktpdC9tYWMvV2ViVmlldy9XZWJWaWV3Lm1tCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YktpdC9tYWMvV2ViVmlldy9XZWJWaWV3Lm1tCShyZXZpc2lvbiA1Mjk1MikKKysrIFdlYktpdC9t YWMvV2ViVmlldy9XZWJWaWV3Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xMzAxLDYgKzEzMDEsOCBA QCBzdGF0aWMgYm9vbCBmYXN0RG9jdW1lbnRUZWFyZG93bkVuYWJsZWQoCiAgICAgc2V0dGluZ3Mt PnNldEFwcGxpY2F0aW9uQ2hyb21lTW9kZShbcHJlZmVyZW5jZXMgYXBwbGljYXRpb25DaHJvbWVN b2RlRW5hYmxlZF0pOwogICAgIGlmIChbcHJlZmVyZW5jZXMgdXNlclN0eWxlU2hlZXRFbmFibGVk XSkgewogICAgICAgICBOU1N0cmluZyogbG9jYXRpb24gPSBbW3ByZWZlcmVuY2VzIHVzZXJTdHls ZVNoZWV0TG9jYXRpb25dIF93ZWJfb3JpZ2luYWxEYXRhQXNTdHJpbmddOworICAgICAgICBpZiAo W2xvY2F0aW9uIGlzRXF1YWw6QCJhcHBsZS1kYXNoYm9hcmQ6Ly9zdHlsZXNoZWV0Il0pCisgICAg ICAgICAgICBsb2NhdGlvbiA9IEAiZmlsZTovLy9TeXN0ZW0vTGlicmFyeS9Qcml2YXRlRnJhbWV3 b3Jrcy9EYXNoYm9hcmRDbGllbnQuZnJhbWV3b3JrL1Jlc291cmNlcy93aWRnZXQuY3NzIjsKICAg ICAgICAgc2V0dGluZ3MtPnNldFVzZXJTdHlsZVNoZWV0TG9jYXRpb24oW05TVVJMIFVSTFdpdGhT dHJpbmc6KGxvY2F0aW9uID8gbG9jYXRpb24gOiBAIiIpXSk7CiAgICAgfSBlbHNlCiAgICAgICAg IHNldHRpbmdzLT5zZXRVc2VyU3R5bGVTaGVldExvY2F0aW9uKFtOU1VSTCBVUkxXaXRoU3RyaW5n OkAiIl0pOwo=