33347 2010-01-07 14:59:38 -0800 [v8] regression: didDestroyScriptContextForFrame no longer called 2010-01-08 10:54:57 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 mpcomplete mpcomplete abarth webkit.review.bot oldest_to_newest 178396 0 mpcomplete 2010-01-07 14:59:38 -0800 This call seems to have gotten lost in the V8Proxy refactoring. I just need to add it back to V8DOMWindowShell::disposeContextHandles. 178399 1 46089 mpcomplete 2010-01-07 15:11:27 -0800 Created attachment 46089 add the call back 178402 2 webkit.review.bot 2010-01-07 15:14:44 -0800 style-queue ran check-webkit-style on attachment 46089 without any errors. 178416 3 46089 abarth 2010-01-07 15:43:39 -0800 Comment on attachment 46089 add the call back Looks good. Sorry I dropped the call. :( 178719 4 46089 abarth 2010-01-08 10:54:51 -0800 Comment on attachment 46089 add the call back Clearing flags on attachment: 46089 Committed r52996: <http://trac.webkit.org/changeset/52996> 178720 5 abarth 2010-01-08 10:54:57 -0800 All reviewed patches have been landed. Closing bug. 46089 2010-01-07 15:11:27 -0800 2010-01-08 10:54:50 -0800 add the call back context.patch text/plain 1166 mpcomplete SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gV2ViQ29yZS9DaGFuZ2VM b2cJKHJldmlzaW9uIDUyOTUyKQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkK QEAgLTEsMyArMSwxNCBAQAorMjAxMC0wMS0wNyAgTWF0dCBQZXJyeSAgPG1wY29tcGxldGVAY2hy b21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEZpeCBhIHJlZ3Jlc3Npb24gdGhhdCByZW1vdmVkIGEgY2FsbCB0bworICAgICAgICBGcmFt ZUxvYWRlckNsaWVudDo6ZGlkRGVzdHJveVNjcmlwdENvbnRleHRGb3JGcmFtZS4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMzMzQ3CisKKyAgICAgICAg KiBiaW5kaW5ncy92OC9WOERPTVdpbmRvd1NoZWxsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlY4 RE9NV2luZG93U2hlbGw6OmRpc3Bvc2VDb250ZXh0SGFuZGxlcyk6CisKIDIwMTAtMDEtMDcgIE5h dGUgQ2hhcGluICA8amFwaGV0QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBE aW1pdHJpIEdsYXprb3YuCkluZGV4OiBXZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV2luZG93U2hl bGwuY3BwDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09DQotLS0gV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdpbmRvd1No ZWxsLmNwcAkocmV2aXNpb24gNTI5NTIpCisrKyBXZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV2lu ZG93U2hlbGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNDQsNiArMTQ0LDcgQEAgYm9vbCBWOERP TVdpbmRvd1NoZWxsOjppc0NvbnRleHRJbml0aWFsaQogdm9pZCBWOERPTVdpbmRvd1NoZWxsOjpk aXNwb3NlQ29udGV4dEhhbmRsZXMoKQogewogICAgIGlmICghbV9jb250ZXh0LklzRW1wdHkoKSkg eworICAgICAgICBtX2ZyYW1lLT5sb2FkZXIoKS0+Y2xpZW50KCktPmRpZERlc3Ryb3lTY3JpcHRD b250ZXh0Rm9yRnJhbWUoKTsKICAgICAgICAgbV9jb250ZXh0LkRpc3Bvc2UoKTsKICAgICAgICAg bV9jb250ZXh0LkNsZWFyKCk7CiAgICAgfQo=