33344 2010-01-07 13:46:25 -0800 [Qt] unskip plugins/get-url-that-the-resource-load-delegate-will-disallow.html 2010-06-21 15:17:45 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 0 robert webkit-unassigned abarth eric ossy webkit.review.bot oldest_to_newest 178368 0 robert 2010-01-07 13:46:25 -0800 The code that this test relates to is gone. It was added by http://trac.webkit.org/changeset/20694, which fixed a crash in WebKit/Plugins/WebNetscapePluginStream.mm. The crash was caused by the lines removed below: loader->documentLoader()->addPlugInStreamLoader(_loader); - if (!_loader->load(request)) - _loader->documentLoader()->removePlugInStreamLoader(_loader); + _loader->load(request); The implementation is now shared, or at least WebBaseNetscapePluginStream.mm maintains a copy of PluginStream.cpp which has always had: void PluginStream::start() { ASSERT(!m_loadManually); m_loader = NetscapePlugInStreamLoader::create(m_frame, this); m_loader->setShouldBufferData(false); m_loader->documentLoader()->addPlugInStreamLoader(m_loader.get()); m_loader->load(m_resourceRequest); } Also, the crash situation doesn't arise for ports that do not implement a ResourceLoadDelegate. So should such ports implement the layoutTestController method the test requires and some drt specific code into the frameloaders to pass this test or should it be removed/moved to platform-specific tests? 237950 1 58677 robert 2010-06-14 11:44:01 -0700 Created attachment 58677 Patch 240616 2 ossy 2010-06-21 00:41:53 -0700 (In reply to comment #1) > Created an attachment (id=58677) [details] > Patch LGTM, but you only missed unskipping plugins/get-url-that-the-resource-load-delegate-will-disallow.html 240881 3 59287 robert 2010-06-21 14:13:11 -0700 Created attachment 59287 Patch 240885 4 robert 2010-06-21 14:15:12 -0700 (In reply to comment #2) > (In reply to comment #1) > > Created an attachment (id=58677) [details] [details] > > Patch > > LGTM, but you only missed unskipping plugins/get-url-that-the-resource-load-delegate-will-disallow.html whoops! 240900 5 robert 2010-06-21 14:39:45 -0700 Committed r61580: <http://trac.webkit.org/changeset/61580> 240917 6 webkit.review.bot 2010-06-21 15:17:45 -0700 http://trac.webkit.org/changeset/61580 might have broken SnowLeopard Intel Release (Tests) The following changes are on the blame list: http://trac.webkit.org/changeset/61579 http://trac.webkit.org/changeset/61580 58677 2010-06-14 11:44:01 -0700 2010-06-21 14:13:06 -0700 Patch bug-33344-20100614194359.patch text/plain 1757 robert ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAxM2Q5ZjIwMWUxM2Q0YjY2ZWY5NDZhYmQxM2U4YjdkMDJkYzMxOWRlLi5hMzIyYzU3 OGNjN2EwOTRjYmM1YzU2NmJhNGJjZDY1MmQzY2UzYjI1IDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAK KzIwMTAtMDYtMTQgIFJvYmVydCBIb2dhbiAgPHJvYmVydEB3ZWJraXQub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gVW5za2lwIHBsdWdp bnMvZ2V0LXVybC10aGF0LXRoZS1yZXNvdXJjZS1sb2FkLWRlbGVnYXRlLXdpbGwtZGlzYWxsb3cu aHRtbAorCisgICAgICAgIEl0J3MgYSBNYWMtc3BlY2lmaWMgdGVzdCBzbyBqdXN0IGFkZCB0aGUg cmVxdWlyZWQgTGF5b3V0VGVzdENvbnRyb2xsZXIKKyAgICAgICAgZnVuY3Rpb24gYXMgYSBuby1v cCB0byBhdm9pZCBmYWlsaW5nLiBTaW1pbGFyIGFwcHJvYWNoIGFkb3B0ZWQgYnkgb3RoZXIKKyAg ICAgICAgcG9ydHMuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTMzMzQ0CisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9xdC9MYXlvdXRUZXN0Q29u dHJvbGxlclF0Lmg6CisgICAgICAgIChMYXlvdXRUZXN0Q29udHJvbGxlcjo6YWRkRGlzYWxsb3dl ZFVSTCk6CisKIDIwMTAtMDYtMTQgIE1haGVzaCBLdWxrYXJuaSAgPG1haGVzaC5rdWxrYXJuaUBu b2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTGFzemxvIEdvbWJvcy4KZGlmZiAtLWdp dCBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0xheW91dFRlc3RDb250cm9sbGVyUXQu aCBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0xheW91dFRlc3RDb250cm9sbGVyUXQu aAppbmRleCBhMDQxYWQwNzk1YjE5ODUwOTZlNjNjMGEzOGU3N2UyM2RiOGIzMDQ0Li5kNDNiZjcx ZGZjYWZkNDdjYjQ3YmE0YmRkODlkNjA0ZjU0Mjc5OTFjIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9EdW1wUmVuZGVyVHJlZS9xdC9MYXlvdXRUZXN0Q29udHJvbGxlclF0LmgKKysrIGIvV2ViS2l0 VG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvTGF5b3V0VGVzdENvbnRyb2xsZXJRdC5oCkBAIC0xODMs NiArMTgzLDEwIEBAIHB1YmxpYyBzbG90czoKICAgICAvLyBGb3Igbm93LCB0aGlzIGlzIGEgbm8t b3AuIFRoaXMgbWF5IGNoYW5nZSBkZXBlbmRpbmcgb24gb3V0Y29tZSBvZgogICAgIC8vIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzMzMwogICAgIHZvaWQgc2V0Q2Fs bENsb3NlT25XZWJWaWV3cygpIHt9CisgICAgLy8gVGhpcyBpcyBhIG5vLW9wIC0gaXQgYWxsb3dz IHVzIHRvIHBhc3MKKyAgICAvLyBwbHVnaW5zL2dldC11cmwtdGhhdC10aGUtcmVzb3VyY2UtbG9h ZC1kZWxlZ2F0ZS13aWxsLWRpc2FsbG93Lmh0bWwKKyAgICAvLyB3aGljaCBpcyBhIE1hYy1zcGVj aWZpYyB0ZXN0LgorICAgIHZvaWQgYWRkRGlzYWxsb3dlZFVSTChjb25zdCBRU3RyaW5nJikge30K IAogICAgIHZvaWQgc2V0TW9ja0dlb2xvY2F0aW9uRXJyb3IoaW50IGNvZGUsIGNvbnN0IFFTdHJp bmcmIG1lc3NhZ2UpOwogICAgIHZvaWQgc2V0TW9ja0dlb2xvY2F0aW9uUG9zaXRpb24oZG91Ymxl IGxhdGl0dWRlLCBkb3VibGUgbG9uZ2l0dWRlLCBkb3VibGUgYWNjdXJhY3kpOwo= 59287 2010-06-21 14:13:11 -0700 2010-06-21 14:27:13 -0700 Patch bug-33344-20100621221309.patch text/plain 3281 robert ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBiM2Y3NjFlODNjYzU4ZjU4YWExNGU4MDE2NDRlOWM0ZDdjOWRkZGE0Li4yZDVhMWI5 NTg2ZDgwOTNkNjczZjhmMjhlMzQ2MWIzN2UxNzc5ZTU4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTkgQEAK IDIwMTAtMDYtMjEgIFJvYmVydCBIb2dhbiAgPHJvYmVydEB3ZWJraXQub3JnPgogCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gVW5za2lwIHBsdWdp bnMvZ2V0LXVybC10aGF0LXRoZS1yZXNvdXJjZS1sb2FkLWRlbGVnYXRlLXdpbGwtZGlzYWxsb3cu aHRtbAorCisgICAgICAgIEl0J3MgYSBNYWMtc3BlY2lmaWMgdGVzdCBzbyBqdXN0IGFkZCB0aGUg cmVxdWlyZWQgTGF5b3V0VGVzdENvbnRyb2xsZXIKKyAgICAgICAgZnVuY3Rpb24gYXMgYSBuby1v cCB0byBhdm9pZCBmYWlsaW5nLiBTaW1pbGFyIGFwcHJvYWNoIGFkb3B0ZWQgYnkgb3RoZXIKKyAg ICAgICAgcG9ydHMuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTMzMzQ0CisKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9Ta2lwcGVkOgorCisyMDEwLTA2 LTIxICBSb2JlcnQgSG9nYW4gIDxyb2JlcnRAd2Via2l0Lm9yZz4KKwogICAgICAgICBSZXZpZXdl ZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbi4KIAogICAgICAgICBbUXRdIE1pc3Npbmcg Zm9yd2FyZCBlbnRyaWVzIHdoZW4gZHVtcGluZyBiYWNrL2ZvcndhcmQgbGlzdApkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZCBiL0xheW91dFRlc3RzL3BsYXRmb3Jt L3F0L1NraXBwZWQKaW5kZXggNDliOGIzYzA3MDAzZjFmNWY4ZGE1NjhlZTkxY2M5OGFiOTI1Yjg2 Yi4uNzIyYzRiODA4ZTJkYzliZWY3MDZlNGJhNzhmNmQ5MjNmZWI0ZWUxNiAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9xdC9Ta2lwcGVkCkBAIC00MTYsOCArNDE2LDYgQEAgZWRpdGluZy9wYXN0ZWJvYXJkL2dldC1k YXRhLXRleHQtcGxhaW4tZHJvcC5odG1sCiAjICAgICAgIEZhaWxpbmcgcGx1Z2lucyB0ZXN0cy4g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAjCiAjID09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PSAjCiAKLSMgLS0tLSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MzMzNDQKLXBsdWdpbnMvZ2V0LXVybC10aGF0LXRoZS1yZXNvdXJjZS1sb2FkLWRl bGVnYXRlLXdpbGwtZGlzYWxsb3cuaHRtbAogIyAtLS0tIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0zNjcyMQogcGx1Z2lucy9nZXQtdXJsLXdpdGgtYmxhbmstdGFyZ2V0 Lmh0bWwKIApkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMv Q2hhbmdlTG9nCmluZGV4IDlhODg4YzZlOTBhNTU3YTQ3ZDAyZjUyNjIwOTVkOGIzNzc5ODIwYTUu Ljk5MjM2YzYzNTFiM2FiMTQ4OTU4MDcwNjU5NDU2NDQzYjhkMTE0MDggMTAwNjQ0Ci0tLSBhL1dl YktpdFRvb2xzL0NoYW5nZUxvZworKysgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxOCBAQAorMjAxMC0wNi0yMSAgUm9iZXJ0IEhvZ2FuICA8cm9iZXJ0QHdlYmtpdC5vcmc+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBVbnNr aXAgcGx1Z2lucy9nZXQtdXJsLXRoYXQtdGhlLXJlc291cmNlLWxvYWQtZGVsZWdhdGUtd2lsbC1k aXNhbGxvdy5odG1sCisKKyAgICAgICAgSXQncyBhIE1hYy1zcGVjaWZpYyB0ZXN0IHNvIGp1c3Qg YWRkIHRoZSByZXF1aXJlZCBMYXlvdXRUZXN0Q29udHJvbGxlcgorICAgICAgICBmdW5jdGlvbiBh cyBhIG5vLW9wIHRvIGF2b2lkIGZhaWxpbmcuIFNpbWlsYXIgYXBwcm9hY2ggYWRvcHRlZCBieSBv dGhlcgorICAgICAgICBwb3J0cy4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MzMzNDQKKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL3F0L0xheW91 dFRlc3RDb250cm9sbGVyUXQuaDoKKyAgICAgICAgKExheW91dFRlc3RDb250cm9sbGVyOjphZGRE aXNhbGxvd2VkVVJMKToKKwogMjAxMC0wNi0yMSAgRHJldyBXaWxzb24gIDxhdHdpbHNvbkBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZC4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xz L0R1bXBSZW5kZXJUcmVlL3F0L0xheW91dFRlc3RDb250cm9sbGVyUXQuaCBiL1dlYktpdFRvb2xz L0R1bXBSZW5kZXJUcmVlL3F0L0xheW91dFRlc3RDb250cm9sbGVyUXQuaAppbmRleCA1NjE1ZDEy YzdmMmJiNTUxYmIwYzgxYWJiOWUwYzc1MTQxYTMxM2JiLi5iNTZmMWM5YzUxYjM1YjdkODVjZDFm ZDg5YWM5OTQ0ZDhkNmYwNmQ4IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJl ZS9xdC9MYXlvdXRUZXN0Q29udHJvbGxlclF0LmgKKysrIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRl clRyZWUvcXQvTGF5b3V0VGVzdENvbnRyb2xsZXJRdC5oCkBAIC0xODMsNiArMTgzLDEwIEBAIHB1 YmxpYyBzbG90czoKICAgICAvLyBGb3Igbm93LCB0aGlzIGlzIGEgbm8tb3AuIFRoaXMgbWF5IGNo YW5nZSBkZXBlbmRpbmcgb24gb3V0Y29tZSBvZgogICAgIC8vIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zMzMzMwogICAgIHZvaWQgc2V0Q2FsbENsb3NlT25XZWJWaWV3 cygpIHt9CisgICAgLy8gVGhpcyBpcyBhIG5vLW9wIC0gaXQgYWxsb3dzIHVzIHRvIHBhc3MKKyAg ICAvLyBwbHVnaW5zL2dldC11cmwtdGhhdC10aGUtcmVzb3VyY2UtbG9hZC1kZWxlZ2F0ZS13aWxs LWRpc2FsbG93Lmh0bWwKKyAgICAvLyB3aGljaCBpcyBhIE1hYy1zcGVjaWZpYyB0ZXN0LgorICAg IHZvaWQgYWRkRGlzYWxsb3dlZFVSTChjb25zdCBRU3RyaW5nJikge30KIAogICAgIHZvaWQgc2V0 TW9ja0dlb2xvY2F0aW9uRXJyb3IoaW50IGNvZGUsIGNvbnN0IFFTdHJpbmcmIG1lc3NhZ2UpOwog ICAgIHZvaWQgc2V0TW9ja0dlb2xvY2F0aW9uUG9zaXRpb24oZG91YmxlIGxhdGl0dWRlLCBkb3Vi bGUgbG9uZ2l0dWRlLCBkb3VibGUgYWNjdXJhY3kpOwo=