33341 2010-01-07 12:59:36 -0800 webkit-patch edit-changelogs (or upload) will open blank files if run outside the root 2010-01-07 20:58:23 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned abarth commit-queue webkit.review.bot oldest_to_newest 178336 0 eric 2010-01-07 12:59:36 -0800 webkit-patch edit-changelogs (or upload) will open blank files if run outside the root EditChangeLogs step probably needs to use absolute paths. The relative paths it currently uses are wrong any time you're not running it from the root of your checkout. This is bad news bears. Shows you a blank ChangeLog entry and creates a new directory (if you're using vi). 178373 1 46085 abarth 2010-01-07 14:01:07 -0800 Created attachment 46085 Patch 178377 2 webkit.review.bot 2010-01-07 14:09:13 -0800 style-queue ran check-webkit-style on attachment 46085 without any errors. 178382 3 46085 eric 2010-01-07 14:31:32 -0800 Comment on attachment 46085 Patch Hum... OK. We could also just make the paths be absolute. Sad there are no tests here. :( 178507 4 46085 commit-queue 2010-01-07 20:58:17 -0800 Comment on attachment 46085 Patch Clearing flags on attachment: 46085 Committed r52968: <http://trac.webkit.org/changeset/52968> 178508 5 commit-queue 2010-01-07 20:58:23 -0800 All reviewed patches have been landed. Closing bug. 46085 2010-01-07 14:01:07 -0800 2010-01-07 20:58:17 -0800 Patch bug-33341-20100107140105.patch text/plain 2273 abarth ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAyZjVhOTEzLi5lYzA4Nzc4IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDEt MDcgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICB3ZWJraXQtcGF0Y2ggZWRpdC1jaGFuZ2Vsb2dz IChvciB1cGxvYWQpIHdpbGwgb3BlbiBibGFuayBmaWxlcyBpZiBydW4gb3V0c2lkZSB0aGUgcm9v dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzMzNDEK KworICAgICAgICBGaXggdGhpcyBieSBtb3ZpbmcgdG8gdGhlIHJvb3QgZGlyZWN0b3J5IGJlZm9y ZSBlZGl0aW5nIENoYW5nZUxvZ3MuCisgICAgICAgIFRoZXJlIGlzIGEgcmVsYXRlZCBidWcgd2l0 aCBDaGVja1N0eWxlLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9zdGVwcy9jaGVja3N0 eWxlLnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3RlcHMvZWRpdGNoYW5nZWxvZy5w eToKKwogMjAxMC0wMS0wNyAgS2ltIEdyw7ZuaG9sbSAgPGtpbS5ncm9uaG9sbUBub21vdm9rLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbnR0aSBLb2l2aXN0by4KZGlmZiAtLWdpdCBhL1dl YktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3RlcHMvY2hlY2tzdHlsZS5weSBiL1dlYktpdFRv b2xzL1NjcmlwdHMvd2Via2l0cHkvc3RlcHMvY2hlY2tzdHlsZS5weQppbmRleCAwZTA2NTg1Li5j OGUyMGY4IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0ZXBzL2No ZWNrc3R5bGUucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdGVwcy9jaGVj a3N0eWxlLnB5CkBAIC0yNiw2ICsyNiw4IEBACiAjIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBP VEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRQogIyBPRiBUSElTIFNP RlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdF LgogCitpbXBvcnQgb3MKKwogZnJvbSB3ZWJraXRweS5leGVjdXRpdmUgaW1wb3J0IFNjcmlwdEVy cm9yCiBmcm9tIHdlYmtpdHB5LnN0ZXBzLmFic3RyYWN0c3RlcCBpbXBvcnQgQWJzdHJhY3RTdGVw CiBmcm9tIHdlYmtpdHB5LnN0ZXBzLm9wdGlvbnMgaW1wb3J0IE9wdGlvbnMKQEAgLTQyLDYgKzQ0 LDcgQEAgY2xhc3MgQ2hlY2tTdHlsZShBYnN0cmFjdFN0ZXApOgogICAgIGRlZiBydW4oc2VsZiwg c3RhdGUpOgogICAgICAgICBpZiBub3Qgc2VsZi5fb3B0aW9ucy5jaGVja19zdHlsZToKICAgICAg ICAgICAgIHJldHVybgorICAgICAgICBvcy5jaGRpcihzZWxmLl90b29sLnNjbSgpLmNoZWNrb3V0 X3Jvb3QpCiAgICAgICAgIHRyeToKICAgICAgICAgICAgIHNlbGYuX3J1bl9zY3JpcHQoImNoZWNr LXdlYmtpdC1zdHlsZSIpCiAgICAgICAgIGV4Y2VwdCBTY3JpcHRFcnJvciwgZToKZGlmZiAtLWdp dCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3RlcHMvZWRpdGNoYW5nZWxvZy5weSBi L1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3RlcHMvZWRpdGNoYW5nZWxvZy5weQppbmRl eCBiZGY3ZDY3Li5kNTQ1YzcyIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtp dHB5L3N0ZXBzL2VkaXRjaGFuZ2Vsb2cucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJr aXRweS9zdGVwcy9lZGl0Y2hhbmdlbG9nLnB5CkBAIC0yNiw5ICsyNiwxMiBAQAogIyAoSU5DTFVE SU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRI RSBVU0UKICMgT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJ TElUWSBPRiBTVUNIIERBTUFHRS4KIAoraW1wb3J0IG9zCisKIGZyb20gd2Via2l0cHkuc3RlcHMu YWJzdHJhY3RzdGVwIGltcG9ydCBBYnN0cmFjdFN0ZXAKIAogCiBjbGFzcyBFZGl0Q2hhbmdlTG9n KEFic3RyYWN0U3RlcCk6CiAgICAgZGVmIHJ1bihzZWxmLCBzdGF0ZSk6CisgICAgICAgIG9zLmNo ZGlyKHNlbGYuX3Rvb2wuc2NtKCkuY2hlY2tvdXRfcm9vdCkKICAgICAgICAgc2VsZi5fdG9vbC51 c2VyLmVkaXQoc2VsZi5jYWNoZWRfbG9va3VwKHN0YXRlLCAiY2hhbmdlbG9ncyIpKQo=