33327 2010-01-07 10:07:37 -0800 [GTK] Expose the IM context via the API 2010-02-09 07:12:32 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 mrobinson webkit-unassigned christian commit-queue gustavo otte pclouds webkit.review.bot xan.lopez oldest_to_newest 178241 0 mrobinson 2010-01-07 10:07:37 -0800 Exposing the IM context of the WebView will allow embedders to recreate the IM context menu items and make possible more extensive unit tests against IM context behavior. 178248 1 46062 mrobinson 2010-01-07 10:16:35 -0800 Created attachment 46062 Patch for this feature 178249 2 webkit.review.bot 2010-01-07 10:17:57 -0800 Attachment 46062 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKit/gtk/webkit/webkitwebview.cpp:4090: Use 0 instead of NULL. [readability/null] [5] WebKit/gtk/webkit/webkitwebview.h:379: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 178250 3 otte 2010-01-07 10:22:57 -0800 I'd mirror the behavior of GtkEntry and GtkTextView here. I was about to say "and they don't expose it" but they grew an "im-module" property (no accessors) in 2.16. Would that work for your use cases? 178334 4 mrobinson 2010-01-07 12:58:25 -0800 From IRC: We determined that this wouldn't work for the use cases that I listed, because im-module only let's you set the type of im-module that the widget uses. We need a handle on the actual IM context instance that the view creates on initialization. 178413 5 gustavo 2010-01-07 15:37:15 -0800 FWIW, I think we should go ahead with the proposed API - perhaps turned into a read-only property that exposes the actual object. What does Xan think, I wonder? =) 184630 6 christian 2010-01-26 10:57:13 -0800 Whether a property or function, it should return a GtkIMContext*, which is what gtk_im_multicontext_new also returns. 184746 7 46062 eric 2010-01-26 14:36:04 -0800 Comment on attachment 46062 Patch for this feature Comments above seem to suggest this has the wrong return value. r- Please re-flag if you disagree. 184981 8 47504 mrobinson 2010-01-27 00:31:39 -0800 Created attachment 47504 Updated patch (fixes style issues and passes tests) Based on all the comments I received, I'm attaching a new patch for this issue which exposes the context as a property of the WebKitWebView of type GtkIMContext. 185029 9 47504 gustavo 2010-01-27 04:28:06 -0800 Comment on attachment 47504 Updated patch (fixes style issues and passes tests) > + Expose the GtkIMMultiContext as a property of WebKitWebView. This will > + allow embedders to generate the input method context menu entires and s/entires/entries/ > + * This is the input method context used for all text entry widgets inside > + * the #WebKitWebView. It can be used to generate context menu items for > + * controlling the active input method. g_object_unref does not need to be > + * called after retrieving this property. I don't think this is true. g_object_get will increase the ref count of the object it is getting, so you need to unref it, right? You could say that the WebView is the owner of the object, though. 185092 10 47532 mrobinson 2010-01-27 07:39:12 -0800 Created attachment 47532 Updated patch (fix documentation mistakes) Whoops. Working late again. Thanks for the review. I've attached a patch fixing those issues. 185312 11 47532 gustavo 2010-01-27 19:02:26 -0800 Comment on attachment 47532 Updated patch (fix documentation mistakes) Looks good, thanks! 185313 12 47532 commit-queue 2010-01-27 19:22:43 -0800 Comment on attachment 47532 Updated patch (fix documentation mistakes) Clearing flags on attachment: 47532 Committed r53967: <http://trac.webkit.org/changeset/53967> 185314 13 commit-queue 2010-01-27 19:22:49 -0800 All reviewed patches have been landed. Closing bug. 187340 14 pclouds 2010-02-03 06:45:31 -0800 *** Bug 33103 has been marked as a duplicate of this bug. *** 188989 15 otte 2010-02-09 07:12:32 -0800 Some quotes from IRC, where exposing IM contexts came up today: <Company> webkit-gtk is exposing the im context, too <Company> because it wants to give developers control over the right-click menu <Company> and you cannot do that sanely without the im context <Company> (i think there was another reason, but don't remember it) <pbor> Company: uh? what does the menu have to do with it? <Company> pbor: you need to add the im context menu options <pbor> Company: e.g. textview has a popupmenu signal that you can use to extend the menu <Company> pbor: yeah, but you cannot use it to create your own menu in a sane way <mclasen> Company: I can't stop people from doing such things....but in gtk3 the im context is not going to be available... <mclasen> I don't really see how you need the context at all for that <mclasen> we do have the id of the current im as a property on the widget now <Company> mclasen, pbor: https://bugs.webkit.org/show_bug.cgi?id=33327 * mclasen not impressed <mclasen> with webkit exposing gtk interna <Company> mclasen: how would you solve the problem (of having an API for right-click menus)? <mclasen> Company: I would start by describing my needs in a gtk bug... <mclasen> Company: that bug should also explain how the populate-popup signals are insufficient... 46062 2010-01-07 10:16:35 -0800 2010-01-27 00:31:39 -0800 Patch for this feature 0001-Expose-the-GTK-IM-context-via-the-API.patch text/plain 2683 mrobinson RnJvbSA1YzRjOGQxZmNlOTNkNWZlZWY2N2VjZGUwNDFhOGUzNDVlODU5YThjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJ0aW4gUm9iaW5zb24gPG1hcnRpbi5qYW1lcy5yb2JpbnNv bkBnbWFpbC5jb20+CkRhdGU6IFRodSwgNyBKYW4gMjAxMCAxMDowNDozNCAtMDgwMApTdWJqZWN0 OiBbUEFUQ0hdIEV4cG9zZSB0aGUgR1RLKyBJTSBjb250ZXh0IHZpYSB0aGUgQVBJLgoKLS0tCiBX ZWJLaXQvZ3RrL0NoYW5nZUxvZyAgICAgICAgICAgICAgICB8ICAgMTMgKysrKysrKysrKysrKwog V2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAgfCAgIDE5ICsrKysrKysrKysrKysr KysrKysKIFdlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuaCAgIHwgICAgMyArKysKIDMg ZmlsZXMgY2hhbmdlZCwgMzUgaW5zZXJ0aW9ucygrKSwgMCBkZWxldGlvbnMoLSkKCmRpZmYgLS1n aXQgYS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyBiL1dlYktpdC9ndGsvQ2hhbmdlTG9nCmluZGV4IGNj NmQxMmUuLmEwMzdhOTQgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nCisrKyBiL1dl YktpdC9ndGsvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDEtMDcgIE1hcnRpbiBS b2JpbnNvbiAgPG1hcnRpbi5qYW1lcy5yb2JpbnNvbkBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gRXhwb3NlIHRoZSBJTSBj b250ZXh0IHZpYSB0aGUgQVBJCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0zMzMyNworCisgICAgICAgIEV4cG9zZSB0aGUgR1RLKyBJTSBjb250ZXh0IHZp YSB0aGUgQVBJLgorCisgICAgICAgICogd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwOgorICAgICAg ICAod2Via2l0X3dlYl92aWV3X2dldF9pbV9jb250ZXh0KToKKyAgICAgICAgKiB3ZWJraXQvd2Vi a2l0d2Vidmlldy5oOgorCiAyMDEwLTAxLTA2ICBKb2FubWFyaWUgRGlnZ3MgIDxqb2FubWFyaWUu ZGlnZ3NAZ21haWwuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFhhbiBMb3Blei4KZGlmZiAt LWdpdCBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwIGIvV2ViS2l0L2d0ay93 ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKaW5kZXggMmQyZTZlNy4uN2JjMmE0OSAxMDA2NDQKLS0t IGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKKysrIGIvV2ViS2l0L2d0ay93 ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKQEAgLTQwNzMsNiArNDA3MywyNSBAQCBHX0NPTlNUX1JF VFVSTiBnY2hhciogd2Via2l0X3dlYl92aWV3X2dldF9pY29uX3VyaShXZWJLaXRXZWJWaWV3KiB3 ZWJWaWV3KQogfQogCiAvKioKKyAqIHdlYmtpdF93ZWJfdmlld19nZXRfaW1fY29udGV4dAorICog QHdlYl92aWV3OiB0aGUgI1dlYktpdFdlYlZpZXcgb2JqZWN0CisgKgorICogT2J0YWlucyB0aGUg R3RrSU1NdWx0aWNvbnRleHQgZnJvbSB0aGUgZ2l2ZW4gI1dlYktpdFdlYlZpZXcuIFRoaXMgY2Fu CisgKiBiZSB1c2VkIHRvIGdlbmVyYXRlIGNvbnRleHQgbWVudSBpdGVtcyBmb3IgY29udHJvbGxp bmcgdGhlIGN1cnJlbnQgaW5wdXQKKyAqIG1ldGhvZC4KKyAqCisgKiBSZXR1cm4gdmFsdWU6IHRo ZSBHdGtJTU11bHRpY29udGV4dCBvZiB0aGUgZ2l2ZW4gI1dlYktpdFdlYlZpZXcuCisgKgorICog U2luY2UgMS4xLjE5CisgKi8KKworR19DT05TVF9SRVRVUk4gR3RrSU1NdWx0aWNvbnRleHQqIHdl YmtpdF93ZWJfdmlld19nZXRfaW1fY29udGV4dChXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3KQorewor ICAgIGdfcmV0dXJuX3ZhbF9pZl9mYWlsKFdFQktJVF9JU19XRUJfVklFVyh3ZWJWaWV3KSwgTlVM TCk7CisgICAgcmV0dXJuIEdUS19JTV9NVUxUSUNPTlRFWFQod2ViVmlldy0+cHJpdi0+aW1Db250 ZXh0KTsKK30KKworLyoqCiAgKiB3ZWJraXRfc2V0X2NhY2hlX21vZGVsOgogICogQGNhY2hlX21v ZGVsOiBhICNXZWJLaXRDYWNoZU1vZGVsCiAgKgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay93ZWJr aXQvd2Via2l0d2Vidmlldy5oIGIvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5oCmlu ZGV4IGU2OWRlMGEuLjI2NWYxOTMgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvd2Via2l0L3dlYmtp dHdlYnZpZXcuaAorKysgYi9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmgKQEAgLTM3 NSw2ICszNzUsOSBAQCB3ZWJraXRfd2ViX3ZpZXdfZ2V0X2hpdF90ZXN0X3Jlc3VsdCAgICAgICAg ICAgICAoV2ViS2l0V2ViVmlldyAgICAgICAgKndlYlZpZXcsCiBXRUJLSVRfQVBJIEdfQ09OU1Rf UkVUVVJOIGdjaGFyICoKIHdlYmtpdF93ZWJfdmlld19nZXRfaWNvbl91cmkgICAgICAgICAgICAg ICAgICAgIChXZWJLaXRXZWJWaWV3ICAgICAgICAqd2ViVmlldyk7CiAKK1dFQktJVF9BUEkgR19D T05TVF9SRVRVUk4gR3RrSU1NdWx0aWNvbnRleHQqCit3ZWJraXRfd2ViX3ZpZXdfZ2V0X2ltX2Nv bnRleHQgICAgICAgICAgICAgICAgICAoV2ViS2l0V2ViVmlldyAgICAgICAgKndlYlZpZXcpOwor CiBXRUJLSVRfQVBJIHZvaWQKIHdlYmtpdF9zZXRfY2FjaGVfbW9kZWwgICAgICAgICAgICAgICAg ICAgICAgICAgIChXZWJLaXRDYWNoZU1vZGVsICAgICBjYWNoZV9tb2RlbCk7CiAKLS0gCjEuNi4z LjMKCg== 47504 2010-01-27 00:31:39 -0800 2010-01-27 07:39:12 -0800 Updated patch (fixes style issues and passes tests) 0001-Expose-the-GtkIMMultiContext-as-a-property-of-WebKit.patch text/plain 4437 mrobinson RnJvbSAzNzQxMzliNGMzM2Q4ZjJhNWYwNjdiODhmZDY2NTU5MjNmZDk0ODFmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJ0aW4gUm9iaW5zb24gPG1yb2JpbnNvbkB3ZWJraXQub3Jn PgpEYXRlOiBXZWQsIDI3IEphbiAyMDEwIDAwOjI1OjM4IC0wODAwClN1YmplY3Q6IFtQQVRDSF0g RXhwb3NlIHRoZSBHdGtJTU11bHRpQ29udGV4dCBhcyBhIHByb3BlcnR5IG9mIFdlYktpdFdlYlZp ZXcuCgotLS0KIFdlYktpdC9ndGsvQ2hhbmdlTG9nICAgICAgICAgICAgICAgIHwgICAxNiArKysr KysrKysrKysrKysrCiBXZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcCB8ICAgMzIg KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0KIDIgZmlsZXMgY2hhbmdlZCwgNDcgaW5z ZXJ0aW9ucygrKSwgMSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL0NoYW5n ZUxvZyBiL1dlYktpdC9ndGsvQ2hhbmdlTG9nCmluZGV4IGI1OTZhOGYuLjc4Zjk5MjkgMTAwNjQ0 Ci0tLSBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nCisrKyBiL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMDEtMjcgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkB3 ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFtHVEtdIEV4cG9zZSB0aGUgSU0gY29udGV4dCB2aWEgdGhlIEFQSQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzMzMjcKKworICAgICAgICBFeHBv c2UgdGhlIEd0a0lNTXVsdGlDb250ZXh0IGFzIGEgcHJvcGVydHkgb2YgV2ViS2l0V2ViVmlldy4g VGhpcyB3aWxsCisgICAgICAgIGFsbG93IGVtYmVkZGVycyB0byBnZW5lcmF0ZSB0aGUgaW5wdXQg bWV0aG9kIGNvbnRleHQgbWVudSBlbnRpcmVzIGFuZAorICAgICAgICBtYWtlIHRlc3RpbmcgY2Vy dGFpbiBJTSBjb250ZXh0IGJlaGF2aW9yIHBvc3NpYmxlLgorCisgICAgICAgICogd2Via2l0L3dl YmtpdHdlYnZpZXcuY3BwOgorICAgICAgICAod2Via2l0X3dlYl92aWV3X2dldF9wcm9wZXJ0eSk6 CisgICAgICAgIChETkRDb250ZW50c1JlcXVlc3Q6OndlYmtpdF93ZWJfdmlld19nZXRfaW1fY29u dGV4dCk6CisgICAgICAgIChETkRDb250ZW50c1JlcXVlc3Q6OndlYmtpdF93ZWJfdmlld19jbGFz c19pbml0KToKKwogMjAxMC0wMS0xOSAgSm9hbm1hcmllIERpZ2dzICA8am9hbm1hcmllLmRpZ2dz QGdtYWlsLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBYYW4gTG9wZXouCmRpZmYgLS1naXQg YS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcCBiL1dlYktpdC9ndGsvd2Via2l0 L3dlYmtpdHdlYnZpZXcuY3BwCmluZGV4IGE0MTE5MWQuLjcyYzhhOGEgMTAwNjQ0Ci0tLSBhL1dl YktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCisrKyBiL1dlYktpdC9ndGsvd2Via2l0 L3dlYmtpdHdlYnZpZXcuY3BwCkBAIC0xNzksNyArMTc5LDggQEAgZW51bSB7CiAgICAgUFJPUF9Q Uk9HUkVTUywKICAgICBQUk9QX0VOQ09ESU5HLAogICAgIFBST1BfQ1VTVE9NX0VOQ09ESU5HLAot ICAgIFBST1BfSUNPTl9VUkkKKyAgICBQUk9QX0lDT05fVVJJLAorICAgIFBST1BfSU1fQ09OVEVY VAogfTsKIAogc3RhdGljIGd1aW50IHdlYmtpdF93ZWJfdmlld19zaWduYWxzW0xBU1RfU0lHTkFM XSA9IHsgMCwgfTsKQEAgLTE4OSw2ICsxOTAsOCBAQCBHX0RFRklORV9UWVBFKFdlYktpdFdlYlZp ZXcsIHdlYmtpdF93ZWJfdmlldywgR1RLX1RZUEVfQ09OVEFJTkVSKQogc3RhdGljIHZvaWQgd2Vi a2l0X3dlYl92aWV3X3NldHRpbmdzX25vdGlmeShXZWJLaXRXZWJTZXR0aW5ncyogd2ViU2V0dGlu Z3MsIEdQYXJhbVNwZWMqIHBzcGVjLCBXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3KTsKIHN0YXRpYyB2 b2lkIHdlYmtpdF93ZWJfdmlld19zZXRfd2luZG93X2ZlYXR1cmVzKFdlYktpdFdlYlZpZXcqIHdl YlZpZXcsIFdlYktpdFdlYldpbmRvd0ZlYXR1cmVzKiB3ZWJXaW5kb3dGZWF0dXJlcyk7CiAKK3N0 YXRpYyBHdGtJTUNvbnRleHQqIHdlYmtpdF93ZWJfdmlld19nZXRfaW1fY29udGV4dChXZWJLaXRX ZWJWaWV3Kik7CisKIHN0YXRpYyB2b2lkIGRlc3Ryb3lfbWVudV9jYihHdGtPYmplY3QqIG9iamVj dCwgZ3BvaW50ZXIgZGF0YSkKIHsKICAgICBXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3ID0gV0VCS0lU X1dFQl9WSUVXKGRhdGEpOwpAQCAtMzg0LDYgKzM4Nyw5IEBAIHN0YXRpYyB2b2lkIHdlYmtpdF93 ZWJfdmlld19nZXRfcHJvcGVydHkoR09iamVjdCogb2JqZWN0LCBndWludCBwcm9wX2lkLCBHVmFs dWUqCiAgICAgY2FzZSBQUk9QX0lDT05fVVJJOgogICAgICAgICBnX3ZhbHVlX3NldF9zdHJpbmco dmFsdWUsIHdlYmtpdF93ZWJfdmlld19nZXRfaWNvbl91cmkod2ViVmlldykpOwogICAgICAgICBi cmVhazsKKyAgICBjYXNlIFBST1BfSU1fQ09OVEVYVDoKKyAgICAgICAgZ192YWx1ZV9zZXRfb2Jq ZWN0KHZhbHVlLCB3ZWJraXRfd2ViX3ZpZXdfZ2V0X2ltX2NvbnRleHQod2ViVmlldykpOworICAg ICAgICBicmVhazsKICAgICBkZWZhdWx0OgogICAgICAgICBHX09CSkVDVF9XQVJOX0lOVkFMSURf UFJPUEVSVFlfSUQob2JqZWN0LCBwcm9wX2lkLCBwc3BlYyk7CiAgICAgfQpAQCAtMTI5OSw2ICsx MzA1LDEyIEBAIHN0YXRpYyBnYm9vbGVhbiB3ZWJraXRfd2ViX3ZpZXdfcXVlcnlfdG9vbHRpcChH dGtXaWRnZXQgKndpZGdldCwgZ2ludCB4LCBnaW50IHksCiB9CiAjZW5kaWYKIAorc3RhdGljIEd0 a0lNQ29udGV4dCogd2Via2l0X3dlYl92aWV3X2dldF9pbV9jb250ZXh0KFdlYktpdFdlYlZpZXcq IHdlYlZpZXcpCit7CisgICAgZ19yZXR1cm5fdmFsX2lmX2ZhaWwoV0VCS0lUX0lTX1dFQl9WSUVX KHdlYlZpZXcpLCAwKTsKKyAgICByZXR1cm4gR1RLX0lNX0NPTlRFWFQod2ViVmlldy0+cHJpdi0+ aW1Db250ZXh0KTsKK30KKwogc3RhdGljIHZvaWQgd2Via2l0X3dlYl92aWV3X2NsYXNzX2luaXQo V2ViS2l0V2ViVmlld0NsYXNzKiB3ZWJWaWV3Q2xhc3MpCiB7CiAgICAgR3RrQmluZGluZ1NldCog YmluZGluZ19zZXQ7CkBAIC0yNDgxLDYgKzI0OTMsMjQgQEAgc3RhdGljIHZvaWQgd2Via2l0X3dl Yl92aWV3X2NsYXNzX2luaXQoV2ViS2l0V2ViVmlld0NsYXNzKiB3ZWJWaWV3Q2xhc3MpCiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIF8oIlRo ZSBVUkkgZm9yIHRoZSBmYXZpY29uIGZvciB0aGUgI1dlYktpdFdlYlZpZXcuIiksCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIE5VTEwsCiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFdF QktJVF9QQVJBTV9SRUFEQUJMRSkpOworICAgIC8qKgorICAgICogV2ViS2l0V2ViVmlldzppbS1j b250ZXh0OgorICAgICoKKyAgICAqIFRoZSBHdGtJTU11bHRpY29udGV4dCBmb3IgdGhlICNXZWJL aXRXZWJWaWV3LgorICAgICoKKyAgICAqIFRoaXMgaXMgdGhlIGlucHV0IG1ldGhvZCBjb250ZXh0 IHVzZWQgZm9yIGFsbCB0ZXh0IGVudHJ5IHdpZGdldHMgaW5zaWRlCisgICAgKiB0aGUgI1dlYktp dFdlYlZpZXcuIEl0IGNhbiBiZSB1c2VkIHRvIGdlbmVyYXRlIGNvbnRleHQgbWVudSBpdGVtcyBm b3IKKyAgICAqIGNvbnRyb2xsaW5nIHRoZSBhY3RpdmUgaW5wdXQgbWV0aG9kLiBnX29iamVjdF91 bnJlZiBkb2VzIG5vdCBuZWVkIHRvIGJlCisgICAgKiBjYWxsZWQgYWZ0ZXIgcmV0cmlldmluZyB0 aGlzIHByb3BlcnR5LgorICAgICoKKyAgICAqIFNpbmNlOiAxLjEuMjAKKyAgICAqLworICAgIGdf b2JqZWN0X2NsYXNzX2luc3RhbGxfcHJvcGVydHkob2JqZWN0Q2xhc3MsIFBST1BfSU1fQ09OVEVY VCwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGdfcGFyYW1fc3BlY19vYmpl Y3QoImltLWNvbnRleHQiLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAiSU0gQ29udGV4dCIsCisgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJUaGUgR3RrSU1NdWx0aUNvbnRleHQgZm9y IHRoZSAjV2ViS2l0V2ViVmlldy4iLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBHVEtfVFlQRV9JTV9DT05URVhULAorICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBXRUJLSVRfUEFSQU1f UkVBREFCTEUpKTsKIAogICAgIGdfdHlwZV9jbGFzc19hZGRfcHJpdmF0ZSh3ZWJWaWV3Q2xhc3Ms IHNpemVvZihXZWJLaXRXZWJWaWV3UHJpdmF0ZSkpOwogfQotLSAKMS42LjMuMwoK 47532 2010-01-27 07:39:12 -0800 2010-01-27 19:22:42 -0800 Updated patch (fix documentation mistakes) 0001-Expose-the-GtkIMMultiContext-as-a-property-of-WebKit.patch text/plain 4355 mrobinson RnJvbSBjMjg2ZjkzZGEwMWRjNjU1Y2VmOTAyOGQwZDRiM2VhZjY0YTQ0MjRiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJ0aW4gUm9iaW5zb24gPG1yb2JpbnNvbkB3ZWJraXQub3Jn PgpEYXRlOiBXZWQsIDI3IEphbiAyMDEwIDAwOjI1OjM4IC0wODAwClN1YmplY3Q6IFtQQVRDSF0g RXhwb3NlIHRoZSBHdGtJTU11bHRpQ29udGV4dCBhcyBhIHByb3BlcnR5IG9mIFdlYktpdFdlYlZp ZXcuCgotLS0KIFdlYktpdC9ndGsvQ2hhbmdlTG9nICAgICAgICAgICAgICAgIHwgICAxNiArKysr KysrKysrKysrKysrCiBXZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcCB8ICAgMzEg KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLQogMiBmaWxlcyBjaGFuZ2VkLCA0NiBpbnNl cnRpb25zKCspLCAxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdl TG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggYjU5NmE4Zi4uNzk1NTc2NyAxMDA2NDQK LS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxOSBAQAorMjAxMC0wMS0yNyAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQHdl YmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgW0dUS10gRXhwb3NlIHRoZSBJTSBjb250ZXh0IHZpYSB0aGUgQVBJCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzMyNworCisgICAgICAgIEV4cG9z ZSB0aGUgR3RrSU1NdWx0aUNvbnRleHQgYXMgYSBwcm9wZXJ0eSBvZiBXZWJLaXRXZWJWaWV3LiBU aGlzIHdpbGwKKyAgICAgICAgYWxsb3cgZW1iZWRkZXJzIHRvIGdlbmVyYXRlIHRoZSBpbnB1dCBt ZXRob2QgY29udGV4dCBtZW51IGVudHJpZXMgYW5kCisgICAgICAgIG1ha2UgdGVzdGluZyBjZXJ0 YWluIElNIGNvbnRleHQgYmVoYXZpb3IgcG9zc2libGUuCisKKyAgICAgICAgKiB3ZWJraXQvd2Vi a2l0d2Vidmlldy5jcHA6CisgICAgICAgICh3ZWJraXRfd2ViX3ZpZXdfZ2V0X3Byb3BlcnR5KToK KyAgICAgICAgKERORENvbnRlbnRzUmVxdWVzdDo6d2Via2l0X3dlYl92aWV3X2dldF9pbV9jb250 ZXh0KToKKyAgICAgICAgKERORENvbnRlbnRzUmVxdWVzdDo6d2Via2l0X3dlYl92aWV3X2NsYXNz X2luaXQpOgorCiAyMDEwLTAxLTE5ICBKb2FubWFyaWUgRGlnZ3MgIDxqb2FubWFyaWUuZGlnZ3NA Z21haWwuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFhhbiBMb3Blei4KZGlmZiAtLWdpdCBh L1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwIGIvV2ViS2l0L2d0ay93ZWJraXQv d2Via2l0d2Vidmlldy5jcHAKaW5kZXggYTQxMTkxZC4uYWQxMzg5NSAxMDA2NDQKLS0tIGEvV2Vi S2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKKysrIGIvV2ViS2l0L2d0ay93ZWJraXQv d2Via2l0d2Vidmlldy5jcHAKQEAgLTE3OSw3ICsxNzksOCBAQCBlbnVtIHsKICAgICBQUk9QX1BS T0dSRVNTLAogICAgIFBST1BfRU5DT0RJTkcsCiAgICAgUFJPUF9DVVNUT01fRU5DT0RJTkcsCi0g ICAgUFJPUF9JQ09OX1VSSQorICAgIFBST1BfSUNPTl9VUkksCisgICAgUFJPUF9JTV9DT05URVhU CiB9OwogCiBzdGF0aWMgZ3VpbnQgd2Via2l0X3dlYl92aWV3X3NpZ25hbHNbTEFTVF9TSUdOQUxd ID0geyAwLCB9OwpAQCAtMTg5LDYgKzE5MCw4IEBAIEdfREVGSU5FX1RZUEUoV2ViS2l0V2ViVmll dywgd2Via2l0X3dlYl92aWV3LCBHVEtfVFlQRV9DT05UQUlORVIpCiBzdGF0aWMgdm9pZCB3ZWJr aXRfd2ViX3ZpZXdfc2V0dGluZ3Nfbm90aWZ5KFdlYktpdFdlYlNldHRpbmdzKiB3ZWJTZXR0aW5n cywgR1BhcmFtU3BlYyogcHNwZWMsIFdlYktpdFdlYlZpZXcqIHdlYlZpZXcpOwogc3RhdGljIHZv aWQgd2Via2l0X3dlYl92aWV3X3NldF93aW5kb3dfZmVhdHVyZXMoV2ViS2l0V2ViVmlldyogd2Vi VmlldywgV2ViS2l0V2ViV2luZG93RmVhdHVyZXMqIHdlYldpbmRvd0ZlYXR1cmVzKTsKIAorc3Rh dGljIEd0a0lNQ29udGV4dCogd2Via2l0X3dlYl92aWV3X2dldF9pbV9jb250ZXh0KFdlYktpdFdl YlZpZXcqKTsKKwogc3RhdGljIHZvaWQgZGVzdHJveV9tZW51X2NiKEd0a09iamVjdCogb2JqZWN0 LCBncG9pbnRlciBkYXRhKQogewogICAgIFdlYktpdFdlYlZpZXcqIHdlYlZpZXcgPSBXRUJLSVRf V0VCX1ZJRVcoZGF0YSk7CkBAIC0zODQsNiArMzg3LDkgQEAgc3RhdGljIHZvaWQgd2Via2l0X3dl Yl92aWV3X2dldF9wcm9wZXJ0eShHT2JqZWN0KiBvYmplY3QsIGd1aW50IHByb3BfaWQsIEdWYWx1 ZSoKICAgICBjYXNlIFBST1BfSUNPTl9VUkk6CiAgICAgICAgIGdfdmFsdWVfc2V0X3N0cmluZyh2 YWx1ZSwgd2Via2l0X3dlYl92aWV3X2dldF9pY29uX3VyaSh3ZWJWaWV3KSk7CiAgICAgICAgIGJy ZWFrOworICAgIGNhc2UgUFJPUF9JTV9DT05URVhUOgorICAgICAgICBnX3ZhbHVlX3NldF9vYmpl Y3QodmFsdWUsIHdlYmtpdF93ZWJfdmlld19nZXRfaW1fY29udGV4dCh3ZWJWaWV3KSk7CisgICAg ICAgIGJyZWFrOwogICAgIGRlZmF1bHQ6CiAgICAgICAgIEdfT0JKRUNUX1dBUk5fSU5WQUxJRF9Q Uk9QRVJUWV9JRChvYmplY3QsIHByb3BfaWQsIHBzcGVjKTsKICAgICB9CkBAIC0xMjk5LDYgKzEz MDUsMTIgQEAgc3RhdGljIGdib29sZWFuIHdlYmtpdF93ZWJfdmlld19xdWVyeV90b29sdGlwKEd0 a1dpZGdldCAqd2lkZ2V0LCBnaW50IHgsIGdpbnQgeSwKIH0KICNlbmRpZgogCitzdGF0aWMgR3Rr SU1Db250ZXh0KiB3ZWJraXRfd2ViX3ZpZXdfZ2V0X2ltX2NvbnRleHQoV2ViS2l0V2ViVmlldyog d2ViVmlldykKK3sKKyAgICBnX3JldHVybl92YWxfaWZfZmFpbChXRUJLSVRfSVNfV0VCX1ZJRVco d2ViVmlldyksIDApOworICAgIHJldHVybiBHVEtfSU1fQ09OVEVYVCh3ZWJWaWV3LT5wcml2LT5p bUNvbnRleHQpOworfQorCiBzdGF0aWMgdm9pZCB3ZWJraXRfd2ViX3ZpZXdfY2xhc3NfaW5pdChX ZWJLaXRXZWJWaWV3Q2xhc3MqIHdlYlZpZXdDbGFzcykKIHsKICAgICBHdGtCaW5kaW5nU2V0KiBi aW5kaW5nX3NldDsKQEAgLTI0ODEsNiArMjQ5MywyMyBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfd2Vi X3ZpZXdfY2xhc3NfaW5pdChXZWJLaXRXZWJWaWV3Q2xhc3MqIHdlYlZpZXdDbGFzcykKICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXygiVGhl IFVSSSBmb3IgdGhlIGZhdmljb24gZm9yIHRoZSAjV2ViS2l0V2ViVmlldy4iKSwKICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgTlVMTCwKICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgV0VC S0lUX1BBUkFNX1JFQURBQkxFKSk7CisgICAgLyoqCisgICAgKiBXZWJLaXRXZWJWaWV3OmltLWNv bnRleHQ6CisgICAgKgorICAgICogVGhlIEd0a0lNTXVsdGljb250ZXh0IGZvciB0aGUgI1dlYktp dFdlYlZpZXcuCisgICAgKgorICAgICogVGhpcyBpcyB0aGUgaW5wdXQgbWV0aG9kIGNvbnRleHQg dXNlZCBmb3IgYWxsIHRleHQgZW50cnkgd2lkZ2V0cyBpbnNpZGUKKyAgICAqIHRoZSAjV2ViS2l0 V2ViVmlldy4gSXQgY2FuIGJlIHVzZWQgdG8gZ2VuZXJhdGUgY29udGV4dCBtZW51IGl0ZW1zIGZv cgorICAgICogY29udHJvbGxpbmcgdGhlIGFjdGl2ZSBpbnB1dCBtZXRob2QuCisgICAgKgorICAg ICogU2luY2U6IDEuMS4yMAorICAgICovCisgICAgZ19vYmplY3RfY2xhc3NfaW5zdGFsbF9wcm9w ZXJ0eShvYmplY3RDbGFzcywgUFJPUF9JTV9DT05URVhULAorICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgZ19wYXJhbV9zcGVjX29iamVjdCgiaW0tY29udGV4dCIsCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJJTSBDb250 ZXh0IiwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIlRoZSBHdGtJTU11bHRpQ29udGV4dCBmb3IgdGhlICNXZWJLaXRXZWJWaWV3LiIsCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEdU S19UWVBFX0lNX0NPTlRFWFQsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIFdFQktJVF9QQVJBTV9SRUFEQUJMRSkpOwogCiAgICAgZ190eXBl X2NsYXNzX2FkZF9wcml2YXRlKHdlYlZpZXdDbGFzcywgc2l6ZW9mKFdlYktpdFdlYlZpZXdQcml2 YXRlKSk7CiB9Ci0tIAoxLjYuMy4zCgo=