33321 2010-01-07 07:06:06 -0800 Don't store RegExp flags string representation 2010-01-08 17:58:04 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 kent.hansen kent.hansen commit-queue eric webkit.review.bot oldest_to_newest 178171 0 kent.hansen 2010-01-07 07:06:06 -0800 There's a FIXME in RegExp.h stating that it shouldn't be necessary to store the original flags string. Well, actually it isn't; RegExp.prototype.toString already uses the flag bits to reconstruct the string. 178172 1 46050 kent.hansen 2010-01-07 07:11:24 -0800 Created attachment 46050 proposed patch 178173 2 webkit.review.bot 2010-01-07 07:15:56 -0800 style-queue ran check-webkit-style on attachment 46050 without any errors. 178606 3 46050 commit-queue 2010-01-08 03:33:04 -0800 Comment on attachment 46050 proposed patch Clearing flags on attachment: 46050 Committed r52983: <http://trac.webkit.org/changeset/52983> 178607 4 commit-queue 2010-01-08 03:33:13 -0800 All reviewed patches have been landed. Closing bug. 178633 5 eric 2010-01-08 04:10:02 -0800 Reverted r52983 for reason: Broke 59 JavaScriptCore tests. I don't think Kent knew about run-javascriptcore-tests. Sadly neither does the commit-bot, yet. Committed r52987: <http://trac.webkit.org/changeset/52987> 178635 6 eric 2010-01-08 04:30:20 -0800 I think my rollout may have been wrong. :( I think the bots are just flakey. They reported more failures after the first failures which seemed to be correlated to this patch. I'll wait for them to calm down and then roll this back in if necessary. Lesson: You can't trust the bots. 178639 7 eric 2010-01-08 04:42:16 -0800 I will have the commit-queue land this again one bug 33376 is landed. 178648 8 46050 eric 2010-01-08 05:03:00 -0800 Comment on attachment 46050 proposed patch Sorry for the troubles. The commit-queue will re-land this shortly (and will re-confirm that it does not break run-javascriptcore-tests before landing). 178907 9 46050 commit-queue 2010-01-08 17:57:59 -0800 Comment on attachment 46050 proposed patch Clearing flags on attachment: 46050 Committed r53032: <http://trac.webkit.org/changeset/53032> 178908 10 commit-queue 2010-01-08 17:58:04 -0800 All reviewed patches have been landed. Closing bug. 46050 2010-01-07 07:11:24 -0800 2010-01-08 17:57:58 -0800 proposed patch DontStoreRegExpStringRepresentation.diff text/plain 2066 kent.hansen ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCAwMTdjMGRhLi5hMzAxM2U4IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTAtMDEtMDcgIEtlbnQgSGFuc2VuICA8a2VudC5oYW5zZW5Abm9raWEuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERvbid0IHN0b3Jl IFJlZ0V4cCBmbGFncyBzdHJpbmcgcmVwcmVzZW50YXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMzMzIxCisKKyAgICAgICAgSXQncyB1bnVzZWQ7 IHRoZSBzdHJpbmcgcmVwcmVzZW50YXRpb24gaXMgcmVjb25zdHJ1Y3RlZCBmcm9tIGZsYWdzLgor CisgICAgICAgICogcnVudGltZS9SZWdFeHAuY3BwOgorICAgICAgICAoSlNDOjpSZWdFeHA6OlJl Z0V4cCk6CisgICAgICAgICogcnVudGltZS9SZWdFeHAuaDoKKwogMjAxMC0wMS0wNiAgR2F2aW4g QmFycmFjbG91Z2ggIDxiYXJyYWNsb3VnaEBhcHBsZS5jb20+CiAKICAgICAgICAgUVQgYnVpbGQg Zml4LgpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvcnVudGltZS9SZWdFeHAuY3BwIGIvSmF2 YVNjcmlwdENvcmUvcnVudGltZS9SZWdFeHAuY3BwCmluZGV4IDdkZDRhOGYuLjRlOTU4ZjQgMTAw NjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvUmVnRXhwLmNwcAorKysgYi9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL1JlZ0V4cC5jcHAKQEAgLTY1LDcgKzY1LDYgQEAgaW5saW5lIFJlZ0V4 cDo6UmVnRXhwKEpTR2xvYmFsRGF0YSogZ2xvYmFsRGF0YSwgY29uc3QgVVN0cmluZyYgcGF0dGVy bikKIAogaW5saW5lIFJlZ0V4cDo6UmVnRXhwKEpTR2xvYmFsRGF0YSogZ2xvYmFsRGF0YSwgY29u c3QgVVN0cmluZyYgcGF0dGVybiwgY29uc3QgVVN0cmluZyYgZmxhZ3MpCiAgICAgOiBtX3BhdHRl cm4ocGF0dGVybikKLSAgICAsIG1fZmxhZ3MoZmxhZ3MpCiAgICAgLCBtX2ZsYWdCaXRzKDApCiAg ICAgLCBtX2NvbnN0cnVjdGlvbkVycm9yKDApCiAgICAgLCBtX251bVN1YnBhdHRlcm5zKDApCmRp ZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1JlZ0V4cC5oIGIvSmF2YVNjcmlwdENv cmUvcnVudGltZS9SZWdFeHAuaAppbmRleCAyNGQ0MTk5Li42MWFiMGJjIDEwMDY0NAotLS0gYS9K YXZhU2NyaXB0Q29yZS9ydW50aW1lL1JlZ0V4cC5oCisrKyBiL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvUmVnRXhwLmgKQEAgLTQ5LDcgKzQ5LDYgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAgIGJv b2wgbXVsdGlsaW5lKCkgY29uc3QgeyByZXR1cm4gbV9mbGFnQml0cyAmIE11bHRpbGluZTsgfQog CiAgICAgICAgIGNvbnN0IFVTdHJpbmcmIHBhdHRlcm4oKSBjb25zdCB7IHJldHVybiBtX3BhdHRl cm47IH0KLSAgICAgICAgY29uc3QgVVN0cmluZyYgZmxhZ3MoKSBjb25zdCB7IHJldHVybiBtX2Zs YWdzOyB9CiAKICAgICAgICAgYm9vbCBpc1ZhbGlkKCkgY29uc3QgeyByZXR1cm4gIW1fY29uc3Ry dWN0aW9uRXJyb3I7IH0KICAgICAgICAgY29uc3QgY2hhciogZXJyb3JNZXNzYWdlKCkgY29uc3Qg eyByZXR1cm4gbV9jb25zdHJ1Y3Rpb25FcnJvcjsgfQpAQCAtNjYsNyArNjUsNiBAQCBuYW1lc3Bh Y2UgSlNDIHsKICAgICAgICAgZW51bSBGbGFnQml0cyB7IEdsb2JhbCA9IDEsIElnbm9yZUNhc2Ug PSAyLCBNdWx0aWxpbmUgPSA0IH07CiAKICAgICAgICAgVVN0cmluZyBtX3BhdHRlcm47IC8vIEZJ WE1FOiBKdXN0IGRlY29tcGlsZSBtX3JlZ0V4cCBpbnN0ZWFkIG9mIHN0b3JpbmcgdGhpcy4KLSAg ICAgICAgVVN0cmluZyBtX2ZsYWdzOyAvLyBGSVhNRTogSnVzdCBkZWNvbXBpbGUgbV9yZWdFeHAg aW5zdGVhZCBvZiBzdG9yaW5nIHRoaXMuCiAgICAgICAgIGludCBtX2ZsYWdCaXRzOwogICAgICAg ICBjb25zdCBjaGFyKiBtX2NvbnN0cnVjdGlvbkVycm9yOwogICAgICAgICB1bnNpZ25lZCBtX251 bVN1YnBhdHRlcm5zOwo=