33312 2010-01-07 01:38:10 -0800 [Qt] Build fix when FAST_MALLOC_MATCH_VALIDATION=1 2010-01-07 04:14:11 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC Linux RESOLVED FIXED Qt P2 Normal --- 1 zoltan webkit-unassigned webkit.review.bot zecke oldest_to_newest 178068 0 zoltan 2010-01-07 01:38:10 -0800 Change pByte to static_cast<AllocAlignmentInteger*>(old_ptr), because pByte (it was in an older patch and has not been updated) doesn't exist. 178070 1 46032 zoltan 2010-01-07 01:40:21 -0800 Created attachment 46032 proposed patch 178072 2 webkit.review.bot 2010-01-07 01:44:42 -0800 Attachment 46032 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 JavaScriptCore/wtf/FastMalloc.cpp:3798: One space before end of line comments [whitespace/comments] [5] Total errors found: 1 178077 3 zecke 2010-01-07 01:51:06 -0800 The patch looks fine... some comments would be: - Refer to the commit that broke/added it. - You could use the same thing as with new_ptr (as in the original patch) - Or try +=.. - Or just treat it as the buildfix and commit. 178080 4 46034 zoltan 2010-01-07 01:53:21 -0800 Created attachment 46034 updated proposed patch 178081 5 webkit.review.bot 2010-01-07 01:55:26 -0800 Attachment 46034 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 JavaScriptCore/wtf/FastMalloc.cpp:3798: One space before end of line comments [whitespace/comments] [5] Total errors found: 1 178083 6 46035 zoltan 2010-01-07 02:02:00 -0800 Created attachment 46035 proposed patch 178087 7 webkit.review.bot 2010-01-07 02:05:52 -0800 style-queue ran check-webkit-style on attachment 46035 without any errors. 178097 8 46035 zecke 2010-01-07 02:16:35 -0800 Comment on attachment 46035 proposed patch Okay. the += sizeof() should be equivalent to casting the address to the AllocAlignmentInteger* and then adding one (as done for new_ptr)... 178099 9 46035 zoltan 2010-01-07 02:19:54 -0800 Comment on attachment 46035 proposed patch Clearing flags on attachment: 46035 Committed r52911: <http://trac.webkit.org/changeset/52911> 178100 10 zoltan 2010-01-07 02:20:03 -0800 All reviewed patches have been landed. Closing bug. 178124 11 46042 zoltan 2010-01-07 03:49:45 -0800 Created attachment 46042 proposed patch for mac 178125 12 zoltan 2010-01-07 03:50:21 -0800 Reopened because of Mac patch. 178129 13 webkit.review.bot 2010-01-07 03:54:34 -0800 style-queue ran check-webkit-style on attachment 46042 without any errors. 178131 14 zecke 2010-01-07 03:55:44 -0800 I think the patch is wrong. It should be '+1' instead of the sizeof. 178132 15 46044 zoltan 2010-01-07 04:01:48 -0800 Created attachment 46044 updated proposed patch for mac 178133 16 46044 zecke 2010-01-07 04:03:35 -0800 Comment on attachment 46044 updated proposed patch for mac Okay. 178135 17 zoltan 2010-01-07 04:14:11 -0800 Committed r52918: <http://trac.webkit.org/changeset/52918> 46032 2010-01-07 01:40:21 -0800 2010-01-07 01:53:21 -0800 proposed patch fast_malloc_match.patch text/plain 1258 zoltan SW5kZXg6IEphdmFTY3JpcHRDb3JlL3d0Zi9GYXN0TWFsbG9jLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBK YXZhU2NyaXB0Q29yZS93dGYvRmFzdE1hbGxvYy5jcHAJKHJldmlzaW9uIDUyOTA4KQorKysgSmF2 YVNjcmlwdENvcmUvd3RmL0Zhc3RNYWxsb2MuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNzk1LDcg KzM3OTUsNyBAQAogICAgIHJldHVybiBuZXdfcHRyOwogICB9IGVsc2UgewogI2lmIEVOQUJMRShG QVNUX01BTExPQ19NQVRDSF9WQUxJREFUSU9OKQotICAgIG9sZF9wdHIgPSBwQnl0ZSArIHNpemVv ZihBbGxvY0FsaWdubWVudEludGVnZXIpOyAgLy8gU2V0IG9sZF9wdHIgYmFjayB0byB0aGUgdXNl ciBwb2ludGVyLgorICAgIG9sZF9wdHIgPSBzdGF0aWNfY2FzdDxBbGxvY0FsaWdubWVudEludGVn ZXIqPihvbGRfcHRyKSArIHNpemVvZihBbGxvY0FsaWdubWVudEludGVnZXIpOyAgLy8gU2V0IG9s ZF9wdHIgYmFjayB0byB0aGUgdXNlciBwb2ludGVyLgogI2VuZGlmCiAgICAgcmV0dXJuIG9sZF9w dHI7CiAgIH0KSW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBK YXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDUyOTA4KQorKysgSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDEtMDcg IFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBCdWlsZCBmaXggd2hlbiBGQVNUX01B TExPQ19NQVRDSF9WQUxJREFUSU9OPTEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTMzMzEyCisKKyAgICAgICAgQ2hhbmdlIHBCeXRlIHRvIHN0YXRpY19j YXN0PEFsbG9jQWxpZ25tZW50SW50ZWdlcio+KG9sZF9wdHIpLCBiZWNhdXNlCisgICAgICAgIHBC eXRlIGRvZXNuJ3QgZXhpc3QuCisKKyAgICAgICAgKiB3dGYvRmFzdE1hbGxvYy5jcHA6CisgICAg ICAgIChXVEY6OlRDTWFsbG9jU3RhdHM6OnJlYWxsb2MpOgorCiAyMDEwLTAxLTA2ICBHYXZpbiBC YXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNvbT4KIAogICAgICAgICBRVCBidWlsZCBm aXguCg== 46034 2010-01-07 01:53:21 -0800 2010-01-07 02:02:00 -0800 updated proposed patch fast_malloc_match.patch text/plain 1293 zoltan SW5kZXg6IEphdmFTY3JpcHRDb3JlL3d0Zi9GYXN0TWFsbG9jLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBK YXZhU2NyaXB0Q29yZS93dGYvRmFzdE1hbGxvYy5jcHAJKHJldmlzaW9uIDUyOTA4KQorKysgSmF2 YVNjcmlwdENvcmUvd3RmL0Zhc3RNYWxsb2MuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNzk1LDcg KzM3OTUsNyBAQAogICAgIHJldHVybiBuZXdfcHRyOwogICB9IGVsc2UgewogI2lmIEVOQUJMRShG QVNUX01BTExPQ19NQVRDSF9WQUxJREFUSU9OKQotICAgIG9sZF9wdHIgPSBwQnl0ZSArIHNpemVv ZihBbGxvY0FsaWdubWVudEludGVnZXIpOyAgLy8gU2V0IG9sZF9wdHIgYmFjayB0byB0aGUgdXNl ciBwb2ludGVyLgorICAgIG9sZF9wdHIgPSBzdGF0aWNfY2FzdDxBbGxvY0FsaWdubWVudEludGVn ZXIqPihvbGRfcHRyKSArIHNpemVvZihBbGxvY0FsaWdubWVudEludGVnZXIpOyAgLy8gU2V0IG9s ZF9wdHIgYmFjayB0byB0aGUgdXNlciBwb2ludGVyLgogI2VuZGlmCiAgICAgcmV0dXJuIG9sZF9w dHI7CiAgIH0KSW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBK YXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDUyOTA4KQorKysgSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDEtMDcg IFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBCdWlsZCBmaXggd2hlbiBGQVNUX01B TExPQ19NQVRDSF9WQUxJREFUSU9OPTEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTMzMzEyCisKKyAgICAgICAgQ2hhbmdlIHBCeXRlIChjb21taXR0ZWQg aW4gcjQyMzQ0IGZyb20gIzIwNDIyKSB0byBzdGF0aWNfY2FzdDxBbGxvY0FsaWdubWVudEludGVn ZXIqPihvbGRfcHRyKSwgCisgICAgICAgIGJlY2F1c2UgcEJ5dGUgZG9lc24ndCBleGlzdC4KKwor ICAgICAgICAqIHd0Zi9GYXN0TWFsbG9jLmNwcDoKKyAgICAgICAgKFdURjo6VENNYWxsb2NTdGF0 czo6cmVhbGxvYyk6CisKIDIwMTAtMDEtMDYgIEdhdmluIEJhcnJhY2xvdWdoICA8YmFycmFjbG91 Z2hAYXBwbGUuY29tPgogCiAgICAgICAgIFFUIGJ1aWxkIGZpeC4K 46035 2010-01-07 02:02:00 -0800 2010-01-07 02:19:53 -0800 proposed patch fast_malloc_match.patch text/plain 1219 zoltan SW5kZXg6IEphdmFTY3JpcHRDb3JlL3d0Zi9GYXN0TWFsbG9jLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBK YXZhU2NyaXB0Q29yZS93dGYvRmFzdE1hbGxvYy5jcHAJKHJldmlzaW9uIDUyOTA4KQorKysgSmF2 YVNjcmlwdENvcmUvd3RmL0Zhc3RNYWxsb2MuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNzk1LDcg KzM3OTUsNyBAQAogICAgIHJldHVybiBuZXdfcHRyOwogICB9IGVsc2UgewogI2lmIEVOQUJMRShG QVNUX01BTExPQ19NQVRDSF9WQUxJREFUSU9OKQotICAgIG9sZF9wdHIgPSBwQnl0ZSArIHNpemVv ZihBbGxvY0FsaWdubWVudEludGVnZXIpOyAgLy8gU2V0IG9sZF9wdHIgYmFjayB0byB0aGUgdXNl ciBwb2ludGVyLgorICAgIG9sZF9wdHIgKz0gc2l6ZW9mKEFsbG9jQWxpZ25tZW50SW50ZWdlcik7 IC8vIFNldCBvbGRfcHRyIGJhY2sgdG8gdGhlIHVzZXIgcG9pbnRlci4KICNlbmRpZgogICAgIHJl dHVybiBvbGRfcHRyOwogICB9CkluZGV4OiBKYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiA1MjkwOCkKKysrIEph dmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisy MDEwLTAxLTA3ICBab2x0YW4gSG9ydmF0aCAgPHpvbHRhbkB3ZWJraXQub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gQnVpbGQgZml4IHdo ZW4gRkFTVF9NQUxMT0NfTUFUQ0hfVkFMSURBVElPTj0xCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzMxMgorCisgICAgICAgIFJlbW92ZSBwQnl0ZSAo Y29tbWl0dGVkIGluIHI0MjM0NCBmcm9tICMyMDQyMiksIGJlY2F1c2UgcEJ5dGUgZG9lc24ndAor ICAgICAgICBleGlzdCBhbmQgaXQgaXMgdW5uZWNlc3NhcnkuCisKKyAgICAgICAgKiB3dGYvRmFz dE1hbGxvYy5jcHA6CisgICAgICAgIChXVEY6OlRDTWFsbG9jU3RhdHM6OnJlYWxsb2MpOgorCiAy MDEwLTAxLTA2ICBHYXZpbiBCYXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNvbT4KIAog ICAgICAgICBRVCBidWlsZCBmaXguCg== 46042 2010-01-07 03:49:45 -0800 2010-01-07 04:01:48 -0800 proposed patch for mac fastmallocmatch.patch text/plain 1350 zoltan SW5kZXg6IEphdmFTY3JpcHRDb3JlL3d0Zi9GYXN0TWFsbG9jLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBK YXZhU2NyaXB0Q29yZS93dGYvRmFzdE1hbGxvYy5jcHAJKHJldmlzaW9uIDUyOTE1KQorKysgSmF2 YVNjcmlwdENvcmUvd3RmL0Zhc3RNYWxsb2MuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNzk1LDcg KzM3OTUsNyBAQAogICAgIHJldHVybiBuZXdfcHRyOwogICB9IGVsc2UgewogI2lmIEVOQUJMRShG QVNUX01BTExPQ19NQVRDSF9WQUxJREFUSU9OKQotICAgIG9sZF9wdHIgKz0gc2l6ZW9mKEFsbG9j QWxpZ25tZW50SW50ZWdlcik7IC8vIFNldCBvbGRfcHRyIGJhY2sgdG8gdGhlIHVzZXIgcG9pbnRl ci4KKyAgICBvbGRfcHRyID0gc3RhdGljX2Nhc3Q8QWxsb2NBbGlnbm1lbnRJbnRlZ2VyKj4ob2xk X3B0cikgKyBzaXplb2YoQWxsb2NBbGlnbm1lbnRJbnRlZ2VyKTsgLy8gU2V0IG9sZF9wdHIgYmFj ayB0byB0aGUgdXNlciBwb2ludGVyLgogI2VuZGlmCiAgICAgcmV0dXJuIG9sZF9wdHI7CiAgIH0K SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDUyOTE1KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDUgKzEsMTggQEAKIDIwMTAtMDEtMDcgIFpvbHRhbiBI b3J2YXRoICA8em9sdGFuQHdlYmtpdC5vcmc+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgW01hY10gQnVpbGQgZml4IHdoZW4gRkFTVF9NQUxMT0NfTUFU Q0hfVkFMSURBVElPTj0xCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0zMzMxMgorCisgICAgICAgIFVzaW5nIG9mIG9wZXJhdG9yICs9IGNhdXNlIGNvbXBp bGUgZXJyb3Igb24gTWFjLCBzbyBpdCBpcyBjaGFuZ2VkIHRvCisgICAgICAgICI9IHN0YXRpY19j YXN0PEFsbG9jQWxpZ25tZW50SW50ZWdlcio+KG9sZF9wdHIpICsiLgorCisgICAgICAgICogd3Rm L0Zhc3RNYWxsb2MuY3BwOgorICAgICAgICAoV1RGOjpUQ01hbGxvY1N0YXRzOjpyZWFsbG9jKToK KworMjAxMC0wMS0wNyAgWm9sdGFuIEhvcnZhdGggIDx6b2x0YW5Ad2Via2l0Lm9yZz4KKwogICAg ICAgICBSZXZpZXdlZCBieSBIb2xnZXIgRnJleXRoZXIuCiAKICAgICAgICAgW1F0XSBCdWlsZCBm aXggd2hlbiBGQVNUX01BTExPQ19NQVRDSF9WQUxJREFUSU9OPTEK 46044 2010-01-07 04:01:48 -0800 2010-01-07 04:03:35 -0800 updated proposed patch for mac fastmallocmatch.patch text/plain 1324 zoltan SW5kZXg6IEphdmFTY3JpcHRDb3JlL3d0Zi9GYXN0TWFsbG9jLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBK YXZhU2NyaXB0Q29yZS93dGYvRmFzdE1hbGxvYy5jcHAJKHJldmlzaW9uIDUyOTE1KQorKysgSmF2 YVNjcmlwdENvcmUvd3RmL0Zhc3RNYWxsb2MuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNzk1LDcg KzM3OTUsNyBAQAogICAgIHJldHVybiBuZXdfcHRyOwogICB9IGVsc2UgewogI2lmIEVOQUJMRShG QVNUX01BTExPQ19NQVRDSF9WQUxJREFUSU9OKQotICAgIG9sZF9wdHIgKz0gc2l6ZW9mKEFsbG9j QWxpZ25tZW50SW50ZWdlcik7IC8vIFNldCBvbGRfcHRyIGJhY2sgdG8gdGhlIHVzZXIgcG9pbnRl ci4KKyAgICBvbGRfcHRyID0gc3RhdGljX2Nhc3Q8QWxsb2NBbGlnbm1lbnRJbnRlZ2VyKj4ob2xk X3B0cikgKyAxOyAvLyBTZXQgb2xkX3B0ciBiYWNrIHRvIHRoZSB1c2VyIHBvaW50ZXIuCiAjZW5k aWYKICAgICByZXR1cm4gb2xkX3B0cjsKICAgfQpJbmRleDogSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gNTI5 MTUpCisrKyBKYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsNSAr MSwxOCBAQAogMjAxMC0wMS0wNyAgWm9sdGFuIEhvcnZhdGggIDx6b2x0YW5Ad2Via2l0Lm9yZz4K IAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbTWFjXSBC dWlsZCBmaXggd2hlbiBGQVNUX01BTExPQ19NQVRDSF9WQUxJREFUSU9OPTEKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMzMzEyCisKKyAgICAgICAgVXNp bmcgb2Ygb3BlcmF0b3IgKz0gY2F1c2UgY29tcGlsZSBlcnJvciBvbiBNYWMsIHNvIGl0IGlzIGNo YW5nZWQgdG8KKyAgICAgICAgIj0gc3RhdGljX2Nhc3Q8QWxsb2NBbGlnbm1lbnRJbnRlZ2VyKj4o b2xkX3B0cikgKyAxIi4KKworICAgICAgICAqIHd0Zi9GYXN0TWFsbG9jLmNwcDoKKyAgICAgICAg KFdURjo6VENNYWxsb2NTdGF0czo6cmVhbGxvYyk6CisKKzIwMTAtMDEtMDcgIFpvbHRhbiBIb3J2 YXRoICA8em9sdGFuQHdlYmtpdC5vcmc+CisKICAgICAgICAgUmV2aWV3ZWQgYnkgSG9sZ2VyIEZy ZXl0aGVyLgogCiAgICAgICAgIFtRdF0gQnVpbGQgZml4IHdoZW4gRkFTVF9NQUxMT0NfTUFUQ0hf VkFMSURBVElPTj0xCg==