33311 2010-01-07 01:23:10 -0800 Build fix for JSVALUE32 when ENABLE_JIT_OPTIMIZE* are disabled 2010-01-07 23:43:00 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Blocker --- 1 loki webkit-unassigned barraclough oliver webkit.review.bot oldest_to_newest 178062 0 46030 loki 2010-01-07 01:23:10 -0800 Created attachment 46030 Build fix for JSVALUE32 when ENABLE_JIT_OPTIMIZE* are disabled When all optimizations are disabled for JSValue32 we have the following error: In function `JSC::JIT::emit_op_get_by_pname(JSC::Instruction*)': undefined reference to `JSC::JIT::compileGetDirectOffset(RegisterID, RegisterID, RegisterID, RegisterID, RegisterID)' The fix moves compileGetDirectOffset function to the common part of Value32. 178063 1 webkit.review.bot 2010-01-07 01:23:43 -0800 style-queue ran check-webkit-style on attachment 46030 without any errors. 178541 2 loki 2010-01-07 23:43:00 -0800 Committed revision 52975. 46030 2010-01-07 01:23:10 -0800 2010-01-07 11:47:24 -0800 Build fix for JSVALUE32 when ENABLE_JIT_OPTIMIZE* are disabled 0001-Build-fix-for-JSVALUE32-when-ENABLE_JIT_OPTIMIZE-ar.patch text/plain 3388 loki RnJvbSA5MjMzYTRhMzE2MDFhMDNjNzI5ZDY2OGU5Y2M5YmQwMzE1OGY4N2FiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHYWJvciBMb2tpIDxsb2tpQHdlYmtpdC5vcmc+CkRhdGU6IFRo dSwgNyBKYW4gMjAxMCAxMDowODoyMyArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIEJ1aWxkIGZpeCBm b3IgSlNWQUxVRTMyIHdoZW4gRU5BQkxFX0pJVF9PUFRJTUlaRSogYXJlIGRpc2FibGVkCgpTaWdu ZWQtb2ZmLWJ5OiBHYWJvciBMb2tpIDxsb2tpQHdlYmtpdC5vcmc+Ci0tLQogSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICB8ICAgMTEgKysrKysrKysrKysKIEphdmFTY3Jp cHRDb3JlL2ppdC9KSVRQcm9wZXJ0eUFjY2Vzcy5jcHAgfCAgIDI4ICsrKysrKysrKysrKysrLS0t LS0tLS0tLS0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgMjUgaW5zZXJ0aW9ucygrKSwgMTQgZGVsZXRp b25zKC0pCgpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nIGIvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nCmluZGV4IDAxN2MwZGEuLmRkZDk2MDIgMTAwNjQ0Ci0tLSBhL0phdmFT Y3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxMC0wMS0wNyAgR2Fib3IgTG9raSAgPGxva2lAd2Via2l0Lm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBCdWlsZCBmaXgg Zm9yIEpTVkFMVUUzMiB3aGVuIEVOQUJMRV9KSVRfT1BUSU1JWkUqIGFyZSBkaXNhYmxlZAorCisg ICAgICAgIE1vdmUgY29tcGlsZUdldERpcmVjdE9mZnNldCBmdW5jdGlvbiB0byBjb21tb24gcGFy dCBvZiBKU1ZBTFVFMzIKKworICAgICAgICAqIGppdC9KSVRQcm9wZXJ0eUFjY2Vzcy5jcHA6Cisg ICAgICAgIChKU0M6OkpJVDo6Y29tcGlsZUdldERpcmVjdE9mZnNldCk6CisKIDIwMTAtMDEtMDYg IEdhdmluIEJhcnJhY2xvdWdoICA8YmFycmFjbG91Z2hAYXBwbGUuY29tPgogCiAgICAgICAgIFFU IGJ1aWxkIGZpeC4KZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRQcm9wZXJ0eUFj Y2Vzcy5jcHAgYi9KYXZhU2NyaXB0Q29yZS9qaXQvSklUUHJvcGVydHlBY2Nlc3MuY3BwCmluZGV4 IDY4MGNiMzAuLmVmOTVmOTkgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRQcm9w ZXJ0eUFjY2Vzcy5jcHAKKysrIGIvSmF2YVNjcmlwdENvcmUvaml0L0pJVFByb3BlcnR5QWNjZXNz LmNwcApAQCAtMTA1MSw2ICsxMDUxLDIwIEBAIHZvaWQgSklUOjplbWl0X29wX2dldF9ieV92YWwo SW5zdHJ1Y3Rpb24qIGN1cnJlbnRJbnN0cnVjdGlvbikKICAgICBlbWl0UHV0VmlydHVhbFJlZ2lz dGVyKGRzdCk7CiB9CiAKK3ZvaWQgSklUOjpjb21waWxlR2V0RGlyZWN0T2Zmc2V0KFJlZ2lzdGVy SUQgYmFzZSwgUmVnaXN0ZXJJRCByZXN1bHQsIFJlZ2lzdGVySUQgc3RydWN0dXJlLCBSZWdpc3Rl cklEIG9mZnNldCwgUmVnaXN0ZXJJRCBzY3JhdGNoKQoreworICAgIEFTU0VSVChzaXplb2YoKChT dHJ1Y3R1cmUqKTApLT5tX3Byb3BlcnR5U3RvcmFnZUNhcGFjaXR5KSA9PSBzaXplb2YoaW50MzJf dCkpOworICAgIEFTU0VSVChzaXplb2YoSlNPYmplY3Q6OmlubGluZVN0b3JhZ2VDYXBhY2l0eSkg PT0gc2l6ZW9mKGludDMyX3QpKTsKKworICAgIEp1bXAgbm90VXNpbmdJbmxpbmVTdG9yYWdlID0g YnJhbmNoMzIoTm90RXF1YWwsIEFkZHJlc3Moc3RydWN0dXJlLCBPQkpFQ1RfT0ZGU0VUT0YoU3Ry dWN0dXJlLCBtX3Byb3BlcnR5U3RvcmFnZUNhcGFjaXR5KSksIEltbTMyKEpTT2JqZWN0Ojppbmxp bmVTdG9yYWdlQ2FwYWNpdHkpKTsKKyAgICBsb2FkUHRyKEJhc2VJbmRleChiYXNlLCBvZmZzZXQs IFNjYWxlUHRyLCBPQkpFQ1RfT0ZGU0VUT0YoSlNPYmplY3QsIG1faW5saW5lU3RvcmFnZSkpLCBy ZXN1bHQpOworICAgIEp1bXAgZmluaXNoZWRMb2FkID0ganVtcCgpOworICAgIG5vdFVzaW5nSW5s aW5lU3RvcmFnZS5saW5rKHRoaXMpOworICAgIGxvYWRQdHIoQWRkcmVzcyhiYXNlLCBPQkpFQ1Rf T0ZGU0VUT0YoSlNPYmplY3QsIG1fZXh0ZXJuYWxTdG9yYWdlKSksIHNjcmF0Y2gpOworICAgIGxv YWRQdHIoQmFzZUluZGV4KHNjcmF0Y2gsIG9mZnNldCwgU2NhbGVQdHIsIDApLCByZXN1bHQpOwor ICAgIGZpbmlzaGVkTG9hZC5saW5rKHRoaXMpOworfQorCiB2b2lkIEpJVDo6ZW1pdF9vcF9nZXRf YnlfcG5hbWUoSW5zdHJ1Y3Rpb24qIGN1cnJlbnRJbnN0cnVjdGlvbikKIHsKICAgICB1bnNpZ25l ZCBkc3QgPSBjdXJyZW50SW5zdHJ1Y3Rpb25bMV0udS5vcGVyYW5kOwpAQCAtMTQ3NywyMCArMTQ5 MSw2IEBAIHZvaWQgSklUOjpjb21waWxlR2V0RGlyZWN0T2Zmc2V0KEpTT2JqZWN0KiBiYXNlLCBS ZWdpc3RlcklEIHRlbXAsIFJlZ2lzdGVySUQgcmVzCiAgICAgfSAKIH0KIAotdm9pZCBKSVQ6OmNv bXBpbGVHZXREaXJlY3RPZmZzZXQoUmVnaXN0ZXJJRCBiYXNlLCBSZWdpc3RlcklEIHJlc3VsdCwg UmVnaXN0ZXJJRCBzdHJ1Y3R1cmUsIFJlZ2lzdGVySUQgb2Zmc2V0LCBSZWdpc3RlcklEIHNjcmF0 Y2gpCi17Ci0gICAgQVNTRVJUKHNpemVvZigoKFN0cnVjdHVyZSopMCktPm1fcHJvcGVydHlTdG9y YWdlQ2FwYWNpdHkpID09IHNpemVvZihpbnQzMl90KSk7Ci0gICAgQVNTRVJUKHNpemVvZihKU09i amVjdDo6aW5saW5lU3RvcmFnZUNhcGFjaXR5KSA9PSBzaXplb2YoaW50MzJfdCkpOwotCi0gICAg SnVtcCBub3RVc2luZ0lubGluZVN0b3JhZ2UgPSBicmFuY2gzMihOb3RFcXVhbCwgQWRkcmVzcyhz dHJ1Y3R1cmUsIE9CSkVDVF9PRkZTRVRPRihTdHJ1Y3R1cmUsIG1fcHJvcGVydHlTdG9yYWdlQ2Fw YWNpdHkpKSwgSW1tMzIoSlNPYmplY3Q6OmlubGluZVN0b3JhZ2VDYXBhY2l0eSkpOwotICAgIGxv YWRQdHIoQmFzZUluZGV4KGJhc2UsIG9mZnNldCwgU2NhbGVQdHIsIE9CSkVDVF9PRkZTRVRPRihK U09iamVjdCwgbV9pbmxpbmVTdG9yYWdlKSksIHJlc3VsdCk7Ci0gICAgSnVtcCBmaW5pc2hlZExv YWQgPSBqdW1wKCk7Ci0gICAgbm90VXNpbmdJbmxpbmVTdG9yYWdlLmxpbmsodGhpcyk7Ci0gICAg bG9hZFB0cihBZGRyZXNzKGJhc2UsIE9CSkVDVF9PRkZTRVRPRihKU09iamVjdCwgbV9leHRlcm5h bFN0b3JhZ2UpKSwgc2NyYXRjaCk7Ci0gICAgbG9hZFB0cihCYXNlSW5kZXgoc2NyYXRjaCwgb2Zm c2V0LCBTY2FsZVB0ciwgMCksIHJlc3VsdCk7ICAgIAotICAgIGZpbmlzaGVkTG9hZC5saW5rKHRo aXMpOwotfQotCiB2b2lkIEpJVDo6dGVzdFByb3RvdHlwZShTdHJ1Y3R1cmUqIHN0cnVjdHVyZSwg SnVtcExpc3QmIGZhaWx1cmVDYXNlcykKIHsKICAgICBpZiAoc3RydWN0dXJlLT5tX3Byb3RvdHlw ZS5pc051bGwoKSkKLS0gCjEuNi4wLjQKCg==