33310 2010-01-07 00:46:39 -0800 editing/pasteboard/4641033.html timed out on Tiger Bot 2010-02-19 16:46:05 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 33289 1 eric eric ap cjerdonek commit-queue justin.garcia oldest_to_newest 178057 0 eric 2010-01-07 00:46:39 -0800 editing/pasteboard/4641033.html timed out on Tiger Bot This is the first time I've noticed this timeout: http://build.webkit.org/results/Tiger%20Intel%20Release/r52905%20(7498)/results.html This test has been here forever: http://trac.webkit.org/browser/trunk/LayoutTests/editing/pasteboard/4641033.html 179240 1 eric 2010-01-10 20:32:26 -0800 This seems to be one of the more common tiger failures. I've seen in a couple times this week, including just now: http://build.webkit.org/results/Tiger%20Intel%20Release/r53059%20(7616)/results.html 179928 2 eric 2010-01-12 12:06:08 -0800 This still times out every 5 to 10 builds or so on Tiger: http://build.webkit.org/results/Tiger%20Intel%20Release/r53142%20(7670)/results.html If we don't have any theories, we should just skip this test. I get the impression that Tiger support is slowly being deprecated anyway. 179929 3 eric 2010-01-12 12:07:43 -0800 I see no reason why this test should be failing unless copy or paste is hanging or unless the DRT timeout machinery is somehow broken on tiger. 179941 4 eric 2010-01-12 12:39:10 -0800 I think this test could be re-written to use onload (I think it's trying to wait for the img to load) and possibly be dumpAsText. I might try that. 181306 5 46697 eric 2010-01-15 12:15:10 -0800 Created attachment 46697 Patch 181308 6 eric 2010-01-15 12:16:48 -0800 I also wonder if the extra </select> close tag could be related to the failure here. I think the selection might unintentionally end up including the <script> tag and we might be copy/pasting the script tag. Not sure. 181316 7 46697 ap 2010-01-15 12:28:48 -0800 Comment on attachment 46697 Patch I'm not sure if setTimeout is unnecessary - the original bug was about DOM traversal and presence or renderers, and the DOM is different when still parsing. If this isn't going to fix the problem, better not make arbitrary changes. One possible reason for the test to time out would be an exception being raised. Maybe you could add a try/catch block instead, and log the exception? 181379 8 eric 2010-01-15 14:07:59 -0800 Exceptions would show up in the stderr. So I don't think exceptions are involved here. Do we have any idea what this test is actually supposed to be about? It's not at all clear from the test. 181380 9 eric 2010-01-15 14:08:40 -0800 I think if we don't understand the test, we should consider skipping it on Tiger, or removing it from the repository in total. :) 181421 10 ap 2010-01-15 15:57:28 -0800 Did we get to see stderr? All I see is "file not found". 182952 11 47074 eric 2010-01-20 15:45:02 -0800 Created attachment 47074 Patch 184166 12 eric 2010-01-24 22:44:00 -0800 run-webkit-tests often makes a stderr link even though there is no stderr file. At least that's my understanding. It's a bug we should fix some day. 184178 13 eric 2010-01-24 23:19:00 -0800 Another timeout: http://build.webkit.org/results/Tiger%20Intel%20Release/r53789%20(8117)/results.html 191360 14 47074 dglazkov 2010-02-17 19:20:39 -0800 Comment on attachment 47074 Patch ok. 191418 15 47074 commit-queue 2010-02-17 22:53:02 -0800 Comment on attachment 47074 Patch Rejecting patch 47074 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Dimitri Glazkov', '--force']" exit_code: 1 patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/platform/mac-tiger/Skipped Hunk #1 FAILED at 98. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/mac-tiger/Skipped.rej Full output: http://webkit-commit-queue.appspot.com/results/283139 192096 16 eric 2010-02-19 16:22:53 -0800 Attachment 47074 was posted by a committer and has review+, assigning to Eric Seidel for commit. 192116 17 eric 2010-02-19 16:46:05 -0800 Committed r55038: <http://trac.webkit.org/changeset/55038> 46697 2010-01-15 12:15:10 -0800 2010-01-20 15:44:57 -0800 Patch bug-33310-20100115121509.patch text/plain 1935 eric ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAzOWYwMTRlLi5hMjQ5YzdjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDEt MTUgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGVkaXRpbmcvcGFzdGVib2FyZC80NjQxMDMzLmh0 bWwgdGltZWQgb3V0IG9uIFRpZ2VyIEJvdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MzMzMTAKKworICAgICAgICAqIGVkaXRpbmcvcGFzdGVib2FyZC80 NjQxMDMzLmh0bWw6CisgICAgICAgICAtIFJlbW92ZSB1bmVjZXNzYXJ5IHNldFRpbWVvdXQoKS4g IEkgZG9uJ3QgZXhwZWN0IHRoaXMgY2hhbmdlIHRvIGZpeCB0aGUgdGltZW91dCBob3dldmVyLgor CiAyMDEwLTAxLTE1ICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2VkaXRpbmcv cGFzdGVib2FyZC80NjQxMDMzLmh0bWwgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL3Bhc3RlYm9hcmQv NDY0MTAzMy5odG1sCmluZGV4IDFmYjk3MTAuLjFmMTZmZmEgMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL2VkaXRpbmcvcGFzdGVib2FyZC80NjQxMDMzLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZWRp dGluZy9wYXN0ZWJvYXJkLzQ2NDEwMzMuaHRtbApAQCAtOSwyNCArOSwxNCBAQCBpZiAod2luZG93 LmxheW91dFRlc3RDb250cm9sbGVyKQogPHNlbGVjdCBpZD0iZW5kIj48b3B0Z3JvdXA+PG9wdGlv bj4xPC9vcHRpb24+PG9wdGlvbj4yPC9vcHRpb24+PG9wdGlvbj4zPC9vcHRpb24+PC9vcHRncm91 cD48L3NlbGVjdD4KIDwvc2VsZWN0PgogPHNjcmlwdD4KLWZ1bmN0aW9uIHJ1blRlc3QoKSB7Ci0g ICAgdmFyIHN0YXJ0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInN0YXJ0Iik7Ci0gICAgdmFy IGVuZCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJlbmQiKTsKLSAgICAKLSAgICB2YXIgcyA9 IHdpbmRvdy5nZXRTZWxlY3Rpb24oKTsKLSAgICBzLnNldEJhc2VBbmRFeHRlbnQoc3RhcnQsIDAs IGVuZCwgZW5kLmNoaWxkTm9kZXMubGVuZ3RoKTsKLSAgICAKLSAgICBkb2N1bWVudC5leGVjQ29t bWFuZCgiQ29weSIpOwotICAgIAotICAgIHMuc2V0UG9zaXRpb24oZG9jdW1lbnQuZ2V0RWxlbWVu dEJ5SWQoInBhc3RlIiksIDApOwotICAgIGRvY3VtZW50LmV4ZWNDb21tYW5kKCJQYXN0ZSIpOwot ICAgIAotICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCi0gICAgICAgIHdpbmRv dy5sYXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCk7ICAgIAotICAgIAotfQotaWYgKHdp bmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKLSAgICB3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xs ZXIud2FpdFVudGlsRG9uZSgpOwotd2luZG93LnNldFRpbWVvdXQocnVuVGVzdCwgMTAwKTsKK3Zh ciBzdGFydCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJzdGFydCIpOwordmFyIGVuZCA9IGRv Y3VtZW50LmdldEVsZW1lbnRCeUlkKCJlbmQiKTsKKwordmFyIHMgPSB3aW5kb3cuZ2V0U2VsZWN0 aW9uKCk7CitzLnNldEJhc2VBbmRFeHRlbnQoc3RhcnQsIDAsIGVuZCwgZW5kLmNoaWxkTm9kZXMu bGVuZ3RoKTsKKworZG9jdW1lbnQuZXhlY0NvbW1hbmQoIkNvcHkiKTsKIAorcy5zZXRQb3NpdGlv bihkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgicGFzdGUiKSwgMCk7Citkb2N1bWVudC5leGVjQ29t bWFuZCgiUGFzdGUiKTsKIDwvc2NyaXB0PgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUK 47074 2010-01-20 15:45:02 -0800 2010-02-17 22:53:02 -0800 Patch bug-33310-20100120154500.patch text/plain 1032 eric ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAwMmNhMTQ4Li45NWE2MzczIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDEt MjAgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGVkaXRpbmcvcGFzdGVib2FyZC80NjQxMDMzLmh0 bWwgdGltZWQgb3V0IG9uIFRpZ2VyIEJvdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MzMzMTAKKworICAgICAgICAqIHBsYXRmb3JtL21hYy10aWdlci9T a2lwcGVkOgorCiAyMDEwLTAxLTIwICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTmlrb2xhcyBaaW1tZXJtYW5uLgpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjLXRpZ2VyL1NraXBwZWQgYi9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9tYWMtdGlnZXIvU2tpcHBlZAppbmRleCBkYzA5ZWZiLi5kYWNkYTQ3IDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtdGlnZXIvU2tpcHBlZAorKysgYi9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9tYWMtdGlnZXIvU2tpcHBlZApAQCAtOTgsMyArOTgsNyBAQCBodHRwL3Rl c3RzL21lZGlhL3ZpZGVvLWVycm9yLWFib3J0Lmh0bWwKICMgRmFpbHMgaW50ZXJtaXR0ZW50bHkg b24gVGlnZXIgQnVpbGQgQm90LgogIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MzE0MTIKIGh0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QvbG9nb3V0Lmh0bWwKKworIyBJ bnRlcm1pdHRlbnRseSB0aW1lcyBvdXQgb24gVGlnZXIgYm90LgorIyBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzMzMTAKK2VkaXRpbmcvcGFzdGVib2FyZC80NjQxMDMz Lmh0bWwK