3331 2005-06-07 20:43:32 -0700 10.3.9 Build Failure: NSString may not respond to `+stringWithCString:encoding:' 2005-06-19 03:17:59 -0700 1 1 1 Unclassified WebKit JavaScriptCore 312.x Mac OS X 10.3 VERIFIED FIXED P2 Normal --- 3354 1 alanr-w darin snu oldest_to_newest 10844 0 alanr-w 2005-06-07 20:43:32 -0700 WebScriptObject.mm: In function `NSString* -[WebScriptObject stringRepresentation](WebScriptObject*, objc_selector*)': WebScriptObject.mm:343: warning: `NSString' may not respond to `+stringWithCString:encoding:' WebScriptObject.mm:343: warning: cannot find method `+stringWithCString:encoding:'; return type `id' assumed Documentation says that +stringWithCString:encoding is 10.4 specific. 10847 1 alanr-w 2005-06-07 20:46:30 -0700 Even though these are warnings, the next thing that prints is ** BUILD FAILED ** 10851 2 mjs 2005-06-07 21:48:45 -0700 There's probably a CFString function that does the same thing as this method. 10852 3 crschmidt 2005-06-07 21:56:35 -0700 Webkit is built with -Werror by default: if you manually pull out the -Werror flag from that build line, you can continue building Webkit -- however, there will be a crash when you encounter that symbol. Advice on #webkit indicates that it may be possible to rewrite this method to use some CFString method instead. I don't know what this means, just tossing it in in case it's helpful. 10853 4 mjs 2005-06-07 22:07:49 -0700 Review of this patch is in progress. 10854 5 crschmidt 2005-06-07 22:09:20 -0700 Another build error: in file: /Users/crschmidt/webkit/WebCore/khtml/ecma/kjs_window.cpp /Users/crschmidt/webkit/WebCore/khtml/ecma/kjs_window.cpp:93: error: `isnan' not declared /Users/crschmidt/webkit/WebCore/khtml/ecma/kjs_window.cpp: In function `int KJS::intFeature(const QMap<QString, QString>&, const char*, int, int, int)': /Users/crschmidt/webkit/WebCore/khtml/ecma/kjs_window.cpp:557: error: `isnan' undeclared (first use this function) /Users/crschmidt/webkit/WebCore/khtml/ecma/kjs_window.cpp:557: error: (Each undeclared identifier is reported only once for each function it appears in.) Interestingly enough, there seems to be some kind of indication in the file of why this might happen: // Must include <cmath> instead of <math.h> because of a bug in the // gcc 3.3 library version of <math.h> where if you include both // <cmath> and <math.h> the macros necessary for functions like // isnan are not defined. But <cmath> is being included. Not sure why exactly this is/isn't working, but I do know that Panther is using gcc-3.3, whereas building on Tiger used gcc-4.0. This one is an error, rather than a warning, so it can't be just skipped over. I was able to continue building by pulling the isnan calls out (as well as the using std::isnan), although obviously the code in this file will suffer as a result. (Not sure what the end result of this really is, just trying to get it to build to find where things which need to change are). 10855 6 crschmidt 2005-06-07 22:19:07 -0700 10.3.9 does not include libxslt header files: it includes the library (-rwxr-xr-x 1 root wheel 202984 12 May 12:13 /usr/lib/libxslt.1.dylib), but there is no /usr/include/libxslt directory. 11069 7 crschmidt 2005-06-08 04:19:35 -0700 Comment #6 has been opened as Bug 3334. Comment #5 has been opened as Bug 3344. 11126 8 crschmidt 2005-06-08 20:58:40 -0700 Changing title: metabug is 3354. This is one specific aspect of said bug. 11830 9 2307 snu 2005-06-13 18:10:00 -0700 Created attachment 2307 proposed fix Unless I'm missing something, this fixes JavaScriptCore to build on Panther. 11832 10 darin 2005-06-13 19:01:15 -0700 The patch is OK if the internal compiler error doesn't start happening again. My guess is that it will, and another solution in that case is to use the deprecated +[NSString stringWithCString:]. 11833 11 snu 2005-06-13 19:03:48 -0700 What internal compiler error? I didn't really grok the comment, not knowing the background ;-) Or of course the non-deprecated [NSString stringWithUTF8String:] or [NSString stringWithString:], but I don't like randomly copying strings for no good reason. 11834 12 mjs 2005-06-13 19:06:01 -0700 I just applied the patch and did not see any internal compile error building with gcc 3.3 on Tiger. 11838 13 snu 2005-06-13 19:38:49 -0700 I didn't get any internal compiler error on Panther with gcc 3.3 1671 or on Tiger with gcc 4.0 5026 11841 14 mjs 2005-06-13 21:47:06 -0700 r=me I'm going to assume the internal compiler error is gone and land this, since Finlay and I could not repro under a variety of circumstances. 12548 15 2307 darin 2005-06-18 16:48:10 -0700 Comment on attachment 2307 proposed fix OK. If this doesn't bring back that mysterious internal compiler error, then it's fine. 12584 16 c.petersen87 2005-06-18 23:02:39 -0700 Reporter, please mark this bug as Verified if this issue has been fixed in the latest TOT Webkit. 2307 2005-06-13 18:10:00 -0700 2005-06-18 16:48:10 -0700 proposed fix 3331.patch text/plain 656 snu SW5kZXg6IGJpbmRpbmdzL29iamMvV2ViU2NyaXB0T2JqZWN0Lm1tCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZp bGU6IC9jdnMvcm9vdC9KYXZhU2NyaXB0Q29yZS9iaW5kaW5ncy9vYmpjL1dlYlNjcmlwdE9iamVj dC5tbSx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4xOApkaWZmIC11IC1yMS4xOCBXZWJTY3JpcHRP YmplY3QubW0KLS0tIFdlYlNjcmlwdE9iamVjdC5tbQkyMDA1LzA1LzA5IDE4OjQ2OjQzCTEuMTgK KysrIFdlYlNjcmlwdE9iamVjdC5tbQkyMDA1LzA2LzE0IDAxOjA5OjQ1CkBAIC0zNDAsNyArMzQw LDcgQEAKIHsKICAgICBpZiAoIVtzZWxmIF9pc1NhZmVTY3JpcHRdKQogICAgICAgICAvLyBUaGlz IGlzIGEgd29ya2Fyb3VuZCBmb3IgYSBnY2MgMy4zIGludGVybmFsIGNvbXBpbGVyIGVycm9yLgot CXJldHVybiBbTlNTdHJpbmcgc3RyaW5nV2l0aENTdHJpbmc6IlVuZGVmaW5lZCIgZW5jb2Rpbmc6 TlNBU0NJSVN0cmluZ0VuY29kaW5nXTsKKwkJcmV0dXJuIEAiVW5kZWZpbmVkIjsKIAogICAgIElu dGVycHJldGVyOjpsb2NrKCk7CiAgICAgT2JqZWN0IHRoaXNPYmogPSBPYmplY3QoY29uc3RfY2Fz dDxPYmplY3RJbXAqPihbc2VsZiBfaW1wXSkpOwo=