<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>33281</bug_id>
          
          <creation_ts>2010-01-06 17:18:46 -0800</creation_ts>
          <short_desc>We should reuse MediaControlTimeDisplayElement::formatTime function</short_desc>
          <delta_ts>2023-10-13 08:22:22 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Media</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>CONFIGURATION CHANGED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Chris Marrin">cmarrin</reporter>
          <assigned_to name="Chris Marrin">cmarrin</assigned_to>
          <cc>ahmad.saleem792</cc>
    
    <cc>eric.carlson</cc>
    
    <cc>jer.noble</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>177884</commentid>
    <comment_count>0</comment_count>
    <who name="Chris Marrin">cmarrin</who>
    <bug_when>2010-01-06 17:18:46 -0800</bug_when>
    <thetext>This function is currently duplicated in FullscreenVideoController on Windows. We should make the function a static method so it can be reused.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1984890</commentid>
    <comment_count>1</comment_count>
    <who name="Ahmad Saleem">ahmad.saleem792</who>
    <bug_when>2023-10-13 08:22:22 -0700</bug_when>
    <thetext>This patch merged &apos;MediaControlTimeDisplayElement&apos; into &apos;MediaControlElementTypes.cpp&apos;.

https://github.com/WebKit/WebKit/commit/f9e9a9581511ef57234ffbd25cd6a7532123b54e

and this commit also deleted above file:

https://github.com/WebKit/WebKit/commit/e3e80694948e94e81d10faf2c0da5fb213ece5e8

Plus no function with &apos;::formatTime&apos; exist as per quick search.

I don&apos;t think this 2010 old bug would add much value and if needed any refactoring, it can be done in new bug.

I am marking this as &apos;RESOLVED CONFIGURATION CHANGED&apos; but will CC - Eric and Jer for any input.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>