3327 2005-06-07 20:14:30 -0700 Exception When Setting Style to Invalid Value Lacks Line/File Information 2005-06-18 23:03:52 -0700 1 1 1 Unclassified WebKit JavaScriptCore 412 Mac OS X 10.4 VERIFIED FIXED http://bdash.net.nz/files/safari-js-error.html P2 Minor --- 1 mrowe mjs oldest_to_newest 10838 0 mrowe 2005-06-07 20:14:30 -0700 When an Javascript exception is raised due to setting a CSS property to an invalid value, the exception object lacks line number and file information. To Reproduce: Load the above URL in Safari, and check the Javascript Console. An exception titled 'CSS exception 0' is listed with a URL of 'undefined' and line number of 0. Excepted behaviour: The Javascript console should contain an exception with the correct URL, http:// bdash.net.nz/files/safari-js-error.html, and line number of 4. 10839 1 2137 mrowe 2005-06-07 20:18:03 -0700 Created attachment 2137 Retrieve the line number + source URL from the current node if an exception is found during KJS_CHECKEXCEPTIONVALUE. 11039 2 2142 mrowe 2005-06-07 23:51:21 -0700 Created attachment 2142 Updated patch using local variable to reduce duplication of effort. Patch updated as requested. I ran run-webkit-tests earlier after creating my initial patch, and everything looked ok. I've pulled in the changes to the Xcode project files since then though and the tests no longer build so I cannot verify them with this latest patch applied. 11048 3 mjs 2005-06-08 00:25:42 -0700 r=me 11049 4 mjs 2005-06-08 00:27:26 -0700 Committed the change. 12583 5 c.petersen87 2005-06-18 23:00:52 -0700 Reporter, please mark this bug as Verified if this issue has been fixed in the latest TOT Webkit. 2137 2005-06-07 20:18:03 -0700 2005-06-07 23:51:21 -0700 Retrieve the line number + source URL from the current node if an exception is found during KJS_CHECKEXCEPTIONVALUE. javascriptcore-css-exception-detail-p1.patch text/plain 799 mrowe SW5kZXg6IGtqcy9ub2Rlcy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9yb290L0phdmFT Y3JpcHRDb3JlL2tqcy9ub2Rlcy5jcHAsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNTQKZGlmZiAt dSAtcCAtcjEuNTQgbm9kZXMuY3BwCi0tLSBub2Rlcy5jcHAJMjAwNS8wNC8yOSAwMDoyMjo1NQkx LjU0CisrKyBub2Rlcy5jcHAJMjAwNS8wNi8wOCAwMjo0Nzo0OApAQCAtNzMsOCArNzMsMTEgQEAg dXNpbmcgbmFtZXNwYWNlIEtKUzsKICAgICByZXR1cm4gQ29tcGxldGlvbihUaHJvdywgRXJyb3I6 OmNyZWF0ZShleGVjLEdlbmVyYWxFcnJvciwiT3V0IG9mIG1lbW9yeSIpKTsKIAogI2RlZmluZSBL SlNfQ0hFQ0tFWENFUFRJT05WQUxVRSBcCi0gIGlmIChleGVjLT5oYWRFeGNlcHRpb24oKSkgXAor ICBpZiAoZXhlYy0+aGFkRXhjZXB0aW9uKCkpIHtcCisgICAgZXhlYy0+ZXhjZXB0aW9uKCkudG9P YmplY3QoZXhlYykucHV0KGV4ZWMsICJsaW5lIiwgTnVtYmVyKHRoaXMtPmxpbmUpKTsgXAorICAg IGV4ZWMtPmV4Y2VwdGlvbigpLnRvT2JqZWN0KGV4ZWMpLnB1dChleGVjLCAic291cmNlVVJMIiwg U3RyaW5nKHRoaXMtPnNvdXJjZVVSTCkpOyBcCiAgICAgcmV0dXJuIGV4ZWMtPmV4Y2VwdGlvbigp OyBcCisgIH1cCiAgIGlmIChDb2xsZWN0b3I6Om91dE9mTWVtb3J5KCkpIFwKICAgICByZXR1cm4g VW5kZWZpbmVkKCk7IC8vIHdpbGwgYmUgcGlja2VkIHVwIGJ5IEtKU19DSEVDS0VYQ0VQVElPTgog Cg== 2142 2005-06-07 23:51:21 -0700 2005-06-07 23:51:21 -0700 Updated patch using local variable to reduce duplication of effort. javascriptcore-css-exception-detail-p2.patch text/plain 813 mrowe SW5kZXg6IGtqcy9ub2Rlcy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9yb290L0phdmFT Y3JpcHRDb3JlL2tqcy9ub2Rlcy5jcHAsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNTQKZGlmZiAt dSAtcCAtcjEuNTQgbm9kZXMuY3BwCi0tLSBub2Rlcy5jcHAJMjAwNS8wNC8yOSAwMDoyMjo1NQkx LjU0CisrKyBub2Rlcy5jcHAJMjAwNS8wNi8wOCAwNjo0NzoxNgpAQCAtNzMsOCArNzMsMTIgQEAg dXNpbmcgbmFtZXNwYWNlIEtKUzsKICAgICByZXR1cm4gQ29tcGxldGlvbihUaHJvdywgRXJyb3I6 OmNyZWF0ZShleGVjLEdlbmVyYWxFcnJvciwiT3V0IG9mIG1lbW9yeSIpKTsKIAogI2RlZmluZSBL SlNfQ0hFQ0tFWENFUFRJT05WQUxVRSBcCi0gIGlmIChleGVjLT5oYWRFeGNlcHRpb24oKSkgXAor ICBpZiAoZXhlYy0+aGFkRXhjZXB0aW9uKCkpIHtcCisgICAgT2JqZWN0IGV4Y2VwdGlvbiA9IGV4 ZWMtPmV4Y2VwdGlvbigpLnRvT2JqZWN0KGV4ZWMpOyBcCisgICAgZXhjZXB0aW9uLnB1dChleGVj LCAibGluZSIsIE51bWJlcih0aGlzLT5saW5lKSk7IFwKKyAgICBleGNlcHRpb24ucHV0KGV4ZWMs ICJzb3VyY2VVUkwiLCBTdHJpbmcodGhpcy0+c291cmNlVVJMKSk7IFwKICAgICByZXR1cm4gZXhl Yy0+ZXhjZXB0aW9uKCk7IFwKKyAgfVwKICAgaWYgKENvbGxlY3Rvcjo6b3V0T2ZNZW1vcnkoKSkg XAogICAgIHJldHVybiBVbmRlZmluZWQoKTsgLy8gd2lsbCBiZSBwaWNrZWQgdXAgYnkgS0pTX0NI RUNLRVhDRVBUSU9OCiAK