33261 2010-01-06 11:34:02 -0800 Add long_help for all common commands. 2010-01-06 22:00:42 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned abarth commit-queue webkit.review.bot oldest_to_newest 177665 0 eric 2010-01-06 11:34:02 -0800 Add long_help for all common commands. 177668 1 45974 eric 2010-01-06 11:35:44 -0800 Created attachment 45974 Patch 177669 2 webkit.review.bot 2010-01-06 11:36:17 -0800 Attachment 45974 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 Traceback (most recent call last): File "WebKitTools/Scripts/check-webkit-style", line 98, in <module> main() File "WebKitTools/Scripts/check-webkit-style", line 62, in main defaults = style.ArgumentDefaults(style.DEFAULT_OUTPUT_FORMAT, AttributeError: 'module' object has no attribute 'ArgumentDefaults' 177671 3 abarth 2010-01-06 11:42:28 -0800 Sorry for the spam. Stylebot is sick. 177834 4 45974 abarth 2010-01-06 16:06:19 -0800 Comment on attachment 45974 Patch No tests! Who are you? 177989 5 45974 commit-queue 2010-01-06 22:00:33 -0800 Comment on attachment 45974 Patch Clearing flags on attachment: 45974 Committed r52901: <http://trac.webkit.org/changeset/52901> 177990 6 commit-queue 2010-01-06 22:00:42 -0800 All reviewed patches have been landed. Closing bug. 45974 2010-01-06 11:35:44 -0800 2010-01-06 22:00:32 -0800 Patch bug-33261-20100106113542.patch text/plain 3284 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA5NjcxMTFjLi5hNDNkM2MxIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTAtMDEt MDYgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBsb25nX2hlbHAgZm9yIGFsbCBjb21tb24g Y29tbWFuZHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0zMzI2MQorCisgICAgICAgIEZvciBub3cgdGhlc2UgbG9uZ19oZWxwcyBhcmUgcHJldHR5IGJh c2ljLgorICAgICAgICBUaGVzZSB3ZXJlIGFsbCB3cml0dGVuIHRvIGp1c3QgZXhwbGFpbiB0aGUg c3RlcHMKKyAgICAgICAgdGhhdCBlYWNoIGNvbW1hbmQgcnVucy4gIFRoaXMgc3R5bGUgbG9uZ19o ZWxwIGNvdWxkCisgICAgICAgIGJlIG1hZGUgZWFzaWVyIGJ5IHVzaW5nOgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzMyNTcKKworICAgICAgICAqIFNj cmlwdHMvd2Via2l0cHkvY29tbWFuZHMvZG93bmxvYWQucHk6CisgICAgICAgICogU2NyaXB0cy93 ZWJraXRweS9jb21tYW5kcy9xdWVyaWVzLnB5OgorCiAyMDEwLTAxLTA2ICBBbmRyYXMgQmVjc2kg IDxhYmVjc2lAaW5mLnUtc3plZ2VkLmh1PgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFk bGVyLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tYW5kcy9k b3dubG9hZC5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbWFuZHMvZG93bmxv YWQucHkKaW5kZXggZDczMmY0NC4uYzdkZWU0ZSAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2Ny aXB0cy93ZWJraXRweS9jb21tYW5kcy9kb3dubG9hZC5weQorKysgYi9XZWJLaXRUb29scy9TY3Jp cHRzL3dlYmtpdHB5L2NvbW1hbmRzL2Rvd25sb2FkLnB5CkBAIC0xODcsNiArMTg3LDggQEAgY2xh c3MgQWJzdHJhY3RQYXRjaEFwcGx5aW5nQ29tbWFuZChBYnN0cmFjdFBhdGNoU2VxdWVuY2luZ0Nv bW1hbmQpOgogICAgIG1haW5fc3RlcHMgPSBbCiAgICAgICAgIHN0ZXBzLkFwcGx5UGF0Y2hXaXRo TG9jYWxDb21taXQsCiAgICAgXQorICAgIGxvbmdfaGVscCA9ICIiIlVwZGF0ZXMgdGhlIHdvcmtp bmcgY29weS4KK0Rvd25sb2FkcyBhbmQgYXBwbGllcyB0aGUgcGF0Y2hlcywgY3JlYXRpbmcgbG9j YWwgY29tbWl0cyBpZiBuZWNlc3NhcnkuIiIiCiAKIAogY2xhc3MgQXBwbHlBdHRhY2htZW50KEFi c3RyYWN0UGF0Y2hBcHBseWluZ0NvbW1hbmQsIFByb2Nlc3NBdHRhY2htZW50c01peGluKToKQEAg LTIxOCw2ICsyMjAsMTQgQEAgY2xhc3MgQWJzdHJhY3RQYXRjaExhbmRpbmdDb21tYW5kKEFic3Ry YWN0UGF0Y2hTZXF1ZW5jaW5nQ29tbWFuZCk6CiAgICAgICAgIHN0ZXBzLkNsb3NlUGF0Y2gsCiAg ICAgICAgIHN0ZXBzLkNsb3NlQnVnLAogICAgIF0KKyAgICBsb25nX2hlbHAgPSAiIiJDaGVja3Mg dG8gbWFrZSBzdXJlIGJ1aWxkZXJzIGFyZSBncmVlbi4KK1VwZGF0ZXMgdGhlIHdvcmtpbmcgY29w eS4KK0FwcGxpZXMgdGhlIHBhdGNoLgorQnVpbGRzLgorUnVucyB0aGUgbGF5b3V0IHRlc3RzLgor Q29tbWl0cyB0aGUgcGF0Y2guCitDbGVhcnMgdGhlIGZsYWdzIG9uIHRoZSBwYXRjaC4KK0Nsb3Nl cyB0aGUgYnVnIGlmIG5vIHBhdGNoZXMgYXJlIG1hcmtlZCBmb3IgcmV2aWV3LiIiIgogCiAKIGNs YXNzIExhbmRBdHRhY2htZW50KEFic3RyYWN0UGF0Y2hMYW5kaW5nQ29tbWFuZCwgUHJvY2Vzc0F0 dGFjaG1lbnRzTWl4aW4pOgpAQCAtMjM5LDYgKzI0OSwxMiBAQCBjbGFzcyBSb2xsb3V0KEFic3Ry YWN0U2VxdWVuY2VkQ29tbW1hbmQpOgogICAgIHNob3dfaW5fbWFpbl9oZWxwID0gVHJ1ZQogICAg IGhlbHBfdGV4dCA9ICJSZXZlcnQgdGhlIGdpdmVuIHJldmlzaW9uIGluIHRoZSB3b3JraW5nIGNv cHkgYW5kIG9wdGlvbmFsbHkgY29tbWl0IHRoZSByZXZlcnQgYW5kIHJlLW9wZW4gdGhlIG9yaWdp bmFsIGJ1ZyIKICAgICBhcmd1bWVudF9uYW1lcyA9ICJSRVZJU0lPTiBSRUFTT04iCisgICAgbG9u Z19oZWxwID0gIiIiVXBkYXRlcyB0aGUgd29ya2luZyBjb3B5LgorQXBwbGllcyB0aGUgaW52ZXJz ZSBkaWZmIGZvciB0aGUgcHJvdmlkZWQgcmV2aXNpb24uCitDcmVhdGVzIGFuIGFwcHJvcHJpYXRl IHJvbGxvdXQgQ2hhbmdlTG9nLCBpbmNsdWRpbmcgYSB0cmFjIGxpbmsgYW5kIGJ1ZyBsaW5rLgor T3BlbnMgdGhlIGdlbmVyYXRlZCBDaGFuZ2VMb2dzIGluICRFRElUT1IuCitTaG93cyB0aGUgcHJl cGFyZWQgZGlmZiBmb3IgY29uZmlybWF0aW9uLgorQ29tbWl0cyB0aGUgcmV2ZXJ0IGFuZCB1cGRh dGVzIHRoZSBidWcgKGluY2x1ZGluZyByZS1vcGVuaW5nIHRoZSBidWcgaWYgbmVjZXNzYXJ5KS4i IiIKICAgICBzdGVwcyA9IFsKICAgICAgICAgc3RlcHMuQ2xlYW5Xb3JraW5nRGlyZWN0b3J5LAog ICAgICAgICBzdGVwcy5VcGRhdGUsCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dl YmtpdHB5L2NvbW1hbmRzL3F1ZXJpZXMucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5 L2NvbW1hbmRzL3F1ZXJpZXMucHkKaW5kZXggM2Q1YTY3NS4uYmM4YjY0MSAxMDA2NDQKLS0tIGEv V2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tYW5kcy9xdWVyaWVzLnB5CisrKyBiL1dl YktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbWFuZHMvcXVlcmllcy5weQpAQCAtMTIwLDYg KzEyMCw4IEBAIGNsYXNzIFRyZWVTdGF0dXMoQWJzdHJhY3REZWNsYXJhdGl2ZUNvbW1tYW5kKToK ICAgICBuYW1lID0gInRyZWUtc3RhdHVzIgogICAgIHNob3dfaW5fbWFpbl9oZWxwID0gVHJ1ZQog ICAgIGhlbHBfdGV4dCA9ICJQcmludCB0aGUgc3RhdHVzIG9mIHRoZSAlcyBidWlsZGJvdHMiICUg QnVpbGRCb3QuZGVmYXVsdF9ob3N0CisgICAgbG9uZ19oZWxwID0gIiIiRmV0Y2hlcyBidWlsZCBz dGF0dXMgZnJvbSBodHRwOi8vYnVpbGQud2Via2l0Lm9yZy9vbmVfYm94X3Blcl9idWlsZGVyCith bmQgZGlzcGxheWVzIHRoZSBzdGF0dXMgb2YgZWFjaCBidWlsZGVyLiIiIgogCiAgICAgZGVmIGV4 ZWN1dGUoc2VsZiwgb3B0aW9ucywgYXJncywgdG9vbCk6CiAgICAgICAgIGZvciBidWlsZGVyIGlu IHRvb2wuYnVpbGRib3QuYnVpbGRlcl9zdGF0dXNlcygpOgo=