33252 2010-01-06 04:32:59 -0800 Allow custom memory allocation control for IconDatabaseClient class 2010-02-01 23:56:44 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 zoltan zoltan darin eric webkit.review.bot oldest_to_newest 177565 0 zoltan 2010-01-06 04:32:59 -0800 Inherits the following struct from Noncopyable because it is instantiated by 'new' and no need to be copyable: class name - instantiated at: WebCore/'location' class IconDatabaseClient - loader/icon/IconDatabase.cpp:89 177566 1 45960 zoltan 2010-01-06 04:34:23 -0800 Created attachment 45960 proposed patch 177568 2 webkit.review.bot 2010-01-06 04:36:29 -0800 style-queue ran check-webkit-style on attachment 45960 without any errors. 177596 3 45960 eric 2010-01-06 09:00:02 -0800 Comment on attachment 45960 proposed patch This is an Abstract Base Class. I don't think that this interface should require non-copyable. The implementors of this interface should inherit from NonCopyable or FastAllocBase instead, no? 177619 4 darin 2010-01-06 09:38:22 -0800 (In reply to comment #3) > This is an Abstract Base Class. It's not. It has no pure virtual functions and is instantiated, as the patch says, on line 89 of IconDatabase.cpp. However, I think it would make more sense if it was an abstract base class. The version that does nothing could be derived from it. I think there's no harm in making the change from this patch, but it's not great to have this client different from other clients. 181756 5 zoltan 2010-01-18 00:02:40 -0800 So, what should be the best solution? Using fastNew in this case wouldn't be nice. Add an extra class? Or Inherit this client? 181927 6 darin 2010-01-18 10:52:32 -0800 (In reply to comment #5) > So, what should be the best solution? Using fastNew in this case wouldn't be > nice. Add an extra class? Or Inherit this client? I know you’re hoping I’ll decide, but both options seem OK to me. 185444 7 45960 zoltan 2010-01-28 05:59:04 -0800 Comment on attachment 45960 proposed patch Okay, this change modifies fewest. I marked r? the patch again. 186643 8 eric 2010-02-01 16:11:39 -0800 Attachment 45960 was posted by a committer and has review+, assigning to Zoltan Horvath for commit. 186831 9 45960 zoltan 2010-02-01 23:56:33 -0800 Comment on attachment 45960 proposed patch Clearing flags on attachment: 45960 Committed r54210: <http://trac.webkit.org/changeset/54210> 186832 10 zoltan 2010-02-01 23:56:44 -0800 All reviewed patches have been landed. Closing bug. 45960 2010-01-06 04:34:23 -0800 2010-02-01 23:56:33 -0800 proposed patch IconDatabaseClient.patch text/plain 1497 zoltan SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1Mjg1NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMTAtMDEtMDYgIFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtp dC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QWxsb3cgY3VzdG9tIG1lbW9yeSBhbGxvY2F0aW9uIGNvbnRyb2wgZm9yIEljb25EYXRhYmFzZUNs aWVudCBjbGFzcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MzMyNTIKKworICAgICAgICBJbmhlcml0cyB0aGUgZm9sbG93aW5nIHN0cnVjdCBmcm9tIE5v bmNvcHlhYmxlIGJlY2F1c2UgaXQgaXMgCisgICAgICAgIGluc3RhbnRpYXRlZCBieSAnbmV3JyBh bmQgbm8gbmVlZCB0byBiZSBjb3B5YWJsZToKKworICAgICAgICBjbGFzcyBuYW1lICAgICAgICAg ICAgICAgLSBpbnN0YW50aWF0ZWQgYXQ6IFdlYkNvcmUvJ2xvY2F0aW9uJworICAgICAgICBjbGFz cyBJY29uRGF0YWJhc2VDbGllbnQgLSBsb2FkZXIvaWNvbi9JY29uRGF0YWJhc2UuY3BwOjg5CisK KyAgICAgICAgKiBsb2FkZXIvaWNvbi9JY29uRGF0YWJhc2VDbGllbnQuaDoKKwogMjAxMC0wMS0w NiAgU2ltb24gSGF1c21hbm4gIDxzaW1vbi5oYXVzbWFubkBub2tpYS5jb20+CiAKICAgICAgICAg VW5yZXZpZXdlZCB0cml2aWFsIFF0IGJ1aWxkIGZpeC4KSW5kZXg6IFdlYkNvcmUvbG9hZGVyL2lj b24vSWNvbkRhdGFiYXNlQ2xpZW50LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9sb2FkZXIvaWNv bi9JY29uRGF0YWJhc2VDbGllbnQuaAkocmV2aXNpb24gNTI4NTQpCisrKyBXZWJDb3JlL2xvYWRl ci9pY29uL0ljb25EYXRhYmFzZUNsaWVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC0yOSw2ICsyOSw4 IEBACiAjaWZuZGVmIEljb25EYXRhYmFzZUNsaWVudF9oCiAjZGVmaW5lIEljb25EYXRhYmFzZUNs aWVudF9oCiAKKyNpbmNsdWRlIDx3dGYvTm9uY29weWFibGUuaD4KKwogLy8gQWxsIG9mIHRoZXNl IGNsaWVudCBtZXRob2RzIHdpbGwgYmUgY2FsbGVkIGZyb20gYSBub24tbWFpbiB0aHJlYWQKIC8v IFRha2UgYXBwcm9wcmlhdGUgbWVhc3VyZXMKICAKQEAgLTM2LDcgKzM4LDcgQEAKIAogY2xhc3Mg U3RyaW5nOwogCi1jbGFzcyBJY29uRGF0YWJhc2VDbGllbnQgeworY2xhc3MgSWNvbkRhdGFiYXNl Q2xpZW50IDogcHVibGljIE5vbmNvcHlhYmxlIHsKIHB1YmxpYzoKICAgICB2aXJ0dWFsIH5JY29u RGF0YWJhc2VDbGllbnQoKSB7IH0KICAgICB2aXJ0dWFsIGJvb2wgcGVyZm9ybUltcG9ydCgpIHsg cmV0dXJuIHRydWU7IH0K