33250 2010-01-06 01:08:30 -0800 [Qt] windowsKeyCodeForKeyEvent() returns 0 for arrow keys on numeric-pad 2010-01-06 22:15:04 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED Qt P2 Normal --- 0 kinuko webkit-unassigned commit-queue eric tkent oldest_to_newest 177551 0 kinuko 2010-01-06 01:08:30 -0800 Currently QT returns 0 as windowsVirtualKeyCode for any key events other than 0-9 and +-*/ keys on numeric-pad. This indirectly makes a layout test fast/tests/keydown-numpad-keys.html failing. 177553 1 45957 kinuko 2010-01-06 01:23:11 -0800 Created attachment 45957 patch 1 177598 2 45957 eric 2010-01-06 09:01:52 -0800 Comment on attachment 45957 patch 1 Looks OK. 177910 3 45957 commit-queue 2010-01-06 18:27:43 -0800 Comment on attachment 45957 patch 1 Rejecting patch 45957 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Eric Seidel', '--force']" exit_code: 1 Last 500 characters of output: ile WebCore/platform/qt/PlatformKeyboardEventQt.cpp patching file WebKitTools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebKitTools/DumpRenderTree/qt/EventSenderQt.cpp Hunk #1 FAILED at 38. Hunk #2 succeeded at 135 (offset 19 lines). Hunk #3 succeeded at 150 (offset 19 lines). 1 out of 3 hunks FAILED -- saving rejects to file WebKitTools/DumpRenderTree/qt/EventSenderQt.cpp.rej patching file WebKitTools/DumpRenderTree/qt/EventSenderQt.h Hunk #1 succeeded at 56 (offset 2 lines). Full output: http://webkit-commit-queue.appspot.com/results/165156 177929 4 eric 2010-01-06 19:45:21 -0800 Sorry. The commit-queue was blocked all day by a very red tree. Looks like someone else checked in in the meanwhile and made your patch not apply. Normally it doesn't take more than 15 minutes between when we set cq+ and when your patch is landed. You'll need to either get someone to land this manually, or post an updated patch so that we can r+/cq+ it. Thanks! 177996 5 tkent 2010-01-06 22:15:04 -0800 Landed manually: http://trac.webkit.org/changeset/52902 45957 2010-01-06 01:23:11 -0800 2010-01-06 18:27:43 -0800 patch 1 bug-33250-20100106182309.patch text/plain 5378 kinuko ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBmODFhZTI2Li4wNTNlMTk3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDEt MDYgIEtpbnVrbyBZYXN1ZGEgIDxraW51a29AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBmYXN0L2V2ZW50cy9rZXlk b3duLW51bXBhZC1rZXkuaHRtbCBmcm9tIHRoZSBTa2lwcGVkIGxpc3QuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMzI1MAorCisgICAgICAgICogcGxh dGZvcm0vcXQvU2tpcHBlZDoKKwogMjAxMC0wMS0wNCAgQ2hyaXMgRmxlaXphY2ggIDxjZmxlaXph Y2hAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZCBiL0xheW91dFRlc3RzL3BsYXRm b3JtL3F0L1NraXBwZWQKaW5kZXggMmU0MWZmYy4uYjkxNDY5NyAxMDA2NDQKLS0tIGEvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9T a2lwcGVkCkBAIC00NDgsNyArNDQ4LDYgQEAgZmFzdC9ldmVudHMvZHJhZy1pbi1mcmFtZXMuaHRt bAogZmFzdC9ldmVudHMvZm9jdXNpbmdVbmxvYWRlZEZyYW1lLmh0bWwKIGZhc3QvZXZlbnRzL2pz LWtleWJvYXJkLWV2ZW50LWNyZWF0aW9uLmh0bWwKIGZhc3QvZXZlbnRzL2tleWRvd24tMS5odG1s Ci1mYXN0L2V2ZW50cy9rZXlkb3duLW51bXBhZC1rZXlzLmh0bWwKIGZhc3QvZXZlbnRzL2tleXBy ZXNzLWluc2VydC10YWIuaHRtbAogZmFzdC9ldmVudHMvbW91c2VvdXQtZGVhZC1ub2RlLmh0bWwK IGZhc3QvZXZlbnRzL29uZHJhZ2VudGVyLmh0bWwKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdl TG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGUyMTE5YS4uN2FkODlkNiAxMDA2NDQKLS0t IGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx NiBAQAorMjAxMC0wMS0wNiAgS2ludWtvIFlhc3VkYSAgPGtpbnVrb0BjaHJvbWl1bS5vcmc+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZSB3aW5k b3dzS2V5Q29kZUZvcktleUV2ZW50KCkgcmV0dXJuIGNvcnJlY3Qga2V5IGNvZGUgZm9yCisgICAg ICAgIG51bWVyaWMtcGFkIGFycm93IGtleXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zMzI1MAorCisgICAgICAgIFRlc3Q6IGZhc3QvZXZlbnRzL2tl eWRvd24tbnVtcGFkLWtleXMuaHRtbAorCisgICAgICAgICogcGxhdGZvcm0vcXQvUGxhdGZvcm1L ZXlib2FyZEV2ZW50UXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6d2luZG93c0tleUNvZGVGb3JL ZXlFdmVudCk6CisKIDIwMTAtMDEtMDUgIFNpbW9uIEhhdXNtYW5uICA8c2ltb24uaGF1c21hbm5A bm9raWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgdHJpdmlhbCBTeW1iaWFuIGJ1aWxkIGZp eApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9xdC9QbGF0Zm9ybUtleWJvYXJkRXZlbnRR dC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL3F0L1BsYXRmb3JtS2V5Ym9hcmRFdmVudFF0LmNwcApp bmRleCBmNzhjN2Q3Li4xMjIwMGY0IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL3F0L1Bs YXRmb3JtS2V5Ym9hcmRFdmVudFF0LmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL3F0L1BsYXRm b3JtS2V5Ym9hcmRFdmVudFF0LmNwcApAQCAtMTcxLDYgKzE3MSwyMiBAQCBzdGF0aWMgaW50IHdp bmRvd3NLZXlDb2RlRm9yS2V5RXZlbnQodW5zaWduZWQgaW50IGtleWNvZGUsIGJvb2wgaXNLZXlw YWQgPSBmYWxzZQogICAgICAgICAgICAgcmV0dXJuIFZLX0RFQ0lNQUw7ICAvLyAoNkUpIERlY2lt YWwga2V5CiAgICAgICAgIGNhc2UgUXQ6OktleV9TbGFzaDoKICAgICAgICAgICAgIHJldHVybiBW S19ESVZJREU7ICAgLy8gKDZGKSBEaXZpZGUga2V5CisgICAgICAgIGNhc2UgUXQ6OktleV9QYWdl VXA6CisgICAgICAgICAgICByZXR1cm4gVktfUFJJT1I7IC8vICgyMSkgUEFHRSBVUCBrZXkKKyAg ICAgICAgY2FzZSBRdDo6S2V5X1BhZ2VEb3duOgorICAgICAgICAgICAgcmV0dXJuIFZLX05FWFQ7 IC8vICgyMikgUEFHRSBET1dOIGtleQorICAgICAgICBjYXNlIFF0OjpLZXlfRW5kOgorICAgICAg ICAgICAgcmV0dXJuIFZLX0VORDsgLy8gKDIzKSBFTkQga2V5CisgICAgICAgIGNhc2UgUXQ6Oktl eV9Ib21lOgorICAgICAgICAgICAgcmV0dXJuIFZLX0hPTUU7IC8vICgyNCkgSE9NRSBrZXkKKyAg ICAgICAgY2FzZSBRdDo6S2V5X0xlZnQ6CisgICAgICAgICAgICByZXR1cm4gVktfTEVGVDsgLy8g KDI1KSBMRUZUIEFSUk9XIGtleQorICAgICAgICBjYXNlIFF0OjpLZXlfVXA6CisgICAgICAgICAg ICByZXR1cm4gVktfVVA7IC8vICgyNikgVVAgQVJST1cga2V5CisgICAgICAgIGNhc2UgUXQ6Oktl eV9SaWdodDoKKyAgICAgICAgICAgIHJldHVybiBWS19SSUdIVDsgLy8gKDI3KSBSSUdIVCBBUlJP VyBrZXkKKyAgICAgICAgY2FzZSBRdDo6S2V5X0Rvd246CisgICAgICAgICAgICByZXR1cm4gVktf RE9XTjsgLy8gKDI4KSBET1dOIEFSUk9XIGtleQogICAgICAgICBkZWZhdWx0OgogICAgICAgICAg ICAgcmV0dXJuIDA7CiAgICAgICAgIH0KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxv ZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxvZwppbmRleCA0OTMyOTdlLi5lMzc4YWQyIDEwMDY0NAot LS0gYS9XZWJLaXRUb29scy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTggQEAKKzIwMTAtMDEtMDYgIEtpbnVrbyBZYXN1ZGEgIDxraW51a29AY2hyb21p dW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtRdF0gU3VwcG9ydCB0aGUgM3JkIGFyZ3VtZW50IG9mIEV2ZW50U2VuZGVyLmtleURvd24gdGhh dAorICAgICAgICBoYXMgYmVlbiByZWNlbnRseSBhZGRlZCB0byByZXBvcnQga2V5TG9jYXRpb24K KyAgICAgICAgKHNlZSBhbHNvOiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjgyNDcpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MzMyNTAKKworICAgICAgICBUZXN0OiBmYXN0L2V2ZW50cy9rZXlkb3duLW51bXBhZC1rZXlz Lmh0bWwKKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL3F0L0V2ZW50U2VuZGVyUXQuY3BwOgor ICAgICAgICAoRXZlbnRTZW5kZXI6OmtleURvd24pOgorICAgICAgICAqIER1bXBSZW5kZXJUcmVl L3F0L0V2ZW50U2VuZGVyUXQuaDoKKwogMjAxMC0wMS0wNCAgTWFjaWVqIFN0YWNob3dpYWsgIDxt anNAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEZpc2hlci4KZGlmZiAt LWdpdCBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0V2ZW50U2VuZGVyUXQuY3BwIGIv V2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvRXZlbnRTZW5kZXJRdC5jcHAKaW5kZXggYjM0 NTljYi4uMjJhNzQ1MSAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvcXQv RXZlbnRTZW5kZXJRdC5jcHAKKysrIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvRXZl bnRTZW5kZXJRdC5jcHAKQEAgLTM4LDcgKzM4LDYgQEAKICNkZWZpbmUgS0VZQ09ERV9VUEFSUk9X ICAgICAweGY3MDAKICNkZWZpbmUgS0VZQ09ERV9ET1dOQVJST1cgICAweGY3MDEKIAotCiBFdmVu dFNlbmRlcjo6RXZlbnRTZW5kZXIoUVdlYlBhZ2UqIHBhcmVudCkKICAgICA6IFFPYmplY3QocGFy ZW50KQogewpAQCAtMTE3LDcgKzExNiw3IEBAIHZvaWQgRXZlbnRTZW5kZXI6OmxlYXBGb3J3YXJk KGludCBtcykKICAgICAvL3FEZWJ1ZygpIDw8ICJFdmVudFNlbmRlcjo6bGVhcEZvcndhcmQiIDw8 IG1zOwogfQogCi12b2lkIEV2ZW50U2VuZGVyOjprZXlEb3duKGNvbnN0IFFTdHJpbmcmIHN0cmlu ZywgY29uc3QgUVN0cmluZ0xpc3QmIG1vZGlmaWVycykKK3ZvaWQgRXZlbnRTZW5kZXI6OmtleURv d24oY29uc3QgUVN0cmluZyYgc3RyaW5nLCBjb25zdCBRU3RyaW5nTGlzdCYgbW9kaWZpZXJzLCB1 bnNpZ25lZCBpbnQgbG9jYXRpb24pCiB7CiAgICAgUVN0cmluZyBzID0gc3RyaW5nOwogICAgIFF0 OjpLZXlib2FyZE1vZGlmaWVycyBtb2RpZnMgPSAwOwpAQCAtMTMyLDYgKzEzMSw4IEBAIHZvaWQg RXZlbnRTZW5kZXI6OmtleURvd24oY29uc3QgUVN0cmluZyYgc3RyaW5nLCBjb25zdCBRU3RyaW5n TGlzdCYgbW9kaWZpZXJzKQogICAgICAgICBlbHNlIGlmIChtID09ICJtZXRhS2V5IikKICAgICAg ICAgICAgIG1vZGlmcyB8PSBRdDo6TWV0YU1vZGlmaWVyOwogICAgIH0KKyAgICBpZiAobG9jYXRp b24gPT0gMykKKyAgICAgICAgbW9kaWZzIHw9IFF0OjpLZXlwYWRNb2RpZmllcjsKICAgICBpbnQg Y29kZSA9IDA7CiAgICAgaWYgKHN0cmluZy5sZW5ndGgoKSA9PSAxKSB7CiAgICAgICAgIGNvZGUg PSBzdHJpbmcudW5pY29kZSgpLT51bmljb2RlKCk7CmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9E dW1wUmVuZGVyVHJlZS9xdC9FdmVudFNlbmRlclF0LmggYi9XZWJLaXRUb29scy9EdW1wUmVuZGVy VHJlZS9xdC9FdmVudFNlbmRlclF0LmgKaW5kZXggOGU5NDY3YS4uMTVjNDBjMiAxMDA2NDQKLS0t IGEvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvRXZlbnRTZW5kZXJRdC5oCisrKyBiL1dl YktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0V2ZW50U2VuZGVyUXQuaApAQCAtNTQsNyArNTQs NyBAQCBwdWJsaWMgc2xvdHM6CiAgICAgdm9pZCBtb3VzZVVwKGludCBidXR0b24gPSAwKTsKICAg ICB2b2lkIG1vdXNlTW92ZVRvKGludCB4LCBpbnQgeSk7CiAgICAgdm9pZCBsZWFwRm9yd2FyZChp bnQgbXMpOwotICAgIHZvaWQga2V5RG93bihjb25zdCBRU3RyaW5nJiBzdHJpbmcsIGNvbnN0IFFT dHJpbmdMaXN0JiBtb2RpZmllcnMgPSBRU3RyaW5nTGlzdCgpKTsKKyAgICB2b2lkIGtleURvd24o Y29uc3QgUVN0cmluZyYgc3RyaW5nLCBjb25zdCBRU3RyaW5nTGlzdCYgbW9kaWZpZXJzID0gUVN0 cmluZ0xpc3QoKSwgdW5zaWduZWQgaW50IGxvY2F0aW9uID0gMCk7CiAgICAgdm9pZCBjbGVhcktp bGxSaW5nKCkge30KICAgICB2b2lkIGNvbnRleHRDbGljaygpOwogICAgIHZvaWQgc2NoZWR1bGVB c3luY2hyb25vdXNDbGljaygpOwo=